Elitist Jerks - View Single Post

◊ Binkenstein · 04/27/08, 3:46 PM

Originally Posted by Ratticus

Trinkets look to be bugged.

Right I have Essence of the Martyr with a better DP then The Skull of Gul'dan.

Looks to me like the healing column (column U) is being used when the dmg column (column V) should be.

Originally Posted by Moshne

I suspect that one is my fault from when we updated the references away from the HEP/DEP values. Trinkets slipped through the cracks as they didn't need to be updated for the gem or enchant references.

EDIT: Or perhaps not, I am not able to replicate the problem, what do you have set as your sort value, EP or DP. The Skulls EP value is going to vary depending on if you are mana sustainable or not, do you have SPriest, JoW, and other such buffs turned off? Also, which list is it showing as an upgrade in, the main page, or the upgrade?

EDIT 2:

I found it, or I suspect I have, its referencing the heal column for hit, are you not hit capped in this instance of the sheet?
@Bink, in the trinketlist page, the DP calculation is referencing column U for hit instead of X, giving some wild values on non-hit capped setups for healing trinkets.

Fixed.

Originally Posted by Moshne

Also, the hit cap value is a bit uncontrolled, I never really tested it being a draenei and having a hard time not being hit capped. As it stands, if you are not hit capped by even a fraction of a percentage, it gives full value to hit on all items that you are looking at (which was the problem with the Martyr, as it was showing 134 hit rating at full value.) I'm not sure if its worth putting in a check for or not, but you could add a conditional check DEP page hit calculation. I'm trying to draft up something workable for it now.

EDIT: Hmmm...it looks like you would have to put a top end DP value check on every item sheet to put a ((16*hitr)-(hit*hitr))*dhit) maximum limit on the IF(slotequip=A2,U2*hite,U2*dhit) calculation to prevent hit from going wild when close to the cap.

Noted. I think I know what to do to fix this bit now.

For reference, something someone emailed me (please don't, just post it here)

Not sure why this hasn't been caught yet, but the calculation for mana is pretty off. You are using the full value of intellect*15 instead of (intellect - base_intellect)*15. We know each race has a different base mana, and some funky 1 mana per first 20 points of intellect takes place. So mana = base_mana + (int - base_int)*15.

Cell Main!R9 =VLOOKUP(Main!B16,racestat,5,FALSE)+(int-VLOOKUP(Main!B16,racestat,3,FALSE))*15
Cell DEP!G27 =VLOOKUP(Main!B16,racestat,5,FALSE)+(B17-VLOOKUP(Main!B16,racestat,3,FALSE))*15

Additionally, the value of base_mana for Taurens is incorrect.

Cell Lists!E73 = 4223 (not 4350).

A request. Would you return a total DPS time before OOM back to the Main worksheet page? Currently I have to ensure my fight duration is large enough, then check the hidden DEP worksheet for the DPS time calculation. Or I have to manually iterate the fight duration cell to see where DPS drops off. Knowing what gear gets me what DPS time is critical information.