Elitist Jerks - View Single Post

Meloeth · 06/02/08, 5:26 PM

Several have pointed out that the health bar doesn't update at all sometimes until damage or healing is received. I haven't really had the time to look into it yet, but it's very likely caused by the health going up to full without the addon noticing. After the health reaches full no more HEALTH_UPDATE events will fire so the health will keep showing incorrectly until the health changes. I will try and fix the bug as soon as I have time (hopefully tomorrow) and see if I can fix it.

There where some questions about how the addon handles effects increasing the max health of a unit, such as using last stand for example. The addon listens for the MAXHEALTH_UPDATE event that fires whenever the max health of a unit changes, at the same time as the MAXHEALTH_UPDATE event fires, HEALTH_UPDATE fires, if the unit gained health from the ability or item used the health won't match the calculated health by the addon. When this happens the addon uses the health provided by the server/client instead of whatever it thought the unit would have and does any further calculations based on that health instead.
This is a important important safety net the addon has, every time it receives a HEALTH_UPDATE event it calculates backwards until the last HEALTH_UPDATE event to verify that the calculated health is correct.

As some have wondered and others guessed health is updated the old fashioned way when someone is not in combat log range, a good example that has already been brought up is the Kalecgos fight, those "not in the realm you are in" will simply have their health updated like normal.

Several have pointed out that damage meters doesn't show correct effective healing done. Many (most?) addons uses the method described by giansm I believe and that would explain why they don't work properly with my addon installed. I don't know if all damage meters uses this simple method however (WWS reports is a example of another method used), but it is my hope that they do... because if that is the case all I should have to do is make sure my addon is the very last one to react to combat log events. This would not only fix the problem but increase the accuracy of the damage meters! (since without my addon several hits and heals can land in between every health update)

I will try and fix both the bug and effective healing issue tomorrow, whatever I don't get done with then will have to wait a whole week though I'm afraid (short vacation). A big thanks to all the comments so far, I really appreciate the feedback!

06/02/08, 5:26 PM	#26 (permalink)
Meloeth Glass Joe Meloeth Night Elf Druid The Maelstrom (EU)	Several have pointed out that the health bar doesn't update at all sometimes until damage or healing is received. I haven't really had the time to look into it yet, but it's very likely caused by the health going up to full without the addon noticing. After the health reaches full no more HEALTH_UPDATE events will fire so the health will keep showing incorrectly until the health changes. I will try and fix the bug as soon as I have time (hopefully tomorrow) and see if I can fix it. There where some questions about how the addon handles effects increasing the max health of a unit, such as using last stand for example. The addon listens for the MAXHEALTH_UPDATE event that fires whenever the max health of a unit changes, at the same time as the MAXHEALTH_UPDATE event fires, HEALTH_UPDATE fires, if the unit gained health from the ability or item used the health won't match the calculated health by the addon. When this happens the addon uses the health provided by the server/client instead of whatever it thought the unit would have and does any further calculations based on that health instead. This is a important important safety net the addon has, every time it receives a HEALTH_UPDATE event it calculates backwards until the last HEALTH_UPDATE event to verify that the calculated health is correct. As some have wondered and others guessed health is updated the old fashioned way when someone is not in combat log range, a good example that has already been brought up is the Kalecgos fight, those "not in the realm you are in" will simply have their health updated like normal. Several have pointed out that damage meters doesn't show correct effective healing done. Many (most?) addons uses the method described by giansm I believe and that would explain why they don't work properly with my addon installed. I don't know if all damage meters uses this simple method however (WWS reports is a example of another method used), but it is my hope that they do... because if that is the case all I should have to do is make sure my addon is the very last one to react to combat log events. This would not only fix the problem but increase the accuracy of the damage meters! (since without my addon several hits and heals can land in between every health update) I will try and fix both the bug and effective healing issue tomorrow, whatever I don't get done with then will have to wait a whole week though I'm afraid (short vacation). A big thanks to all the comments so far, I really appreciate the feedback!