Elitist Jerks - Death Knights

Serveral people joined the SimulationCraft team to work on the DK module, worked a few weeks on it and then stopped.

So a few days ago I started push it forward myself as I did with druid and warrior modules.

The module itself: sc_death_knight.cpp - simulationcraft - Project Hosting on Google Code
Should be quite straight forward even if you have no clue of C++.

This is just like all other class threads for SimulationCraft: Getting feedback, and pointed to false implementations/bugs etc. :)

Ghoul needs quite some workd (does not use abilites)

I will make a run with the current state of the module with an UnholyDK and post the results.
I'll look into posting a list of actions that I consider 'done'.

Abilities I looked at:

raise_dead: talents + glyph, but only auto_attacks
SS (+3.3 version)
Plague Strike + BP
Icy Touch + FF (killing_machine=1)
Blood Strike
Death Coil
BoneShield
Hysteria
Horn of Winter
2T8, 4T8, 2T9, 4T9, 2T10, 4T10 Melee
Howling Blast (rime=1, killing_machine=1)
Frost Strike (killing_machine=1)

Code:

Globals.simc

threads=2

smooth_scale_factors=0

optimal_raid=1

report_precision=3



death_knight=UnholyDK

level=80

race=undead

talents=http://www.wowarmory.com/talent-calc.xml?cid=6&tal=2305020400000000000000000000000000000000000000000000000002300303350032152000150003133151

glyphs=dark_death/pestilence/raise_dead/the_ghoul/horn_of_winter/icy_touch

actions=flask,type=endless_rage

actions+=/food,type=dragonfin_filet

actions+=/blood_presence

actions+=/snapshot_stats

actions+=/raise_dead

actions+=/auto_attack

actions+=/sequence,wait_on_ready=1:plague_strike:icy_touch:blood_strike:blood_strike:scourge_strike

actions+=/death_coil

actions+=/restart_sequence,name=default

main_hand=dualblade_butcher,stats=90crit_82arpen_147str_155sta,gems=20str,weapon=axe2h_3.60speed_736min_1105max

head=frostforged_helmet,stats=1925armor_73hit_62arpen_127str_107sta,gems=chaotic_skyflare_10str_10agi_10sta_10int_10spi_8str,enchant=50ap_20crit

neck=ancient_pendant_of_arathor,stats=119ap_44crit_33arpen_42agi_52sta

shoulders=majestic_silversmith_shoulderplates,stats=1741armor_40crit_60haste_82str_78sta,gems=14str_4haste,enchant=45ap

chest=chestplate_of_the_frostwolf_hero,stats=2473armor_74hit_90haste_139str_155sta,gems=6str_9sta_34str_6str

waist=belt_of_the_impaler,stats=1332armor_52haste_58arpen_94str_102sta,gems=10hit_10str_10hit_10str_4arpen

legs=legplates_of_ascension,stats=2164armor_90crit_74haste_139str_155sta,gems=34str_34str,enchant=75ap_22crit

feet=plated_greaves_of_providence,stats=1596armor_38crit_59arpen_86str_78sta,gems=10hit_10str_4str,enchant=12crit_12hit

wrists=armplates_of_the_nether_lord,stats=1036armor_39crit_48arpen_76str_76sta,enchant=50ap

hands=gauntlets_of_mounting_anger,stats=1480armor_46hit_63crit_94str_102sta,gems=10hit_10str_4hit,enchant=44ap

finger1=ring_of_the_violent_temperament,stats=50crit_50haste_86str_86sta

finger2=urukas_band_of_zeal,stats=100ap_34crit_32exp_36agi_44sta

trinket1=corens_chromium_coaster,stats=84crit,equip=corens_chromium_coaster

trinket2=banner_of_victory,stats=84arpen,equip=onattackhit_1008ap_20%_10dur_50cd

back=shroud_of_reverberation,stats=145armor_86ap_31exp_25agi_64sta,enchant=16agi

main_hand=dualblade_butcher,stats=90crit_82arpen_147str_155sta,gems=20str,enchant=rune_of_the_fallen_crusader,weapon=axe2h_3.60speed_736min_1105max

ranged=sigil_of_virulence

tabard=tabard_of_the_kirin_tor

Code:

SimulationCraft for World of Warcraft release 3.2.2 ( iterations=9999, max_time=300, optimal_raid=1, smooth_rng=0 )



DPS Ranking:

   7084 100.0%  Raid

   7090  100.0%  UnholyDK



Player: UnholyDK undead death_knight unholy 80

  DPS: 7090.3  Error=2.8  Range=515  DPR=933.0  RPS=7.6/7.8  (runic_power)

  Origin: input=Druid_T7_00_55_16.simc

  Core Stats:  strength=1944|1497(1280)  agility=507|239(129)  stamina=1906|1434(1273)  intellect=162|43(10)  spirit=218|74(10)  health=26561|22281  mana=20|20

  Spell Stats:  power=280|0(0)  hit=12.49%|12.49%(249)  crit=19.10%|14.10%(647)  penetration=0|0(0)  haste=19.04%|10.07%(330)  mp5=0|0(0)

  Attack Stats  power=6610|4182(569)  hit=7.59%|7.59%(249)  crit=30.42%|21.11%(647)  expertise=12.69|12.69(63)  penetration=30.72%|30.72%(430)  haste=39.77%|13.08%(330)

  Defense Stats:  armor=16714|14370(13892)  blockv=972|749(0)  defense=0|0(0)  miss=0.00%|0.00%  dodge=0.00%|0.00%(0)  parry=0.00%|0.00%(0)  block=0.00%|0.00%(0) crit=13.90%|13.90%

  Glyphs: dark_death/pestilence/raise_dead/the_ghoul/horn_of_winter/icy_touch

  Priorities:

    flask,type=endless_rage/food,type=dragonfin_filet/blood_presence/snapshot_stats/raise_dead

    auto_attack/sequence,wait_on_ready=1:plague_strike:icy_touch:blood_strike:blood_strike:scourge_strike

    death_coil/restart_sequence,name=default

  Actions:

    blood_caked_blade  Count= 35.2| 8.36sec  DPE=   993| 2%  DPET=     1  DPR=   0.0  pDPS= 117  Miss=0.43%  Hit=1032| 635|1216  Dodge=3.4%

    blood_plague       Count= 29.2|10.44sec  DPE=  3438| 5%  DPET=     1  DPR=   0.0  pDPS= 335  Miss=0.00%  TickCount=87  MissTick=0.0%  Tick=1151|967|1435

    blood_strike       Count= 59.9| 4.98sec  DPE=  3122| 9%  DPET=     1  DPR=   0.0  pDPS= 624  Miss=0.40%  Hit=2099|1392|2399  Crit= 4324| 2740| 4941|49.5%  Dodge=3.3%

    death_coil         Count= 56.9| 5.16sec  DPE=  4572|12%  DPET=  3328  DPR= 114.3  pDPS= 869  Miss=1.50%  Hit=3385|2938|4047  Crit= 7073| 6140| 8458|33.6%

    frost_fever        Count= 29.7|10.22sec  DPE=  3344| 5%  DPET=     1  DPR=   0.0  pDPS= 331  Miss=0.00%  TickCount=87  MissTick=0.0%  Tick=1136|955|1423

    icy_touch          Count= 30.1|10.07sec  DPE=  2221| 3%  DPET=     1  DPR=   0.0  pDPS= 223  Miss=1.53%  Hit=1645|1424|1993  Crit= 3437| 2977| 4166|33.6%

    melee_main_hand    Count=121.6| 2.48sec  DPE=  3848|22%  DPET=  1566  DPR=   0.0  pDPS=1561  Miss=0.40%  Hit=2891|2444|3428  Crit= 5956| 5034| 7062|40.4%  Glance=2169|24.0%  Dodge=3.3%

    necrosis           Count=117.1| 2.57sec  DPE=   751| 4%  DPET=     1  DPR=   0.0  pDPS= 294  Miss=0.00%  Hit= 751| 345|1328

    plague_strike      Count= 30.3|10.07sec  DPE=  3538| 5%  DPET=     1  DPR=   0.0  pDPS= 358  Miss=0.41%  Hit=2206|1904|2564  Crit= 5244| 4528| 6098|46.5%  Dodge=3.3%

    scourge_strike     Count= 29.7|10.07sec  DPE=  5787| 8%  DPET=     1  DPR=   0.0  pDPS= 574  Miss=0.39%  Hit=3352|2582|3847  Crit= 7970| 5848| 9149|55.4%  Dodge=3.3%

    unholy_blight      Count= 56.1| 5.24sec  DPE=   902| 2%  DPET=     1  DPR=   0.0  pDPS= 169  Miss=0.00%  TickCount=118  MissTick=0.0%  Tick=428|118|814

    wandering_plague   Count= 52.9| 5.54sec  DPE=  1143| 3%  DPET=     1  DPR=   0.0  pDPS= 202  Miss=0.00%  Hit=1143| 955|1435

   ghoul  (DPS=1435.4)

    ghoul_melee        Count=414.0| 0.73sec  DPE=  1038|20%  DPET=  1023  DPR=   0.0  pDPS=1435  Miss=0.40%  Hit= 946| 832| 971  Crit= 1893| 1665| 1942|16.5%  Glance= 710|24.0%  Dodge=0.3%

  Constant Buffs: arcane_brilliance/blessing_of_kings/blessing_of_might/blessing_of_wisdom/divine_spirit/fortitude

  Constant Buffs: mark_of_the_wild/replenishment

  Dynamic Buffs:

    banner_of_victory           : start=5.9   refresh=0.0    interval= 55.1|55.1   uptime=20%  trigger=20%

    bloodlust                   : start=1.0   refresh=0.0    interval=  0.0|0.0    uptime=13%  benefit=22%

    corens_chromium_coaster     : start=4.1   refresh=0.0    interval= 73.9|73.9   uptime=14%  trigger=10%

    desolation                  : start=1.0   refresh=56.7   interval=143.5|5.2    uptime=99%  benefit=98%

    rune_of_the_fallen_crusader : start=3.7   refresh=10.2   interval= 41.1|10.5   uptime=38%  benefit=75%  trigger=10%

    sigil_of_virulence          : start=5.3   refresh=17.6   interval= 55.5|12.9   uptime=92%  trigger=80%

  Up-Times:

     98.2% : blood_plague                  

     98.9% : frost_fever                   

  Gains:

      147.4 : butchery         (overflow=1.5%)

      278.0 : dirge            (overflow=3.8%)

      296.6 : glyph_icy_touch

       30.7 : power_refund   

     1577.6 : rune_abilities   (overflow=1.1%)



Auras and De-Buffs:

  Constant: abominations_might/arcane_empowerment/battle_shout/bleeding/blood_frenzy/blood_plague/crypt_fever

  Constant: curse_of_elements/devotion_aura/earth_and_moon/ebon_plaguebringer/elemental_oath/expose_armor/faerie_fire

  Constant: ferocious_inspiration/flametongue_totem/frost_fever/heart_of_the_crusader/horn_of_winter/hunters_mark

  Constant: improved_faerie_fire/improved_moonkin/improved_scorch/improved_shadow_bolt/infected_wounds/insect_swarm

  Constant: judgement_of_wisdom/judgements_of_the_just/leader_of_the_pack/mana_spring_totem/mangle/master_poisoner

  Constant: misery/moonkin/poisoned/rampage/sanctified_retribution/savage_combat/strength_of_earth/sunder_armor

  Constant: swift_retribution/thunder_clap/totem_of_wrath/totem_of_wrath_debuff/trauma/trueshot/unleashed_rage

  Constant: windfury_totem/winters_chill/wrath_of_air

  Dynamic:



Waiting:

     1.9% : UnholyDK



Baseline Performance:

  TotalEvents   = 20817991

  MaxEventQueue = 17

  TargetHealth  = 2123809

  SimSeconds    = 2998932

  CpuSeconds    = 41.728

  SpeedUp       = 71869



RNG global Actual/Expected Roll=1.001411 Range=1.000000 Gauss=1.000000

Random things I found out not mentioned in other threads:

Quote:

Originally Posted by Nyth_ (Post 1466121)

That seems quite odd, because it never worked that way as far as I know. It has always been multiplicative, also on previous PTR builds with scourge strike.

In previous occasions where coefficient calculation didn't add up, it usually turned out to either be the overlooking of a variable (like outbreak).

Yea I know, everybody just assumes multipilcativity with damage modifiers, but nobody ever goes on and tries it.
I did the same for balance druid when, you would be supprised how much '+x% damage' talents are actually additive

PTR Testing:
-Black Ice
-Desolation
-Outbreak
-Bone shield
This is just to show that RoR is not affecting the shadow damage

Code:

UP, 1h, FF+EP

09:50:33> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (540 Overkill)

09:50:33> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (304 Overkill)

541 * 2*.25 *1.13 = 305.665



UP, 1h, BP+EP

09:55:27> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (530 Overkill)

09:55:27> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (299 Overkill)

531 * 2*.25 *1.13 = 300.0



UP, 1h, FF+BP+EP

09:51:17> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (1285 Overkill) *

09:51:17> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (1089 Overkill)

1286 * 3*.25 *1.13 = 1089.9



BP, 1h, FF+EP

09:52:58> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (620 Overkill)

09:52:59> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (402 Overkill)

621 * 2*.25 *1.13*1.15 = 403.49



BP, 1h, BP+EP

09:53:47> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (636 Overkill)

09:53:48> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (413 Overkill)

637 * 2*.25 *1.13*1.15 = 413.9



BP, 1h, FF+BP+EP

10:01:29> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (1482 Overkill) *

10:01:29> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (1445 Overkill)

1483 * 3*.25 *1.13*1.15 = 1445.37

-Black Ice
-Bone shield
+Desolation
-Outbreak

This is to show that Desolation is additive with Blood Presence

Code:

UP, 1h, FF+BP+EP, Desolation

10:07:11> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (1334 Overkill) *

10:07:12> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (1187 Overkill)

1335 * 3*.25  *1.13 *1.05 = 1187.98



BP, 1h, FF+BP+EP, Desolation

10:08:57> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (668 Overkill)

10:08:57> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (679 Overkill)

667 * 3*.25  *1.13 *1.05 * 1.15 = 682.58

667 * 3*.25  *1.13 *1.20        = 678.34

-Black Ice
+Bone shield
-Desolation
-Outbreak

This is to show that Bone Shield is additive with Blood Presence

Code:

UP, 1h, FF+BP+EP, Bone shield

10:16:40> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (590 Overkill)

10:16:40> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (510 Overkill)

591 * 3*.25  *1.13 *1.02 = 510.89



BP, 1h, FF+BP+EP, Bone shield

10:14:41> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (667 Overkill)

10:14:42> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (662 Overkill)

668 * 3*.25  *1.13 *1.02 * 1.15 = 662.07

668 * 3*.25  *1.13 *1.17        = 664.37

To close really.



BP, 2h, FF+BP+EP, Bone shield

10:20:23> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (2550 Overkill) *

10:20:23> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (2629 Overkill)

2551 * 3*.25 * 1.13 * 1.04 * 1.02 * 1.15 = 2637.4

2551 * 3*.25 * 1.13 * 1.04 * 1.17        = 2630.7

-Black Ice
+Bone shield
+Desolation
-Outbreak

This is to show that Desolation, Bone Shield and Blood Presence are additive

Code:

BP, 2h, FF+BP+EP, Bone shield, Desolation

10:23:08> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (1139 Overkill)

10:23:08> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (1225 Overkill)

1140 * 3*.25 * 1.13 * 1.04 * 1.02 * 1.05 * 1.15 = 1237.557

1140 * 3*.25 * 1.13 * 1.04 * 1.22               = 1225.85

+Black Ice
-Bone shield
-Desolation
-Outbreak

This is to show that Black Ice and Blood Presence are additive

Code:

BP, 2h, FF+BP+EP

10:26:06> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (2708 Overkill) *

10:26:06> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (2984 Overkill)

2709 * 3*.25 * 1.13 * 1.04 * 1.10 * 1.15 = 3020.46

2709 * 3*.25 * 1.13 * 1.04 * 1.25        = 2984.64

+Black Ice
+Bone shield
+Desolation
-Outbreak

This is to show that Black Ice, Desolation, Bone Shield and Blood Presence are additive

Code:

BP, 2h, FF+BP+EP, Bone shield, Desolation

10:27:55> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (2697 Overkill) *

10:27:55> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (3138 Overkill)

2698 * 3*.25 * 1.13 * 1.04 * 1.02 * 1.05 * 1.10 * 1.15 = 3221.77

1140 * 3*.25 * 1.13 * 1.04 * 1.32                      = 3138.98

+Black Ice
-Bone shield
-Desolation
+Outbreak

Outbreak has no effect on the shadow damage

Code:

BP, 2h, FF+BP+EP

10:30:13> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Physical. (2946 Overkill) *

10:30:13> [Your] Scourge Strike hit [Ebon Knight's Training Dummy] 1 Shadow. (3246 Overkill)

2947* 3*.25 * 1.13 * 1.04 * 1.25 = 3246.86

Ghoul:
0 haste

Code:

1197 AP

85.5 dps

224 - 265, 2.0

122.3 dps



1886 Ap

134.7 dps

307 - 348, 2.0

163.6 dps



2106 ap

150.4

333 - 374, 2.0

176.8

Ghoul weapon dps = 50 + AP/14*0.84

Gargoyle Strike

Code:

 543 AP

 355 dmg



4026 AP

1731 dmg

AP Scaling: (1731-355)/(4026-543) = 0.40
Base damage: 1731 - (1731-355)/(4026-543)*4026 = 140 ]]>