Oh, I see. You're just talking about having one macro be
/cast maul
/cast mangle
and the other be
/cast mangle
And then physically changing them between fights.
I don't think that will really save anything; I'd probably rather just do it via a modification flag at that point.
The addon/macro modifier looks more promising.
Negative. I am talking about one macro being:
#showtooltip
/cast Mangle
and the other doing some nifty macro changing the following:
/run if not InCombatLockdown() then local i=GetMacroId("Mangle") local mt=oldMacroText if not mt then oldMacroText=GetMacroBody(i) mt=oldMacroText.."\n/cast !Maul") else oldMacroText = "" end local n,t,_,l=GetMacroInfo(i) EditMacro(i,n,t,mt,l) end
(drycoded, not tested)
The name of the macro it changes is Mangle (the GetMacroId part). It saves the old macro and adds a new line with /cast !Maul. If used again, it restores the original macro.
Improvements include making it an addon, allowing it to operate on more than one macro (not impossible to do in a macro, but the 255 char constraint in the Blizzard Macro is a problem), make the line it adds customizable, add the line below the #showtooltip line in case of other spells...
Hope this helps. If you run into problems with it, please honk here.
Originally Posted by Wraithlin
Do your hospitals have unusually narrow doorways?
If not how do "lifestyle choices" explain the waiting time statistics?
Without a #show or #showtooltip included it will of course default to Kill Shot. With the following I get to see Chimera Shot instead, but what I really want is it to switch from Chimera > Aimed as it would with a simple /castsequence macro in place, even though now it has the additional 2 commands first.
Does anyone know if this is possible? I've tried all the iterations I can think of to make it show the shots as I would like but with no luck. If it's not possible perhaps Blizzard will at some point allow for sequential use of commands within #show and #showtooltip in the same manner as for /castsequence.
Last edited by Tolmandary : 02/24/09 at 11:37 AM.
Reason: Fixing typo missed during preview
Have you tried putting the /castsequence before the two /casts? #showtooltip just shows the first spell listed when more than one spell would go off during a macro activation, so (assuming there aren't CGD issues) just put the one you want to see at the top of the list and it'll be the tooltip.
Have you tried putting the /castsequence before the two /casts? #showtooltip just shows the first spell listed when more than one spell would go off during a macro activation, so (assuming there aren't CGD issues) just put the one you want to see at the top of the list and it'll be the tooltip.
Unfortunately this isn't possible. Kill Shot and Kill Command do not have GCDs so can be instantly used, both Chimera Shot and Aimed Shot however do, so alas there is no way to switch the macro order around otherwise I would do. This is why I need to find (if it exists) a method of displaying Chimera and Aimed rather than just Chimera alone as it does now.
Unfortunately this isn't possible. Kill Shot and Kill Command do not have GCDs so can be instantly used, both Chimera Shot and Aimed Shot however do, so alas there is no way to switch the macro order around otherwise I would do. This is why I need to find (if it exists) a method of displaying Chimera and Aimed rather than just Chimera alone as it does now.
That doesn't necessarily mean it doesn't work. For example at lvl 70 i had a macro for my warrior that was something like:
Which worked perfectly, at least in that regard. That being said, the implementation of these things seems to be a fairly ugly hack so it differs a lot from spell to spell how it works.
Does anyone know if this is possible? I've tried all the iterations I can think of to make it show the shots as I would like but with no luck. If it's not possible perhaps Blizzard will at some point allow for sequential use of commands within #show and #showtooltip in the same manner as for /castsequence.
You could set up two macros:
/cast Kill Shot
/cast Kill Command
/click ActionButton37 -- Will click the next macro
/castsequence reset=8 Chimera Shot, Aimed Shot
Voila!
--
I've got a question myself: Is it possible to fire off a spell on myself if my target is hostile?
/cast [target=target, harm] Flash Heal ... Nope, doesn't work
I can imagine it'll be possible with the use of /click [harm] MyButton linking to /cast [target=player] Flash Heal, but I'll be using this a lot so it'll be a hassle to set it all up.
The name of the macro it changes is Mangle (the GetMacroId part). It saves the old macro and adds a new line with /cast !Maul. If used again, it restores the original macro.
Improvements include making it an addon, allowing it to operate on more than one macro (not impossible to do in a macro, but the 255 char constraint in the Blizzard Macro is a problem), make the line it adds customizable, add the line below the #showtooltip line in case of other spells...
Hope this helps. If you run into problems with it, please honk here.
Ressing this old bit, since it seems even more relevant now.
I couldn't get it to work; I would get errors with the specific script ending prematurely, and apparently nothing was changed or modified. I'll keep playing around with it and see if I can get lucky at all.
/run if not InCombatLockdown() then local i=GetMacroIndexByName ("Ma") local mt=GetMacroBody(i) local len=strlen(mt) local v="/cast Mangle" if len < 15 then mt=v.."\n/cast !Maul" else mt=v end local n,t,_,l=GetMacroInfo(i) EditMacro(i,n,t,mt,l,1) end
GetMacroID had to be done to GetMacroIndexByName, which sucks. I couldn't figure out how to get the value to set/reset back and forth properly, so I did the hacky way of simply toggling what the text was every time you pressed the key. It does work, though it's right at the edge of the 255 char limit.
If people have suggestions on how to get this to work so that the actual text isn't printed/reprinted and is smaller, I'd be grateful.
Sorry for not checking by earlier - happy to see you got it to work (sorry for the drycode problems!). If people are interested enough, I can whip up an addon that does the change to several macros at once (most of the stuff would be hardcoded, as I still haven't gotten around to read up on Ace addons to provide easy customizability).
Originally Posted by Wraithlin
Do your hospitals have unusually narrow doorways?
If not how do "lifestyle choices" explain the waiting time statistics?
That would be brilliant, honestly. I think there would be plenty of warriors, druids and DKs that would love to not have to do their on next attack button all the time but would like to turn it off and on for long periods of time.
A question - could you get rid of the InCombatLockdown() check? I know that you can't modify macros during combat, but I'd be curious if you could not worry about the check at all and assume that you weren't doing it. That would solve some issues with the size of the thing and at least allow tooltips.
Is it possible to use ground target spells in a macro? For example, I'd like to be able to cast Hurricane at my feet. I read/searched through the thread and couldn't find an answer. If I missed it, please point me to it?
That would be brilliant, honestly. I think there would be plenty of warriors, druids and DKs that would love to not have to do their on next attack button all the time but would like to turn it off and on for long periods of time.
A question - could you get rid of the InCombatLockdown() check? I know that you can't modify macros during combat, but I'd be curious if you could not worry about the check at all and assume that you weren't doing it. That would solve some issues with the size of the thing and at least allow tooltips.
If I do it as an addon, the length of the toggle check is no longer a problem - you don't need a keypress or anything to change a macro, so you can do the modifications in normal code. I've actually written a macro addon that allows you to create macros that are up to about 4000 chars big - the 255 limit is only for Blizzard macros. I'll see if I can do the addon tonight, but can't promise - unspecified raid (probably undermanning Naxx-25 in our 10 man guild).
If you mean to do it in the macro, then yes, you can do that - but I think that using the macro would then fail if you try to do it in combat (haven't tried to call EditMacro in combat).
Originally Posted by ools
Is it possible to use ground target spells in a macro? For example, I'd like to be able to cast Hurricane at my feet. I read/searched through the thread and couldn't find an answer. If I missed it, please point me to it?
You used to be able to do so by clicking the minimap or somesuch - it triggered the ground targeted spell on top of you. According to my failing memory, it has been disabled.
EDIT:
As I suspected, raiding Naxx with other peoples alts took up all night yesterday. Bright side: KT is still up and will be milked by other peoples mains on Sunday. </emo>
Have fixed a dry-coded version of the addon. Will add a few bells and whistles to it and then try it when I get home.
EDIT2:
Attached ToggleOnNextStrike.zip, the addon I mentioned. Should be quite easy to use, use /tons to access CLI. /tons scan followed by /tons enable should do the trick. Read the readme for more info.
EDIT3:
See attachment on post further down for the updated version.
Last edited by sarf : 03/29/09 at 5:08 PM.
Originally Posted by Wraithlin
Do your hospitals have unusually narrow doorways?
If not how do "lifestyle choices" explain the waiting time statistics?
Thank you very much for the macro, it has helped tremendously. However, I am having issues trying to get it to work with Mangle. It seems to work absolutely perfectly with Lacerate and Swipe, but with Mangle it doesn't register the macro.
The macro itself is:
/cast Mangle - Bear
Similar to all the other macros. I have checked the addon files but my limited knowledge of LUA means that I can't really see the exact issue.
Just thinking you should be aware of the issue, otherwise thanks very much for the addon.
If you are referring to my addon, it's currently set up to only patch Mangle and Swipe. For some reason, I forgot Lacerate.
You'd think I would have tested this with my Druid, but I actually just tested it with a DK due to not wanting to mess up macros just before a raid. I'll check it out once I am back home and fix the Lacerate not appearing. Hopefully I will be able to fix the Mangle issue, but it is making me slightly suspicious since the code should work on both Mangle and Swipe.
Perhaps wowheads spell ids are wrong, though, and I have actually put Lacerate and Swipe in there, which would explain the results you get.
Originally Posted by Wraithlin
Do your hospitals have unusually narrow doorways?
If not how do "lifestyle choices" explain the waiting time statistics?
Hey, Sarf - I was just able to try the addon. Sorry for the delay; we had our baby on Friday and things have been a bit hectic.
It seems to work okay. One thing that was amusing was that it found the modifying macro as well as the basic attack macros, which was a bit annoying. But it otherwise works well, and I'm planning on modifying it so that instead of removing the maul it adds either a [modifier:shift] maul or a [nomodifier] maul as the toggle.
I hope this is the right place to post this but I am having problems with my focus target dropping somewhat randomly. Me and another rogue tried setting up a Tricks of the Trade (TotT) rotation by having each other as focus and running a macro each cooldown. My macro is as follows (I am not sure what his is):
#showtooltip Tricks of the Trade
/cast [target=focus,help,exists] Tricks of the Trade; [target=targettarget,help,exists] Tricks of the Trade; [help] Tricks of the Trade
My initial thought was that using vanish to drop aggro was also dropping focus but we specifically tested for that case and it was not that. I want to find out here if this is a known bug and, if not, is there anything wrong with my macro that may be causing my focus target to get cleared?
I hope this is the right place to post this but I am having problems with my focus target dropping somewhat randomly. Me and another rogue tried setting up a Tricks of the Trade (TotT) rotation by having each other as focus and running a macro each cooldown. My macro is as follows (I am not sure what his is):
#showtooltip Tricks of the Trade
/cast [target=focus,help,exists] Tricks of the Trade; [target=targettarget,help,exists] Tricks of the Trade; [help] Tricks of the Trade
My initial thought was that using vanish to drop aggro was also dropping focus but we specifically tested for that case and it was not that. I want to find out here if this is a known bug and, if not, is there anything wrong with my macro that may be causing my focus target to get cleared?
As far as I can recall, it's killing spree that drops focus (if you use kspree, the other rogue loses you as his focus). I've gotten around this by just using a simple /cast[target=roguename] macro, which, unfortunately defeats the purpose of using one macro to do multiple things as a space saver on my bar.
Hey, Sarf - I was just able to try the addon. Sorry for the delay; we had our baby on Friday and things have been a bit hectic.
It seems to work okay. One thing that was amusing was that it found the modifying macro as well as the basic attack macros, which was a bit annoying. But it otherwise works well, and I'm planning on modifying it so that instead of removing the maul it adds either a [modifier:shift] maul or a [nomodifier] maul as the toggle.
Thanks again!
Yeah, it just searches for the keywords currently - you can manage the macros it changes by using /tons addmacro X and removemacro X. /tons scan just searches for the macros using the not-so-advanced algorithm of "does it have ability X, Y or Z?"
To change what it does, just change the function ToggleOnNextStrike:ChangeMacro - it should be a rather straightforward replacement. If you do this, please PM me the function you created and I'll add that into the addon with an option to use it instead.
I think I found the bug with Mangle - it seems the string:find function (due to defaulting to pattern-finding) doesn't really like the "-" character (just have to update it to do a plain find, though). Adding Lacerate to the addon and fixing this ought to work. I'll attach the updated addon to this message as well as replacing the old addon.
Yeah, that fixed it.
Originally Posted by Wraithlin
Do your hospitals have unusually narrow doorways?
If not how do "lifestyle choices" explain the waiting time statistics?
I encountered a small issue with TONS 0.2. When using the scan function, it catches macros that have "Swipe (Cat)" in them. I used the removemacro command to fix it. Otherwise the addon works well, thanks for putting it together.
I encountered a small issue with TONS 0.2. When using the scan function, it catches macros that have "Swipe (Cat)" in them. I used the removemacro command to fix it. Otherwise the addon works well, thanks for putting it together.
Ah. Hm. Don't know if there's a point in fixing that; I suppose I could add a bit of code to check if it finds Swipe (Cat) at the same place and continue searching if it does. Anyhow, I doubt I'll meddle with it more (at the moment) - I'm more interested in making a macro changing API/lib and let other people make macro-changing addons.
Sorry for the inconvenience, though! In all honesty, the scan command should probably have been omitted, as the number of macros you want to change is rather low. That said, it does make it easier to use, so...
Originally Posted by Wraithlin
Do your hospitals have unusually narrow doorways?
If not how do "lifestyle choices" explain the waiting time statistics?
It lets me spam it without leaving bear form, which is useful when stunned/feared/etc for pvp. However, i'm having an issue where if I spam it to clear roots in pvp and i end up getting stunned, it causes me to shift out to caster form during the stun, which pretty much kills me.
Basically the macro works fine and doesn't shift me out to caster form unless I'm stunned/have no control of my character.
It lets me spam it without leaving bear form, which is useful when stunned/feared/etc for pvp. However, i'm having an issue where if I spam it to clear roots in pvp and i end up getting stunned, it causes me to shift out to caster form during the stun, which pretty much kills me.
Basically the macro works fine and doesn't shift me out to caster form unless I'm stunned/have no control of my character.
Any idea how to get around this?
There is currently no way around it other than simply not to hit the button while you're stunned.
The macro is effectively shifting you out and back in far faster than either you can see and your game can react, so you don't see it, but it is shifting you out and back in. Because shifting out if just the cancellation of a buff, it can be done at anytime, but shifting in requires a spellcast which cannot happen while stunned. Since there's no way to check for buffs/debuffs, in afraid you're stuck with it.
Just FYI, that'll still happen whether you use a macro or just spam the button twice in quick succession.
Is there any way to create a toggle for a macro to switch to using a different spell without using a modifier?
My problem is how i switch between using heroic strike and cleave while tanking. I have a single keybind i use for both, and actually switch the spell on the bar between pulls depending on the situation. And sometimes via the spellbook during combat due to locked actionbars which is hardly ideal.
What i want to do is be able to use the single keybind to use both, but somehow toggle between cleave and heroic strike without using a modifier such as shift or ctrl during combat. The perfect solution would be to use a macro to toggle the state of a variable of some kind which another cleave/hs macro could check to determine which spell to use. Something along the lines of these pseudo code macro's:
cleave/hs macro:
if ( state == true )
cleave
else
hs
switch macro:
if ( state == true)
state = false
else
state = true
I'm pretty sure there is no shared variable scope for macro's that would allow something like this, and if there is i probably just haven't looked hard enough, sorry, and would greatly appreciate a pointer in that direction, but i was intrigued by sarf's addon that actually changed the text of the macro if i understood it correctly? Is that what it does? As a similar addon could very easily achieve the functionality i want.