Macro for automatic autoattack - Page 2

kharen · 07/26/06, 1:53 PM

Fails to work on multi-target fights and boss fights where the player is always in combat.

Always used to work fine for me (even in multi-target fights and bosses), although it's been a while since i used the default frames... (PlayerFrame.inCombat seemed to indicate whether autoattack was active, while UnitAffectingCombat worked to see if you were combat flagged or not). Always thought it was rather confusing that a flag called "inCombat" didn't actually tell you if you were in combat or not. Maybe they "fixed" it at some point...

But the IsCurrentAction version is guaranteed to work, so probably better to use that.

Personally, i just use the discord DL_ATTACKING flag, and have seperate keybinds for autoattack on and autoattack off, and it hasn't failed me ever (except when discord gets disabled after a patch and i forget to reenable it <_< )

dares · 07/26/06, 1:58 PM

Pretty simple.

For Backstab...

/cast Backstab(Rank 9)
/script if not IsCurrentAction(x) then AttackTarget() end;

[where x is the location of your attack button]

For Sinister Strike/Riposte...

/script if (UnitMana("Player")>=10) and (IsUsableAction(y)) then CastSpellByName("Riposte");end
/script if (UnitMana("Player")>=40) then CastSpellByName("Sinister Strike(Rank 8"); end
/script if not IsCurrentAction(x) then AttackTarget() end;

[where y is the location of your Riposte button and x is the location of your attack button]

• Andeh · 07/26/06, 2:05 PM

Dares posted the ideal macros for this. The SS one is perfect. The only issue with the Backstab one is that it fucks up Gouge->BS. I've tried to come up with some sort of logic check to get around this, but haven't thought of a good one. Basically you'll need to swap in your macro only while you raid.

dares · 07/26/06, 2:08 PM

Absolutely.

I wouldn't use the Backstab one if you're pvping and have a tendency to mash your Backstab button because it will turn on your auto-attack and break Gouge.

Mist · 07/26/06, 2:16 PM

Originally Posted by dares

Pretty simple.

For Backstab...

/cast Backstab(Rank 9)
/script if not IsCurrentAction(x) then AttackTarget() end;

[where x is the location of your attack button]

For Sinister Strike/Riposte...

/script if (UnitMana("Player")>=10) and (IsUsableAction(y)) then CastSpellByName("Riposte");end
/script if (UnitMana("Player")>=40) then CastSpellByName("Sinister Strike(Rank 8"); end
/script if not IsCurrentAction(x) then AttackTarget() end;

[where y is the location of your Riposte button and x is the location of your attack button]

I actually found a problem with this macro. If you're attacking a moving target in PvP, it'll turn on autoattack when you're not in range which screws up your swing timer and you then won't get the awesome Sinister Strike + Mainhand autoattack at the same instant when you finally do close the distance.

Bluefish · 07/26/06, 3:11 PM

I used a macro to perform both Riposte and SS for a while, but swapped to having them separate after a couple untimely deaths caused by having them linked. Using separate buttons allows you to use Riposte to its greatest strategic advantage and also doesn't interfere with your CP generation. Certainly it's rare that you'd rather SS than Riposte, but it does happen and if you parried some random cleave your macro won't do it for you.

Also makes Riposte much more deadly in PvP when you can parry the Valor Warrior's IBS and tab over to the Spinal Reaper you know doesn't have a weapon chain... :)

sp00n · 07/27/06, 4:07 AM

/script if (IsCurrentAction(x) == nil) then AttackTarget(); end

Ok, tested yesterday during a full BWL run.
Didn't notice any autoattack stops, so it seems to work like a charm.

Dares posted the ideal macros for this. The SS one is perfect. The only issue with the Backstab one is that it fucks up Gouge->BS. I've tried to come up with some sort of logic check to get around this, but haven't thought of a good one. Basically you'll need to swap in your macro only while you raid.

Well, you get used to observe your energy while in PvP. Not that big of a problem.

dreadnor · 07/27/06, 7:24 AM

Originally Posted by sp00n

Ok,
/script if (IsCurrentAction(13) == nil) then AttackTarget(); end
seems to work for me. Have to test it under raid conditions though.

Note that you have a typing error there, shouldn't it be nil instead of nill?

Although I dont understand why, the following line does the job perfectly and you don't need to have auto attck on any of your bars.
/script if (not isCurrentAction(1)) then AttackTarget();end

Doesn't work for me, it delivers
Error: [string "if (not isCurrentAction(1)) then AttackTarg..."]:1: attempt to call global `isCurrentAction' (a nil value)

Do you have autoattack bind to your 1st key? :)

You need a capital "I" in isCurrentAction. So it should be :

/script if (not IsCurrentAction(1)) then AttackTarget();end

The idea here is that you save a slot on your bars since auto attack is in the hidden number 1 slot. And no, auto attack is not on any of my bars and this macro still works.

sp00n · 07/27/06, 8:15 AM

This somehow confuses me.
I thought IsCurrentAction(x) is counting the buttons on the bars, beginning with 1.
1 being the first button of the first bar. One bar has 12 buttons, therefore 13 is the 1st button of the second bar, where I placed my attack icon.
And using (IsCurrentAction(13) == nil) works just fine, whereas (IsCurrentAction(10) == nil) did toggle the autoattack.

I just checked with /script if (not IsCurrentAction(1)) then AttackTarget();end
Toggles autoattack aswell for me. Tried with an empty button 1 and with sinister strike in button 1.
Placing the attack button in that slot works fine of course.

Whats in your first button in your first bar then?

dreadnor · 07/27/06, 8:32 AM

I'm a warrior so I have a different bar for each stance. I'm not sure which is considered number 1. In battle stance I have a macro in the first slot. In berserker stance I have Whirlwind in the first slot and in defensive stance I have shield block in the first slot.

Oh I just realized that you need to have auto attack in the number 1 slot of your "null stance" bar for this to work. Sorry for the confusion.

KalelScilla · 07/27/06, 8:33 AM

Did you try turning on "attack on assist" in the interface options then just mashing your assist MA macro? This should turn on your autoattack successfully.