I am looking at picking up a Drakefang or Badge of the Swarmguard. I was wondering which is better to be using? I haven't found any math out there to find out which is the best yet, so was just curious what would be said here. Also using an HoJ currently with BHB. Should i be replacing both of these or just BHB? Thanks in advance.

DFT + HoJ - BotSG is typically considered a PvP trink, and absent a rogue ability to reliably trinket swap in combat, it will most likely stay that way.

I'm sure you were looking for this link:
http://forums.elitistjerks.com/profile.php?id=3096
followed by http://forums.elitistjerks.com/profile.php?id=3096

If you can get a DFT, pick it up. It will probably not be replaced until sometime in the expansion. The only two trinkets that are better are: Kiss of the Spider and Slayer's Crest

regarding the KoTS dps increase...

Assume: 1% crit = 1% dps increase
Assume: 1% hit = 0.6% dps increase (we're assuming 60% of your damage is white damage)

so for reference, Blackhand's Breadth dps increase = 2%

1% for 1% its Crit
0.6% for 1% its Hit
Subtotal of passives = 1.6% dps increase

assuming perfect time on target, 1/8 of time you'll have the 20% buff to weapon speed. This averages out to 60% of dps * 20% * 1/8 = 1.5% dps increase.

So, with perfect time on target with KoTS running, you're getting 3.1% dps increase. Relative to BhB, the scaling is the same (well, a little less when you consider that passives will never get wasted cause you got mindcontolled, died, had to bandage, got web-wrapped, etc), but compared to anything with a flat AP modifier, it will indeed scale better.

Bad assumptions to make, Discofiend, regarding how much of a dps increase crit and hit are. Plus, you leave out the best part of KoTS: stacking it with blade flurry and SnD. All haste effects are multiplicative.

/boggle

if anything.. 1% crit ~ 1% hit

first, what are better assumptions to make? The reason that i put those assumptions in is so that people like you could dispute them and give me better ones ;-)

second, your bladeflurry is going to be up anyway. 20% of 100 = 20. 20% of 156 = 31.52. Both are 20% increase of the initial value (the white dmg). I see what you're saying, that if you're only stacking them so that they're running at the same time, you get an additional attack speed bonus = to the marginal affect of KoTS on the BF, but the end result isn't *that* much different.

i've seen this numerous times and asked for explanations (i'm very open to being wrong). So far no one has spelled this out for me. Can someone help me here?

edit: pls ignore gimmick crit cap fights like loatheb, and assume you already have +15% hit or so for the purposes of this explanation.

I guess you'd have to reverse-engineer your question. How is missing 1% more not 1% less damage?

because 40% of your damage comes from attacks are special attacks which you already have 0% miss rate on since the base to miss on those are 5%, not the white damage 24%. If any rogue here doesn't have 5% at elast between precision and gear, i'd be astounded.

You only need about 6% hit to not miss on specials anymore, and you can get 5 of that through talents. After that, +hit is pure white damage increase only. Crit affects both white and yellow attacks and so scales better.

You may have wanted to include the assumption that you have 15% to hit already. That changes your statement quite a bit.

man, ej should really just make a new post and sticky a link to all the class spreadsheets that were made. Anyways, here's the rogue one, put in your gear, it shows you exactly what hit% = crit% in your current gear.

http://www.savefile.com/projects/299694

are you seriously saying that, for the question at hand - a rogue considering picking up a kiss of the spider, that you would assume they dont have at least 5% to hit from their gear?