I raid and main tank a lot on my warrior, and I find myself in the position of trying to pick the optimal professions.
My goals are to pick professions that will be useful for a long period of time (switching is both time-consuming and expensive), and bring something to my raid role (tanking) that I cannot substitute by having an alt or guild mate do for me. I.e. BoP or profession-only items.
Based on these goals, here is my take on the various relevant professions and my thoughts/critique. I'd be interested in your opinions and perhaps adding anything to the list which I may have missed.
Blacksmith:
Armor:
http://www.wowhead.com/?item=28483
http://www.wowhead.com/?item=28484
http://www.wowhead.com/?item=28485
The Bulwark of Ancient Kings chest craftable seems quite good. It appears to have standard epic armor for it's ilvl, good stamina allocation, and the second and third upgrades have an LGG-proc use ability which is quite nice.
On the negative side, a lot of the item budget is wasted on marginal tanking stats. The +STR would be better itemized as +AGI, the +crit could be allocated to def or block or dodge/parry to significantly improve the chest for tanking.
Compare the craftable to an ilvl 100 drop from nightbane (
http://www.wowhead.com/?item=28597) which has almost ideal tanking stat allocation. This is clearly superior to the comparable ilvl crafted, and in my opinion a fair bit better than the second upgrade (20 ilvl higher).
Probably the biggest advantage of the Bulwark of Kings chest is its early availability. Undoubtedly it'll be replaced fairly easily with better budget allocation item drops. Consider that the Destroyer Chestguard (
http://www.wowhead.com/?item=30113) is quite superior to crafted version at the same ilvl, but the crafted only requires a bunch of heroic runs to make (10) whereas we have yet to see what drops the destroyer chest token.
Sword:
http://www.wowhead.com/?item=28425
http://www.wowhead.com/?item=28426
http://www.wowhead.com/?item=28427
The BoP sword craftable is quite a respectable tank weapon. Decent allocation of stats to sta/agi/hit. Good dps and speed for heroic strike.
Compare to the King's Defender (chess event, Karazhan
http://www.wowhead.com/?item=28749). The King's defender seems to be better itemized for mitigation tanking and quite a good all-around tank weapon.
Summary: the craftable is good, but there are easily available alternatives which are quite comparable. Raiding 25man dungeons will likely obsolete the crafted sword as a primary tanking weapon pretty quickly.
Mace:
http://www.wowhead.com/?item=28437
http://www.wowhead.com/?item=28438
http://www.wowhead.com/?item=28439
Nice for devastate, poor for heroic strike. Not many tank stats, just a little stamina.
Axe:
http://www.wowhead.com/?item=28431
http://www.wowhead.com/?item=28432
http://www.wowhead.com/?item=28433
Dps weapon - good for tanking soft hitting stuff where rage generation is more important than mitigation.
Jewelcrafting:
http://www.wowhead.com/?item=24125
The Dawnstone Crab is a nice tank trinket, passive def and a dodge use effect. Won't make or break your tank suit because the +def soft-cap seems relatively easy to achieve.
Engineering:
http://www.wowhead.com/?item=23836
45 sta trink, not unique. It's not BoP, but you need Engi to use it. 900 extra hp is quite good for caster-type bosses where block/armor don't help nearly as much.
Enchanting:
http://www.wowhead.com/?item=22538
+4 stats to ring.
It looks like this will never become obsolete - there is no upgrade/drop which applies to rings yet.
So, in conclusion it seems that the the best picks seem to be - Armorsmithing for a chest that will likely be replaced in a few months or Swordsmithing for a tanking weapon that will likely be replaced even faster. The profession with the apparent longest term benefit seems to be Enchanting. Two ring enchants for +8 stats which will likely go on every single ring upgrade till blizzard sees fit to use the ring enchant slot for non-self enchanting.
Finally, some combination of alchemy/herbalism. Yes, this is doable by an alt, but I don't think many folk will deny the significant benefit herbing or alchemy bring to a raider's income. These would be picked based on server population - high pop servers alchemy is slightly better than herbalism I think.
thoughts?