So I'm pretty new to the forums and have been messing around with the various spreadsheets that people have already posted, but i wanted to ask a couple questions for feedback from the community, rather than looking at a spreadsheet.
First of all, I'm a Combat Swords Rogue and I was curious as to which, in essence of personal opinion or theorycrafting, would better benefit me at the moment in PvE DPS. I have been combat swords for a while but I've never truly delved into this question and I have mainly been looking for more Crit than AP.
Second, I was curious if anyone could give me feedback on my talent build to support more PvE DPS output in raids. My guild is currently only raiding Karazhan so much raiding gear is still unavailable to me, but that will change pretty soon as our progress is moving forward quickly.
Well uh, I think you've undervalued hit to a somewhat extreme extent. Like, the question isn't so much, "Should I choose crit or AP?" as it is, I think, "Should I choose crit or hit?" The thing about AP is, although it's fine and all that, obviously, you get a ton of it in raids, and I don't think it scales as well, assuming you have full raid buffs (as in, 2300 AP or whatever), as crit/hit do, being that at that point AP is still a static increase in damage, whereas crit/hit are at least scaling increases (that is to say, 1% crit, which would be 22 or so crit rating, means more in a raid with fully buffed AP and substantially higher damage than it would unbuffed, in terms of the actual flat amount of damage it would add compared to 44 AP). I think hit/crit are generally more important in a raid, since you get a TON of AP from buffs, but that's just because I think you should keep things balanced, and I'd say it might be a better idea to balance your stats around being fully raid buffed as opposed to being unbuffed, since the only time your sustained DPS is going to matter will be with full buffs on. So I wouldn't be adverse to maybe dipping a little low on unbuffed AP to get your hit to a really good place, and maybe keep your crit up, since in a Karazhan raid you're going to be picking up like 800 more AP.
So to answer your question, I personally would say crit is more valuable, and scales better, than AP in raids. But from your gear, I think the correct answer is really neither, and that you should focus on getting your hit in a better spot (above 200, ideally). Also, as far as your spec goes, it's pretty typical for pure PVE, and I think the only real notable change you could make would be to swap out 2 points in Vile Poisons for 2/2 Murder.
Thanks for the input, I'm working on upping my hit atm and I did a bit last night and messed around with my DPS a bit as well as changing the talent points. I'd thought to change them earlier, but I hadn't gotten to it. But i did notice at least some improvement in my dps in the testing I did.
To be honest, I was underestimating how much +hit can help, and it didn't seem to click until I came here and started browsing around. Everything seems to be making a bit more sense now.