With most of the good caster trinkets being haste procs and crit procs i've started wondering what the best trinkets are for warlocks. There have been lots of talk about it for a page or so on many of the other warlock threads and i thought it would be good to get all of the discussion in one place.

It looks like the best trinkets for an affliction lock are crusade card and icon, if your hit capped. Destruction warlocks prolly could just use the same trinkets as fireball mages. Or am i wrong?

Using the equation from Uptime, the Ashtongue Trinket comes out to 31% uptime at 220 spell damage, which averages out to 68 spell damage if you have corruption ticking 100% of the time on one mob. It's decent but not amazing. It gets dramatically better if you can keep Corruption ticking on two mobs though, bringing it up to 115 spell damage.

I put Ashtongue Trinket in my Warlock DPS XLS calculator , along with number of other potentially good warlock trinkets, and effective +dmg from it is close to what Demi mentioned above.

Since I calculate based on actual number of ticks, which is less than 100% caorruption coverage due to misses, lag and corruption recast delay (ie it wears off just as you start SB), results that i get are +60 dmg equivalent if corruption used only on boss, and 104 +dmg if used on one more mob (+135 for 3 corruptions, +158 for 4 , but use all numbers over 1 corruption with reserve, since i presumed corruption uptime same as on boss , ie over 90%, which could be done on 2 mobs abut rarely can be done on more )

Because I tend to be lazy and forget about trinkets, I still use my old Neltharion's Tear as it's one of the best passive benefits of any trinket. Something like Quagmirran's Eye has a decent chunk of damage (still less), but the haste benefit is generally lost on me since I'm Affliction.

I like having one passive trinket (will end up being the Ashtongue trinket later on) and one "Use" trinket. My ideal trinket set up is the Icon of the Silver Crescent and the Ashtongue trinket. I should get Silver Crescent shortly, but I'm quite a ways off from getting any sort of Ashtongue rep (let alone the amount needed for the tinket), so I'll probably stick with Neltharion's Tear for quite some time.