Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » User Interface and AddOns

Reply
 
LinkBack Thread Tools
Old 01/19/11, 10:30 PM   #1
kameelyan
Von Kaiser
 
Tauren Druid
 
Kil'Jaeden
Druid Resto Mastery Addon

I'm working on an addon to track healing gains through Druid Mastery (Resto).

Currently I've got the addon working to track if a spell is affected by mastery or not. From my testing it appears to be working perfectly. The last step I need to take is summing the values and analyzing them.

However, there is an error I'm seeing every now and again. It's really hard to replicate, so I wanted to reach out to the community to get some ample base sizes.

The files are here:
Addons/Druid Mastery

WoWInterface:
Druid Mastery : Druid : WoWInterface AddOns

Huge props to Pyrates as I began with looking at his MasteryCounter addon and getting some ideas. Eventually went another way, but he definitely played a part.

Thanks!

Here's a Pastey link for anyone who wants it:
Pastey.net - wowuidev paste bin

Last edited by kameelyan : 01/20/11 at 11:52 AM.

Offline
Reply With Quote
Old 01/20/11, 4:35 AM   #2
Pyrates
Piston Honda
 
Pyrates's Avatar
 
Night Elf Druid
 
Nozdormu (EU)
Great you're working on this, so I don't have to do it Code looks good so far, although I'm not sure why you didn't include efflorescence in the spell list (should just be a matter of adding it in, right?). But why aren't you checking on "sourceName == UnitName("player")" on SPELL_HEAL and SPELL_PERIODIC_HEAL? I'd say that one would start the handler function of COMBAT_LOG_EVEN_UNFILTERED just with "if not sourceName == UnitName("player") then return end" and be done with it.

Could you give an indication what the error is about? That might make triggering it easier

Offline
Reply With Quote
Old 01/20/11, 11:22 AM   #3
kameelyan
Von Kaiser
 
Tauren Druid
 
Kil'Jaeden
Nice catch on the sourceName on spell_heal and spell_periodic_heal. I run 10 man as the only resto, so when I tested it last night it was working, but would have screwed up had there been another in raid.

In terms of efflorescence, I'm not sure it's affected by mastery. For example, if you rejuv a target you're standing next to, then swiftmend (with glyph of course), the player has a hot on them, but efflorescence ticks the same on both myself (no hot) and the player (has rejuv). Obviously, it's affected by Swiftmend's mastery gains, but that'll be 100% of the time.

After about 3 hours of testing, I couldn't get the error to recreate, so I'm satisfied currently. Going to keep testing as I update the addon, although I'm pretty much done with it I think.

Here's a pastey link with the line of code that typically errors:
Pastey.net - wowuidev paste bin

I believe it's happening because the combat log event isn't always properly returning the destName (who the spell was cast on) argument.

Lastly, I update the first post with the latest version. I'll be updating with a wowInterface link once it gets approved. The addon has been updated with collecting data now. It'll collect both tick counts and overall healing breakdowns. Lastly, there is a toggle to have it collect in/out of combat (although currently it's set to only collect in combat and sets to that toggle on every load of the addon [every time you load wow]).

Last edited by kameelyan : 01/20/11 at 11:34 AM.

Offline
Reply With Quote
Old 01/20/11, 3:51 PM   #4
kameelyan
Von Kaiser
 
Tauren Druid
 
Kil'Jaeden
Here's the error I'm getting:
Pastey.net - wowuidev paste bin

And the code to this version:
Pastey.net - wowuidev paste bin

Offline
Reply With Quote
Reply

Go Back   Elitist Jerks » User Interface and AddOns

Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
[Druid] Cataclysm Resto Druid PvP Tips & Tricks lazorbeam Player vs. Player 12 09/08/11 7:10 AM
[Horde][Malfurion]<Promethean> 11/12 HM-ICC25 LF Melee DPS, Resto Druid, Resto Shaman Amiye /LFGuild 0 04/06/10 10:47 AM
[Alliance][Executus] <Eye Candy> 4/5 ToGC - LF Resto Druid/Shaman, Feral Druid goss /LFGuild 0 09/24/09 6:54 PM
[2v2] Rogue + Resto Druid vs. Warrior + Resto Druid Reubarb Player vs. Player 14 10/07/07 5:47 AM