Mondragon

Figured this was a good place to ask this. For a coder like yourself, are agro reducing trinkets given any special coding focus?

Are they equipped by a player and then treated the same as a player who has spent talents on an agro reduce?

I only ask after seeing the Vashj trinket reducing agro on crits..and wondered if this would be hard for you to implement into a threat meter.

 

Antiarc

Equipment is handled separately. Most -threat items produce a buff on the player that has some effect on threat; this is fairly trivial to add, and is just a matter of making sure the buff is detected and handled.

In other news:



Eats CPU like a mofo, but it sure is fun to watch.

 

Caryna

Many of my guild are now moving over to Omen for obvious reasons. However, scaling of the frame is still highly desired. Another thing that would be great would be to be able to have the frame/border be a fixed size so it can be fit into an UI layout without having to guess how big it will grow.

You know that you play too much WoW if you partners pants become a rare drop.

 

Schneeb

Does anyone else experience only seeing KTM data and/or not seeing yourself ?! For me being a healer i'd imagine not seeing myself might be due to being out of the top10 but was curious.

 

Nemaa

Just tell them to use KTM and omen as well. If they don't like the current layout of omen they can toggle it off, it will be running in the background. Also you can filter KTM to get more accurate data for situations where there are more mobs (if all tanks have omen running).
This is what I'm going to tell to convince my guildmates.

 

whiteshade

Latest version of OMEN can be resized

 

• Shareel

We tested Threat-1.0 and Omen (latest build) yesterday and have some false calculations.

There was an single mage (always the same mage) around 300% threat ahead of all other raiders on most mobs.
The biggest mistake was at our Maulgar kill. The "Mage-Tank" from Krosh Firehand wasnt in the Top-10 from Krosh. But the mage from above was 300% ahead of all others but don't shot anything at Krosh .
I stand next to the "Krosh-Tank" and dont understand why this data are so weird.

What can cause Threat-1.0 to report such wrong data or is there anything we can do to track this down.
My assumption is an Threat-1.0 user with an inaccurate system cloak which corrupt the sync data. But I dont have any idea how Threat-1.0 works internally.

 

Cel

I updated all my mods yesterday night and subsequently got nothing in my Omen window during raid.

The Threat1.0 seems to be working fine, since Pitbull (which has recently implemented a display for my threat) was showing my threat, but I wasn't getting KTM data passed to Pitbull, and a Warlock in the raid had Omen working, but also wasn't getting KTM data.

Could it be that Pitbull messed with Omen for me? I didn't try disabling Pitbull cause I need a lot of it's features.

"There is much pleasure to be gained from useless knowledge." - Bertrand Russell

Alpha is recruiting... go go.

 

Muggins

Strange little bug occurred today.

I've been testing Omen for a couple of days and its been running nicely, i also keep it updated as often as i can. Today i wanted to get rid of Atlas Loot simply because i felt it was a waste of my system resources, however when i did remove it the Omen GUI also vanished. I tried using the various commands to bring it back to no avail, i exited the game and reentered, i even removed omen from the addon list and then added it back on again to see if it worked. No luck at all, however as soon as i turned Atlas Loot back on Omen is sat there waiting for me with a 'where have you been?' puppy dog look.

Edit:

This is getting wierd now, one of my guildies was having trouble getting omen to show up even though he was getting the welcome message. Jokingly i said, 'Hey try getting Atlas Loot and see if that works ^^' he downloaded it and as soon as he turned it on up popped the Omen GUI.

 

Zadnak

I had the same problem yesterday as well and I'm using Xperl unit frames.

 

Zerix

This is probably because you removed a mod with the Dewdrop Library. For some reason Omen doesn't include this library, we had to figure this out last night too for guildies that ran no Ace mods.

Also it seems like the Omen window flickers from time to time for whatever reason. I tried setting the TPS numbers much higher and it seemed to cut down on it but still flickered, just a slightly annoying bug .

 

surrender

** delete pls **

 

Lofted

As of posting this I can't get Omen to show up at all. I downloaded 'Omen-r38893' and 'Threat-1.0-r38867' this morning.

[e] I use ag_UnitFrames and have AtlasLoot as well.
[e2] Omen showed up only when took the FP from Shat to Blade's Edge and it started working when Chat Channels changed. Seemed like that kicked it into working somehow. ??

I'm not sure yet how that 'real time' graph works, but since it eats so much CPU would it be possible to allow each person to look at their threat in real time vs. the person who currently has agro and then allow the person with agro to see them self vs. the next highest?

In my experience this would be really useful when the Tank was stunned, knocked down, or had sudden changes in TPS. A visual of this would be a lot easier for DPS Players to respond to than having to notice changes in relatively small TPS digits. There are some DPS in my guild that jump ahead of my threat on some encounters because my threat dips suddenly for a second or two.

I would really like a real time graph like the one you have in the screen shot so long as it doesn't destroy everyone's CPU and is still updating fast enough to still matter.


So far the only problems I have noticed with Omen are small; such as I get a killing blow on a mob and at least some portion of threat is applied to the meter after I leave combat. Seems like whatever code deals with clearing threat values needs to be looked at.

I look forward to being able to use this Mod in the near future.

 

Antiarc

The reason so many people had GUI problems yesterday was likely that I checked in a broken build; it should be working better now.

I'll make sure that Dewdrop is externed.

Shareel: Was this mage with the reporting problems running KTM? If not, was he up to date with the latest copy of Threat?

 

Dirich

Damn, doubleposted :/

 

Dirich

Are you talking about that graph under the standard "bar window"? I agree it can be fun to watch, but where's the utility in watching at it (and I doubt that we would be able to "read" it during a 25 man raid anyway)? If it's only for tps comparison than it would be easier to see a big number (tank tps - your tps). An additional window which shows a bar for tank's tps and another for your tps would be another good option (mmhh I think someone already suggested something similar, but ) can't remember exactly :P ).

By the way, it would be good to be able to "set" who's the tank on certain mobs (with "tank" = "higher on trath" as the default option). With the tank "setted" the tps comparison is not going to be falsed by someone overaggroing the tank.

Edit: ok, maybe the graph basic idea is to provide us with some way to see the average and actual tps, because both of them are interesting data. If only the tank and your tps are monitored, as long as you solve the cpu issue and you are able to "set" the tank on the mob, it's going to be really great.

 

chase

Filters. You know who the tanks are before the fight, so you can filter out all bars but yours and the tanks. The GUI could even go so far as to attempt to import a list of tanks from ORA MT list. Your bar list than contains all tanks with threat on the target and your threat.

I would be wary of filtering it further as you can run into many rare cases where filtering it further increases the likelyhood of failure to display relevant information.
e.g. Highest theat + MT list does not give 100% certainty they have aggro.
e.g. Cases where you want to stay away from being #2 in threat.

 

• Cryect

Heh, performance for the realtime graph's is my job and I've doubled the performance of the graphs since last night few more changes should be possible as well to improve performance (such as reducing the frame rate of the real time graph to actually be less than your current frame rate).

I need to do something useless.

 

Celandro

The small graph shows far far more information than the simple table does. Graphs are far far superior to tables for time series data (like threat over the course of a fight). I would suggest that a 10px by 10px square graph would be all most dpsers really need. You could very easily show the 80% to 110% or 100% to 130% agro ranges in 10 pixels.

I'm a huge fan of graphs, especially extremely compact ones.

 

Celandro

I'd suggest using an 'update graph' type event that the addon could fire itself. Updaing a TPS graph 2 times a second should be ok from a cpu perspective.

Also Im not sure how you are generating the graphs, but if you are creating a texture what you can do is make a texture with the width and height of the graph, say 10 by 10. You then start with texture coordinates of 0,0 -> 1,1. On first update, you change the texture coordinates to 0.1,0 -> 1.1,1. You then only have to change 10 pixels of the texture. Not having to recreate the entire texture is a faster operation. Also the addon will only have to send you a message that says 'add one data point' instead of 'display all these data points' Once you get up to 1.0,0 -> 2.0,1 you can put the coords back to 0,0 -> 1,1 since the textures will map that way anyhow.

 

• Cryect

It's using GraphLib and its not creating textures or anything on the fly. It actually uses StatusBars since when you set the value of a status bar it doesn't require WoW to check if any frames are attached to the bar (was like a 10% increase over using :SetHeight with textures from what I recall though that was long ago).

Anyways most the obvious stuff has been addressed long ago. I just haven't spent much time optimizing them since I nor anyone else has been using them. Though, now I'm about to add them into Recount and Antiarc expressed interest in using them so spending some time on improving them.

One thing I could do is add bucketing of data as it comes in but wouldn't really matter for addons like Omen or Recount (data in these cases is actually fairly sparse) though would matter for things like a FPS graph (where you have a new data entry every frame but a single bar actually represents several frames so can bucket that data down to the size of 1 bar while essentially keeping it the same).

I need to do something useless.

 

Antiarc

I've had a few people tell me that as of 2.1, Nightbane no longer clears aggro before landing. Does anyone know if this is accurate or not?

 

Celandro

I was actually talking about creating and modifying a texture in memory but I don't know if the wow api lets you do that. Creating and setting the texture 1 time and then just modifying the pixels in the texture and the texcoords is usually a fast way to do real time graphs.

 

• Nite_Moogle

Some wipes last night where our tank had a huge threat lead before the transition followed shortly by one of our ranged DPS getting plastered suggests he still clears aggro on landing.

 

Jandari

Unsure, I've only done one Nightbane kill since 2.1 and the tank did pick him up flawlessly on each landing. But I don't know if that was due to threat not wiping, or his ability to pick him up.