Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » User Interface and AddOns

Reply
 
LinkBack Thread Tools
Old 06/05/07, 7:38 PM   #326
Harem
Great Tiger
 
Harem's Avatar
 
Tauren Warrior
 
Mal'Ganis
Originally Posted by chase View Post
Looking at your code you seem to be pulling information from the threat lib every .5 seconds or so. (can be set by user)

Maybe I read the API wrong, but isn't the min update frequency (broadcasts) set at 1.5 seconds for a 25 man raid? Are you actually requesting updates from everyone every .5 seconds?
UI is requesting threat from Library every 0.5 seconds. Library is updating it's list from everyone else's Library every 1.5 seconds.

Offline
Reply With Quote
Old 06/05/07, 8:17 PM   #327
Antiarc
Still alive
 
Antiarc's Avatar
 
Human Rogue
 
Cenarion Circle
Originally Posted by chase View Post
Looking at your code you seem to be pulling information from the threat lib every .5 seconds or so. (can be set by user)

Maybe I read the API wrong, but isn't the min update frequency (broadcasts) set at 1.5 seconds for a 25 man raid? Are you actually requesting updates from everyone every .5 seconds?
The TPS update speed is solely client-side and just determines how often TPS is re-calculated based on the threat information that Threat-1.0 itself has received from other clients.. Raising it (or disabling it) will free up more CPU; lowering it will make the display smoother at the cost of more CPU. You never make a request for threat info to other clients; clients publish info as they have it on a timer ranging from (right now) 0.5 seconds to 1.5 seconds based on group size. Note that you're not going to fire off threat updates on that period unless you actually have changes to report, so the actual reporting period tends to be lower.

Offline
Reply With Quote
Old 06/05/07, 8:40 PM   #328
Vulpes
Glass Joe
 
Night Elf Warrior
 
Runetotem
Originally Posted by Necrotoid View Post
DoTimer seems to separate mobs 100% when they are marked with raid icons (and shows the raid mark icon on the timer), and I have trouble with it collapsing mobs with the same name when they are not marked. I'd always assumed it had access to the mob's icon and could use this to differentiate them.

Is the reason a target-based mod (like DoTimer) can do this but not a threat meter because a threat meter must work even when you are not targetting the mob to be tracked?
I think this post got lost in the tread but Necrotid brings up a great point. I'm wondering why is it not possible to separate marked mobs through some other means outside combat log. Asheyla seemed to have figured out the way to do it, maybe so can threat-1.0?

Offline
Reply With Quote
Old 06/05/07, 8:52 PM   #329
chase
Piston Honda
 
Dwarf Priest
 
Malygos
Originally Posted by Antiarc View Post
The TPS update speed is solely client-side and just determines how often TPS is re-calculated based on the threat information that Threat-1.0 itself has received from other clients.. Raising it (or disabling it) will free up more CPU; lowering it will make the display smoother at the cost of more CPU. You never make a request for threat info to other clients; clients publish info as they have it on a timer ranging from (right now) 0.5 seconds to 1.5 seconds based on group size. Note that you're not going to fire off threat updates on that period unless you actually have changes to report, so the actual reporting period tends to be lower.
So any TPS update quicker than the broadcast update only makes TPS smoother for the owner of the client. Granularity for everyone elses TPS is the broadcast frequency. Makes sense now.

e.g. My TPS will be smooth on my UI. The TPS I see for the tank will never have granularity of under the broadcast update.

Offline
Reply With Quote
Old 06/05/07, 8:59 PM   #330
Antiarc
Still alive
 
Antiarc's Avatar
 
Human Rogue
 
Cenarion Circle
Originally Posted by Vulpes View Post
I think this post got lost in the tread but Necrotid brings up a great point. I'm wondering why is it not possible to separate marked mobs through some other means outside combat log. Asheyla seemed to have figured out the way to do it, maybe so can threat-1.0?
Any spell that can hit something you don't necessarily have to have targeted can't be tracked by any means other than the combat log. Multishot is a good example.

Offline
Reply With Quote
Old 06/05/07, 9:06 PM   #331
Kalman
Super Macho Man
 
Kalman's Avatar
 
<>
Orc Shaman
 
No WoW Account
Originally Posted by Antiarc View Post
Any spell that can hit something you don't necessarily have to have targeted can't be tracked by any means other than the combat log. Multishot is a good example.
Actually, even easier, any spell that can be targeted via mouseover is *probably* untrackable by any means other than the combat log.

Last edited by Kalman : 06/05/07 at 9:21 PM. Reason: Qualified the statement, there are better people than me.

Melador> Incidentally, these last few pages are why people hate lawyers.
Viator> I really don't want to go all Kalman here.
Bury> Just imagine what the world would be like if you used your powers for good.

Clearly law school has done wonders for me.

United States Offline
Reply With Quote
Old 06/05/07, 9:07 PM   #332
♦ Praetorian
Mike Tyson
 
Praetorian's Avatar
 
Orc Shaman
 
Mal'Ganis
Random question: I know tanks that use mouseover Sunder Armor macros. Is that untrackable?

Offline
Reply With Quote
Old 06/05/07, 9:16 PM   #333
Antiarc
Still alive
 
Antiarc's Avatar
 
Human Rogue
 
Cenarion Circle
Originally Posted by Praetorian View Post
Random question: I know tanks that use mouseover Sunder Armor macros. Is that untrackable?
A mouseover sunder armor -might- be problematic. For some reason, I want to say it won't be, but I'll double-check the events tonight. Given Sunder's lack of a combat message when it lands on a 5-stacked target, this will need to be verified.

Edit: Mouseover should be fine - UNIT_SPELLCAST_SENT specifies the name of the target that you sent the spellcast to.

Offline
Reply With Quote
Old 06/06/07, 4:35 AM   #334
Demi9OD
Don Flamenco
 
Orc Warlock
 
Shadowmoon
Any chance of getting a toggle to turn off KTM interoperability? I have a strong feeling its far more trouble than good, yet some people will continue running KTM for weeks even after we mandate Threat use. Also, I couldn't see myself on Omen all night tonight. I saw others that had KTM install but had no idea where I was.

Offline
Reply With Quote
Old 06/06/07, 4:50 AM   #335
Antiarc
Still alive
 
Antiarc's Avatar
 
Human Rogue
 
Cenarion Circle
I committed a KTM filter in Omen tonight.

Offline
Reply With Quote
Old 06/06/07, 5:33 AM   #336
Imba
Von Kaiser
 
Imba's Avatar
 
Tauren Warrior
 
Doomhammer (EU)
Just an idea how to different mobs with same name could be authorized by Threat... if they are marked by raid marks maybe its possible to see what marks are what and then recognize threat done to them? :S but i guess that would make even more problems if marks get changed :S

Offline
Reply With Quote
Old 06/06/07, 7:06 AM   #337
whiteshade
Glass Joe
 
Draenei Mage
 
Nagrand (EU)
i did some trivial modification to the code to let it resize the width of the window & the bars cuase some my guildy stressed me about the dimensions of the window. It's very bad accurate but this let them use it and test a bit in KZ.

btw we tested OMEN with KTM on during our last Prince in KZ yesterday and well it does some mistakes:

a) shadowfiend always displayed
b) aggro was not equal in KTM window and OMEN window (it seems KTM was more precise).

Hope u can fix it soon.

Sorry for my english again.

Offline
Reply With Quote
Old 06/06/07, 7:25 AM   #338
• Chicken
Co-starring: The Egg
 
Chicken's Avatar
 
Ginakursia
Goblin Warlock
 
No WoW Account (EU)
Originally Posted by Imba View Post
Just an idea how to different mobs with same name could be authorized by Threat... if they are marked by raid marks maybe its possible to see what marks are what and then recognize threat done to them? :S but i guess that would make even more problems if marks get changed :S
This isn't possible to do accurately. It works for DoT Timer addons as you can always know which exact mob someone targeted and after that the duration of the DoT is pretty much fixed, but it'd get inaccurate for a threat meter which doesn't just have to track the spellcast, but also the damage done by the spell, and the damage done by the spell can vary through partial resists, damage increasing debuffs etc.

Plus there's simply no good way of handling AoE through it.

buff /bʌf/ Pronunciation[buhf]
–verb (used with object)
- to reduce or deaden the force of

Netherlands Online
Reply With Quote
Old 06/06/07, 7:37 AM   #339
radiante
Von Kaiser
 
Draenei Shaman
 
Stormreaver
Originally Posted by Antiarc View Post
There's an option for the TPS update speed in there, as well as the sample window (larger window = smoother numbers); however, my TPS algorithm is pretty shoddy, and I'm working with Kalman to come up with a better one.
There are some know alrorithms that u could use:

- First you could use several windows information an take the average which would have an efect of having a larger window
- You take serveral windows with weight. For example you have two windows one from the last 0.5secs and one from 1 sec ago, you want to give the last one priority then it would be someting like1*WindowOne+2*WindowTwo)/(1+2). This gives a higher priority to the most recent information
- ActualTps =(1-A)*LastTps+A*ThisWindowTps were A is between 1 and 0. For example take A=0.5 and in the first period you a WindowTps=30, your ActualTps=30 because u dont have more info. In the second perioriod you have a Tps=100, then: ActualTps= 0.5*30+0.5*100=65. In the third period you have WindowTps=100 again, then ActualTps= 0.5*65+0.5*100= 82.5
Etc. The closer A to 1 the more weight new information has.

Offline
Reply With Quote
Old 06/06/07, 9:41 AM   #340
Zanthor
Von Kaiser
 
Orc Shaman
 
Blackhand
Originally Posted by Antiarc View Post
I committed a KTM filter in Omen tonight.
Filters out KTM? Highlights the KTM data? Or?

Offline
Reply With Quote
Old 06/06/07, 11:44 AM   #341
• Chicken
Co-starring: The Egg
 
Chicken's Avatar
 
Ginakursia
Goblin Warlock
 
No WoW Account (EU)
Originally Posted by Zanthor View Post
Filters out KTM? Highlights the KTM data? Or?
KTM Filter. Read it a few times, and you'll get it.

(In case you still don't: Your first option)

buff /bʌf/ Pronunciation[buhf]
–verb (used with object)
- to reduce or deaden the force of

Netherlands Online
Reply With Quote
Old 06/06/07, 1:28 PM   #342
Antiarc
Still alive
 
Antiarc's Avatar
 
Human Rogue
 
Cenarion Circle
I believe that shadow priest threat has problems; my Karazhan run last night showed everyone except our shadow priest right about where he should be, so there's work to be done there.

Offline
Reply With Quote
Old 06/06/07, 5:24 PM   #343
Ellurion
Glass Joe
 
Ellurion's Avatar
 
Night Elf Hunter
 
Warsong (EU)
Sorry if I repeat someone, but had some errors today on Hydross the Unstable.

Btw nice mod.

Offline
Reply With Quote
Old 06/06/07, 5:45 PM   #344
Antiarc
Still alive
 
Antiarc's Avatar
 
Human Rogue
 
Cenarion Circle
Yeah, I've had a few people tell me about the Hydross errors. I think it's a problem in the core, rather than the Hydross module itself, but damned if I can reproduce it.

Offline
Reply With Quote
Old 06/06/07, 6:50 PM   #345
• Chicken
Co-starring: The Egg
 
Chicken's Avatar
 
Ginakursia
Goblin Warlock
 
No WoW Account (EU)
Originally Posted by Antiarc View Post
Yeah, I've had a few people tell me about the Hydross errors. I think it's a problem in the core, rather than the Hydross module itself, but damned if I can reproduce it.
I reported this error on WoWAce before with Hydross, but the exact same 'yell_arg2' error happened to me on Magtheridon as well today. The moment it happened is when he released.
For reference this is the error I'm speaking of: Threat-1.0\Threat-1.0\ThreatNPCModuleCore.lua:187: attempt to call local 'yell_arg2' (a table value)

Could be related to the fact I'm using an enGB client. Or perhaps not.

buff /bʌf/ Pronunciation[buhf]
–verb (used with object)
- to reduce or deaden the force of

Netherlands Online
Reply With Quote
Old 06/06/07, 7:01 PM   #346
Antiarc
Still alive
 
Antiarc's Avatar
 
Human Rogue
 
Cenarion Circle
Hm. I wouldn't think that enGB would cause problems. When did you last update - I made a fix in that area yesterday afternoon.

Offline
Reply With Quote
Old 06/06/07, 7:03 PM   #347
• Chicken
Co-starring: The Egg
 
Chicken's Avatar
 
Ginakursia
Goblin Warlock
 
No WoW Account (EU)
Originally Posted by Antiarc View Post
Hm. I wouldn't think that enGB would cause problems. When did you last update - I made a fix in that area yesterday afternoon.
Ah that could be it, I didn't update since yesterday afternoon in my local time, which is before your yesterday afternoon.
Edit: Currently I'm on r38409

I'll try to remember updating before the raid tomorrow, we'll be going SSC again and I'll be able to test if the Hydross error still pops.

Last edited by Chicken : 06/06/07 at 7:12 PM.

buff /bʌf/ Pronunciation[buhf]
–verb (used with object)
- to reduce or deaden the force of

Netherlands Online
Reply With Quote
Old 06/06/07, 7:06 PM   #348
Mulva
Von Kaiser
 
Human Warrior
 
Arthas
Originally Posted by Chicken View Post
Could be related to the fact I'm using an enGB client. Or perhaps not.
It's not just an enGB client issue - I had the exact same error on Magtheridon, and it occurred 16 times total according to bugsack. It seemed to correlate to when he was doing his blast nova.

Offline
Reply With Quote
Old 06/07/07, 12:13 AM   #349
Roana
Piston Honda
 
Blood Elf Paladin
 
Turalyon
Originally Posted by whiteshade View Post
b) aggro was not equal in KTM window and OMEN window (it seems KTM was more precise).
That's probably due to a bug in KTM I discovered today, namely that KTM gives Shield Slam too much threat (my guess is that the innate threat gets added both for "You perform Shield Slam on <mob>" and "Your Shield Slam hits <mob> for <damage>", but I may be off -- I'm speculating as to what the reason is).

Briefly, a 529 damage Shield Slam made KTM 19.18 jump by over 1.7k threat, when it should be less than 1.3k for me.

Omen, in comparison, seems to calculate Shield Slam threat correctly.

Last edited by Roana : 06/07/07 at 12:19 AM. Reason: Added version information for KTM.

Offline
Reply With Quote
Old 06/07/07, 1:24 AM   #350
Eyana
Glass Joe
 
Blood Elf Paladin
 
Taerar (EU)
First of all:
I apretiate all the effort you and your team make for this mod! THANK YOU
i waited for a ktm replacement for a long time now and i can't wait to get my hand on the first "stable beta".

i testet it for a litle while in ssc and tk this night.
KaelThas:
Phase 1:
threat-1.0 dont wipes globalthreat after each add is dead. i start with old healthreat on each add ( which i should not have)
here are the emotes when an add engages:
1. doesnt matter
2. Lord Sanguinar yells: Blood for blood!
3. Grand Astromancer Capernian yells: The sin'dorei reign supreme!
4. Master Engineer Telonicus yells: Anar'alah belore!

The Lurker below:
The adds that spawn during phase 2 also have my global threat not wiped. i dont remember their names right now, ill have to check next week.


Other stuff:
-shadowpriest aggro is broken somehow (as you said before)
-Some guildies of mine reported that omen screwed up their other addons settings. Iam sorry that i cant give you anymore specifics on this one

Offline
Reply With Quote
Reply

Go Back   Elitist Jerks » User Interface and AddOns

Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
Threat and threat reducing abilities of bosses (Void Reaver) alkis Public Discussion 4 06/26/07 7:23 PM
Which damage meter? Pane User Interface and AddOns 35 04/16/07 8:03 PM
Omen of Clarity proc rate Floria Class Mechanics 13 03/24/07 2:12 PM