starlon

I was hoping to see something different when I loaded Warmup. What's taking Threat and Omen so long to load?

 

Antiarc

Huh, not sure. If that's the first mod you have in there that's loading all the Ace libs Threat uses, then that'll drive up the load time; if you load them after various libs have been loaded, it'll drive up the garbage generated, but the load time should be relatively low. Regardless, I will definitely be looking at ways to slim it down. If you come across anything obvious, please let me know!

You could easily test it by disembedding the Threat and Omen libs - install them without externals, and then install the libs they require and run another Warmup report. I suspect they'll be a lot lower. In particular, the Babble libs likely contribute to a vast majority of that time, just due to their sheer file size and the amount of time it takes to parse the file.

 

◊ Shalas

Lua table parsing/evaluating takes effectivly zero time regardless of size. An addon with a 500k row table of short strings loads in .3-.5 seconds according to warmup, and has no mesuarable effect on startup/login time when mesured by hand. Each Babble module takes about a twentieth of a second to load according to warmup, so if you're loading all of them that'd explain about a second of it, but that second is spent almost entirly on Ace2 stuff and would not be any faster if you removed the data completly.

 

Gonkish

Awesome.

Why Hunters suffer...
Benefactor's Bar learns you some goodness quicklike...

 

starlon

Ok, I did as you suggested. I loaded it twice just to make sure.

 

Antiarc

Ok, well, that's definitely better in the Omen department, but that Threat number is higher than I'd like. Once I've got the other bugs worked out, I'll dig around and see if I can find places to slim it down.

 

starlon

The majority of that time seems to be related to Threat-1.0-Cleanup.lua.

 

Antiarc

That's not too surprising. That's where Threat actually gets "created" as it were - the rest of it is just function definitions that aid in the creation of the Threat library, basically so that we can have a multi-file embeddable library.

In short, that's where Threat actually gets "booted up", so unfortunately, it hides where the time's actually being spent. Though, it should be pretty easy time profile the individual function loads in there, so we can identify the slow spots pretty easily.

 

Antiarc

Fixed the pet ability bug in Threat tonight (turns out I got a little overzealous with my comments in fixing Misdirection last night) and added skinning to Omen. Now you can basically set any combo of settings as a "skin", and switch between skins at will. Omen now ships with four default skins, and you can, of course, add your own at will.

Oh, and font sizes/faces/colors are configurable now, too.

http://i17.tinypic.com/61vxisn.jpg for a rather poor example.

 

◊ Zoid

Just did a get, looks like Omen is depending on Babble-Race but didn't include it as an embedded library. I solved it for now by getting it as an external.

 

Abbi

Someone's written an Omen -> KTM threat reporting bridge; still in beta, haven't tried it myself, but here:

http://www.wowace.com/forums/index.php?topic=6768.0

 

authority11

Downloaded the mod today. I set it to show 8 bars only, but when I hit "test bars" it was still showing the default number of bars. I then tried to clear the threatmeter and even made myself a raid leader in a raid to do so and it still would not reset. Am I doing something wrong?


edit---
Now I deleted omen from my addons and then reinstalled it and now I'm not even able to see the mod at all. I type /omen and it does nothing. There is no minimap button either. However, performanceFU is showing Omen as running in the background. I'm so confused

 

Huss

Yeah, newest version of Omen seems to be slightly bugged. It's showing up on my FuBar, but no Omen window appears when the plugin is clicked. The mouse-over tooltip for the FuBar plugin appears normally, and the right-click menu drops down below the screen. No errors or anything, just isn't working.

 

Miaxi

Thanks a lot for the new interface options, Antiarc. Being able to assign different textures to my own bar makes it SO much easier to read than the tiny arrow on the left.

 

Zyz

Not sure if this has been requested already, but would it be possible to add an option to toggle the version text and "omen" title text?

 

• Chicken

I tried it out yesterday a bit, it's definitely still under heavy development. The version I had, for instance, sent out some really insane threat numbers constantly... And while I'm used to generating high threat on Phantom Guest packs in Karazhan, I don't think I'm usually generating approximately one million threat per second in total.

Oddly enough it also caused other displays using threat-1.0 to bug. Not just other people's KTM.

buff /bʌf/ Pronunciation[buhf]
–verb (used with object)
- to reduce or deaden the force of

 

sp00n

Is there any advantage in using TTK over Omen's build in KTM compatibility?

 

• Chicken

Omen doesn't send threat to KTM. That's pretty much the advantage.

buff /bʌf/ Pronunciation[buhf]
–verb (used with object)
- to reduce or deaden the force of

 

sp00n

Ah, I thought this was already the case. Must have misunderstood it then.

 

Opioid

Can you please not make the pet bars pink? Its pretty maddening when I am doing a five man with my Felguard and the tank is a Protection Paladin and I just two pink bars dancing without knowing who is who. I know the names are still there and all but its still an extra second each time I glance over and I'd prefer not having to analyze it and just seeing the pretty colors dance during the times when I know things are "safe"

 

Fireye

I'm noticing some not-accuracies with my voidwalker and my threat. Specificly, referring to Torment. I'll pull aggro at about 100-105%, instead of 130% as it should be. I'll try and narrow down the exact percentage. Only affects threat when torment is used, so I think Threat-1.0 may be calculating Torment's generated threat too high.

 

Nemaa

I have the latest Omen (40327) and I noticed wrong coloring of class threat bars. I filtered out all classes except druids, warriors, hunters and warlocks. One of the hunters got warlock color, than later he changed to paladin color. One of the warlocks has blue color like my threat bar. I did not change any bar's color. I can't tell you more specifics.

 

sp00n

Had that happen as well, the warrior color was suddenly those for warlocks, hunter was mage, my own yellow instead of red, etc.
Moreover I had the bug again where the threat for other players stops, again together with the bug that I couldn't open the raid window anymore. I'm starting to believe that the threat bars not showing/updating is just a follow up of the other bug, which doesn't necessarily has to be caused by Omen/Threat.

 

Beska

I've also had this bug occur, it's very annoying and confusing if you quickly glance at the meter during an encounter.



Correct sequence of classes are:
Warrior
Druid
Warrior
Druid
Warrior
Shaman
Mage
Warrior

 

Antiarc

Huh, thought I squashed that one. I'll take a second look into it.

Opioid, the pet bars are pink due to internal Blizzard assignments - that is, pets are assigned a class, and in your pet's case, the assigned class is "paladin". My hunter's pet, for example, is a "warrior", and my warlock's imp is a "mage".

I'll see what I can do about custom-coloring for pets, though.

Fireye: What rank of Torment was being used?