While your rooting around in the code, mind adding those arrows back in that I asked about a month or so ago? I know it's a minor change, but it'd be nice, so when you get a chance. ^_^


edit:
I'm forgetting all kinds of punctuation today. >_<

I've noticed some display issues with Omen every now and then:



The threat values themselves appear to be correct, but the percentages are a bit out of whack. I don't really know how to reproduce the problem, but I know that switching targets will clean it up.

The percentages would be out of whack if Omen thought someone else was tanking. I'll take a look at it.

(And try to add the arrows back in. :P)

Antiarc i was wondering if it was possible to increase the amount of events the TPS number is based on from 15? Possibly from an ingame option or by changing the Lua files directly. I would personally like a slightly higher sample size myself or perhaps even configure it to measure my TPS on a fight where i'm in melee range of a boss constantly so i can get a reliable total TPS for the entire fight (thinking prince here sinec i want a good fight where i can measure my correct TPS on. Druid TPS tends to spike since we have 30% critchance or so when tanking so numbers might vary).

Oh and give back arrows

I've just added :SetTPSSamples(samples) - until I add an interface for it, you can use:

Or whatever value you prefer.

I've been thinking about adding a fight-long TPS number, but I didn't really think that would be valuable to anyone, since you typically need TPS numbers so be able to evaluate relative threat velocity.

Edit: It was easy to do, so I just added a second return value to GetTPS(), which returns TPS over the entire encounter.

Just updated Omen a minute ago and getting:

Interface\AddOns\Omen\Libs\Threat-1.0\Threat-1.0.lua:282: bad argument #1 to 'setmetatable'(table expected, got number)

Edit: And after my game freezing a couple times on the first couple trash pulls in SSC, i disabled some addons one-by-one, and I didn't stop locking up until I disabled Omen. Not sure exactly what was causing it except that it would happen about 10-15secs after a pull.

Confirmed, multiple people in my raid having hard lockups related to LibThreat as of today's raid.

I'm glad I'm not the only one. Happening to me to.

Same error as sovelis41 and also experiencing the lockups.

Two wipes now as half our raid disconnects every time we pull the first trash pack in Black Temple. =( WTB fix to Threat or Omen or whatever is doing it.

Index of /Omen/

We're having the same issue and having people revert to a stable version. Revisions prior to 44130 seem fine?

The problem is that it appears Threat is causing the disconnects and for a lot of people that install mods with externals they aren't able to revert the version of Threat. Multiple mods are using it as a lib, like Omen and Pitbull.

The latest version of Omen is showing 0 TPS most of the time.

At least they got rid of the infinite loop that was crashing everyone.

Yeah some of the TPS numbers show up as 0, but that,s not too big of a deal for now. The values are accurate and it doesn't lock me up anymore.

TPS numbers and hardlock are fixed.

(I really shouldn't be allowed to drycode away from WoW)

Getting a Lua error when anything dies. Player or mob. Interface\AddOns\Omen\Omen.lua:693: bad argument #1 to 'math_floor' (number expected, got nil)

I can confirm that the supremus mod isn't working. noone in my raid was using ktm as we forced a switch to omen

I was wondering if there were any issues regarding the TPS calculations that Threat performs. During Morogrim tonight, Omen was reporting that I was sustaining over 8000 threat per second with spikes above 10,000. I'd like to think that I'm some crazy-awesome tank but I really think that something is just a bit wonky. For more information, it seems that the TPS number slowly creeps up over the duration of a fight (The reason I think it was so high on Morogrim was because it's a relatively long fight with essentially full rage the entire time)

Anywho, cheers and thanks for a great addon.

Yesterday I encountered the bug that our tank was not showing up on Omen anymore. He had no Threat/Omen installed and was running KTM.
A /reloadui fixed it. Running with Omen 43550 and Threat 44023.

Also on Nightbane I had a weird TPS number. He was landing again, and I had 0 aggro but a rather high TPS display:



On Sunday we were killing Void Reaver and a Fire Mage had exceptional threat, although the fight had just begun. I suppose the threat wasn't cleared between attempts, but I cannot tell you if he had Omen installed (forgot to scroll up on the screenshot).

I experienced some rather strange issues with Omen at Hydross yesterday, on most occasions the threat meter would go completely nuts after a phase switch, and on some(very few) it would be perfectly fine.

Screenshot of what it looks like, Haven being a hunter pet:

Can you explain to a UI newbee how to get the total TPS over a fight please?

We had some problemes with Omen yesterday on Essence of Anger (last phase of Reliquary of Souls). The threat table seemed to reset but some people (especially a paladin) kept high threat even if they didn't do anything in this phase. Apparently, the wipe threat function didn't wipe threat of everyone or something like that.