Antiarc

Yeah, you're probably right. I may start using a branch for commits during the day, given the userbase Omen seems to have at the moment.

 

Marroc

Like I said above... watch the charge counter buff? It's dirty as hell, but I don't recall the charges having any sort of duration, so what you could do is set a flag when the number charges gets to 2 and then check the charges after each lightning bolt until the buff is less than 2, at which point the last lightning bolt should have been the one from the trinket (lag may effect this somehow though >_<).

 

Antiarc

Yeah, my concern there is race conditions. You can very certainly cast a lightning bolt right about the same time that you proc the capacitor. What I really need to do is find a guildmate with it and hijack them for happy fun event logging time.

I'd say that you could check for cast times...but well, Lightning Overload blows that theory apart.

 

Marroc

But lightning overload has a different name for the spell (I think, I'm no shaman though), so you might be able to check cast times, or at the very least check cast times for non-crits.

That very well may be your answer :P

 

Antiarc

"Gives your Lightning Bolt and Chain Lightning spells a 5% chance to cast a second, identical spell on the same target at no additional cost."

I don't think it does, actually. :/

 

Marroc

damn... Is there really nothing that is odd about the capacitor hit? I'm going to go digging to see if there is anything unique about it...

edit:

/sigh Nope... exactly the same. Looks like you'd have to go with the solution we do have and just deal with the race mechanics, which now that I think about it isn't that bad. Given the number of times a 'race' situation is likely to occur DURING a lightning capacitor proc and is rather low, so for the most part you should be catching the right bolt, and if you don't then it's likely to happen very rarely and the higher reported threat isn't that big of a deal, so long as it isn't happening all the time.

Actually, I can't think of how the race mechanic could occur.

What could possibly crit from the shaman while he's casting a lightning bolt? It doesn't proc off DoTs (obviously) or their lightning shield.

 

Antiarc

Nothing that I've been able to ascertain, no. There may be a distinguishable event pattern, though, but I won't be able to find that without firsthand access to the trinket.

 

Trouble

You most definitely have attracted a large userbase despite the beta. I would guess a large portion of guilds that are savvy enough to read these forums regularly have switched, including a very large portion of top 200 progressed guilds. Doing updates between 6 PM EST and 9 pm EST will hit the very largest portion of people doing their updates for the day shortly before their raids. Good if you want to test something new that you know won't result in Threat not functioning at all, bad if you're committing drycode that may or may not explode the WoW client.

 

◊ Praetorian

Capacitor procs are basically identical to Lightning Bolts in the combat log. WWS can't distinguish them either and lumps them together.

 

Geheim

Cast time on a shaman lightning bolt is 2 seconds minimum (per wowwiki not 100% sure), a proc from [The Lightning Capacitor] should be more or less instant after the last lightning bolt that causes the cap to get the third charge.

If a lightning bolt is seen within a second of the last bolt, the last bolt was a crit, and the damage is between 694 and 806 damage; assume for threat reasons that it is from the lightning capacitor.

Disclaimer, I'm not a shaman, I've never played a shaman. Just had an idea on how you might be able to discern between the two types of lightning bolt.

 

◊ Praetorian

Haste gear, bloodlust, metagem procs, NS, etc... too many variables that can cause normal quick-cast LBs.

 

Marroc

also, the capacitor can crit, which throws using a damage range right out the window.

 

Geheim

Damn, I guess ask Blizzard to rename the spell effect from the item in a future patch. Because without a name or discernible time difference, I can't think of any way to tell them apart in the combat log.

 

Marroc

Again we can get reasonably close and approximate. The only thing that effects this is the 'race' mechanic where something happens between when we realize a proc has gone off and figure out what lightning bolt to use.

Most of the time it won't be a big deal, and when it is, it should be a fairly marginal threat difference.

Given that this effects one spec, of one class, with one trinket, I would think that using the buff to model when the effect goes off is within a decent realm of accuracy.

 

sovelis41

We experienced this problem (abnormally high mage threat) last week on Void Reaver, but Tuesday's (7/17) kill showed no signs of this bug.

Edit: Apologies for not having the revision numbers available =/

 

Thebigcheeze

I updated to the hardlocking revision, then went and updated to 44143 (omen) I'm not sure what version of threat that is. Hope that helps. Cheers.

 

Antiarc

No problem; please let me know if you see it crop up again.

Okay, thanks for the report. I'll take (yet another ) look and see what I can find.

Edit: Found it, I had an order-of-operations thing going on that was causing a slow oscillation, which added up over a long fight. My unit tests have been running for about 9 minutes now and seem to be checking out.

 

Thebigcheeze

Sweet. My guild will be doing VR today so that should be a good test if it's still accumulating over long fights.

Cheers.

 

Unaz

If the capacitor procs in close proximity to a normal LB, then it shouldn't matter for the most part I would think. The first bolt can be counted as the capacitor, and the second will be counted normally. Assuming the damage range is approximately the same.

As far as Lightning Overload, I don't believe the actual cast message is different, but I think there's a second line in the combat log that says something about gaining LO. I'm not positive about this though.

 

Antiarc

I don't think that's a valid assumption, actually. The Capacitor's bolt is 50% threat, whereas an EP'd normal bolt would be 90%. Halving threat from a 2k LB would be a bit on the dangerous side.

 

Antiarc

Those doing Supremus:

1) Has it worked for anyone?
2) If it hasn't worked for you, what's your locale?
3) Can you manage to get a Transcriptor or BigWigs debug log to me?

 

Geheim

So to bring back up an old problem, I pulled agro while under 90% of the tanks threat tonight on Nightbane. I was running Omen 44158/Threat 44250. Tank was running both Threat 44250 and KTM 19.18.

Something still seems odd about the threat situation of this fight.

 

Oscarvil

There's some talk about it in this thread, basically it seems like vanish isn't wiping aggro on NB/Magtheridon properly. Seems like it's not really an Omen problem as well.

 

Antiarc

Vanish definitely doesn't wipe aggro 100% of the time on Nightbane. I ran into that myself Tuesday.

I pulled aggro while well below the tank threshold. I immediately vanished; Nightbane remained on me and hit me a second or two later, pulling me out of stealth (definitely not a lag issue). I stopped attacking, and a paladin BOP'd me. Nightbane remained on me through the BOP, with the tank frantically attacking and trying to regain aggro. BOP wore off and I hit evasion. I lasted through the evasion, again, not attacking. Once Evasion was done, I died, and aggro returned to the tank. There is no way there was a normal aggro mechanic at play there.

I mildly suspect that NB's breath may be a deaggro, and I've added a raid-settable variable for it, so I can test it next week.

 

Crazytrucker

Could you add in if a player gains Insignifigance, they generate 0 threat until they loose Insignifigance.