Scrub - Raidmember talent scanner (was TalentShow) - Page 12

daemok · 01/18/08, 5:49 PM

I'd suggest that the Arcane Subtlety check for mages only be included for deeper arcane specs. 0/?/? specs get yellow flagged for not having it.

-40% threat on Arcane spells doesn't do much for someone casting only Fire or Frost spells, and 10 Spell Penetration is next to useless.

chase · 01/18/08, 6:38 PM

Originally Posted by daemok

I'd suggest that the Arcane Subtlety check for mages only be included for deeper arcane specs. 0/?/? specs get yellow flagged for not having it.

-40% threat on Arcane spells doesn't do much for someone casting only Fire or Frost spells, and 10 Spell Penetration is next to useless.

Yellow flag is reasonable. Most mages use arcane explosion for AoE. 40% threat reduction on a primary AoE is a good thing to have.
If you use another form of AoE, (IV+imp blizz (frost), IV+imp FS (fire), etc) and it works for your guild than your raid leader will realize this.

Yellow only means "Are you sure this person knows what he is doing?".

Tifordin · 01/20/08, 9:28 PM

This is a great addon, have been putting it to good use on the other mages in my guild

It seems to slot people a little rigidly into cookie cutter specs, but if you take it with a grain of salt it is a very handy tool indeed.

♦ Lorewanderer · 01/21/08, 12:36 AM

I finally looked over the Balance druid code, and I have a few tweaks.

First off, drop the yellow flag for Brambles. It is a perfectly legitimate filler talent, if not the most commonly taken.

Add in:

check("Lacking Focused Starlight",		RED,	function (talents) return (talents:spent(1) >= 34) and (talents:rank(1, 5) < 2); end);
check("Lacking Vengeance",			RED,	function (talents) return (talents:spent(1) >= 34) and (talents:rank(1, 10) < 5); end);
check("Lacking Moonfury",			RED,	function (talents) return (talents:spent(1) >= 46) and (talents:rank(1, 15) < 5); end);
check("Lacking Balance of Power",		YELLOW,	function (talents) return (talents:spent(1) >= 46) and (talents:rank(1, 16) < 2); end);
check("Lacking Wrath of Cenarius",		RED,	function (talents) return (talents:spent(1) >= 46) and (talents:rank(1, 20) < 5); end);
check("Balance without Imp. MOTW",		YELLOW,	function (talents) return (talents:spent(1) >= 34) and (talents:rank(3, 1) < 5); end);
check("Lacking Subtlety",			YELLOW,	function (talents) return (talents:spent(3) > 13) and (talents:spent(1) > 34) and (talents:rank(3, 7) < 1); end);

Emolate · 01/21/08, 1:17 AM

Scrub freaks out on Warlocks with 0/40/21 specs. This is a perfectly viable "in-between affliction and destruction" build with a large damage ceiling or a lot of threat reduction via the Imp.

I will give a unified diff if nobody objects.

Edit:
Here are my suggestions.

Raiding locks probably shouldn't have 5/5 Fel Concentration, and having it means there is some room elsewhere for beneficial talents to the raid.

You shouldn't be called out for being 0/40/21. Master Demonologist gives you 20% threat reduction and the other talents in that tree help your damage output. It also encourages you to use the Imp, which some raids prefer. Indeed, you're best off using Improved Imp and rocking it most of the time unless you really need to squeeze more juice out of your Shadow Bolts with the Succubus out.

This build will typically do three things: Curse, spam Shadowbolts, and toss up an Immolate when appropriate.

Yellow'ed Improved Howl of Terror. I see it as a PVP talent. I could be wrong. It isn't worth a redline but it warrants looking at closer.

Took out the redline about Unholy Power without a Felguard. Of course you will have Unholy Power. You need 5 points in it to get Master Demonologist, which is the whole point of going that deep into Demonology.

Here is my diff:

$ diff Warlock.lua Warlock.lua.old 
19c19
< check("Partial Demonology Spec",		RED,	function (talents) return (talents:spent(2) >= 21) and (talents:spent(2) < 40); end);
---
> check("Partial Demonology Spec",		RED,	function (talents) return (talents:spent(2) >= 22) and (talents:spent(2) < 41); end);
30d29
< check("Fel Concentration",		YELLOW,	function (talents) return (talents:spent(1) >= 10) and (talents:rank(1,  8) > 4); end);
36d34
< check("Improved Howl of Terror (PvP)",		YELLOW, function (talents) return (talents:spent(1) >= 36) and (talents:rank(1, 19) > 0); end);
38c36
< check("No Unstable Affliction",			RED,	function (talents) return (talents:spent(1) >= 41) and (talents:rank(1, 21) < 1); end);
---
> check("No Unstable Affliction",			YELLOW,	function (talents) return (talents:spent(1) >= 41) and (talents:rank(1, 21) < 1); end);
44a43
> check("Unholy Power without Felguard",	RED,	function (talents) return (talents:rank(2, 12) > 0) and (talents:rank(2, 22) < 1); end);

Stosh · 01/30/08, 8:43 PM

Originally Posted by tedv

Third, you can get every other increased damage and raid utility talent as a warlock and still have points leftover for Malediction. Check out this PvE oriented spec: Talent Calculator - World of Warcraft

It's got all kinds of wrong in it, like too many points in Suppression for the likely amount of hit gear. It spends a full 5 points in shadow embrace, something most affliction warlocks skip (but shouldn't). It has improved curse of agony when they should be casting curse of elements or shadows. It has curse of Exhaustion and Amplify curse, two spell that will almost never be used on bosses, and it STILL has 5 points left. Malediction is only 3. You could easily trim points for 5/5 Demonic Embrace and still have points left for Devastation and 3/3 Malediction.

I would never put points into Improved CoA, but you need to spend 15 talent points before you can open up Grim Reach and Empowered Corruption. Given:

5X Improved Corruption
2X Improved Drain Soul
2X Improved Life Tap
2X Soul Siphon

Therefore you are forced to spend 4 points across Amp Curse, Fel Concentration, Improved Curse of Agony or Improved CoW.

• Slake · 03/12/08, 3:22 AM

Probably my final update to Scrub, if you need or want to make further changes the class check files are very easy to edit. If I do revisit this, it will be to implement an in-game setup interface as was mentioned somewhere earlier in the thread, but I don't have any kind of eta on that. Anyway, enjoy and thanks for all the suggestions and corrections on the various spec checks.

1.1.7
- DRUID: Removed Brutal Impact check
- DRUID: Removed Brambles check
- DRUID: Added Lorewanderer's Balance checks
- HUNTER: FI without Animal Handler changed to require two points in Animal Handler
- HUNTER: Barrage check removed
- HUNTER: Lacking Hawk Eye relaxed to two points
- HUNTER: Lacking Survival Instincts changed to red severity
- MAGE: Lacking Arcane Subtlety will now only flag when there are more than 20 points spent in the Arcane tree
- MAGE: Lacking Arcane Subtlety changed to red severity
- MAGE: No Dragon's Breath changed to yellow severity
- PALADIN: Partial Retribution check threshold increased to 20 points in the Retribution tree
- PALADIN: No BoK changed to yellow severity
- PALADIN: Pursuit of Justice check removed
- ROGUE: Lacking Ruthlessness relaxed to two points for dagger rogues
- WARRIOR: Lacking 1H Weapon Spec check removed

Caduceus · 03/15/08, 10:11 AM

For the purpose of evaluating Ret paladins, unless they fixed Vindication allowing JoW and JoL procs off of it's failed attempts on bosses, it's reasonable to drop a point into it. If they HAVE fixed that, I need to respec.

Moshne · 05/03/08, 2:18 AM

I have been missing this mod since it stopped being updated. I see above that he has stopped support for it, but I'm looking at bringing it up to speed.

My biggest issue is not the reports from the mod, as I can easily fix that, but the "Scrub" function itself, it seems to either lag or time out, causing the report to sometimes not come for 10 minutes to some times more than a couple hours. Does anyone happen to know what changed in the game in 2.4 that would be causing this hang-up, or a potential work around?

sag_ich_nicht · 06/22/08, 8:40 PM

Should this still be maintained(Which I doubt, as the only way I can still use it reliably is using Talented_Scrub):

The retribution paladin talents are a bit off, having Imp. Judgment 0/2 should be red(which it already is), but 1/2 should be yellow, as 1/2 yields more DPS than 2/2 but is harder to manage.