If I'm reading the Warlock.lua file correctly, it seems to be red-flagging any felguard build - is that intended? I don't have any experience with felguard raiding myself, but there certainly seem to be some people who believe in it. The current code also doesn't seem to check for Bane, which is *the* most universally accepted requirement for any raiding build.
In my opinion even the idea of requiring UA for any build with >30 in Affliction is a bit questionable. I guess the question is how strict we want to be in requiring the absolute optimal DPS builds vs. allowing slightly inoptimal builds for the sake of accommodating personal preference and playstyle. I'd say you should try to err on the side of the latter, but maybe that just shows I'm not elitist enough for this place
I'll write up my own suggestion for better Warlock requirements, just wanted to make sure I was reading the code correctly first.
[EDIT:] Here's my suggestion:
function Scrub:CheckWarlock(TSval,val1,val2,val3)
local temp1
local temp2
local temp3
local rc
local yc
temp1 = self.GetPoints(3,1,true)
if (temp1 < 5) then
rc = true
end
temp1 = self.GetPoints(3,3,true)
if (temp1 < 5) then
rc = true
end
if (val1 > 30) then
temp1 = self:GetPoints(1,21,true)
temp2 = self:GetPoints(1,16,true)
temp3 = self:GetPoints(1,12,true)
if ((temp1 < 1) or (temp2 < 5) or (temp3 < 3)) then
yc = true
end
elseif (val3 > 38) then
temp1 = self:GetPoints(3,14,true)
temp2 = self:GetPoints(3,20,true)
if ((temp1 < 1) or (temp2 < 4)) then
rc = true
end
temp1 = self:GetPoints(1,14,true)
temp2 = self:GetPoints(2,14,true)
if (temp2 < 1) then
if (temp1 < 1) then
rc = true
else
yc = true
end
end
else
yc = true
end
if (rc) then
temp3 = 2
elseif (yc) then
temp3 = 1
else
temp3 = 0
end
return temp3
end
It will:
- Red-flag anything without ISB and Bane, plus anything deep destro without Ruin, S&F and either SL or DS
- Green-flag traditional 41+/X/10+ and 0/21/40 builds
- Yellow-flag everything else, including felguard builds, 40/0/21, 21/0/40, 30/21/10, etc.
This should catch and red-flag the most common no-nos (including any SL/SL PvP spec), and yellow-flag anything else that isn't widely considered optimal.