Omen, Threat-2.0, and 2.4 - I need your help!

Antiarc · 02/15/08, 2:36 AM

Hey folks. 2.4 is upon us, and as we all know, this means a full and complete rewrite of the Threat-1.0 library to be compatible with the new log format (hence, the 2.0 version!)

One of the things I'm doing in the upgrade is moving to use the spell IDs that Blizzard is making available to us in 2.4, rather than localized spell names. This means that Babble-Spell is no longer a requirement, and it also means that other localizations won't have to wait on translations for Threat-2.0 to work for them (this is especially good in light of the looming Russian distribution of WoW).

The flipside to this is that I need those spell IDs! They are mostly available via mining sites like Wowhead and Wowdb, but I have to guess at a number of them. Also, I don't know what the combat log entries for certain actions - like a soulshatter with a mob resisting - look like.

So. What I need:

- As you run instances on the PTR, just turn on your combat log with /combatlog
- When you're done, zip up the combat log (It should be in WoWTest/Logs/WoWCombatLog.txt), and either post it here for me to download, or email it to me at cheald at gmail
- If possible, include the classes that were in your group (if it's a 5-man - if it's a 25-man, it's a safe bet they're all there)

I need logs from the following sorts (though all logs will be helpful!):

- Elemental Shaman with Lightning Overload procs
- Resto Shaman using Earth Shield
- Rogue, use Feint and Vanish
- Mage, use Invis
- Druid, Feral and Resto, use, uh, everything.
- Protection warrior using Devastate
- Protection paladin using Righteous Defense, resists included would be ideal
- Warlock, use Soulshatter, resists included would be ideal
- Hunter, use Feign Death, resists would be ideal
- I am specifically looking for someone with a Lighting Capacitor to provide log entries of it proccing, as well.

Edit: Wow, that was fast. I got a ton of logs very quickly. I've now got all the Threat class modules finished up.

Edit: Also, if people have -threat trinkets lying around like the Hypnotist's Watch and the Shadow Lab trinket that I can't remember, throw one of those on and use it - I don't expect them to be significant but it'd be nice to have them for completion's sake.

I should be able to use those logs to glean the information I need to complete Threat-2.0 and make it totally awesome. The good news is that the core is already finished, and Threat-2.0 is capable of truly tracking mob-specific threat. 6 mobs of the same name? No problem! You'll get separate threat tables for each!

As I get closer to a releasable beta, I'll post download links here and get feedback, as well.

Thank you!

Edit: Alpha/late betas will be incoming soon!

koaschten · 02/15/08, 4:05 AM

Rogue Feint and Vanish vs humanoid / mechanic units (including immune msg) Free file hosting by Savefile.com

bimmian · 02/15/08, 4:28 AM

Sent you a PM with a Hunter log with FD and FD resist.

Rannasha · 02/15/08, 4:29 AM

And a log with almost all Druid abilities (base and feral-talented) has been emailed.

nife · 02/15/08, 4:54 AM

I think right now there is a general need by most of the programmers for logs(I know wws is also looking for logs). I know I myself am looking for all the logs that I can get too. Blizzard still won't let me get a char on the server so I am looking for stuff too. Most specifically I am looking for arena and pvp logs.

So if people could just post all the log you have and as much info as possible.
Such as:

Who Recorded?:
What Class?:
What Race?:
Who was in the group?
Where?:
PVP?:
Server Location US/EU/Asia?
Client Language?:
Arena? and Win/loss:
Special Events that happened?:

Franklin · 02/15/08, 7:36 AM

Log from an Elemental Shaman with a TLC sent, if this confuses things drop me a PM.

Kyth · 02/15/08, 8:04 AM

Sending a log of a lock with lightning capacitor now, and let me know if you had any problems with those three SW25 logs I sent.

Gwaihir · 02/15/08, 3:50 PM

The one from me had Elemental Shaman/LO/TLC as well.

Antiarc · 02/16/08, 6:57 PM

Edit: Nevermind, found an issue, will post in a sec.

Roywyn · 02/16/08, 8:04 PM

Invisibilty:

2/17 01:57:23.015  SPELL_CAST_SUCCESS,0x000000000098FF9B,Roywyn,0x511,0x000000000098FF9B,Roywyn,0x511,32612,Invisibility,0x40
2/17 01:57:23.218  SPELL_AURA_APPLIED,0x0000000000000000,nil,0x80000000,0x000000000098FF9B,Roywyn,0x511,32612,Invisibility,0x40,BUFF
2/17 01:57:43.296  SPELL_AURA_REMOVED,0x0000000000000000,nil,0x80000000,0x000000000098FF9B,Roywyn,0x511,32612,Invisibility,0x40,BUFF

Just realised that there is no entry for the actual spell cast, which should be at 01:57:18.***
Just the "become invisible" part, and the gain/fade of the invisibility buff.

Edit:
Just tried again, same combat log. There is no log entry for the initial cast of Invisibility. Not in the ingame log, not in /combatlog.
I do get the buff listed in Invisibility - Spells - World of Warcraft (Invisibility - Fading), but it does not appear in the log.

Rokh · 02/16/08, 8:09 PM

Can anyone tell from any of these logs if they improved the timestamping at all? Currently on live it "jitters" a bit from client to client, making events happen in different order sometimes and things like that, making the exactly timing appear slightly off.

North101 · 02/16/08, 9:44 PM

Just a minor thing, I downloaded Threat-2.0 from the svn and noticed that in the embeds.xml you are loading the .lua files instead of the .xml files

Roywyn · 02/17/08, 1:21 PM

Originally Posted by North101

Just a minor thing, I downloaded Threat-2.0 from the svn and noticed that in the embeds.xml you are loading the .lua files instead of the .xml files

Hm, I've been searching for half an hour for something/place/anything to get a threat-2.0 library/mod/thingy, but found nothing at all.

Any hint/link where to look for? I'm all out of ideas.

Elhana · 02/17/08, 6:04 PM

grep Invisibility |grep Magename

2/16 21:21:03.828  SPELL_CAST_SUCCESS,0x0000000000993713,Trancer,0x514,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40
2/16 21:21:04.750  SPELL_AURA_APPLIED,0x0000000000000000,nil,0x80000000,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40,BUFF
2/16 23:43:49.109  SPELL_CAST_SUCCESS,0x0000000000993713,Trancer,0x514,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40
2/16 23:43:50.125  SPELL_AURA_APPLIED,0x0000000000000000,nil,0x80000000,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40,BUFF
2/16 23:44:05.984  SPELL_AURA_REMOVED,0x0000000000000000,nil,0x80000000,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40,BUFF
2/17 00:42:46.890  SPELL_CAST_SUCCESS,0x0000000000993713,Trancer,0x514,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40
2/17 00:42:47.296  SPELL_AURA_APPLIED,0x0000000000000000,nil,0x80000000,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40,BUFF
2/17 00:42:49.453  SPELL_AURA_DISPELLED,0xF130006112012203,Kalecgos,0xa48,0x0000000000993713,Trancer,0x514,45018,Arcane Buffet,0x40,32612,Invisibility,64,BUFF
2/17 00:42:50.078  SPELL_AURA_REMOVED,0x0000000000000000,nil,0x80000000,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40,BUFF
2/17 02:48:33.109  SPELL_CAST_SUCCESS,0x0000000000993713,Trancer,0x514,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40
2/17 02:48:33.156  SPELL_AURA_APPLIED,0x0000000000000000,nil,0x80000000,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40,BUFF
2/17 02:48:53.625  SPELL_AURA_REMOVED,0x0000000000000000,nil,0x80000000,0x0000000000993713,Trancer,0x514,32612,Invisibility,0x40,BUFF

groktar · 02/17/08, 7:12 PM

Originally Posted by Roywyn

Hm, I've been searching for half an hour for something/place/anything to get a threat-2.0 library/mod/thingy, but found nothing at all.

Any hint/link where to look for? I'm all out of ideas.

You would need SVN access, which requires an account that can only be obtained by request from the people that run wowace.

SVN For Beginners - WowAce Wiki

Antiarc · 02/17/08, 8:59 PM

You can get Omen2 and Threat-2.0 without a Wowace SVN account, from the public SVN.

You can get the current working copy at Revision 61847: /branches/Omen/2.4

Please note that this is an alpha release, many things are still untested, and you should expect it to break. If you use it, please use an error-capturing addon like !BugGrabber and BugSack to capture stack traces of errors to foward to me.

Also, yes, I'm going to be mocked for this, but the days of "Update your Omen every 45 sec" are back while I develop this.

I am specifically not publishing zips right now, as I want people who are using this branch to be able to stay up to date and try new fixes quickly.

groktar · 02/17/08, 9:26 PM

Ah, thank you. I didn't see there was a public SVN. It looks like the main problem is that it wipes your threat from a target once you deselect it. I wish I could help, but I've never played with Luau, let alone written any addons for WoW.

koaschten · 02/18/08, 12:18 PM

Some Error pastey from a ptr raid: Pastey.net - ace paste bin

Gearknight · 02/18/08, 12:53 PM

Will patch 2.4 and Threat-2.0 make it possible to tell which mobs resisted a FD? Sometimes not knowing this in Live means stopping dps unnecessarily in fights like Tidewalker/Jan'Alai where maybe only the adds resisted FD.

koaschten · 02/18/08, 1:12 PM

Once Antiarc figured out how Feign Death is displayed in the new combat log that will indeed be possible, as every Unit will have a unique identifier.

Elhana · 02/18/08, 1:48 PM

Error:  attempt to compare number with string
File: Interface\AddOns\Omen\Bar.lua
Line: 17
Count: 3
(tail call): ?
...ce\AddOns\Omen\Modules\SingleTarget\SingleTarget.lua:82: in function `UpdateBar'
...ce\AddOns\Omen\Modules\SingleTarget\SingleTarget.lua:162: in function `DisplayThreatForGUID'
...ce\AddOns\Omen\Modules\SingleTarget\SingleTarget.lua:50: in function <...ce\AddOns\Omen\Modules\SingleTarget\SingleTarget.lua:47>
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>
[C]: ?
[string "safecall Dispatcher[2]"]:13: in function `?'
...men\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'
...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:133: in function `ProcessActor'
...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:111: in function `?'
...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:94: in function <...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:93>
--------------------------------------------------

Error:  attempt to compare number with string
AddOn: Omen
File: Threat-2.0.lua
Line: 702
Count: 4
[C]: ?
Interface\AddOns\Omen\Libs\Threat-2.0\Threat-2.0.lua:725: in function `IterateGroupThreatForTarget'
...ce\AddOns\Omen\Modules\SingleTarget\SingleTarget.lua:161: in function `DisplayThreatForGUID'
...ce\AddOns\Omen\Modules\SingleTarget\SingleTarget.lua:50: in function <...ce\AddOns\Omen\Modules\SingleTarget\SingleTarget.lua:47>
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>
[C]: ?
[string "safecall Dispatcher[2]"]:13: in function `?'
...men\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'
...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:133: in function `ProcessActor'
...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:112: in function `?'
...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:94: in function <...men\Libs\LibGUIDRegistry-0.1\LibGUIDRegistry-0.1.lua:93>

r61914

groktar · 02/18/08, 5:36 PM

I've noticed that it's not correctly calculating my threat modifier. I have 3/3 defiance and 2% threat to gloves and the debugging windows says my modifier is 1.326. This is using version r61943. I've noticed it the other revisions I've tried, too. I can see that the 1.326 number is accurate by hitting a mob once with a white attack and comparing it with the threat listed in Omen.

For instance, I just white hit a mob for 138 and it said I have 182.9 threat.
138 182.9.

Even more interestingly, I did a console reloadui and it now says my total threat modifier is 1.5249. Now I just white hit a mob for 145 and it says I have 221 threat, which is correct. After relogging it went back to the 1.326 number. Reloading my UI got me the correct 1.5249. It seems that it's not calculating the talents correctly the first time around.

Nite_Moogle · 02/18/08, 5:45 PM

Originally Posted by groktar

I've noticed that it's not correctly calculating my threat modifier. I have 3/3 defiance and 2% threat to gloves and the debugging windows says my modifier is 1.326. This is using version r61943. I've noticed it the other revisions I've tried, too. I can see that the 1.326 number is accurate by hitting a mob once with a white attack and comparing it with the threat listed in Omen.

3/3 Defiance + 2% = 1.30 * 1.02 = 1.326 which is correct. Threat is multiplicative, not additive.

nontoxic · 02/18/08, 5:55 PM

Originally Posted by Nite_Moogle

3/3 Defiance + 2% = 1.30 * 1.02 = 1.326 which is correct. Threat is multiplicative, not additive.

Your numbers are off.

Defensive stance = 1.3
Defiance = 1.15
Glove enchant = 1.02

1.3 * 1.15 * 1.02 = 1.5249

groktar · 02/18/08, 5:56 PM

Yes, we all know those modifiers are multiplicative. However, the base modifier of Defensive Stance is 1.3. 1.3 * 1.15 * 1.02 = 1.5249.

edit:

The above poster beat me to it. However, he does demonstrate where that 1.326 modifer is coming from, which is the 1.3 from defensive stance and 1.02 from 2% threat to gloves.