 |
06/10/08, 4:02 PM
|
#101
|
|
Rawr
Night Elf Druid
Stormrage
|
FYI, I made a little addon to create a new Target of Target frame like the blizz target frame, so that I can use InstantHealth and still use the blizz player/target/targettarget frames. (Except now it's a full target frame for targettarget instead of just the little one attached to the target frame).
If anyone would like a copy, let me know.
EDIT: Also, I made a small upgrade to Instant Health. On line 125, after the 'if(change ~= 0) then' line, insert:
if (health <= 0 and unitTable.health > 0) then
DEFAULT_CHAT_FRAME:AddMessage(select(4, ...) .. ' brought ' .. select(7, ...) .. ' back from the dead!' , 255, 0, 255);
end
I haven't gotten a chance to test it in raids, but that should write to the chat log whenever someone brings someone back from the dead. I expect it'll give false positives sometimes (ie, you did actually die even though the heals landed), but should be neat to see how often it actually happens.
Last edited by Astrylian : 06/10/08 at 4:42 PM.
|
Rawr!
|
|
|
06/10/08, 5:08 PM
|
#102
|
|
Von Kaiser
|
Astrylian, I think that a hosted fix such as that would be welcomed by many. I'm sure that theres loads of people using the default unit frames that have run into this issue, and would love to get access to your mod (myself included!)
|
|
|
|
|
06/10/08, 5:25 PM
|
#103
|
|
Rawr
Night Elf Druid
Stormrage
|
This isn't a fix, and it's not something I want to toss on Curse and have to support or something. It's actually some mod I found on wowinterface for a focus frame, and converted it to targettarget (really ugly conversion too, all the frames and stuff are still named FocusFrame, etc.)... I'll just attach it here.
Disclaimer: It's based on FocusFrame, which is its author property, partly, I think, which is based on Blizz's target frame... I take no credit for this at all. Also, cooldown timers on target of target debuffs are broken. I probably won't fix it. It's also incompatible with FocusFrame.
|
Rawr!
|
|
|
06/10/08, 9:34 PM
|
#104
|
|
Glass Joe
|
I tried InstantHealth, and really liked it, but had a few minor issues and decided that I could do with something a little simpler. I've written an alert plugin for Grid that tries to give you some of the benefits of InstantHealth, without overriding the default Blizzard interfaces for every addon. This module was inspired by Meloeth's InstantHealth addon. Grid is required to use this addon.
This module gives you a timed duration alert in Grid whenever someone in your party/raid takes damage (as indicated by the combat log). The alert stays active for a configurable period (the default is 2 seconds). The amount of damage, or threshold, it takes to trigger the alert, is also configurable (the default is 500 hp).
By tying the alert to an indicator (like a corner square), you can potentially get a *slightly* early indicator of who has taken damage. As a healer, I liken it to the "aggro status" which can sometimes provide an early indicator of who is about to take damage. You can also tie it to a textual indicator to see the amount of damage reported by the combat log event.
I find it useful. Your mileage may vary. Meloeth's InstantHealth addon is awesome, and if you don't use Grid, or don't want to deal with the setting up Grid to use a seperate alert, you should really try it.
You can post questions/suggestions to the official WoW Ace forum thread here: GridStatusCombatLogDmg
You can download it from the WoW Ace SVN here: http://files.wowace.com/GridStatusCo...mbatLogDmg.zip
You can read about it on the WoW Ace Wiki here: GridStatusCombatLogDmg - WoW Ace Wiki
Last edited by Pachelbel : 06/11/08 at 8:49 AM.
|
|
|
|
|
06/11/08, 12:43 AM
|
#105
|
|
Glass Joe
Night Elf Druid
The Maelstrom (EU)
|
@fredshino
Instant Health uses UnitGUID("unit") that was introduced in 2.4 to uniquely identify different targets, whatever name the unit might have makes no difference. It's most likely your unit frames that mixes up the pet and the hunter by going by name.
|
|
|
|
|
06/11/08, 4:12 AM
|
#106
|
|
Piston Honda
none
Human Warrior
No WoW Account (EU)
|
Ace is not an acronym.
|
|
|
|
06/11/08, 9:02 AM
|
#107
|
|
Glass Joe
|
Originally Posted by funkydude
Ace is not an acronym.
|
correct(ed.)
|
|
|
|
|
06/11/08, 9:06 AM
|
#108
|
|
Glass Joe
|
@Meloeth - I'm not sure the IH_CombatLogFilter() in InstantHealth is handling SPELL_PERIODIC_DAMAGE or DAMAGE_SPLIT events. You should probably add something like the following:
if msg == "SPELL_PERIODIC_DAMAGE" then
return -msg4
end
if msg == "DAMAGE_SPLIT" then
return -msg4
end
You are currently using
local prefix, suffix, special = strsplit("_", msg)
to split the event name, which would result in a prefix of SPELL and suffix of PERIODIC and special of DAMAGE for SPELL_PERIODIC_DAMAGE, which is why I think you need a separate line (like you did for SPELL_PERIODIC_HEAL).
Last edited by Pachelbel : 06/11/08 at 11:22 AM.
|
|
|
|
|
06/11/08, 11:49 AM
|
#109
|
|
Glass Joe
Night Elf Druid
The Maelstrom (EU)
|
Thanks, I'll look into it and make sure it catches all damage/heal events.
|
|
|
|
|
06/12/08, 3:48 PM
|
#110
|
|
Von Kaiser
|
Originally Posted by Nyxie
I've seen this happen in Grid, too. I don't think it's specific to this mod.
|
Yeah this is simply a Grid bug, as far as I know. I've had this happen both before and after installing this addon.
|
|
|
|
|
06/14/08, 11:03 AM
|
#111
|
|
Von Kaiser
Tauren Druid
Alleria (EU)
|
receiving:
Error occured in: Global
Count: 3
Message: ..\AddOns\Instant_Health\Instant_Health.lua line 74:
attempt to call a nil value
Debug:
[C]: ?
Instant_Health\Instant_Health.lua:74:
Instant_Health\Instant_Health.lua:65
Instant_Health\Instant_Health.lua:124: ?()
Instant_Health\Instant_Health.lua:203:
Instant_Health\Instant_Health.lua:203
in combination with DiamondThreatMeter
with the new 1.0.4
btw: I've the feeling that the frames in healbot aren't supported...can anyone confirm this ?
|
|
|
|
|
06/15/08, 4:53 AM
|
#112
|
|
Glass Joe
|
Working fine for me with diamond and healbot works great as well.
The only addon i have that causes problems is ZMobDB, a neat little mod that shows a 3d view of your char, target, ToT, party, pretty much anything... I have it set to show just my target so i can check out what gear they're wearing. I find it really useful for pvp.
WoWInterface Downloads : Unit Mods : ZMobDB Advanced5
Any idea why i would be getting an error with this mod?
This is the error i'm getting:
\Instant_Health.lua:74: attempt to call a nill value
Last edited by pengwynman : 06/15/08 at 12:34 PM.
|
|
|
|
|
06/15/08, 2:12 PM
|
#113
|
|
Glass Joe
Night Elf Druid
The Maelstrom (EU)
|
There was no test to make sure the frame being called had a OnEvent handler. So if a frame was registered for UNIT_HEALTH events but did not have a OnEvent handler Instant Health would attempt to call a function that didn't exist.
Should be fixed in the new version (1.0.5)
|
|
|
|
|
06/16/08, 7:52 PM
|
#114
|
|
Piston Honda
Night Elf Druid
Stormrage
|
Originally Posted by Astrylian
FYI, I made a little addon to create a new Target of Target frame like the blizz target frame, so that I can use InstantHealth and still use the blizz player/target/targettarget frames. (Except now it's a full target frame for targettarget instead of just the little one attached to the target frame).
|
Tried this mod. The new window appears in the middle of the screen and cannot be moved; also, it generates a repeating clicking noise.
I do really like the potential InstantHealth has, but I must have my Target of Target frame as well.  And the taint issue stops the Blizzard default ToT frame from from coming up if I engage the mob before the ToT window has appeared.
|
upstart feline miscreant (32 feral/9 resto)
|
|
|
06/16/08, 8:23 PM
|
#115
|
|
Rawr
Night Elf Druid
Stormrage
|
Originally Posted by Tuftears
Tried this mod. The new window appears in the middle of the screen and cannot be moved; also, it generates a repeating clicking noise.
I do really like the potential InstantHealth has, but I must have my Target of Target frame as well.  And the taint issue stops the Blizzard default ToT frame from from coming up if I engage the mob before the ToT window has appeared.
|
/focusframe unlock
will unlock it... kind of. It's got a problem where whenever the ToT frame is visible, it periodically closes dropdown menus and dragging frames every half sec or so. If you unlock it, you can drag it, but drag it really fast; you've got like half a sec before it undrags. I've seen that bug before in some other addons, where it closes dropdown menus... Anyone know why it does that, or how to fix it?
|
Rawr!
|
|
|
06/19/08, 2:32 PM
|
#116
|
|
Glass Joe
Blood Elf Paladin
Lightbringer
|
I was wondering if anyone else was able to get this to work with MSBT? My incoming and outgoing texts are completely gone with Instant Health enabled. I still see the status/notifications texts though. Disabling Instant Health restores incoming/outgoing 
|
|
|
|
|
06/20/08, 3:18 PM
|
#117
|
|
Glass Joe
Troll Death Knight
Daggerspine
|
I use MSBT and I use Instant Health Update and have seen no change in MSBT's behavior since I installed IHU a week or so ago. Unfortunately I cannot offer you anything like a fix because it simply works for me. I just wanted to let you know that these 2 mods can indeed play nice together.
|
|
|
|
|
06/23/08, 12:28 PM
|
#118
|
|
Von Kaiser
Troll Priest
Kor'gall (EU)
|
Originally Posted by Phairoh
I use MSBT and I use Instant Health Update and have seen no change in MSBT's behavior since I installed IHU a week or so ago. Unfortunately I cannot offer you anything like a fix because it simply works for me. I just wanted to let you know that these 2 mods can indeed play nice together.
|
Same for me.
There were issues with version 1.0 - MSBT showed most healing as OH - but that was fixed and is working fine now
Edit: There seems to be some confusion between my grid health bars and my VisualHeal one... could this be related to Instant Health? I haven't noticed it before, really. My visual heal bar may show my target to be at full hp, while my grid shows it to be at 50%. Guess I'll have to do without Visual Heal if that's the case, but would just like to know for sure if there's any known issues with this.
For info on visual heal, see VisualHeal - WowAce Wiki
Last edited by Alv!ra : 06/25/08 at 6:10 AM.
|
|
|
|
|
06/25/08, 6:51 AM
|
#119
|
|
Glass Joe
Night Elf Druid
The Maelstrom (EU)
|
@Alv!ra
I haven't read any other reports about any issue between Grid and VisualHeal, are you sure you are reading VisualHeal correctly? Just going by the wiki it shows current health, the health that you will have when the next heal lands and then the health you will have after all incoming heals have landed. When comparing Grid with VisualHeal it's important you compare your current health on both.
|
|
|
|
|
06/25/08, 7:57 AM
|
#120
|
|
Von Kaiser
Troll Priest
Kor'gall (EU)
|
Thanks for replying Meloeth
I see your point, but yes, I'm quite sure I'm reading Visual Heal correctly. I've used it for a very long time, and know how it works 
What I compare is the "first" bar of Visual Heal (which displays current health of target) with Grid's health.
In effect, this means that Grid may show my target to be at 50% hp, my visual heal shows it to be at 100%, with my incoming heal landing on the target, showing my heal would bring him to 150%, for example, i.e. full overheal.
This is of no major consequence however, I have already adapted to it and don't "trust" VisualHeal alone as I used to - so now I glance at my grid to verify that my target really is topped off before stopping the heal. That makes visual heal kinda useless though. I won't rule out the possibility that I've been paranoid with this and it's simply been an unfortunate set of damage hits on my targets that have lead me to believe that there's a difference between the displayed health.
Since you say you haven't heard anyone else have this issue, I'll try to pay more attention to it and see if I can get absolute certain that it's the case. Think I can do that easily by paying more attention to the hp bar displayed by my xperl target frame, and moving it closer to the visual heal bar. So far I haven't seen any differences in hp bar displays between grid and xperl, so should be easier to spot any issues with VH this way...
|
|
|
|
|
06/25/08, 8:02 AM
|
#121
|
|
Piston Honda
Orc Death Knight
Dunemaul
|
Alvira, I get the same behavior and blame it on Visual Heal being slow to actually register the heal. So for a split second after you land your heal, InstantHealth has picked it up and adjusted the HP bar, but VisualHeal still hasn't recognized it and still appears on the larger health bar.
|
|
|
|
|
06/25/08, 8:13 AM
|
#122
|
|
Von Kaiser
Troll Priest
Kor'gall (EU)
|
Hm well, yes Xelopheris, that would explain this behaviour - if by "your heal" you mean "any" heal, from me or anyone else. I haven't just noticed this after I've landed a heal on the target, it's most often when my heal is nearly finished and I check the hp on target. Sometimes VH shows target at more health than Grid, other times it's Grid that shows the target with more hp than VH. Only way this can happen is if one of the addons are slower on updating health generally than the other, be it an increase in hp (heals) or a decrease (damage), right?
By letting the heals land and watch what they land for, though, I've concluded that Grid is the addon displaying the correct hp bar.
That's what my intuition says any ways, I haven't raided much lately due to exams and honestly just paid proper attention to this in a raid yesterday, despite that I've had suspicions before too. Mainly because my landed heals would be displayed as OH'ing by MSBT, even though VH showed that my heal would only overheal by a minor amount... I initially wrote that off as some sort of remaining minor inconsistency with MSBT, but Phairos post got me thinking twice about that 
|
|
|
|
|
06/26/08, 4:41 AM
|
#123
|
|
Glass Joe
Night Elf Druid
The Maelstrom (EU)
|
I checked the code of VisualHeal and VisualHeal saves a local copy of the UnitHealth("UnitID") function. This means that if VisualHeal loads before Instant Health it won't get the calculated health from Instant Health but will instead just use blizzards original UnitHealth function. If this is the case it would explain VisualHeal updating slower then your other unit frames. If Instant Health loads first it won't be a problem though so it could be something else causing it as well. I couldn't find any other cause though, VisualHeal seems to update the "main" health bar like any other unit frames.
If you want to try this theory open VisualHeal.lua and go to line 24, the line should look like this:
local UnitHealth = UnitHealth;
Simply remove this line and the problem will hopefully be fixed.
|
|
|
|
|
06/26/08, 7:49 AM
|
#124
|
|
Von Kaiser
Draenei Shaman
Kult der Verdammten (EU)
|
I'm running the combination of VisualHeal, IHU and Grid for three weeks now, and observed the same behaviour as Alv!ra. It's especially obvious in MH, when our prot-palas are taking a lot of smaller, consecutive hits and are getting hammered by a lot of massive heals. I'm sure that Grid displays correct current health by IHU, and Visualheal is falling behind due to the slower update-rate of the standard health-computation. I'll try your fix Melo, and hopefully VisualHeal will be working correctly.
Thank you very much for your work on this addon, by the way. No longer dead tanks, due to drops from 100 to 0 healthpercent. Even if I can't react THAT fast, at least I saw it coming 
|
|
|
|
|
06/27/08, 8:38 AM
|
#125
|
|
Glass Joe
|
Sorry about the noob question but does anyone know of a frame mod compatible with this that's very similar to the normal blizzard raid frames? i've grown accustomed to them, dislike certain aspects of grid and xperl and am looking for some frames very similar to blizzard ones
|
|
|
|
|
|