Elitist Jerks
Register
Blogs
Chat
Forums
New Posts


Go Back   Elitist Jerks > Public Discussion > User Interface and AddOns

Welcome to Elitist Jerks
If this is your first visit, please be sure to check out the FAQ and the forum rules. Users must register to post and new registrations are subject to a one day "mute" period to get acquainted with the community. To start viewing messages, select the forum that you want to visit from the selection below.

Reply
 
LinkBack (37) Thread Tools
Old 07/31/08, 7:30 AM   37 links from elsewhere to this Post. Click to view. #1 (permalink)
Glass Joe
 
Orc Warrior
 
Blackrock
LibQuickHealth (Inspired by Instant Health)

With inspiration from Meloeth's Instant Health addon, cncfanatics has coded a new addon called LibQuickHealth that provides exactly the same function, but improves on it in more than one way. Not only is it a library that does not replace the default UNIT_HEALTH event but adds to it instead, providing health updates from both the combat log and the default UNIT_HEALTH update, but it is also modular. In addition, there is less of a performance hit, as it takes less code and doesn't force-call updates to the frames. Unit frame addons that don't support it (yet) will not show the updates with the lib installed, but once the appropriate module is installed, they will use the library to update health. In addition, it is fully compatible with the default Blizzard frames and does not cause taint.

Currently supported unit frames are Grid, Pitbull, oUF, x-Perl, PerfectRaid, sRaidFrames, and the default Blizzard frames. They have all been tested and are error-free. The library, as well as all modules, can be acquired from the wowace site.

Modules:
Blizzard default UI
Pitbull
Grid
sRaidFrames
PerfectRaid
oUF

Just needs the library:
x-Perl


ag_UF support will be coming soon.

The original thread on the wowace forums is here: QuickHealth

Last edited by Diao : 07/31/08 at 7:41 AM.
 
User is offline.
Reply With Quote
Old 08/01/08, 4:51 AM   #2 (permalink)
Von Kaiser
 
Night Elf Rogue
 
The Maelstrom (EU)
I'm no coder, but I hear from those who are that this version does not use the same error-checking method that Meloeth's original version does, and can be a bit less reliable to accurately display real current health values.
 
User is offline.
Reply With Quote
Old 08/01/08, 5:11 AM   #3 (permalink)
Glass Joe
 
Orc Warrior
 
Blackrock
LibQuickHealth works in tandem with the UNIT_HEALTH event, so you will never have inaccurate health values. There is no error checking to be done. All it does is take the latest hp update from UNIT_HEALTH, then add and subtract to it based on combat log events. It can't be inaccurate. When the next UNIT_HEALTH from Blizzard fires, it updates the health to that value, so it is always accurate.
 
User is offline.
Reply With Quote
Old 08/01/08, 5:21 AM   #4 (permalink)
Glass Joe
 
Orc Warlock
 
Burning Legion
Well I am a coder and after reviewing the most recent InstantHealth I'm wondering what errorchecking it does? Over half of the code seems to be a total hack job to try and prevent all the errors that the original version created because it hijacked the global UnitHealth function affecting every mod.

The original idea was brilliant but the implementation was somewhat sloppy. An opt-in style like LibQuickHealth-1.0 is a lot better than the opt-out style of InstantHealth IMHO.
 
User is offline.
Reply With Quote
Old 08/01/08, 3:03 PM   #5 (permalink)
Von Kaiser
 
Night Elf Rogue
 
The Maelstrom (EU)
From what I understand, this library checks it's own calculation with the calculation by the server, but that server info very often doesn't include the latest combat log infos, making it think it is wrong. It will then use that false data to do the next calculation, which is potentially also wrong.

The original Instant Health remembers the last few combat logs and calculates backwards to check the math.

I'm sure a modular system can provide some benefits and a more efficient system load (although I've never noticed anything like a performance hit with either of these mods); I'm just sharing what I have been told by people I trust.
 
User is offline.
Reply With Quote
Old 08/01/08, 3:13 PM   #6 (permalink)
Von Kaiser
 
Blood Elf Warlock
 
Garona
The people you trust were wrong, then. When UNIT_HEALTH fires, it is accurate. It's only over the time until the next UNIT_HEALTH that the accuracy decays.

The combat log is generated by the server, too - neither the combatlog nor UNIT_HEALTH are generated client side. It's just that Blizzard's servers automatically throttle calculation of current health, whereas combat log events aren't throttled. So no, any new UNIT_HEALTH includes the combat log events up to the point in time that UNIT_HEALTH is generated, because both things are coming from the server - sure, it might take a moment for the message to travel to the client, but that lag time is the same lag time in receiving any combat log messages, too.
 
User is offline.
Reply With Quote
Old 08/01/08, 7:41 PM   #7 (permalink)
Glass Joe
 
Orc Warlock
 
Burning Legion
InstantHealth has code to store a history for some reason but the only code that uses it is so messed up its hard to figure out what its ment to do.
 
User is offline.
Reply With Quote
Old 08/04/08, 8:58 PM   #8 (permalink)
Glass Joe
 
Orc Warrior
 
Blackrock
Healbot is now supported as well. Just update to the latest version and it will be included.
 
User is offline.
Reply With Quote
Old 08/04/08, 10:36 PM   #9 (permalink)
Don Flamenco
 
tsigo's Avatar
 
Undead Priest
 
Mal'Ganis
I'm seeing discrepancies between Grid_QuickHealth and oUF_QuickHealth. Grid seems to update much more quickly (this is relative, it's probably about half a second behind).

Last edited by tsigo : 08/04/08 at 10:42 PM.
 
User is offline.
Reply With Quote
Old 08/04/08, 10:44 PM   #10 (permalink)
Glass Joe
 
Orc Warrior
 
Blackrock
I'm not sure what the issue would be. I don't use oUF myself, but I did test it for cncfanatics, and it seemed to update immediately when I tested it without any other addons.
 
User is offline.
Reply With Quote
Old 08/05/08, 12:38 AM   #11 (permalink)
Von Kaiser
 
Night Elf Druid
 
Vashj
I had similar problems with Grid/PitBull discrepancies when using Instant Health, and I'm seeing similar ones with LibQuickHealth as well. This is purely anecdotal, but the differences appeared to be more drastic with Instant Health than with LibQuickHealth, but they still seem to be present.

In general, PitBull seems to show a more accurate representation of current health than Grid. This was the case regardless of using IH or LQH, so perhaps it is a problem with Grid?
 
User is offline.
Reply With Quote
Old 08/05/08, 2:08 AM   #12 (permalink)
Don Flamenco
 
tsigo's Avatar
 
Undead Priest
 
Mal'Ganis
I didn't have any such problems with InstantHealth. And in my case, Grid is more "accurate" (updating more quickly) than oUF. There's a possibility that it's the health updating method in my custom oUF layout, so I'll try a different one for a bit tomorrow.
 
User is offline.
Reply With Quote
Old 08/05/08, 7:07 AM   #13 (permalink)
Glass Joe
 
Alv!ra's Avatar
 
Dwarf Priest
 
Silvermoon (EU)
Originally Posted by Diao View Post
Healbot is now supported as well. Just update to the latest version and it will be included.
Do you know if VisualHeal is supported also? When I started using InstantHealth I had to stop using VisualHeal, as Meloeth didn't seem to hit the nail on the head with whatever was wrong with it... Would be nice if LQH works with VH? :-)
 
User is offline.
Reply With Quote
Old 08/05/08, 7:51 AM   #14 (permalink)
Von Kaiser
 
Evolve's Avatar
 
Tauren Druid
 
<Ave>
Magtheridon (EU)
Originally Posted by Alv!ra View Post
Do you know if VisualHeal is supported also? When I started using InstantHealth I had to stop using VisualHeal, as Meloeth didn't seem to hit the nail on the head with whatever was wrong with it... Would be nice if LQH works with VH? :-)
The easyest way to achieve that would probably be to ask the author to support it

edit: Would it be possible for someone to make a quick video showing the discrepancies ? It'd make it much easyer to debug.

It's not a tank's job to keep everyone alive, it's the tank's job to keep the competent people alive. if that's the entire party, it's a good day
 
User is offline.
Reply With Quote
Old 08/05/08, 4:48 PM   #15 (permalink)
Don Flamenco
 
tsigo's Avatar
 
Undead Priest
 
Mal'Ganis
Encoding a video right now, but here's a screengrab example. Grid (second row from the top, far-right column) says he's at about 7.6k health, both my oUF layout and oUF_Basic by the oUF author show him at 2700. It stays that way for 24 frames and then catches up. You can even see oUF_CombatFeedback register the 5k heal that pushes Grid to the correct value.

Edit: Video for QuickHealth, Video example of InstantHealth
Attached Thumbnails
quickhealth.jpg  

Last edited by tsigo : 08/05/08 at 5:03 PM.
 
User is offline.
Reply With Quote
Old 08/05/08, 5:06 PM   #16 (permalink)
Glass Joe
 
Orc Warrior
 
Blackrock
In that case, wouldn't oUF be the one that's lagging? I see Grid displaying the "proper" health while oUF is slightly behind. Sum the health shown on oUF and the incoming heal, giving you 2301 hp short of max health, which is what Grid is displaying.
 
User is offline.
Reply With Quote
Old 08/05/08, 5:17 PM   #17 (permalink)
Don Flamenco
 
tsigo's Avatar
 
Undead Priest
 
Mal'Ganis
Isn't that what I said in my first two posts?

And in my case, Grid is more "accurate" (updating more quickly) than oUF.
Grid seems to update much more quickly (this is relative, [oUF is] probably about half a second behind).
 
User is offline.
Reply With Quote
Old 08/06/08, 1:22 AM   #18 (permalink)
Glass Joe
 
Orc Warrior
 
Blackrock
Oh, sorry. I confused your post with Rieux's. I should pay more attention when reading. I'll ask cncfanatics to check the code for the oUF plugin. It might be that the UFs themselves are calling the health updates at a throttled time, which would mean that haste would have to modify the oUF code itself.
 
User is offline.
Reply With Quote
Old 08/07/08, 1:07 AM   #19 (permalink)
Von Kaiser
 
Evolve's Avatar
 
Tauren Druid
 
<Ave>
Magtheridon (EU)
the oUF issues should be fixed now, there were errors in the plugin itself. Please redownload the latest version of the plugin.

It's not a tank's job to keep everyone alive, it's the tank's job to keep the competent people alive. if that's the entire party, it's a good day
 
User is offline.
Reply With Quote
Old 08/07/08, 7:27 PM   #20 (permalink)
"If its not the best then its wrong"
 
sadris's Avatar
 
Tauren Druid
 
Mal'Ganis
Are there any plans for a Perl Classic plugin or shall I roll my own?

Perl Classic Unit Frames | World of Warcraft Addons | Curse
 
User is offline.
Reply With Quote
Old 08/07/08, 7:39 PM   #21 (permalink)
Glass Joe
 
Night Elf Priest
 
Illidan
This may be a dumb question, but if I download the plugins for grid and Pitbull do I need the library as well? Without a link to it in the first post I feel like it might be an extra step I don't need to take..
 
User is offline.
Reply With Quote
Old 08/07/08, 10:37 PM   #22 (permalink)
Glass Joe
 
Orc Warrior
 
Blackrock
Yes, you do need the library. It is required by the plugins. However, if you downloaded the plugins using an automatic updater, the library will be installed automatically. Also, if you download from World of Warcraft Addons - WowAce.com the library is included inside the addon itself, so you won't need to download the library separately.
 
User is offline.
Reply With Quote
Old 08/11/08, 9:15 PM   #23 (permalink)
Piston Honda
 
Human Priest
 
Alonsus (EU)
It works for me but there is a weird behaviour which causes the healthbar to drop on damage taken, then immediately jump back to its previous value and then a moment later back down. This is with Grid.
 
User is offline.
Reply With Quote
Old 08/12/08, 2:43 PM   #24 (permalink)
Piston Honda
 
Gnome Mage
 
Cenarion Circle
Any plans for oRA2? That's my way of watching MT spikes.
 
User is offline.
Reply With Quote
Old 08/13/08, 6:37 AM   #25 (permalink)
Von Kaiser
 
Human Rogue
 
Doomhammer
Are you planning to make the Aguf version with the one that uses ace3?
 
User is offline.
Reply With Quote
Reply

Go Back   Elitist Jerks > Public Discussion > User Interface and AddOns

Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
Instant Health Updates Optikalusion User Interface and AddOns 148 10/18/08 4:25 PM
Effective Health Calculator Sepulture Class Mechanics 20 07/25/07 1:51 PM
Pet health bars for healers? Egel User Interface and AddOns 5 06/30/07 12:06 AM
Target health in Perl UI Shiatzu Public Discussion 12 09/12/05 7:22 AM