ShockAndAwe (formerly DisqoDice) - Page 5

Levva · 10/23/08, 8:57 PM

Version 3.30beta2
Fixed export routine to export EnhSim data (first pass at this - I need to know of problems)
Added warning if you have active buffs that MIGHT affect stats and thus the sim

Version 3.30beta3
Fixed MW stacks sometimes not showing

Mindrila · 10/24/08, 10:33 AM

So I just tried the exporting function on a german client. It worked! The one big problem are of course the item names are in german.

And as the export is now you can't simply put it in a new textfile and just open it with EnhSimGUI, it gives a nice runtime exception. But if you replace the old stats with the new its working fine. Thank you very much, thats one big annoiance removed

What I'm surprised about is that you parsed WF - FT and Mongoose right out of my german client.

Levva · 10/24/08, 11:46 AM

Originally Posted by Mindrila

So I just tried the exporting function on a german client. It worked! The one big problem are of course the item names are in german.

And as the export is now you can't simply put it in a new textfile and just open it with EnhSimGUI, it gives a nice runtime exception. But if you replace the old stats with the new its working fine. Thank you very much, thats one big annoiance removed

What I'm surprised about is that you parsed WF - FT and Mongoose right out of my german client.

Ah ok so trinkets and totems are going to be a pain. Hmm looks like I will have to do a lookup list after all.

The Enchants are looked up by enchantID and converted into a named enchant. The WF/FT is picked up from your buffing preferences in ShockAndAwe, Rather than which buff you have on your weapon at the time.

Levva · 10/24/08, 10:14 PM

Version 3.30 is ready. Lots of new features. In particular I'd like feedback on using the export to EnhSim - command is /saa export - please let me know if there are any strange results - unrecognised item names, incorrect talents or similar such things.

Changelog from v3.21

Version 3.30beta1
Added sound for shield expiry - needs proper testing and more sounds
Added keybinds for mh & oh enchants
Added option to change font effects
Added option to hide priority frame title
Added msg frame to use for wf combos if no sct installed - not working but does print in chat for now
Added command to display paper doll stats for export to EnhSim
- very early version - no cut n paste yet - limited data - no warnings about buffs
Added News frame to show important changes from one version to another.
- first news article is only Hello World
Fixed moving frames showing priority and uptime frames despite option to disable them
Since the msg frame isn't working the loss of a weapon buff only reports to chat at present
Warning when enchants expire - not working
Warning when enter combat without weapon buffs not working

Version 3.30beta2
Fixed export routine to export EnhSim data (first pass at this - I need to know of problems)
Added warning if you have active buffs that MIGHT affect stats and thus the sim

Version 3.30beta3
Fixed MW stacks sometimes not showing

Version 3.30
Added Russian Localisations
Fixed Weapon Rebuffs keybindings - still asks for confirmation if you overwrite one though
Fixed playing sound if shield expires
Added a few more sound choices
Fixed Warning of missing weapon buff on entering combat
Fixed Message Frame - now visible and moveable
Added options to set timeout for text on for message frame
Added option to set colour for text on message frame

Wundorn · 10/25/08, 3:49 AM

Originally Posted by Levva

Version 3.30 is ready. [...]
Version 3.30beta1
Added keybinds for mh & oh enchants

I was all set to cheer for that when I noticed you saying it would still prompt for confirmation for overwriting existiing buffs.

That has got to be THE most annoying thing about playing enh right now. I even wrote a macro which removes the weapon buff before applying the new imbue... and it doesn't work. Apparently the removal takes a little while to register. (Or maybe the client is doing the validation, and doesn't yet know that the old imbue is gone.)

Either way, this sucks horribly. Do you have any idea how to get around this? It's making me nuts.

Levva · 10/25/08, 6:55 AM

Originally Posted by Wundorn

I was all set to cheer for that when I noticed you saying it would still prompt for confirmation for overwriting existiing buffs.

That has got to be THE most annoying thing about playing enh right now. I even wrote a macro which removes the weapon buff before applying the new imbue... and it doesn't work. Apparently the removal takes a little while to register. (Or maybe the client is doing the validation, and doesn't yet know that the old imbue is gone.)

Either way, this sucks horribly. Do you have any idea how to get around this? It's making me nuts.

I know!! I KNOW!!!

I tried a LOT of things to get this to work and whilst it seems to work fine if you have wf/wf if you have two different buffs eg: wf/ft it wants a confirmation even if you are wanting to just update a buff. The problem is I'm not too familiar with dealing with the secure frames. There is a command "ReplaceEnchant()" that allows you to acknowledge the message but its "Reserved for Blizzard code" I'm not sure if this means that it can never be used by an addon or if it just needs to run in a secure manner.

If I can clarify that I can get the addon to use that command then I could start to do something about it. I've noted that even other addons (eg: Bartender4) which have secure buttons still have this behaviour. I need to investigate weapon buff addons though to find one that does what I am looking to do. I suspect a rogue one might do something similar ie: one time select of a poision and on a button click just reapply. Can anyone point me to such an addon? Preferably an ace3 one?

Mindrila · 10/25/08, 11:20 AM

Smartbuff has the same problem and well even if you take the spell out of your spellbook it asks you if you really want to change the wf to a wf buff :-(

Levva · 10/25/08, 5:48 PM

Ah ok thats good to know then the secure function is just not available to addons. I'll see if I can post a msg on US forums and ask Slouken and Iriel why this might be the case and if its at all possible to have this changed.

I've made a few fixes in particular the Localisation issue on trinkets/totems. V3.31 is now up on Curse.com

Changelog:

Version 3.31
Fixed msgFrame not being movable using the moveframes option
Added option to hide timer bars out of combat
Export to EnhSim now adds the 1% heroic presence buff if you are Draenai to save you having to remember
Fixed having accidentally undone the MW not showing after 5 fix
Replaced code dealing with trinkets & totems to use an itemID lookup to get string - fixes localised names

Skiace · 10/25/08, 11:18 PM

Error trying to export:

Date: 2008-10-25 20:15:54
ID: 65
Error occured in: Global
Count: 1
Message: ..\AddOns\ShockAndAwe\Export.lua line 40:
   attempt to index a nil value
Debug:
   [C]: ?
   ShockAndAwe\Export.lua:40: OnAccept()
   ..\FrameXML\StaticPopup.lua:2792: StaticPopup_OnClick()
   [string "*:OnClick"]:1:
      [string "*:OnClick"]:1

I clicked the export button, a window pop'd up saying to ctrl-C even tho it looks empty, so i did, then hit accept, and got this error.

edit: It worked the next time however.

Levva · 10/26/08, 8:22 AM

Actually the "Accept" button doesn't do anything other than close the form, its decoration really. The important thing is doing a Ctrl-C.

I've fixed the click accept gives error for next version though.

Malan · 10/26/08, 6:29 PM

Levva can you add a /saa menu option to open up the gui menu options?

[e] I updated to the latest version today (had been out of town) and now I have a 'dead spot' near my character, where I can't do anything that involves the right mouse button. You don't seem to have a frame there that's visible, but do you have some sort of debug frame that's sitting in the background or something?

Levva · 10/26/08, 10:19 PM

Yup done. New version up on curse. Changelog is :

Version 3.40
Removed leftover debug code from export routine
Fixed error msg bug if you clicked Accept on export
New option to show Shamanistic Rage icon when mana below a configurable percentage (10% by default)
Added option to show Windshock icon for World Bosses only
Updated Export routine to include Spirit, Max_mana, MP5, race, and weapon type - for sim v1.4.2 onwards
Removed bonus on export stats if player alliance as sim now handles this
Added command /saa config to open graphical config window

Originally Posted by Malan

[e] I updated to the latest version today (had been out of town) and now I have a 'dead spot' near my character, where I can't do anything that involves the right mouse button. You don't seem to have a frame there that's visible, but do you have some sort of debug frame that's sitting in the background or something?

There are two hidden frames neither of which should be clickable, and thus shouldn't care if you click a mouse since they should be transparent.

Try /saa moveframes to see if its the Warning Frame. By default the warning frame should be above your characters head but not clickable. The /saa moveframes will allow you to move around the warning frame for now if thats the cause and I can fix it next version.

Or try /script ShockAndAwe.BindingFrame:Show() it isn't movable but would at least tell me if thats the frame in question. If it is I can fix it temporarily by moving it off screen until I work out why its clickable.

If you can report back any findings please, I can then fix this in a 3.41 patch.

Malan · 10/27/08, 9:25 AM

No it's definitely not the warning frame, that one is visible when I unlock the frames, and it's up above my char right now. The spot that is causing issues is up and to the right of my character head, no more than a few inches. I can left click through it, but the right mouse button is totally disabled on that spot.

I'll check at lunch if it might be the other frame.

Blayder · 10/27/08, 11:24 AM

Somehow i can't get this addon to work with ruRU locale. I mean i can do all the configurations etc. etc., but it doesn't track any spells. tried checking spell names in locale-ruRU.lua - seems ok to me, but still not working. Anything i could post here to help with this problem solving? Or maybe few tips if i missed something?

But perhaps it is somehow connected to AceLocale library that only containt enUS and enGB locales?

Levva · 10/27/08, 12:07 PM

Originally Posted by Blayder

Somehow i can't get this addon to work with ruRU locale. I mean i can do all the configurations etc. etc., but it doesn't track any spells. tried checking spell names in locale-ruRU.lua - seems ok to me, but still not working. Anything i could post here to help with this problem solving? Or maybe few tips if i missed something?

But perhaps it is somehow connected to AceLocale library that only containt enUS and enGB locales?

Someone on the curse forum just posted that the line in the locale-ruRU.lua file that initialises the locale needs to be

local L = LibStub("AceLocale-3.0"):NewLocale("ShockAndAwe", "ruRU", false)

I'll fix this for v3.41

Malan · 10/27/08, 12:18 PM

Ok it's not the keybind frame, that was situated below my character and wasn't clickable even when visible. Unless you have another hidden frame some place I'm about to blame AGUF.

Blayder · 10/27/08, 1:28 PM

local L = LibStub("AceLocale-3.0"):NewLocale("ShockAndAwe", "ruRU", false)

k, i'll test it now and see if it works.
UPD. Yep! Works nice!

Levva · 10/27/08, 2:44 PM

Originally Posted by Malan

Ok it's not the keybind frame, that was situated below my character and wasn't clickable even when visible. Unless you have another hidden frame some place I'm about to blame AGUF.

You might want to try Devtools at DevTools : WoWInterface Downloads : Developer Utilities

Once installed you have extra command line options eg: /dtframestack which shows a small window so that when you mouse over a frame it lists everything under the mouse as seen by the UI.

It should then be possible to track down the frame from its name. Even if its fairly generic name a search of all the *.lua & *.xml files in your addons folder should find out what what addon is the culprit.

Wundorn · 10/27/08, 5:40 PM

Originally Posted by Levva

Yup done. New version up on curse. Changelog is :

Version 3.40
[...]

Curse seems to be stuck at 3.31.

Levva · 10/27/08, 9:05 PM

Hmm indeed it does. Ah well minor bug fix version 3.41 should now be up will see if it appears.

Version 3.41
Fixed localisation issues with Russian and French locale files thanks to cranium_dc and Phops - Illidan (EU)
- can users who use locale's outside enUS please check these files so that I know they work, thanks.
- I am unable to check them myself because I have no non english client and I wouldn't understand the
- language anyway. Je m' comprende le Francaise peu t'etre.
- (I know thats probably wrongly spelt my French is limited to spoken, and a limited vocabulary at that.)
Fixed bug that priority wouldn't show Maelstrom weapon if the maelstrom weapon bar was switched off

Blayder · 10/28/08, 6:27 AM

After few hours of mashing training dummies in UC found 1 weird bug:
Pretty often addon doesn't catch new maelstrom stack, i.e. i hit lighting bolt with full stack and on next hit i get first stack of maelstrom, but addon doesn't show anything. Bar appears only when you get full stack again.

Levva · 10/28/08, 7:23 AM

Originally Posted by Blayder

After few hours of mashing training dummies in UC found 1 weird bug:
Pretty often addon doesn't catch new maelstrom stack, i.e. i hit lighting bolt with full stack and on next hit i get first stack of maelstrom, but addon doesn't show anything. Bar appears only when you get full stack again.

Can you tell me what version you are using. I thought this bug was squashed.

Use /saa version and give me the exact details of what it says.

Blayder · 10/28/08, 9:31 AM

v3.31 (r63)
Haven't updated today thou..

Levva · 10/28/08, 9:54 AM

Hmm changelog indicates it should have been fixed in v3.31 can you test with v3.41 and see if you see the issue. I've not seen it happening on my version lately. If it is still happening on some versions it must be down to some config settings, and I'd like to get to the bottom of it once and for all.

I did do a couple of tweaks in v3.41 from v3.40 that "Fixed bug that priority wouldn't show Maelstrom weapon if the maelstrom weapon bar was switched off" so that might have affected it too. Let me know please.

Blayder · 10/28/08, 11:10 AM

K, will do it in first place as i get home.
And maybe a small suggestion:
Would it be possible to add an option for maelstrom bar to change color depending on stack amount, i.e. make it darker with each stack or something. In that way it would be easier to watch stacks without paying attention to numbers on the bar.