 |
12/09/09, 11:50 AM
|
#251
|
|
Von Kaiser
|
I tried making the modifications last night, but was not able to get it to work. I'm sure I did something wrong, but I am not experianced with Lua and WoW addons at all. Could you guys upload a updated version on WoWInterface?
|
|
|
|
12/09/09, 12:36 PM
|
#252
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Originally Posted by Cdin
I tried making the modifications last night, but was not able to get it to work. I'm sure I did something wrong, but I am not experianced with Lua and WoW addons at all. Could you guys upload a updated version on WoWInterface?
|
Based on the feedback in this thread, I'll probably upload it sometime today.
Shibby, do you know what memory footprint it was using before? 1MB is a lot, the changes aren't storing any new data, and I can't imagine that adding an event handler consumes that much memory. Not that it's a huge issue for it to be that large in principle, but I don't like confusing results.
Beef, I have no idea what would cause it to hiccup on just HoTs, does it hiccup on the spells it's supposed to track as well?
|
|
|
|
|
12/09/09, 12:50 PM
|
#253
|
|
Glass Joe
|
I was able to run it in raid last night, but found that the addon would seem to lockup in combat tracking my trinkets.
At least the error I was getting is as shown below and disabling tracking of trinkets resolved my issue. No other problems were observed.
"SquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:1247: attempt to concatenate field 'itemname' (a nil value)\nSquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:895: in function <Interface\\AddOns\\SquawkAndAwe\\SquawkAndAwe.lua:894>\n\n ---",
|
|
|
|
|
12/09/09, 12:53 PM
|
#254
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Originally Posted by kila
I was able to run it in raid last night, but found that the addon would seem to lockup in combat tracking my trinkets.
At least the error I was getting is as shown below and disabling tracking of trinkets resolved my issue. No other problems were observed.
"SquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:1247: attempt to concatenate field 'itemname' (a nil value)\nSquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:895: in function <Interface\\AddOns\\SquawkAndAwe\\SquawkAndAwe.lua:894>\n\n ---",
|
Yes, this has been known for a long time. I have no idea what's causing the trinket bars to bork, nor why it only seems to affect certain trinkets, nor why that list seems to change every patch. I will probably be making the trinket bars default off when I upload today (though this will of course only affect new users).
|
|
|
|
|
12/09/09, 1:12 PM
|
#255
|
|
Glass Joe
|
I have no idea where it was running beforehand.
My testing that came up with 1 meg consisted of me mousing over my addon memory when I was spamming on a target dummy trying to decide if my interface was working, so take that number with a grain of salt.
I will try to keep track of it tonight if the instance servers are up.
|
|
|
|
|
12/09/09, 3:37 PM
|
#256
|
|
Great Tiger
Orc Death Knight
Blutkessel (EU)
|
Here is a working copy of SquawkAndAwe, if you want to raid today:
Edit: See here SquawkAndAwe.
It worked on the dummy like before.
Last edited by dr_AllCOM3 : 12/09/09 at 7:29 PM.
|
|
|
|
12/09/09, 5:54 PM
|
#257
|
|
Von Kaiser
|
When I tried to use the lua file from the moonkin repository, I had a lot less of the editing features compared to the file I downloaded from here. I like this version of Doc's download it a lot better than the "quick fix" where we were self-editing the files. We can just turn off things like the trinket stuff that isn't working as well.
Last edited by lissanna : 12/09/09 at 6:02 PM.
|
|
|
|
|
12/09/09, 6:23 PM
|
#258
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Official patch is attached to this post, I'd like at least a couple people to make sure it actually works before I upload it to WoWI/Curse given that I de-abstracted some of Cop's code so it's not quite as ugly of a hack. I also defaulted the trinket bars to off, and bumped the TOC.
[edit] Helps to actually attach things.
Last edited by Adoriele : 12/10/09 at 5:58 PM.
|
|
|
|
|
12/09/09, 6:40 PM
|
#259
|
|
Glass Joe
|
works for me (on dummy). english client, german server
thanks a lot!!!!!
Last edited by smallrabbit : 12/09/09 at 7:00 PM.
|
|
|
|
|
12/09/09, 7:10 PM
|
#260
|
|
Glass Joe
Troll Druid
Shattered Halls (EU)
|
I just installed it and tried it, it seems that cd after buff goes off shows 30s instead of 15s, or am I wrong?
|
|
|
|
|
12/09/09, 7:10 PM
|
#261
|
|
Glass Joe
Night Elf Druid
Turalyon (EU)
|
Originally Posted by Adoriele
Official patch is attached to this post, I'd like at least a couple people to make sure it actually works before I upload it to WoWI/Curse given that I de-abstracted some of Cop's code so it's not quite as ugly of a hack. I also defaulted the trinket bars to off, and bumped the TOC.
[edit] Helps to actually attach things.
|
Hi,
Seems to work a treat so far... really struggled without it aswell.
Thanks for the work from you all 
|
|
|
|
|
12/09/09, 7:15 PM
|
#262
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Originally Posted by Zagortenej
I just installed it and tried it, it seems that cd after buff goes off shows 30s instead of 15s, or am I wrong?
|
That's an artifact from pre-3.2, as it's showing you the CD of the Eclipse that just procced (which is still 30s).
With 3 reports of the mod working, I'm uploading it to WoWI and Curse.
|
|
|
|
|
12/09/09, 8:59 PM
|
#263
|
|
Morcego, disciple of Melthu
|
The version on curse is showing as "SquawkAndAwe", instead of 1.4.0.
|
|
|
|
|
12/09/09, 10:22 PM
|
#264
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Originally Posted by aldones
The version on curse is showing as "SquawkAndAwe", instead of 1.4.0.
|
Yeah, that's from me having no idea how their update process works.
|
|
|
|
|
12/09/09, 10:46 PM
|
#265
|
|
<Druid Trainer> Emeritus
|
Originally Posted by Zagortenej
I just installed it and tried it, it seems that cd after buff goes off shows 30s instead of 15s, or am I wrong?
|
Yes, Eclipse cooldown is borked. It keeps repeatedly refreshing to 30s when it shouldn't.
|
|
|
|
12/09/09, 11:28 PM
|
#266
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Originally Posted by Arawethion
Yes, Eclipse cooldown is borked. It keeps repeatedly refreshing to 30s when it shouldn't.
|
Ooh, I know why it's doing that (mostly because I forgot to put in the second half of my de-abstraction). Gimme a few to fix it.
[edit] Try this.
Last edited by Adoriele : 12/10/09 at 5:58 PM.
|
|
|
|
|
12/10/09, 3:01 AM
|
#267
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Actually, try this one instead. Includes the fix for the constantly refreshing Eclipse cooldown bar, but it also includes some other changes to the Eclipse bar functionality that fits with 3.3 that I think people may like (if it works, obviously drycoded).
Last edited by Adoriele : 12/10/09 at 5:58 PM.
|
|
|
|
|
12/10/09, 6:48 AM
|
#268
|
|
Von Kaiser
Night Elf Druid
Eonar (EU)
|
Thanks very much adoriele for keeping this up to date even if you dont even play the game anymore.
|
|
|
|
|
12/10/09, 6:56 AM
|
#269
|
|
Glass Joe
Night Elf Druid
Shattrath
|
Thanks for the updates. The first link works great, the second needs a little fine tuning :P. It doesn't load up in game.
|
|
|
|
|
12/10/09, 8:31 AM
|
#270
|
|
Glass Joe
Troll Druid
Shattered Halls (EU)
|
Originally Posted by Hoedown
Thanks for the updates. The first link works great, the second needs a little fine tuning :P. It doesn't load up in game.
|
Confirmed, I have problems too with the last one
|
|
|
|
|
12/10/09, 8:58 AM
|
#271
|
|
Von Kaiser
Night Elf Druid
Burning Blade
|
Originally Posted by xaktsaroth
Thanks very much adoriele for keeping this up to date even if you dont even play the game anymore.
|
Absolutely; thanks man. My favorite mod! :-)
|
|
|
|
|
12/10/09, 10:04 AM
|
#272
|
|
Save Greendale!
Night Elf Druid
Dragonblight
|
Originally Posted by Hoedown
Thanks for the updates. The first link works great, the second needs a little fine tuning :P. It doesn't load up in game.
|
Someone PM'd me the error message, here's another try at the fix.
Last edited by Adoriele : 12/10/09 at 5:58 PM.
|
|
|
|
|
12/10/09, 11:51 AM
|
#273
|
|
Von Kaiser
Night Elf Druid
Shadowsong (EU)
|
Is it possible to switch order of bars in S&A? In some old version (1.1 I think) I used to have MF bar above IS bar. Not it is the opposite. I would like to customize it, making it more in line with order of my keybindings.
|
|
|
|
|
12/10/09, 12:24 PM
|
#274
|
|
Great Tiger
Night Elf Druid
Echo Isles
|
I used the one from post 272. It works, but then I got
Date: 2009-12-10 10:20:54
ID: 3
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 1059:
attempt to perform arithmetic on field 'cd' (a nil value)
Debug:
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:1059: ProcBars()
SquawkAndAwe\SquawkAndAwe.lua:391: ?()
...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[13]"]:4:
[string "safecall Dispatcher[13]"]:4
[C]: ?
[string "safecall Dispatcher[13]"]:13: ?()
...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119
|
|
|
|
|
12/10/09, 12:40 PM
|
#275
|
|
Von Kaiser
Tauren Druid
Blackhand (EU)
|
used version from post 272
got following error:
Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1376: attempt to index field 'text' (a nil value)
Time: 12/10/09 17:34:17
Count: 3
Stack: [C]: ?
Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1376: in function `OnUpdate'
Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:893: in function <Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:892>
|
|
|
|
|
|