SquawkAndAwe - Page 12

• Adoriele · 12/10/09, 12:51 PM

Originally Posted by Erdluf

I used the one from post 272.

Originally Posted by M� nze

used version from post 272

This should fix both of those.

Khornate · 12/10/09, 12:57 PM

Im no pro with addon coding or anything but i feel like something is wrong when SAA use this much memory

Click here

ninor · 12/10/09, 1:15 PM

Got the following error:

[2009/12/10 18:08:56-2315-x2]: SquawkAndAwe-SquawkAndAwe v1.4.1 (r1)\SquawkAndAwe.lua:1376: attempt to index field 'text' (a nil value)
SquawkAndAwe-SquawkAndAwe v1.4.1 (r1)\SquawkAndAwe.lua:893: in function <Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:892>

---
[EDIT]: I can't see whats wrong anyway.

• Adoriele · 12/10/09, 1:30 PM

Originally Posted by Khornate

Im no pro with addon coding or anything but i feel like something is wrong when SAA use this much memory

Click here

I really have no idea what's causing that. Are you using 1.4.0 and, if so, could you tell me if it's eating up that much memory in 1.3.3? The UNIT_AURA change isn't storing any new information.

Originally Posted by Ranghar

Is it possible to switch order of bars in S&A? In some old version (1.1 I think) I used to have MF bar above IS bar. Not it is the opposite. I would like to customize it, making it more in line with order of my keybindings.

The short answer is no. The long answer is that yes, it's possible to control the bar order in SAA, but it requires an even uglier hack to accomplish quickly.

The really long answer is that the bars in SAA are generated by iterating through an array for each type of bar, ex. SAA.combat.procs (which makes it really easy to add more bars to a category in the future). Unfortunately, the iteration process is, while deterministic, also uncontrollable - the data comes out of the array in the order in which it was stored internally, and using string keys means that I have no control over that internal order. This is a limitation of Lua itself, and switching the order in which the data is added to the array may not change the order that the bars are added to the screen.

When creating bars, there is a variable - barcount, in CreateBarFrames() - which controls bar order (well, really it controls how far down from the top of the SAA frame a bar is placed, but it amounts to the same thing). If you were to hack SAA to rearrange the bars, this is the variable you would want to play with. Unfortunately, this is a personal preference thing, so it's not something I'll add to the official version of the mod, but you'd want to do something like

-- Creates bar frames by iterating through categories and setting up each,
-- either merged or not
function SquawkAndAwe:CreateBarFrames()

<snip>
	-- Debuff bars
	layer = 1
	add = 0
	if self.db.char.bars.mergedebuffs then
		
<snip merged debuff code>

---------OLD CODE----------------------
	else
		for k,v in pairs(self.db.char.bars.debuffs) do
			if v.show then
				SquawkAndAwe:SetBarFrame(k, barCount, SquawkAndAwe.combat.debuffs[k].id)
				SquawkAndAwe:AddStatusBar(self.frames[k], k, v.color, 1)
				if v.tick then
					SquawkAndAwe:AddStatusBar(self.frames[k], k.."Tick", self.db.char.bars.tickcolor, 2, true, SquawkAndAwe.combat.debuffs[k].tick)
				end
				barCount = barCount + 1
			end
		end
	end

----------NEW CODE-----------------
	else
		local tempBarCount = 0
		local position = 0
		for k,v in pairs(self.db.char.bars.debuffs) do
			if v.show then
				if k == "Moonfire" then position = 0
				elseif k == "Insect" then position = 1
				elseif k == "Faerie" then postition = 2 end
				SquawkAndAwe:SetBarFrame(k, barCount + position, SquawkAndAwe.combat.debuffs[k].id)
				SquawkAndAwe:AddStatusBar(self.frames[k], k, v.color, 1)
				if v.tick then
					SquawkAndAwe:AddStatusBar(self.frames[k], k.."Tick", self.db.char.bars.tickcolor, 2, true, SquawkAndAwe.combat.debuffs[k].tick)
				end
				tempBarCount = tempBarCount + 1
			end
		end
		barCount = barCount + tempBarCount
	end

I was intending to add an order field to the options for each bar (only within each category, so your debuffs would always be together, etc) which could control this, but that's a bunch of backend work.

lissanna · 12/10/09, 2:58 PM

Doc's Version from post 256 isn't having that bug. Maybe we should be using that one, instead? His version has been working great for me. I raided with it last night and it was working great.

• Adoriele · 12/10/09, 3:09 PM

Originally Posted by lissanna

Doc's Version from post 256 isn't having that bug. Maybe we should be using that one, instead? His version has been working great for me. I raided with it last night and it was working great.

Well, I'd rather just fix issues if I can. Speaking of, with a little help from a guildy testing:

ninor · 12/10/09, 3:16 PM

It's kind of confusing that all versions are called 1.4.1

• Adoriele · 12/10/09, 3:21 PM

Originally Posted by ninor

It's kind of confusing that all versions are called 1.4.1

Yeah, I'll see if I can rename the attachments to include a build number. Just don't want to have WoWI/Curse jump from 1.4.0 to 1.4.7 or something. That said, the post 281's version was working for my guildy so I imagine it will be the 1.4.1 release.

[edit] As for the memory issue, it's looking to me like it's a library conflict, based off of what my guildy's saying. He's going to run it during the raid tonight to make sure it's not exploding for him, though.

(for those unaware, if an addon is using a bunch of memory, and doing so by calling a library function, that memory will be attributed to the first addon loaded that uses that library, instead of the addon that's actually sinking the memory. Same for CPU use)

ninor · 12/10/09, 3:27 PM

I have the same issue still.

After the proc part of the eclipse bar is done, the ICD bar just dissappears. Doesn't matter if I have other debuff bars running. Nothing is merged. Showing Eclipse, IS, MF and FF.

This version does not give out any error msg though.

• Adoriele · 12/10/09, 3:34 PM

Originally Posted by ninor

I have the same issue still.

After the proc part of the eclipse bar is done, the ICD bar just dissappears. Doesn't matter if I have other debuff bars running. Nothing is merged. Showing Eclipse, IS, MF and FF.

This version does not give out any error msg though.

Is the ICD bar showing when Eclipse is up? If not, you probably have Eclipse Cooldown turned off.

The additions in 1.4.1 are as follows, assume you procced Solar Eclipse and then you clicked it off/it got purged after 8s, and that you have Spell Names, Durations, Eclipse Cooldown, and Eclipse Type turned on:
From 0-8s, there should be a green bar in front of a light grey bar, and the text should read "Eclipse (Wrath): 15-7s".
From 8-15s, there should be a dark grey bar in front of a light grey bar, and the text should read "Eclipse (Starfire) Cooldown: 7-0s".
From 15-30s, there should only be a light grey bar, and the text should read "Eclipse (Wrath) Cooldown: 15-0s".

ninor · 12/10/09, 3:37 PM

It was. I did a "Reset to default", and set it up again, and after a /reloadui it's working like it should. No idea what that was about.

• Adoriele · 12/10/09, 3:49 PM

Found another bug, with the ICD bar not depleting after Eclipse fades (though this time at 15s), fixed.

Angelostyle · 12/10/09, 4:01 PM

Thanks alot for the fix mate, I really appreciate your work

lissanna · 12/10/09, 4:53 PM

Originally Posted by Adoriele

Found another bug, with the ICD bar not depleting after Eclipse fades (though this time at 15s), fixed.

This newest version is working for me. I just tried it out on a testing dummy. Thanks for working to fix it!

Forgiven · 12/11/09, 11:41 AM

Adoriele, Thanks so much for the hard work! This is definitely my preferred my rotation cycle.

scudetto · 12/13/09, 3:10 PM

not working
shows everything, but eclipse proc

I've tried to reinstall, delete all configs, even delete all addons (and installing only the latest Squawk version), but nothing

(

• Adoriele · 12/13/09, 3:47 PM

Originally Posted by scudetto

not working
shows everything, but eclipse proc

I've tried to reinstall, delete all configs, even delete all addons (and installing only the latest Squawk version), but nothing

(

I'd need an error log to work off of before I'd have any idea of how to fix it.

I was asked in a PM about adding sounds when Eclipse procs. Ironically, SAA already had sounds imported, it just wasn't doing anything with them, so hacking it in isn't too difficult. I did promise someone I'd add it into the mod proper, though, so I'll work on that over the next couple days (and will probably add the order control, too).

To get sounds into SAA:
1.) You'll need to figure out which sounds SAA has available. This should be whatever your SharedMedia has access to, but there may also be more. Luckily, it's fairly easy to find - with WoW running, type the following into the chat box

/run for k,v in pairs(SquawkAndAwe.sounds) do SquawkAndAwe:Print(v.." ") end

You'll get a listing of all of the sounds SAA has access to. Most of these should be familiar from other addons such as BW, Parrot, etc. so if you want to listen to them to pick out which one you want to use, go into one of them and select it (getting the sound to play from the chat box is a lot tougher).

2.) Once you know what sound you want to use (or if you have no other way of testing them out), insert the following code:

PlaySoundFile(media:Fetch("sound", "THE NAME OF YOUR SOUND HERE")

at both lines 369 and 373, replacing the obvious text with the name you grabbed from step 1, keeping the quotes. Your UNIT_AURA() function should then look something like:

function SquawkAndAwe:UNIT_AURA(event,id)
	if id == "player" and not SquawkAndAwe.ActiveEclipseBuff then
		local _,_,_,_,_,_,_,_,_,_,spellID = UnitBuff("player",SquawkAndAwe.combat.procs.Eclipse.name);
		if spellID == SquawkAndAwe.combat.procs.Eclipse.id then
			SquawkAndAwe.ActiveEclipseBuff = true
			PlaySoundFile(media:Fetch("sound", "ping"))
			SquawkAndAwe:ProcBars("Eclipse", SquawkAndAwe.combat.procs.Eclipse)
		elseif spellID == SquawkAndAwe.combat.procs.Eclipsew.id then
			SquawkAndAwe.ActiveEclipseBuff = true
			PlaySoundFile(media:Fetch("sound", "ping"))
			SquawkAndAwe:ProcBars("Eclipsew", SquawkAndAwe.combat.procs.Eclipsew)
		end
	end -- if id == "player"
end -- function SAA:UNIT_AURA()

Note that all of this is drycoded, so if it doesn't work, let me know what errors you get and I'll adjust the instructions accordingly.

LostBoyJim · 12/15/09, 4:15 PM

With the new 12./10/08 download my trinket procs are no longer showing (particularly [Dying Curse]). I tried

/saa trinketshow

but it threw an error saying that trinketshow isn't a valid option. On testing, neither is trinketcd. Are the man pages borked, or is that part of /saa not working?

LostBoyJim · 12/15/09, 4:16 PM

error post.

• Adoriele · 12/15/09, 4:42 PM

Originally Posted by LostBoyJim

With the new 12./10/08 download my trinket procs are no longer showing (particularly [Dying Curse]). I tried

/saa trinketshow

but it threw an error saying that trinketshow isn't a valid option. On testing, neither is trinketcd. Are the man pages borked, or is that part of /saa not working?

You're not using the full command. You'd need /saa trinkets trinketshow, I think. Alternatively, you could just use the options panel in the Blizzard options, which has been there since Blizzard started allowing addons to put their options in the Blizzard interface.

[edit] The naming for that option is a little redundant, which probably leads to the confusion. For example, if you wanted to turn on or off Eclipse tracking, you'd use /saa procs Eclipse show, which makes a little more sense.

romoe · 12/16/09, 1:37 PM

Nice job with the addon! works just fine for me. But it's one thing im missing, would be nice to be able to keep lunar/solar cd tracked even if a new one proccs especially during Bl etc. otherwise the addon works fine

• Adoriele · 12/16/09, 1:40 PM

Originally Posted by romoe

Nice job with the addon! works just fine for me. But it's one thing im missing, would be nice to be able to keep lunar/solar cd tracked even if a new one proccs especially during Bl etc. otherwise the addon works fine

Err, it's already showing both cooldowns, at least as of 1.4.1. Remember that when a new Eclipse procs, the other cooldown is extended to at least 15s. So if your Eclipse hasn't been purged, the shortest cooldown matches its duration. If it has, the bar changes colors to indicate this.

romoe · 12/16/09, 3:36 PM

strange.. im running with 1.4.1.287 and when an eclipse proccs it shows both the duration and the cooldown, but when it has ran out and the other eclipse proccs the new bar overwrites the old and im unable to track the cd =(

• Adoriele · 12/16/09, 3:42 PM

Originally Posted by romoe

strange.. im running with 1.4.1.287 and when an eclipse proccs it shows both the duration and the cooldown, but when it has ran out and the other eclipse proccs the new bar overwrites the old and im unable to track the cd =(

Um. Yes. This is exactly what I explained above. If you proc a Solar Eclipse, then Lunar is on cooldown for exactly the same duration as the Solar Eclipse buff. Even if you procced it after 10s of downtime, proccing Solar forces Lunar back to 15s cooldown. This is the change in 3.3 that killed WiseEclipse. Therefore, since they have exactly the same duration, there is no reason to show another bar for it. Instead, if you happen to lose your Solar Eclipse by Purge, or you're fighting Garr, or you click it off for some reason, SAA will change the color of the bar to dark grey to show that your Eclipse is no longer active, but Lunar is still on cooldown. This is the only time when seeing both cooldowns is either possible or necessary.

romoe · 12/17/09, 6:03 AM

aaah ofc, sry about that :P

then the addon works perfectly :P