I have been trying out the sound, it seems to work just fine. I have not gotten any errors as of yet either. I will let you know if I come across anything. One thing, my line Numbers were slightly off from yours. Of course, if you are editing the lua file I would hope you could find the right place on your own, but just figured I would mention it.
not working
shows everything, but eclipse proc
I've tried to reinstall, delete all configs, even delete all addons (and installing only the latest Squawk version), but nothing (
Weirdly enough, i'm having the same issue, just installed the addon (from curse) for the first time and it doesn't show neither the eclipse duration or cooldown. It works fine for everything else like starfall and force of nature, showing both the duration and cooldown. I was fiddling around with the settings before i first used it, removing some things shown by default, but that shouldn't cause it to bug out like that?
It does show a bar when eclipse procs, but one that's only half blue and half gray without text and numbers, and doesn't go away before i relog.
About that error log (or debug log?) how can you get one of those going regarding this addon?
EDIT: Nevermind, it's working now, with a few relogs it seems to have solved itself, weird :P
Firstly, thanks on such an excellent addon. I can't imagine playing a Moonkin without it now.
I'd just like to know if there is a way of changing the colour of the Border Texture? If not, what is the frame called for Eclipse duration/cooldown that I should anchor the likes of a KGPanel to? As I've tried 'SquawkAndAweBase' (which is what a script to find the frame names told me it was), yet it doesn't seem to disappear when the SAA bars aren't showing.
Firstly, thanks on such an excellent addon. I can't imagine playing a Moonkin without it now.
I'd just like to know if there is a way of changing the colour of the Border Texture? If not, what is the frame called for Eclipse duration/cooldown that I should anchor the likes of a KGPanel to? As I've tried 'SquawkAndAweBase' (which is what a script to find the frame names told me it was), yet it doesn't seem to disappear when the SAA bars aren't showing.
Ah. Well, that's probably because SquawkAndAweBase is the "container" for all of the other bars, and so is always active. The good news is that, even though the bars are generated in pseudo-random order (which is why the FF bar is between the two debuff bars), the bars are stored in numerical order. The bar you're going to want to anchor to will be SAABarFrameX, where X is the number of the bar you want to anchor from, starting with 1, counting from the top. So if your SAA looks like
Trinkets
Eclipse
OOC
MF
FF
IS
you'd want to anchor to SAABarFrame2, assuming you want it to show up any time there's an Eclipse bar. If you want to tie to a specific bar, either the proc or the cooldown, that's a little trickier. If you want to tie to something that disappears whenever all the bars are gone, that's gonna be pretty much impossible.
I'm only showing the Eclipse Procs bar, so setting up KGPanels to Anchor and Parent to SAABarFrame1 worked like a charm. Thanks for the quick reply! =)
First I'd like to say that sn'a is one of the most functional addons I've used. It seems to have an issue, however. At random points while doing my random dungeon or while in a raid, it will stop showing insect swarm at first, then after about another 10 minutes I will get an error, and it will bug out completely (save eclipse proc, and frozen proc bars that have no text every now and then) Based on the information I have given you, can you see what my problem is? The next time i receive an error I will copy it down and edit it in.
First I'd like to say that sn'a is one of the most functional addons I've used. It seems to have an issue, however. At random points while doing my random dungeon or while in a raid, it will stop showing insect swarm at first, then after about another 10 minutes I will get an error, and it will bug out completely (save eclipse proc, and frozen proc bars that have no text every now and then) Based on the information I have given you, can you see what my problem is? The next time i receive an error I will copy it down and edit it in.
Just making sure I understand you, you're describing the situation as follows:
You can cast all your spells normally
At some time t0, which you've been unable to find a cause for, the IS bar stops functioning. I'll make the assumption that all bars that would normally show below the IS bar also stop functioning, which would include the ability, CC, and GCD bars if you have them enabled. All bars above the IS bar continue functioning as normal.
At t0 + 10 minutes, the rest of the addon stops functioning properly. All non-proc bars cease to be spawned, non-Eclipse proc bars stop decreasing and have no text, but the Eclipse bar works as expected.
With that information I'm really confused as to what's causing it. I'd point to the standby of a trinket bar issue, but a.) Eclipse is still functioning properly, and b.) none of the trinkets have a 10-minute cooldown. In fact, nothing I can think of lines up with the 10-minute window at all, since Rebirth got dropped to 8 minutes (IIRC, it's been a looong time since I played but I try to keep up). I'm really going to need to see an error message for this one, it's about as far out of the ballpark as I can imagine. In the meantime, you might try reinstalling SAA, don't forget to clear your savedvariables when you do.
Just making sure I understand you, you're describing the situation as follows:
You can cast all your spells normally
At some time t0, which you've been unable to find a cause for, the IS bar stops functioning. I'll make the assumption that all bars that would normally show below the IS bar also stop functioning, which would include the ability, CC, and GCD bars if you have them enabled. All bars above the IS bar continue functioning as normal.
At t0 + 10 minutes, the rest of the addon stops functioning properly. All non-proc bars cease to be spawned, non-Eclipse proc bars stop decreasing and have no text, but the Eclipse bar works as expected.
With that information I'm really confused as to what's causing it. I'd point to the standby of a trinket bar issue, but a.) Eclipse is still functioning properly, and b.) none of the trinkets have a 10-minute cooldown. In fact, nothing I can think of lines up with the 10-minute window at all, since Rebirth got dropped to 8 minutes (IIRC, it's been a looong time since I played but I try to keep up). I'm really going to need to see an error message for this one, it's about as far out of the ballpark as I can imagine. In the meantime, you might try reinstalling SAA, don't forget to clear your savedvariables when you do.
Np, thanks for the quick response, your awesome! Our server is crashing repeatedly, so I'm having trouble actually getting on to get the error message, but i will as soon as I can. Another note I only have eclipse IS MF trees and innervate turned on, everything else is off. Ill respond as soon as I can repeat the error, but its not every raid night, however reloading UI doesn't fix it, which makes me think its conflicting with something.
There is currently a bug in the WoW client that is probably at fault. At seemingly random times, the CombatLog will just stop working. Dps meters like Recount/Skada will no longer update because they're no longer receiving data. Nothing will get written to the combatlog.txt so there will be a hole in any World of Logs data. Any mods which use the CombatLog to track state will no longer trigger.
I believe SaA uses your own buffs to track Eclipse, so this isn't affected. But I believe it uses the CombatLog to track debuffs on your targets, so when this happens you'll no longer get timers for FF, IS and MF. There's not much mod authors can do about this, we just need to wait for Bliz to fix the CombatLog.
So far the only work-around is to log off and back on again. The error is pretty rare, the most I've seen it is about twice a week, and never twice in the same day. So it's not a huge burden, but still it'll be nice once it's fixed.
I and at least one or two others (not sure if it's a widespread issue or not) are seeing a problem where the proc bar for Solar Eclipse isn't being shown. The addon seems to detect it, as it displays a cooldown bar when it procs (which would normally be under the proc bar), but not the green Solar Eclipse bar.
Since they put Eclipse back into the combat log, is the fix that was implemented when they removed eclipse from the combat log going to be reversed back to the combat log checking?
Since they put Eclipse back into the combat log, is the fix that was implemented when they removed eclipse from the combat log going to be reversed back to the combat log checking?
I'll look into it, I think the fix was made in a way that it should be easy to remove. Standard caveats apply, it may be a couple days before I can look at it.
It seems to detect Solar eclipse just fine for me. It just doesn't show up with a green bar -- it's only showing a grey cooldown bar labeled "Eclipse (Lunar) (Starfire) Cooldown: 15.0s" that ticks down at half speed. When the timer reaches 0 the bar is still half full, and the text changes to say "Eclipse (Lunar) (Wrath) Cooldown: 15.0s"
It seems to detect Solar eclipse just fine for me. It just doesn't show up with a green bar -- it's only showing a grey cooldown bar labeled "Eclipse (Lunar) (Starfire) Cooldown: 15.0s" that ticks down at half speed. When the timer reaches 0 the bar is still half full, and the text changes to say "Eclipse (Lunar) (Wrath) Cooldown: 15.0s"
I'm on 1.4.1 (r1).
Confirmed. I think the eclipses are now properly labeled in the combat log, where previously both lunar and solar eclipse were just named "eclipse". That's probably messing up the addon.
edit: just double-checked: my combat log now displays:
X gains X's Eclipse (Solar).
At least until someone fixes it, I just replaced the UNIT_AURA function with the one posted by cop at SquawkAndAwe. That added the coloring back, though the label will still say "Eclipse (Lunar)" during solar eclipses. Since I don't use the text labels and the icon shows up fine with or without the change, it's not a big deal for me.
I wasn't able to test this in a raid, so I don't know how noticeable the performance hit is.
<onslut> all the women in my family leave a bad taste in my mouth =(
I hacked together a temporary fix which isn't very pretty, but seems to fix the problem and not break anything else. You can grab my version of the updated "SquawkAndAwe.lua" at http://pastie.org/884388.txt, just make sure you save the file as "SquawkAndAwe.lua" in your Interface/AddOns/SquawkAndAwe folder (overwrite the old one).
If you've customized your own SAA, and you know how to read a patch (pretty simple, just delete the "-" lines and add the "+" lines corresponding to them), the following lets you know what I did to resolve the problem:
@@ -361,2 +361 @@
- local _,_,_,_,_,_,_,_,_,_,spellID = UnitBuff("player",SquawkAndAwe.combat.procs.Eclipse.name);
- if spellID == SquawkAndAwe.combat.procs.Eclipse.id then
+ if UnitBuff("player",SquawkAndAwe.combat.procs.Eclipse.name) then
@@ -365 +364 @@
- elseif spellID == SquawkAndAwe.combat.procs.Eclipsew.id then
+ elseif UnitBuff("player",SquawkAndAwe.combat.procs.Eclipsew.name) then
@@ -486 +485 @@
- if name == spellName then
+ if name == spellName or (spellName == "Eclipse (Lunar)" and EclipseType == "Wrath" and name == "Eclipse (Solar)") then
@@ -1330 +1329 @@
- namestring = SquawkAndAwe.combat.procs[k].name..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "").." "..L["Cooldown"]..(SquawkAndAwe.db.char.durations and ": " or "")
+ namestring = ((k=="Eclipse" and "Eclipse") or SquawkAndAwe.combat.procs[k].name)..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "").." "..L["Cooldown"]..(SquawkAndAwe.db.char.durations and ": " or "")
@@ -1344 +1343 @@
- namestring = SquawkAndAwe.combat.procs[k].name..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "")..(SquawkAndAwe.db.char.durations and ": " or "")
+ namestring = ((k=="Eclipse" and "Eclipse") or SquawkAndAwe.combat.procs[k].name)..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "")..(SquawkAndAwe.db.char.durations and ": " or "")
@@ -1368,2 +1367 @@
- local typestring = SquawkAndAwe.db.char.eclipsetype and " ("..(EclipseType == SquawkAndAwe.combat.Wrath.name and SquawkAndAwe.combat.Starfire.name or SquawkAndAwe.combat.Wrath.name)..")"
- namestring = SquawkAndAwe.combat.procs.Eclipse.name..(SquawkAndAwe.db.char.eclipsetype and typestring or "").." "..L["Cooldown"]..(SquawkAndAwe.db.char.durations and ": " or "")
+ namestring = "Eclipse ("..EclipseType..")"..(SquawkAndAwe.db.char.durations and ": " or "")
Aldones, thanks for the id on T10-2P. I've got the bar added into the working copy for the next version, complete with the options settings. Should work out of the box assuming I didn't fudge a comma somewhere. Also, adding it in made me notice an error with the PVP set proc bar (the option to turn it on or off was incorrectly tied to the T8-4P bar, go fig), which has also been fixed.
I'm in the process of adding UI support for sounds as well. I mentioned it on the comments at the Curse download site, but SAA has access to any sounds in SharedMedia (I think). I have no idea how sounds get added to SharedMedia, as I've never done it myself, but you could conceivably add your own custom sounds if you wish. Probably will end up adding options for sounds on all of the procs, individually selectable.
Still working on the official 3.3 fix, I think I have a handle on what's going on. Should be able to remove the UNIT_AURA() event handler that fixed the 3.3.0 issue, and update things to use the new separated buff names. Kinda cool that Blizzard made the Lunar/Solar names official.
Aldones, thanks for the id on T10-2P. I've got the bar added into the working copy for the next version, complete with the options settings. Should work out of the box assuming I didn't fudge a comma somewhere. Also, adding it in made me notice an error with the PVP set proc bar (the option to turn it on or off was incorrectly tied to the T8-4P bar, go fig), which has also been fixed.
I'm in the process of adding UI support for sounds as well. I mentioned it on the comments at the Curse download site, but SAA has access to any sounds in SharedMedia (I think). I have no idea how sounds get added to SharedMedia, as I've never done it myself, but you could conceivably add your own custom sounds if you wish. Probably will end up adding options for sounds on all of the procs, individually selectable.
Still working on the official 3.3 fix, I think I have a handle on what's going on. Should be able to remove the UNIT_AURA() event handler that fixed the 3.3.0 issue, and update things to use the new separated buff names. Kinda cool that Blizzard made the Lunar/Solar names official.
I'm pretty stoked that you still support this Adoriele as it is by far my favorite and most functional mod, thanks in advance for fixing the latest round of Blizzard breaking it on all of us!
I'm pretty stoked that you still support this Adoriele as it is by far my favorite and most functional mod, thanks in advance for fixing the latest round of Blizzard breaking it on all of us!
yup, thanks for you support. Even if you dont play your moonkin or the game anymore! Don´t know what to do without SAA!
12/19/09, 3:18 PM
