Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Reply
 
LinkBack Thread Tools
Old 12/08/09, 2:38 PM   #241
Knoway
Glass Joe
 
Night Elf Druid
 
Perenolde
Added cop's fix to my SAA code, after the servers come up and I've had a chance to test it I'll report back with performance changes/any other relevant info.

Offline
Reply With Quote
Old 12/08/09, 3:33 PM   #242
copialinex
Von Kaiser
 
copialinex's Avatar
 
Tauren Druid
 
Minahonda (EU)
Originally Posted by Adoriele View Post
I should also note that, in the case that Eclipse does not spawn a UNIT_AURA event (which I'm not sure if it does, and don't know any way of testing), your Eclipse cooldown bar may be sliiightly off. We're talking on the order of however long it takes for you to have another aura change, which is likely milliseconds at most.
Tested, It does fire UNIT_AURA (Tested in PTR with a premade char without other procs (talents, items) than eclipse)

Spain Offline
Reply With Quote
Old 12/08/09, 4:10 PM   #243
 Hamlet
<Druid Trainer>
 
Hamlet's Avatar
 
Tauren Druid
 
Mal'Ganis
I'm not expecting a large performance hit. Everyone's probably already running multiple mods that hook UNIT_AURA (buff mods, unit frames, etc.).


United States Offline
Reply With Quote
Old 12/08/09, 4:13 PM   #244
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by Arawethion View Post
I'm not expecting a large performance hit. Everyone's probably already running multiple mods that hook UNIT_AURA (buff mods, unit frames, etc.).
No, neither am I, but I'd prefer confirmation before I make it official.

United States Online
Reply With Quote
Old 12/08/09, 9:05 PM   #245
Lord BEEF
Soda Popinski
 
Lord BEEF's Avatar
 
Tauren Druid
 
Mal'Ganis
Caused a serious performance hit for me in testing whenever I put a hot on myself. It would hiccup.

Offline
Reply With Quote
Old 12/09/09, 2:18 AM   #246
Akutsito
Glass Joe
 
Tauren Druid
 
Ragnaros
No noticeable performance hit here either.

Offline
Reply With Quote
Old 12/09/09, 2:22 AM   #247
Knoway
Glass Joe
 
Night Elf Druid
 
Perenolde
No noticeable performance hit vs target dummies. Didn't get a chance to test it in a raid setting, if anything is different there I'll update this post.

Offline
Reply With Quote
Old 12/09/09, 9:02 AM   #248
Eilt
Piston Honda
 
Night Elf Druid
 
Bloodhoof
I did not notice a performance change, I even applied hots to myself and had other druids do it as well (in a raid). However, I was capturing a lot of errors with squawk and awe, unfortunately I did not have time to look into it. I will get more info on that tonight though.

Offline
Reply With Quote
Old 12/09/09, 9:56 AM   #249
shibbytastic
Glass Joe
 
Tauren Druid
 
Stonemaul
I had good luck with the fix that you posted, but was unable to test it in a raid environment because our raid and instance servers went down the instant i finished fixing my interface. Against a target dummy it was using about 1Mb of memory, which is more than it was using before, but less than a lot of other timer mods.

If you plan on editing your lua file be sure you have the most updated version of Squawk And Awe. If you do not have the most updated version you will get a large number of error messages.

Thanks for getting a fix out there so fast guys. I really didn't want to have to find and adjust a new moonkin timer when i enjoy using this one so much.

Offline
Reply With Quote
Old 12/09/09, 10:02 AM   #250
aldones
Von Kaiser
 
Troll Druid
 
Skullcrusher
Only tested on stray mobs and the test dummy, but worked flawlessly for me, without any performance hits.
Going to test on a raiding environment tonight.

Offline
Reply With Quote
Old 12/09/09, 10:50 AM   #251
Cdin
Von Kaiser
 
Cdin's Avatar
 
Troll Druid
 
Stonemaul
I tried making the modifications last night, but was not able to get it to work. I'm sure I did something wrong, but I am not experianced with Lua and WoW addons at all. Could you guys upload a updated version on WoWInterface?

www.GrayMatterWoW.blogspot.com - My Moonkin related Blog.

Offline
Reply With Quote
Old 12/09/09, 11:36 AM   #252
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by Cdin View Post
I tried making the modifications last night, but was not able to get it to work. I'm sure I did something wrong, but I am not experianced with Lua and WoW addons at all. Could you guys upload a updated version on WoWInterface?
Based on the feedback in this thread, I'll probably upload it sometime today.

Shibby, do you know what memory footprint it was using before? 1MB is a lot, the changes aren't storing any new data, and I can't imagine that adding an event handler consumes that much memory. Not that it's a huge issue for it to be that large in principle, but I don't like confusing results.

Beef, I have no idea what would cause it to hiccup on just HoTs, does it hiccup on the spells it's supposed to track as well?

United States Online
Reply With Quote
Old 12/09/09, 11:50 AM   #253
kila
Glass Joe
 
Night Elf Druid
 
Baelgun
I was able to run it in raid last night, but found that the addon would seem to lockup in combat tracking my trinkets.

At least the error I was getting is as shown below and disabling tracking of trinkets resolved my issue. No other problems were observed.


"SquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:1247: attempt to concatenate field 'itemname' (a nil value)\nSquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:895: in function <Interface\\AddOns\\SquawkAndAwe\\SquawkAndAwe.lua:894>\n\n ---",

Offline
Reply With Quote
Old 12/09/09, 11:53 AM   #254
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by kila View Post
I was able to run it in raid last night, but found that the addon would seem to lockup in combat tracking my trinkets.

At least the error I was getting is as shown below and disabling tracking of trinkets resolved my issue. No other problems were observed.


"SquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:1247: attempt to concatenate field 'itemname' (a nil value)\nSquawkAndAwe-SquawkAndAwe v1.3.3 (r1)\\SquawkAndAwe.lua:895: in function <Interface\\AddOns\\SquawkAndAwe\\SquawkAndAwe.lua:894>\n\n ---",
Yes, this has been known for a long time. I have no idea what's causing the trinket bars to bork, nor why it only seems to affect certain trinkets, nor why that list seems to change every patch. I will probably be making the trinket bars default off when I upload today (though this will of course only affect new users).

United States Online
Reply With Quote
Old 12/09/09, 12:12 PM   #255
shibbytastic
Glass Joe
 
Tauren Druid
 
Stonemaul
I have no idea where it was running beforehand.

My testing that came up with 1 meg consisted of me mousing over my addon memory when I was spamming on a target dummy trying to decide if my interface was working, so take that number with a grain of salt.

I will try to keep track of it tonight if the instance servers are up.

Offline
Reply With Quote
Reply

Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Thread Tools