Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Reply
 
LinkBack Thread Tools
Old 12/10/09, 7:58 AM   #271
Zifrelm
Von Kaiser
 
Night Elf Druid
 
Burning Blade
Originally Posted by xaktsaroth View Post
Thanks very much adoriele for keeping this up to date even if you dont even play the game anymore.
Absolutely; thanks man. My favorite mod! :-)

Offline
Reply With Quote
Old 12/10/09, 9:04 AM   #272
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by Hoedown View Post
Thanks for the updates. The first link works great, the second needs a little fine tuning :P. It doesn't load up in game.
Someone PM'd me the error message, here's another try at the fix.

Last edited by Adoriele : 12/10/09 at 4:58 PM.

United States Online
Reply With Quote
Old 12/10/09, 10:51 AM   #273
Ranghar
Von Kaiser
 
Ranghar's Avatar
 
Night Elf Druid
 
Shadowsong (EU)
Is it possible to switch order of bars in S&A? In some old version (1.1 I think) I used to have MF bar above IS bar. Not it is the opposite. I would like to customize it, making it more in line with order of my keybindings.

Poland Offline
Reply With Quote
Old 12/10/09, 11:24 AM   #274
Erdluf
Great Tiger
 
Night Elf Druid
 
Echo Isles
I used the one from post 272. It works, but then I got

Date: 2009-12-10 10:20:54
ID: 3
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 1059:
attempt to perform arithmetic on field 'cd' (a nil value)
Debug:
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:1059: ProcBars()
SquawkAndAwe\SquawkAndAwe.lua:391: ?()
...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[13]"]:4:
[string "safecall Dispatcher[13]"]:4
[C]: ?
[string "safecall Dispatcher[13]"]:13: ?()
...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119

United States Offline
Reply With Quote
Old 12/10/09, 11:40 AM   #275
MÃ nze
Von Kaiser
 
Tauren Druid
 
Blackhand (EU)
used version from post 272
got following error:
Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1376: attempt to index field 'text' (a nil value)
Time: 12/10/09 17:34:17
Count: 3
Stack: [C]: ?
Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1376: in function `OnUpdate'
Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:893: in function <Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:892>

Germany Offline
Reply With Quote
Old 12/10/09, 11:51 AM   #276
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by Erdluf View Post
I used the one from post 272.
Originally Posted by M� nze View Post
used version from post 272
This should fix both of those.

Last edited by Adoriele : 12/10/09 at 4:58 PM.

United States Online
Reply With Quote
Old 12/10/09, 11:57 AM   #277
Khornate
Glass Joe
 
Tauren Druid
 
Shadowmoon
Im no pro with addon coding or anything but i feel like something is wrong when SAA use this much memory

Click here

Offline
Reply With Quote
Old 12/10/09, 12:15 PM   #278
ninor
Piston Honda
 
ninor's Avatar
 
Tauren Druid
 
<nam>
Stormscale (EU)
Got the following error:

[2009/12/10 18:08:56-2315-x2]: SquawkAndAwe-SquawkAndAwe v1.4.1 (r1)\SquawkAndAwe.lua:1376: attempt to index field 'text' (a nil value)
SquawkAndAwe-SquawkAndAwe v1.4.1 (r1)\SquawkAndAwe.lua:893: in function <Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:892>

---
[EDIT]: I can't see whats wrong anyway.

Last edited by ninor : 12/10/09 at 2:24 PM.


Offline
Reply With Quote
Old 12/10/09, 12:30 PM   #279
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by Khornate View Post
Im no pro with addon coding or anything but i feel like something is wrong when SAA use this much memory

Click here
I really have no idea what's causing that. Are you using 1.4.0 and, if so, could you tell me if it's eating up that much memory in 1.3.3? The UNIT_AURA change isn't storing any new information.

Originally Posted by Ranghar View Post
Is it possible to switch order of bars in S&A? In some old version (1.1 I think) I used to have MF bar above IS bar. Not it is the opposite. I would like to customize it, making it more in line with order of my keybindings.
The short answer is no. The long answer is that yes, it's possible to control the bar order in SAA, but it requires an even uglier hack to accomplish quickly.

The really long answer is that the bars in SAA are generated by iterating through an array for each type of bar, ex. SAA.combat.procs (which makes it really easy to add more bars to a category in the future). Unfortunately, the iteration process is, while deterministic, also uncontrollable - the data comes out of the array in the order in which it was stored internally, and using string keys means that I have no control over that internal order. This is a limitation of Lua itself, and switching the order in which the data is added to the array may not change the order that the bars are added to the screen.

When creating bars, there is a variable - barcount, in CreateBarFrames() - which controls bar order (well, really it controls how far down from the top of the SAA frame a bar is placed, but it amounts to the same thing). If you were to hack SAA to rearrange the bars, this is the variable you would want to play with. Unfortunately, this is a personal preference thing, so it's not something I'll add to the official version of the mod, but you'd want to do something like

-- Creates bar frames by iterating through categories and setting up each,
-- either merged or not
function SquawkAndAwe:CreateBarFrames()

<snip>
	-- Debuff bars
	layer = 1
	add = 0
	if self.db.char.bars.mergedebuffs then
		
<snip merged debuff code>

---------OLD CODE----------------------
	else
		for k,v in pairs(self.db.char.bars.debuffs) do
			if v.show then
				SquawkAndAwe:SetBarFrame(k, barCount, SquawkAndAwe.combat.debuffs[k].id)
				SquawkAndAwe:AddStatusBar(self.frames[k], k, v.color, 1)
				if v.tick then
					SquawkAndAwe:AddStatusBar(self.frames[k], k.."Tick", self.db.char.bars.tickcolor, 2, true, SquawkAndAwe.combat.debuffs[k].tick)
				end
				barCount = barCount + 1
			end
		end
	end

----------NEW CODE-----------------
	else
		local tempBarCount = 0
		local position = 0
		for k,v in pairs(self.db.char.bars.debuffs) do
			if v.show then
				if k == "Moonfire" then position = 0
				elseif k == "Insect" then position = 1
				elseif k == "Faerie" then postition = 2 end
				SquawkAndAwe:SetBarFrame(k, barCount + position, SquawkAndAwe.combat.debuffs[k].id)
				SquawkAndAwe:AddStatusBar(self.frames[k], k, v.color, 1)
				if v.tick then
					SquawkAndAwe:AddStatusBar(self.frames[k], k.."Tick", self.db.char.bars.tickcolor, 2, true, SquawkAndAwe.combat.debuffs[k].tick)
				end
				tempBarCount = tempBarCount + 1
			end
		end
		barCount = barCount + tempBarCount
	end
I was intending to add an order field to the options for each bar (only within each category, so your debuffs would always be together, etc) which could control this, but that's a bunch of backend work.

United States Online
Reply With Quote
Old 12/10/09, 1:58 PM   #280
lissanna
Von Kaiser
 
Night Elf Druid
 
Elune
Doc's Version from post 256 isn't having that bug. Maybe we should be using that one, instead? His version has been working great for me. I raided with it last night and it was working great.

Offline
Reply With Quote
Old 12/10/09, 2:09 PM   #281
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by lissanna View Post
Doc's Version from post 256 isn't having that bug. Maybe we should be using that one, instead? His version has been working great for me. I raided with it last night and it was working great.
Well, I'd rather just fix issues if I can. Speaking of, with a little help from a guildy testing:

Last edited by Adoriele : 12/10/09 at 4:58 PM.

United States Online
Reply With Quote
Old 12/10/09, 2:16 PM   #282
ninor
Piston Honda
 
ninor's Avatar
 
Tauren Druid
 
<nam>
Stormscale (EU)
It's kind of confusing that all versions are called 1.4.1


Offline
Reply With Quote
Old 12/10/09, 2:21 PM   #283
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by ninor View Post
It's kind of confusing that all versions are called 1.4.1
Yeah, I'll see if I can rename the attachments to include a build number. Just don't want to have WoWI/Curse jump from 1.4.0 to 1.4.7 or something. That said, the post 281's version was working for my guildy so I imagine it will be the 1.4.1 release.

[edit] As for the memory issue, it's looking to me like it's a library conflict, based off of what my guildy's saying. He's going to run it during the raid tonight to make sure it's not exploding for him, though.

(for those unaware, if an addon is using a bunch of memory, and doing so by calling a library function, that memory will be attributed to the first addon loaded that uses that library, instead of the addon that's actually sinking the memory. Same for CPU use)

Last edited by Adoriele : 12/10/09 at 2:29 PM.

United States Online
Reply With Quote
Old 12/10/09, 2:27 PM   #284
ninor
Piston Honda
 
ninor's Avatar
 
Tauren Druid
 
<nam>
Stormscale (EU)
I have the same issue still.

After the proc part of the eclipse bar is done, the ICD bar just dissappears. Doesn't matter if I have other debuff bars running. Nothing is merged. Showing Eclipse, IS, MF and FF.

This version does not give out any error msg though.


Offline
Reply With Quote
Old 12/10/09, 2:34 PM   #285
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by ninor View Post
I have the same issue still.

After the proc part of the eclipse bar is done, the ICD bar just dissappears. Doesn't matter if I have other debuff bars running. Nothing is merged. Showing Eclipse, IS, MF and FF.

This version does not give out any error msg though.
Is the ICD bar showing when Eclipse is up? If not, you probably have Eclipse Cooldown turned off.

The additions in 1.4.1 are as follows, assume you procced Solar Eclipse and then you clicked it off/it got purged after 8s, and that you have Spell Names, Durations, Eclipse Cooldown, and Eclipse Type turned on:
From 0-8s, there should be a green bar in front of a light grey bar, and the text should read "Eclipse (Wrath): 15-7s".
From 8-15s, there should be a dark grey bar in front of a light grey bar, and the text should read "Eclipse (Starfire) Cooldown: 7-0s".
From 15-30s, there should only be a light grey bar, and the text should read "Eclipse (Wrath) Cooldown: 15-0s".

United States Online
Reply With Quote
Reply

Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Thread Tools