SquawkAndAwe - Page 20

• Adoriele · 04/03/10, 8:12 PM

Originally Posted by gannonjf

Is there a way of adding a check box to indicate number of trinkets so that the issue with that space is never a problem? Kind of thinking something along the lines of click this box if you have 1 trinket you would like tracked or click here if you have 2? I could go thru and add all the trinkets that aren't currently supported, that's not a big deal. But with this all being said I'm not aware of the problem people were having with the trinket bars previously so I could be asking for something you aren't interested in or could cause piles of unforeseen problems but it's worth a shot.

Honestly, I'm not even sure if I'm going to maintain tracking trinkets or not. At this point I'm going to play with it for a few days and see how it feels and what I decide to do with that. Will all the other "proc" items we have now I'm not even sure if it will be worth it so I guess at this point I'm just kind of experimenting to see how it all feels.

That's kinda my issue as well. It's borked, and generally doesn't add much. So I tend to leave it alone instead of removing it, because people might still be using it, but I try not to add any features, and if it breaks for good after an update I don't mind.

mLs · 04/04/10, 3:58 PM

Confirming that 1.5.1.329 solves the problem with debuff collission and no errors when mixing and trixing in the options menu so thumbs up for release to various addon sites.

aldones · 04/04/10, 5:52 PM

Originally Posted by Adoriele

That's kinda my issue as well. It's borked, and generally doesn't add much. So I tend to leave it alone instead of removing it, because people might still be using it, but I try not to add any features, and if it breaks for good after an update I don't mind.

One simpler and easier solution (since it adds similar code) is to add an extra checkbox called "save space for second trinket", that interacts with that +1/+2 code posted before. Since I'm way too lazy, that is the way I would probably do it.

• Adoriele · 04/05/10, 2:10 PM

Originally Posted by aldones

One simpler and easier solution (since it adds similar code) is to add an extra checkbox called "save space for second trinket", that interacts with that +1/+2 code posted before. Since I'm way too lazy, that is the way I would probably do it.

I'll probably do this, mixed with switching the bar positions so that the empty space is gone even if you reserve a slot for both.

As for long trinket names, I'm going to insert truncation code on namestring. Should be safe enough, as that's never used for anything but display.

• Adoriele · 04/05/10, 2:36 PM

Code attached. There's a new checkbox under trinkets to only allocate space for one trinket. If this is checked, and SAA detects two trinket buffs at the same time, the second buff will collide with the first proc. I really didn't want to try and figure out what I'd need to remove to kill the second bar completely. If unchecked, the trinket bar positions are swapped (and it still allocates space for both) so that the normal case of one trinket buff up doesn't have empty space.

For long trinket names, SAA now supports a shortname field in trinket data declarations. For instance, with Phylactery:

SquawkAndAwe.combat.trinkets.Phylactery = {id = 71605, itemid = 50360, name = GetSpellInfo(71605), itemname = GetItemInfo(50360), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 100, shortname = "Phylactery"}

If the field doesn't exist, SAA will use itemname.

gannonjf · 04/05/10, 3:02 PM

Thank you sir!

• Adoriele · 04/05/10, 3:08 PM

Originally Posted by gannonjf

Thank you sir!

Working correctly? It's a fairly simple hack, but I just want to make sure before I upload.

gannonjf · 04/05/10, 3:39 PM

I hadn't checked yet, trying to get some coffee in me before I start breaking things and not remembering what I did. I fail at documentation typically...Give me a few and I will get it installed and checked for ya.

gannonjf · 04/05/10, 4:24 PM

Renaming the Phaly works perfectly, thank you for that. It doesn't appear that the 2nd trinket bar is working though. I tried with a Paly and Eye of the Broodmother and there is nothing being drawn for the 2nd bar nor is there an empty space there as I kind of expected with the box unchecked. It's also not throwing any LUA errors either so....

• Adoriele · 04/05/10, 4:49 PM

Originally Posted by gannonjf

Renaming the Phaly works perfectly, thank you for that. It doesn't appear that the 2nd trinket bar is working though. I tried with a Paly and Eye of the Broodmother and there is nothing being drawn for the 2nd bar nor is there an empty space there as I kind of expected with the box unchecked. It's also not throwing any LUA errors either so....

That's a bug with trinkets with no cooldown, and one that's going to take a bit to fix. Probably best to try with a different trinket if possible.

(technically, the bar will briefly exist, but since it has no cooldown and cooldown bars are drawn first, it hides the bar thinking it's done with it)

[edit] I lied, try this. Should handle 0-cooldown trinkets, hopefully.

gannonjf · 04/05/10, 5:01 PM

Hrmm. I took a Sundial out on loan from the kind vendor in Dalaran and can confirm that proc trinkets are displaying as intended with the box checked. Also confirmed that with the box unchecked trinkets mash into eclipse as expected so... working as intended and fix is good. =)

Let me check that new version real quick...

gannonjf · 04/05/10, 5:28 PM

The new tracking works fine on trinkets with 0 cooldown as well. I added support for the normal/heroic versions of the spyglass and Phaly. Not really sure how to approach DFO with it's stacking effect.

I don't see how/where to attach a file so you can have a version with trinkets added, if you point me in the right direction I'll stick it up here so we can both be working with the same versions.. =)

• Hamlet · 04/05/10, 5:30 PM

I think only Benefactors can attach files.

gannonjf · 04/05/10, 5:37 PM

Ah, that makes sense. Here are the lines then for ya.

SquawkAndAwe.combat.trinkets.Phylactery = {id = 71605, itemid = 50360, name = GetSpellInfo(71605), itemname = GetItemInfo(50360), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 100, shortname = "Phylactery"}
SquawkAndAwe.combat.trinkets.HeroicPhylactery = {id = 71636, itemid = 50365, name = GetSpellInfo(71636), itemname = GetItemInfo(50365), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 100, shortname = "Phylactery"}
SquawkAndAwe.combat.trinkets.Spyglass = {id = 71570, itemid = 50340, name = GetSpellInfo(71570), itemname = GetItemInfo(50340), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 0}
SquawkAndAwe.combat.trinkets.HeroicSpyglass = {id = 71572, itemid = 50345, name = GetSpellInfo(71572), itemname = GetItemInfo(50345), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 0}

• Adoriele · 04/05/10, 5:37 PM

Originally Posted by Arawethion

I think only Benefactors can attach files.

This is the case. If you want, just pop up the arrays for the trinkets you've added, I'll add them into the official version and upload. For DFO, it's probably okay as a normal trinket with a CD field. SAA doesn't track stacks on IDS/Broodmother either, though it's a little different of a situation.

[edit] Too slow!

gannonjf · 04/05/10, 6:00 PM

SquawkAndAwe.combat.trinkets.DFO = {id = 71601, itemid = 50353, name = GetSpellInfo(71601), itemname = GetItemInfo(50353), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}
SquawkAndAwe.combat.trinkets.HeroicDFO = {id = 71644, itemid = 50348, name = GetSpellInfo(71644), itemname = GetItemInfo(50348), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}

I THINK these are correct for the DFO's. I can't say for sure as I don't have one myself and the proc effect actually activates two different spells from what I can see. The proc itself works just as it's written. You get two buffs, one with a 20 seconds duration and one with no duration. The one with no duration starts at 1 stack and stacks up to 10 stacks, giving 105 SP per stack and fading when the other buff expires.

• Adoriele · 04/05/10, 6:12 PM

Originally Posted by gannonjf

SquawkAndAwe.combat.trinkets.DFO = {id = 71601, itemid = 50353, name = GetSpellInfo(71601), itemname = GetItemInfo(50353), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}
SquawkAndAwe.combat.trinkets.HeroicDFO = {id = 71644, itemid = 50348, name = GetSpellInfo(71644), itemname = GetItemInfo(50348), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}

I THINK these are correct for the DFO's. I can't say for sure as I don't have one myself and the proc effect actually activates two different spells from what I can see. The proc itself works just as it's written. You get two buffs, one with a 20 seconds duration and one with no duration. The one with no duration starts at 1 stack and stacks up to 10 stacks, giving 105 SP per stack and fading when the other buff expires.

If the spellID listed is for the 20s duration buff, that should work fine.

gannonjf · 04/05/10, 6:15 PM

Yup, just double checked and they both look correct. I can't say for a fact that the CD is correct but I'm fairly certain it is.

• Adoriele · 04/05/10, 6:24 PM

Originally Posted by gannonjf

Yup, just double checked and they both look correct. I can't say for a fact that the CD is correct but I'm fairly certain it is.

Attached. I'll upload this when I get home if no one has any errors with it.

gannonjf · 04/05/10, 7:07 PM

I'm sure there are some trinkets missing, if anyone sees something missing and would like it added you can post here and it can get added.

• Adoriele · 04/05/10, 7:13 PM

Originally Posted by gannonjf

I'm sure there are some trinkets missing, if anyone seems something missing and would like it added you can post here and it can get added.

This is a good idea. I'll make a post on the upload sites as well to see if anyone wants other idols or balance-specific items added for tracking.

Krom[Fenris] · 04/10/10, 1:10 PM

I have Innervate unchecked so it doesn't show, but I'm noticing that whenever the GCD is triggered the Innervate bar is still popping up. It looks like it's the dummy version of the bar when you make the bars usable, as it's only half filled, and showing the icon.

Ruin · 04/15/10, 1:04 AM

I've been playing around with the sound options, I really like them, but i was wondering if it wouldn't be to hard to add a option for a sound when starfall & treants come off cooldown.

• Adoriele · 04/15/10, 11:03 AM

Originally Posted by Krom[Fenris]

I have Innervate unchecked so it doesn't show, but I'm noticing that whenever the GCD is triggered the Innervate bar is still popping up. It looks like it's the dummy version of the bar when you make the bars usable, as it's only half filled, and showing the icon.

I'll look into this.

Originally Posted by Ruin

I've been playing around with the sound options, I really like them, but i was wondering if it wouldn't be to hard to add a option for a sound when starfall & treants come off cooldown.

This should be doable.

gannonjf · 04/27/10, 7:03 PM

So it's been a few weeks and I actually find tracking my Phaly useful, just FYI.