SquawkAndAwe - Page 22

nzoq · 03/23/10, 10:22 PM

It seems to detect Solar eclipse just fine for me. It just doesn't show up with a green bar -- it's only showing a grey cooldown bar labeled "Eclipse (Lunar) (Starfire) Cooldown: 15.0s" that ticks down at half speed. When the timer reaches 0 the bar is still half full, and the text changes to say "Eclipse (Lunar) (Wrath) Cooldown: 15.0s"

I'm on 1.4.1 (r1).

Lamente · 03/24/10, 12:05 AM

Originally Posted by nzoq

It seems to detect Solar eclipse just fine for me. It just doesn't show up with a green bar -- it's only showing a grey cooldown bar labeled "Eclipse (Lunar) (Starfire) Cooldown: 15.0s" that ticks down at half speed. When the timer reaches 0 the bar is still half full, and the text changes to say "Eclipse (Lunar) (Wrath) Cooldown: 15.0s"

I'm on 1.4.1 (r1).

Confirmed. I think the eclipses are now properly labeled in the combat log, where previously both lunar and solar eclipse were just named "eclipse". That's probably messing up the addon.

edit: just double-checked: my combat log now displays:
X gains X's Eclipse (Solar).

gannonjf · 03/24/10, 12:25 AM

So who is the LUA guru that is going to fix this for us? It's still mostly functional but definitely annoying.

aldones · 03/24/10, 12:40 AM

Also, you might want to put the 2xT10 bonus there as a proc. I did some hacking here and have it running on mine. Pretty easy. To make things easier:

SquawkAndAwe.combat.procs.T102P = {id = 70721, name = GetSpellInfo(70721)}

helliax · 03/24/10, 2:29 AM

At least until someone fixes it, I just replaced the UNIT_AURA function with the one posted by cop at SquawkAndAwe. That added the coloring back, though the label will still say "Eclipse (Lunar)" during solar eclipses. Since I don't use the text labels and the icon shows up fine with or without the change, it's not a big deal for me.

I wasn't able to test this in a raid, so I don't know how noticeable the performance hit is.

btn · 03/24/10, 5:59 AM

I hacked together a temporary fix which isn't very pretty, but seems to fix the problem and not break anything else. You can grab my version of the updated "SquawkAndAwe.lua" at http://pastie.org/884388.txt, just make sure you save the file as "SquawkAndAwe.lua" in your Interface/AddOns/SquawkAndAwe folder (overwrite the old one).

If you've customized your own SAA, and you know how to read a patch (pretty simple, just delete the "-" lines and add the "+" lines corresponding to them), the following lets you know what I did to resolve the problem:

@@ -361,2 +361 @@
-		local _,_,_,_,_,_,_,_,_,_,spellID = UnitBuff("player",SquawkAndAwe.combat.procs.Eclipse.name);
-		if spellID == SquawkAndAwe.combat.procs.Eclipse.id then
+		if UnitBuff("player",SquawkAndAwe.combat.procs.Eclipse.name) then
@@ -365 +364 @@
-		elseif spellID == SquawkAndAwe.combat.procs.Eclipsew.id then
+		elseif UnitBuff("player",SquawkAndAwe.combat.procs.Eclipsew.name) then
@@ -486 +485 @@
-			if name == spellName then
+			if name == spellName or (spellName == "Eclipse (Lunar)" and EclipseType == "Wrath" and name == "Eclipse (Solar)") then
@@ -1330 +1329 @@
-					    namestring = SquawkAndAwe.combat.procs[k].name..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "").." "..L["Cooldown"]..(SquawkAndAwe.db.char.durations and ": " or "")
+					    namestring = ((k=="Eclipse" and "Eclipse") or SquawkAndAwe.combat.procs[k].name)..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "").." "..L["Cooldown"]..(SquawkAndAwe.db.char.durations and ": " or "")
@@ -1344 +1343 @@
-					    namestring = SquawkAndAwe.combat.procs[k].name..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "")..(SquawkAndAwe.db.char.durations and ": " or "")
+					    namestring = ((k=="Eclipse" and "Eclipse") or SquawkAndAwe.combat.procs[k].name)..((SquawkAndAwe.db.char.eclipsetype and k == "Eclipse") and " ("..EclipseType..")" or "")..(SquawkAndAwe.db.char.durations and ": " or "")
@@ -1368,2 +1367 @@
-								local typestring = SquawkAndAwe.db.char.eclipsetype and " ("..(EclipseType == SquawkAndAwe.combat.Wrath.name and SquawkAndAwe.combat.Starfire.name or SquawkAndAwe.combat.Wrath.name)..")"
-								namestring = SquawkAndAwe.combat.procs.Eclipse.name..(SquawkAndAwe.db.char.eclipsetype and typestring or "").." "..L["Cooldown"]..(SquawkAndAwe.db.char.durations and ": " or "")
+								namestring = "Eclipse ("..EclipseType..")"..(SquawkAndAwe.db.char.durations and ": " or "")

aldones · 03/24/10, 1:12 PM

For those interested, I merged the above fixed with my 2xT10 changes, and posted them on pastbin:

Lua | --[[ Version 1.4.1.1 Aut - SAA with T10 support and dirty 3.3.3 fix - daas3viG - Pastebin.com

It calls for a small addition on the locale, also posted:

Lua | local L = LibStub("AceLocale - SAA Locale with T10 support and dirty 3.3.3 fix - Pe5aebmT - Pastebin.com

• Adoriele · 03/24/10, 1:31 PM

Aldones, thanks for the id on T10-2P. I've got the bar added into the working copy for the next version, complete with the options settings. Should work out of the box assuming I didn't fudge a comma somewhere. Also, adding it in made me notice an error with the PVP set proc bar (the option to turn it on or off was incorrectly tied to the T8-4P bar, go fig), which has also been fixed.

I'm in the process of adding UI support for sounds as well. I mentioned it on the comments at the Curse download site, but SAA has access to any sounds in SharedMedia (I think). I have no idea how sounds get added to SharedMedia, as I've never done it myself, but you could conceivably add your own custom sounds if you wish. Probably will end up adding options for sounds on all of the procs, individually selectable.

Still working on the official 3.3 fix, I think I have a handle on what's going on. Should be able to remove the UNIT_AURA() event handler that fixed the 3.3.0 issue, and update things to use the new separated buff names. Kinda cool that Blizzard made the Lunar/Solar names official.

gannonjf · 03/24/10, 2:08 PM

Originally Posted by Adoriele

Aldones, thanks for the id on T10-2P. I've got the bar added into the working copy for the next version, complete with the options settings. Should work out of the box assuming I didn't fudge a comma somewhere. Also, adding it in made me notice an error with the PVP set proc bar (the option to turn it on or off was incorrectly tied to the T8-4P bar, go fig), which has also been fixed.

I'm in the process of adding UI support for sounds as well. I mentioned it on the comments at the Curse download site, but SAA has access to any sounds in SharedMedia (I think). I have no idea how sounds get added to SharedMedia, as I've never done it myself, but you could conceivably add your own custom sounds if you wish. Probably will end up adding options for sounds on all of the procs, individually selectable.

Still working on the official 3.3 fix, I think I have a handle on what's going on. Should be able to remove the UNIT_AURA() event handler that fixed the 3.3.0 issue, and update things to use the new separated buff names. Kinda cool that Blizzard made the Lunar/Solar names official.

I'm pretty stoked that you still support this Adoriele as it is by far my favorite and most functional mod, thanks in advance for fixing the latest round of Blizzard breaking it on all of us!

Paso · 03/24/10, 2:50 PM

Originally Posted by gannonjf

I'm pretty stoked that you still support this Adoriele as it is by far my favorite and most functional mod, thanks in advance for fixing the latest round of Blizzard breaking it on all of us!

yup, thanks for you support. Even if you dont play your moonkin or the game anymore! Don´t know what to do without SAA!

aldones · 03/24/10, 4:00 PM

I have my 2xT10 version of SAA, with btn's fix, working like a charm here. At least on the heroics I've ran. Anyone who needs an emergency fix can either work his version directly, or mine (posted above). And yes, mine have the menu option to add the 2xT10 bar and everything working.

• Adoriele · 03/24/10, 4:05 PM

Alright, first crack at the 3.3.3 fix is attached. Included are:

EclipseType option no longer makes sense, since the official buff names have been changed to include type. The option has been removed.
Functionality of the Eclipse bars should be identical to 1.4.1.287. Eclipse bar should list type, count down from 15. Cooldown bar will list type (though you won't see the text if Eclipse is up), count down from 30. If your Eclipse buff is purged, etc. the bar should turn gray and show the cooldown of the opposite Eclipse.
Sounds added. Single option under Procs turns them all on or off, new option under each proc bar allows you to select which sound comes with which proc. As mentioned, adding sounds to SharedMedia will give SAA access to them.
Omen of Doom bar added. I have no idea where this one will end up in the list of procs, gogo Lua limitations.

I haven't added bar order selection yet, though the Omen of Doom proc makes a serious case for it. If you load this and have errors, post them here (only the first couple lines are necessary, I really don't need a list of all the addons you have loaded, thank you Svartalf). If you're comfortable fixing the errors yourself, go ahead and do so (but please still post them so I can fix them as well) so we can get past the semantic errors more quickly. TOC hasn't been updated, nor have any of the references to version number, etc. in the code.

gannonjf · 03/24/10, 4:32 PM

Hrm. I just tried your latest version Adoriele and it doesn't appear to be loading correctly. I see it within Addon Control Panel but not under interface options. Also I now have 0 bars for any sort of tracking. Any ideas?

• Adoriele · 03/24/10, 4:35 PM

Originally Posted by gannonjf

Hrm. I just tried your latest version Adoriele and it doesn't appear to be loading correctly. I see it within Addon Control Panel but not under interface options. Also I now have 0 bars for any sort of tracking. Any ideas?

This means the addon isn't loading properly, which could have a large number of causes (usually semantic, like a missing bracket somewhere), I did a fair amount of mucking about. I'll need an error message.

xaktsaroth · 03/24/10, 4:36 PM

Thanks so much Adoriele for this a really big /hug I know nothing,nada,zero about these kind of stuff or I would gladly picked it up and made a fan version. Anyone else up for the task ?

Date: 2010-03-24 21:34:57
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 193:
unexpected symbol near ','
Debug:
(tail call): ?
[C]: ?

That error I get tough from youre version