SquawkAndAwe - Page 26

xaktsaroth · 03/25/10, 4:54 PM

T102P:
SquawkAndAwe: 6
SquawkAndAwe: Bar Frames created
SquawkAndAwe: 6
SquawkAndAwe: Bar Frames created
SquawkAndAwe: 6
SquawkAndAwe: Bar Frames created

With a :

Date: 2010-03-25 21:44:35
ID: 1
Error occured in: Global
Count: 24
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 1067:
attempt to index field '?' (a nil value)
Debug:
(tail call): ?
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:1067: ProcBars()
SquawkAndAwe\SquawkAndAwe.lua:404: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[13]"]:4:
[string "safecall Dispatcher[13]"]:4
[C]: ?
[string "safecall Dispatcher[13]"]:13: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
Ace3\AceEvent-3.0\AceEvent-3.0.lua:120:
Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

helliax · 03/25/10, 5:03 PM

Originally Posted by Adoriele

...
barname is nil - unlikely, since there are tests on it prior to the error, and it would require k to be nil as well.
barname is an invalid value ("Eclipsew" would be invalid) - also unlikely, as the previous tests would stop the code from reaching 1079.
color is invalid - possible, this might require deleting the saved variables file to determine. Still unlikely, though
frames[barname][barname] doesn't exist - this is the most likely I can think of.
...

In case this helps, barname always showed up as "Eclipse" in 306 when an Eclipse of either type procced.

• Adoriele · 03/25/10, 5:04 PM

Originally Posted by xaktsaroth

T102P:
SquawkAndAwe: 6
SquawkAndAwe: Bar Frames created
SquawkAndAwe: 6
SquawkAndAwe: Bar Frames created
SquawkAndAwe: 6
SquawkAndAwe: Bar Frames created

I assume that first line means it's printing when Omen procs, but still errors (and shows no Omen of Doom bar). And the listing is exactly what I expected, it's not creating any proc bars. For curiosity, which bars do you have turned on, including debuffs, etc.

[edit]

Originally Posted by helliax

In case this helps, barname always showed up as "Eclipse" in 306 when an Eclipse of either type procced.

Thank you, that's good to know as well, and is intended - SAA needs to check Eclipse storage for toggle options, but Eclipsew storage for color and sound (for Solar, every other proc uses the same storage for both); barname lets it do that.

MrLulz · 03/25/10, 5:10 PM

I get the same Bar Frames Created, but I've got 5 instead of 6. Using Eclipse, MF, IS, FF, Starfall/FoN and 2T10 if that helps at all. As stated above, it always says "Eclipse" and yes, the T102P pops up whenever Omen of Doom procs but no bar appears.

This is the error that throws with the eclipse proc:
Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1067: attempt to index field '?' (a nil value)
(think it was shown above already)

Edit: The same error throws on Omen of Doom.

xaktsaroth · 03/25/10, 5:11 PM

The bars I have active is Omen of Doom,Eclipse,starfire,wrath eclipse and the cc bars. And yes none of them are showing up but on youre debugg mode version at least the Iff,Is and Mf timers works they did not before

btn · 03/25/10, 5:14 PM

Since I didn't get around to actually getting it totally working, I will go ahead and give you the few problems I did identify, though there are a few others for sure.

First, the most obvious one is that line 1395 is still using "k" to get at bars rather than "barname", I believe this should change.

@@ -1395 +1395 @@
-							SquawkAndAwe.frames.Eclipse.Eclipse.spark:SetPoint("CENTER", SquawkAndAwe.frames[k][k.."CD"], "LEFT", timeLeft * sparkscale, 0)
+							SquawkAndAwe.frames.Eclipse.Eclipse.spark:SetPoint("CENTER", SquawkAndAwe.frames[barname][barname.."CD"], "LEFT", timeLeft * sparkscale, 0)

Second is with how bars are being hidden. I was running into an issue where I would proc one Eclipse, then say 20 seconds later I proc the next, the bar for the second eclipse would be hidden after 10 seconds. This was a result of the way you were hiding bars relative to the SquawkAndAwe.times[k.."CD"], because when one Eclipse would end it's 30 second CD it would hide the Eclipse bar regardless of if the other Eclipse was in effect. This fix needs to occur at line 1344, per the following patch.

@@ -1344,3 +1344,6 @@
-				    SquawkAndAwe.actives.procs[k] = false
-				    SquawkAndAwe.frames[barname]:Hide()
-				    SquawkAndAwe.frames[barname].text:SetText("")
+					SquawkAndAwe.actives.procs[k] = false
+					-- don't turn off eclipse bar if the other Eclipse is active
+					if (k == "Eclipse" and not SquawkAndAwe.actives.procs.Eclipsew) or (k == "Eclipsew" and not SquawkAndAwe.actives.procs.Eclipse) or (k ~= "Eclipse" and k ~= "Eclipsew") then
+						SquawkAndAwe.frames[barname]:Hide()
+						SquawkAndAwe.frames[barname].text:SetText("")
+					end

This seems to work, though there is probably a better way to go about it, I am still familiarizing myself with SAA.

Anyhow, that's all I've got for now. I will be away from my computer for a few days, so hope you can get everything resolved. If not, I am more than willing to keep working on this when I get back.

EDIT: Oh huh, looks like you've been working on something with bars, maybe you've already fixed these issues in another way.

• Adoriele · 03/25/10, 5:17 PM

Originally Posted by xaktsaroth

The bars I have active is Omen of Doom,Eclipse,starfire,wrath eclipse and the cc bars. And yes none of them are showing up but on youre debugg mode version at least the Iff,Is and Mf timers works they did not before

Yeah, 305 was erroring before any bars could be created. 307/8 is allowing all non-proc bars to be created (as far as I can tell), but erroring when any proc bar gets accessed (because it doesn't exist).

Correct me if I'm wrong, but this means you have:
Eclipse
Omen of Doom
Roots
Hibernate
Cyclone
IS
MF
FF

active, debuff and cc bars unmerged, no abilities active (if you have other proc bars active, that's fine and expected). This matches what I was looking for. As does your report, MrLulz. So it's the patch from 305-307 that's causing issues, but I have no idea why it's killing every proc bar, instead of just Eclipsew. I'll keep thinking on it, no updates this time.

xaktsaroth · 03/25/10, 5:24 PM

That is correct Adoriele. This lua occurs when OoC proccs

Date: 2010-03-25 22:23:56
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 1067:
attempt to index field '?' (a nil value)
Debug:
(tail call): ?
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:1067: ProcBars()
SquawkAndAwe\SquawkAndAwe.lua:404: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[13]"]:4:
[string "safecall Dispatcher[13]"]:4
[C]: ?
[string "safecall Dispatcher[13]"]:13: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
Ace3\AceEvent-3.0\AceEvent-3.0.lua:120:
Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

• Adoriele · 03/25/10, 5:31 PM

Originally Posted by btn

Anyhow, that's all I've got for now. I will be away from my computer for a few days, so hope you can get everything resolved. If not, I am more than willing to keep working on this when I get back.

First issue, good catch, though just using a static ".Eclipse.Eclipse" is fine since that's Eclipse-specific code anyway (and shouldn't be referencing the EclipseCD statusbar either, bad copypasta, even though it amounts to the same thing since they're left-aligned). Second issue, also good catch. I flipped the logic over for easier understanding, but it's the right implementation.

Any help is good help, since I'm not able to jump in and test on my own.

• Adoriele · 03/25/10, 5:42 PM

Originally Posted by xaktsaroth

That is correct Adoriele. This lua occurs when OoC proccs

Date: 2010-03-25 22:23:56
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 1067:
attempt to index field '?' (a nil value)
Debug:
(tail call): ?
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:1067: ProcBars()
SquawkAndAwe\SquawkAndAwe.lua:404: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[13]"]:4:
[string "safecall Dispatcher[13]"]:4
[C]: ?
[string "safecall Dispatcher[13]"]:13: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
Ace3\AceEvent-3.0\AceEvent-3.0.lua:120:
Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

Thanks, that still matches what I'm expecting.

I think I have the fix for the 1067 error, and if I do I'm going to kick either myself or the people who designed Lua's logical operators (probably both). Attached.

xaktsaroth · 03/25/10, 5:53 PM

Date: 2010-03-25 22:52:32
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 560:
attempt to index field '?' (a boolean value)
Debug:
(tail call): ?
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:560: FindNumBars()
SquawkAndAwe\SquawkAndAwe.lua:641: SetBaseFrame()
SquawkAndAwe\SquawkAndAwe.lua:540: RedrawFrames()
SquawkAndAwe\Options.lua:1180: SetBorderTexture()
SquawkAndAwe\SquawkAndAwe.lua:367: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[1]"]:4:
[string "safecall Dispatcher[1]"]:4
[C]: ?
[string "safecall Dispatcher[1]"]:13: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
Ace3\AceEvent-3.0\AceEvent-3.0.lua:120:
Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

• Adoriele · 03/25/10, 6:03 PM

Originally Posted by xaktsaroth

Premature, unfortunately. Now we're back to 305. Try this, it's a slightly different patch (again, uuuuugh), with a print of the value of k.

xaktsaroth · 03/25/10, 6:04 PM

nvm sec trying latest. Ok this pops when starting game.
Date: 2010-03-25 23:05:05
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 561:
attempt to index field '?' (a boolean value)
Debug:
(tail call): ?
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:561: FindNumBars()
SquawkAndAwe\SquawkAndAwe.lua:642: SetBaseFrame()
SquawkAndAwe\SquawkAndAwe.lua:540: RedrawFrames()
SquawkAndAwe\Options.lua:1180: SetBorderTexture()
SquawkAndAwe\SquawkAndAwe.lua:367: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[1]"]:4:
[string "safecall Dispatcher[1]"]:4
[C]: ?
[string "safecall Dispatcher[1]"]:13: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
Ace3\AceEvent-3.0\AceEvent-3.0.lua:120:
Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

• Adoriele · 03/25/10, 6:07 PM

Originally Posted by xaktsaroth

nvm sec trying latest. Ok this pops when starting game.
Date: 2010-03-25 23:05:05
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SquawkAndAwe\SquawkAndAwe.lua line 561:
attempt to index field '?' (a boolean value)
Debug:
(tail call): ?
(tail call): ?
SquawkAndAwe\SquawkAndAwe.lua:561: FindNumBars()
SquawkAndAwe\SquawkAndAwe.lua:642: SetBaseFrame()
SquawkAndAwe\SquawkAndAwe.lua:540: RedrawFrames()
SquawkAndAwe\Options.lua:1180: SetBorderTexture()
SquawkAndAwe\SquawkAndAwe.lua:367: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[1]"]:4:
[string "safecall Dispatcher[1]"]:4
[C]: ?
[string "safecall Dispatcher[1]"]:13: ?()
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
Ace3\AceEvent-3.0\AceEvent-3.0.lua:120:
Ace3\AceEvent-3.0\AceEvent-3.0.lua:119

Does it print anything before erroring?

xaktsaroth · 03/25/10, 6:13 PM

SquawkAndAwe: sounds. Turned sound on proccs off still got error.