Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Reply
 
LinkBack Thread Tools
Old 03/25/10, 6:17 PM   #391
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by xaktsaroth View Post
SquawkAndAwe: sounds. Turned sound on proccs off still got error.
... Oh son of a bitch I didn't even think about that. Fixed and attached.

Last edited by Adoriele : 04/02/10 at 4:41 PM.

United States Online
Reply With Quote
Old 03/25/10, 6:25 PM   #392
xaktsaroth
Von Kaiser
 
Night Elf Druid
 
Eonar (EU)
I think we are making progress !

SquawkAndAwe: T102P
SquawkAndAwe: T84P
SquawkAndAwe: Eclipse
SquawkAndAwe: PVP
SquawkAndAwe: Omen
SquawkAndAwe: 8
SquawkAndAwe: T102P
SquawkAndAwe: EclipseCD
SquawkAndAwe: Eclipse
SquawkAndAwe: Bar Frames created
SquawkAndAwe: T102P
SquawkAndAwe: T84P
SquawkAndAwe: Eclipse
SquawkAndAwe: PVP
SquawkAndAwe: Omen
SquawkAndAwe: 8
SquawkAndAwe: T102P
SquawkAndAwe: EclipseCD
SquawkAndAwe: Eclipse
SquawkAndAwe: Bar Frames created
SquawkAndAwe: T102P
SquawkAndAwe: T84P
SquawkAndAwe: Eclipse
SquawkAndAwe: PVP
SquawkAndAwe: Omen
SquawkAndAwe: 8
SquawkAndAwe: T102P
SquawkAndAwe: EclipseCD
SquawkAndAwe: Eclipse
SquawkAndAwe: Bar Frames created

Offline
Reply With Quote
Old 03/25/10, 6:31 PM   #393
xaktsaroth
Von Kaiser
 
Night Elf Druid
 
Eonar (EU)
Ok some testing done. everything except 1 thing works for me now. When going lunar-solar text,icons,colours everything is fine. But going from solar to lunar makes only icon and colour update not text. how ever the text is updated when its 3-4 secs left of lunar to saying "lunar eclipse"

Offline
Reply With Quote
Old 03/25/10, 6:35 PM   #394
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by xaktsaroth View Post
I think we are making progress !

SquawkAndAwe: T102P
SquawkAndAwe: T84P
SquawkAndAwe: Eclipse
SquawkAndAwe: PVP
SquawkAndAwe: Omen
SquawkAndAwe: 8
SquawkAndAwe: T102P
SquawkAndAwe: EclipseCD
SquawkAndAwe: Eclipse
SquawkAndAwe: Bar Frames created
SquawkAndAwe: T102P
SquawkAndAwe: T84P
SquawkAndAwe: Eclipse
SquawkAndAwe: PVP
SquawkAndAwe: Omen
SquawkAndAwe: 8
SquawkAndAwe: T102P
SquawkAndAwe: EclipseCD
SquawkAndAwe: Eclipse
SquawkAndAwe: Bar Frames created
SquawkAndAwe: T102P
SquawkAndAwe: T84P
SquawkAndAwe: Eclipse
SquawkAndAwe: PVP
SquawkAndAwe: Omen
SquawkAndAwe: 8
SquawkAndAwe: T102P
SquawkAndAwe: EclipseCD
SquawkAndAwe: Eclipse
SquawkAndAwe: Bar Frames created
Aha, perfect, I'll remove the prints. In a related question, does Omen of Doom have a cooldown? I assume not, since Omen of Clarity doesn't.

As for the lunar/solar text, looking into it.

[edit] Also, could you double-check that clicking off the Eclipse buff has the desired effect of switching the bar to a lighter gray and shows "Eclipse(opposite) Cooldown"?

United States Online
Reply With Quote
Old 03/25/10, 6:37 PM   #395
xaktsaroth
Von Kaiser
 
Night Elf Druid
 
Eonar (EU)
Nope Omen of Doom is lovely and nicely chain proccing for me at times.

Cancelling eclipse produce correct bars as well.

"Good new everyone the fluid is flowing again"

Last edited by xaktsaroth : 03/25/10 at 6:43 PM.

Offline
Reply With Quote
Old 03/25/10, 6:45 PM   #396
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Hmm. Let me get a sense of what's happening:

T0: Lunar Eclipse procs. Eclipse bar is white with a darkish gray bar behind it to represent Lunar eclipse cooldown. Text is "Eclipse (Lunar): xxxx"
T15: Lunar Eclipse fades. White bar is gone, gray bar remains. Text updates to "Eclipse (Lunar) Cooldown: xxxx"
T~18: Solar Eclipse procs. Eclipse bar updates to green with a darkish gray bar behind it to represent Solar eclipse cooldown. Text is "Eclipse (Solar): xxxx"
T~33: Solar Eclipse fades. Green bar is gone, gray bar remains. Text updates to "Eclipse (Solar) Cooldown: xxxx"
T~36: Lunar Eclipse procs. Eclipse bar updates to white with a darkish gray bar behind. Text is "Eclipse (Solar) Cooldown: xxxx" <------ This is the error
T~48: Text updates to show the correct value of "Eclipse (Lunar): xxxx"

Is that correct?

United States Online
Reply With Quote
Old 03/25/10, 6:57 PM   #397
xaktsaroth
Von Kaiser
 
Night Elf Druid
 
Eonar (EU)
Aha paid a bit more attention never really connected that grey area of the bar as the total Eclipse Cd bar before !
What happens is not exactly what you wrote I think if I understand you correctly let me use other words.

"T~36 Lunar eclipse procc. Solar cd bar still shown. When solar cd ends Lunar bar shows with the current time left.

Offline
Reply With Quote
Old 03/25/10, 7:01 PM   #398
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by xaktsaroth View Post
Aha paid a bit more attention never really connected that grey area of the bar as the total Eclipse Cd bar before !
What happens is not exactly what you wrote I think if I understand you correctly let me use other words.

"T~36 Lunar eclipse procc. Solar cd bar still shown. When solar cd ends Lunar bar shows with the current time left.
Good, this makes a lot more sense (and yeah, the longer gray bar is kinda a holdover from pre-3.2, but still useful since there are times you're not proccing solar right after lunar or vice versa). Is it always the Solar bar overriding (which I expect), or does bar which overrides depend on how you start your rotation? I.E. if you let both Eclipses cool down, then begin again with Solar instead of Lunar, does Lunar override Solar?

United States Online
Reply With Quote
Old 03/25/10, 7:04 PM   #399
xaktsaroth
Von Kaiser
 
Night Elf Druid
 
Eonar (EU)
Nope it is as you expected its only solar cd that overrides everything else. As a sidenote I ticked in and activated every kind of bar you can have (except for bonus proccs) they all seemed to work just wonderfull as well now. Starfall,trees,bark skin etc that is.

*edit*

Bed time for me now work in 5 hours but once again a really huge THANK YOU for the really kind work you done here. If you ever come to sweden I can give you a really big hug and a pay a beer for you, cant live without this addon

Offline
Reply With Quote
Old 03/25/10, 7:13 PM   #400
gannonjf
Piston Honda
 
Worgen Druid
 
Korgath
Originally Posted by Adoriele View Post
... Oh son of a bitch I didn't even think about that. Fixed and attached.

So this is a good working version now that we should be using, am I understanding all of that correctly? =)

Ninja edit, talking about post 391 attachment.

Offline
Reply With Quote
Old 03/25/10, 7:18 PM   #401
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by xaktsaroth View Post
Nope it is as you expected its only solar cd that overrides everything else. As a sidenote I ticked in and activated every kind of bar you can have (except for bonus proccs) they all seemed to work just wonderfull as well now. Starfall,trees,bark skin etc that is.

*edit*

Bed time for me now work in 5 hours but once again a really huge THANK YOU for the really kind work you done here. If you ever come to sweden I can give you a really big hug and a pay a beer for you, cant live without this addon
Okay, that's what I figured. This should fix the issue (hopefully without introducing any others) as it deactivates Solar when Lunar procs and vice versa.

[edit] Gannon, this version (1.5.0.312) should work, assuming nothing got mucked up with this change. At least it should load without errors

Last edited by Adoriele : 04/02/10 at 4:41 PM.

United States Online
Reply With Quote
Old 03/25/10, 7:30 PM   #402
gannonjf
Piston Honda
 
Worgen Druid
 
Korgath
Originally Posted by Adoriele View Post
At least it should load without errors


LOL. I'll check in a bit and post back I have to run some errands before wiping on Putricide 25man Heroic all night. =(

Offline
Reply With Quote
Old 03/25/10, 7:42 PM   #403
Tuffhead
Glass Joe
 
Tauren Druid
 
Blackhand
Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1351: unexpected symbol near ')'
Time: 03/25/10 19:44:36
Count: 1
Stack:
Locals:


if timeLeft < 0 or (timeleft < 15 and ())then

From line 1351, I assume there should be a function call there?

Offline
Reply With Quote
Old 03/25/10, 7:44 PM   #404
MrLulz
Glass Joe
 
Night Elf Druid
 
Aegwynn
Last release won't load. Throws the following error:

Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1351: unexpected symbol near ')'
Time: 03/25/10 17:38:38
Count: 1
Stack:
Locals:

Line 1351 is:
if timeLeft < 0 or (timeleft < 15 and ())then
Edit: Tuff posted a bit quicker than me. :P

Offline
Reply With Quote
Old 03/25/10, 7:49 PM   #405
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by MrLulz View Post
Last release won't load. Throws the following error:

Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1351: unexpected symbol near ')'
Time: 03/25/10 17:38:38
Count: 1
Stack:
Locals:

Line 1351 is:
if timeLeft < 0 or (timeleft < 15 and ())then
See, I KNEW I fucked something up. Change that to "if timeLeft < 0 then", that was the start of a second way of dealing with the override that I decided against, forgot to revert it.

Fixed and attached.

Last edited by Adoriele : 04/02/10 at 4:41 PM.

United States Online
Reply With Quote
Reply

Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Thread Tools