Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Reply
 
LinkBack Thread Tools
Old 03/27/10, 8:11 AM   #436
Tuffhead
Glass Joe
 
Tauren Druid
 
Blackhand
Originally Posted by Adoriele View Post
Oh. Is the repeating new as of 3.3.3 (well, 3.3, I suppose, since I also was out of game for that one)?
Thats exactly it. I was not sure the best way to describe it.

Offline
Reply With Quote
Old 03/27/10, 9:18 AM   #437
mLs
Banned
 
Tauren Druid
 
Argent Dawn (EU)
Originally Posted by Adoriele View Post
Could you go into more detail on this? The tick bar should be "on top" of the debuff bar and a third the height. Is that not the case?
No no it is working as you described :)


Offline
Reply With Quote
Old 03/29/10, 1:04 PM   #438
Hyperion
Glass Joe
 
Night Elf Druid
 
Thrall
I didn't see this posted yet but if you want to make the statusbar texture work correctly add the following.

statusbar:SetPoint("BOTTOMRIGHT", addToFrame, "BOTTOMRIGHT", -3, 3)
statusbar:SetStatusBarTexture(media:Fetch("statusbar", self.db.char.texture))
statusbar:GetStatusBarTexture():SetHorizTile(false)
Thanks for the fix. Unfortunately, I'm a bit of a noob when it comes to addons; could you tell me which file needs this added?

Offline
Reply With Quote
Old 03/29/10, 1:49 PM   #439
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by Hyperion View Post
Thanks for the fix. Unfortunately, I'm a bit of a noob when it comes to addons; could you tell me which file needs this added?
SquawkAndAwe.lua, in function AddStatusBar(), between lines 945/946. It'll be added to the official version in the next couple days, though, if it's not a huge deal for you.

Figured I might as well add in the order option as well, while I've still got SAA in my neural cache. I'll also add some procs and debuffs, so if you've got ideas of moonkin-specific things you want tracked, I'm open to suggestions. Good idea: Idol procs; Bad idea: Rejuvenation. Good idea: Languish (are the wrath and starfire languish debuffs separate?); Bad idea: Winter's Chill. They're easy, or should be, to add, so I can take suggestions up until just before the addon gets uploaded.

As for the order option, note that life gets a lot simpler if the bars are still grouped by category (abilities with abilities, procs with procs, etc.), so order will only apply within a category. I.E. you'll be able to put moonfire on top of IS, but you won't be able to put Starfall between them. For simplicity, order will be strictly priority based. You can have MF:3, IS:7, FF:1, and it will output FF-MF-IS with no gap in between. Setting two bars to the same priority will have the same effect as right now; SAA will pick one to be on top, and it should always be the same one.

[edit]
Order will also have a global enable, which will be enabled by default. If you don't want to muck with it, click off the checkbox to return SAA back to the way it used to be.

[edit2] You should also be able to rearrange categories, though that may take a little more work.

Last edited by Adoriele : 03/29/10 at 1:58 PM.

United States Offline
Reply With Quote
Old 03/29/10, 3:58 PM   #440
aldones
Von Kaiser
 
Troll Druid
 
Skullcrusher
Originally Posted by Adoriele View Post
Good idea: Languish (are the wrath and starfire languish debuffs separate?);
I really don't see the point of adding Languish, since tracking it won't help. I mean, not like we are going to switch targets when we crit, quite the opposite. Unless you want to track the damage it is ticking for.

Offline
Reply With Quote
Old 03/29/10, 3:59 PM   #441
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Tester version of 1.5.1 attached. Note that the order option has not been fully implemented. The options are in the config menu, but don't actually control anything yet. Need double-checking that the tier 9 and 10 idols and Languish are implemented correctly, and the the options menu doesn't throw any errors. I'll be working on the order implementation in the meantime.

[edit]
Originally Posted by aldones View Post
I really don't see the point of adding Languish, since tracking it won't help. I mean, not like we are going to switch targets when we crit, quite the opposite. Unless you want to track the damage it is ticking for.
Not really a point, I suppose, but it's there, and it's a debuff, so it's easy enough to add if people are interested in it. Tracking damage from it is definitely outside the scope of SAA.

Last edited by Adoriele : 04/02/10 at 4:41 PM.

United States Offline
Reply With Quote
Old 03/29/10, 7:02 PM   #442
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Aaand here's the first iteration with bar ordering working. It only applies to procs, I wanted to keep the impact small, but the same idea will be applied to all of the other bars as well once I can confirm that it's working.

Last edited by Adoriele : 04/02/10 at 4:41 PM.

United States Offline
Reply With Quote
Old 03/29/10, 8:08 PM   #443
mLs
Banned
 
Tauren Druid
 
Argent Dawn (EU)
Sounds great Adoriele, will test it out in a couple of hours when back from work!

Edit: This pops up when I logon:

Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:92: '}' expected near 'name'

Which is:

SquawkAndAwe.combat.procs.Idol9 = {id = 67360 name = GetSpellInfo(67360)}

By the look of it I guess there should be a comma after the ID numbers right?


Edit2: Lots of errors when loading after adding that comma:

Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:366: attempt to call method 'GetOptions' (a nil value)
Message: Interface\AddOns\SquawkAndAwe\Options.lua:103: unexpected symbol near '['
Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:412: attempt to call method 'SetBorderTexture' (a nil value)
Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:515: attempt to index field 'bars' (a nil value)

I also get a lot of these errors whenever targeting something:
Message: Interface\FrameXML\UIPanelTemplates.lua:365: attempt to perform arithmetic on field 'cursorOffset' (a nil value)

Btw do you need any more lines for the errors or is it enought with the first one? Kinda new to addon bug hunting and stuff so dunno how much info to post...

Last edited by mLs : 03/30/10 at 1:14 AM.

Offline
Reply With Quote
Old 03/31/10, 7:17 PM   #444
MrLulz
Glass Joe
 
Night Elf Druid
 
Aegwynn
I'll jump you ahead one more error since you can't get in to test things yourself:

Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:92: '}' expected near 'name'

Added a comma to make line 92:
SquawkAndAwe.combat.procs.Idol9 = {id = 67360, name = GetSpellInfo(67360)}

-------------------

Which brought us to the next set of errors listed in the above post. Using this error:
Message: Interface\AddOns\SquawkAndAwe\Options.lua:103: unexpected symbol near '['
I added the missing L to line 103 of the options page to make:

desc = L["help_autoorder"],

-------------------

This gets us some new errors, which I'll leave to you. :P


Upon loading the game:
Message: AceLocale-3.0: SquawkAndAwe: Missing entry for 'Tier 10 4-Piece bonus'




And then when targeting something we get all these, some multiple times:

Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:602: attempt to index local 'procs' (a nil value)

Message: Interface\FrameXML\UIPanelTemplates.lua:365: attempt to perform arithmetic on field 'cursorOffset' (a nil value)

Message: Interface\FrameXML\UIPanelTemplates.lua:365: attempt to perform arithmetic on field 'cursorOffset' (a nil value)

Message: Interface\FrameXML\UIPanelTemplates.lua:365: C stack overflow

Message: Interface\AddOns\SquawkAndAwe\SquawkAndAwe.lua:1178: attempt to index field '?' (a nil value)

Offline
Reply With Quote
Old 03/31/10, 7:27 PM   #445
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Yuck, I completely missed mLs' errors, I thought this thread was getting quiet. For future reference if it's been more than a half an hour or so, go ahead and double-post. No one's going to report you in this thread, and it'll help me make sure that I catch all the error reports.

In general, the Message line is going to be enough for me to figure out what's going on. If I need more, I'll ask (sometimes I need a stack trace to figure out what's calling the erroring function, but not often).

Lulz, your first error is a missing Locale entry, solved by adding
L["Tier 10 4-Piece bonus"]= true
somewhere in the locale file. That b in bonus should be capitalized, but it's not in the Options file either so don't worry about editing it. As for the others, I'll check up on them when I get home. Thanks for the feedback, guys.

United States Offline
Reply With Quote
Old 03/31/10, 9:12 PM   #446
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Fixed the two errors from mLs, and the Tier 10 bonus error (case mismatch, yuck). Also fixed the error on line 602, which was probably causing the other errors in that list. Attached.

Last edited by Adoriele : 04/02/10 at 4:41 PM.

United States Offline
Reply With Quote
Old 03/31/10, 9:55 PM   #447
mLs
Banned
 
Tauren Druid
 
Argent Dawn (EU)
Goodie goodie, will try out when back from night shift in about two and a half hour.

Offline
Reply With Quote
Old 04/01/10, 12:26 AM   #448
mLs
Banned
 
Tauren Druid
 
Argent Dawn (EU)
Getting the following errors when testing latest version:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:625: attempt to call method 'SortbyValue' (a nil value)
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:699: in function `SetBaseFrame'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:577: in function `RedrawFrames'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\Options.lua:1598: in function `SetBorderTexture'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:412: in function `?'

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:1178: attempt to index field '?' (a nil value)
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:1186: in function `TriggerDebuffs'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:522: in function `?'

I installed Buggrabber / BugSack which seems like a "better" way of getting info from the errors (dunno if it is).

Offline
Reply With Quote
Old 04/01/10, 12:40 AM   #449
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by mLs View Post
Getting the following errors when testing latest version:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:625: attempt to call method 'SortbyValue' (a nil value)
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:699: in function `SetBaseFrame'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:577: in function `RedrawFrames'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\Options.lua:1598: in function `SetBorderTexture'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:412: in function `?'

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:1178: attempt to index field '?' (a nil value)
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:1186: in function `TriggerDebuffs'
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:522: in function `?'

I installed Buggrabber / BugSack which seems like a "better" way of getting info from the errors (dunno if it is).
Very much so, I used it back when I was developing SAA to begin with.

First error is another case mismatch, it should be SortByValue, line 625. The other error stems from this one. Fixed and attached.

Last edited by Adoriele : 04/02/10 at 4:41 PM.

United States Offline
Reply With Quote
Old 04/01/10, 1:04 AM   #450
mLs
Banned
 
Tauren Druid
 
Argent Dawn (EU)
No errors! :)

Only thing now is that, and I know you only made bar orders for the procs, when Lunar / Solar is procing they are at the same place as IS is.



This is only when having the barorder checkbox unchecked, when checking it it displayes just as before.

Edit: When I uncheck the T10P4 debuff I get following error though:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\Options.lua:1007: attempt to index field 'Languish' (a nil value)

Last edited by mLs : 04/01/10 at 1:14 AM.

Offline
Reply With Quote
Reply

Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Thread Tools