SquawkAndAwe - Page 31

• Adoriele · 04/01/10, 1:10 AM

Originally Posted by mLs

No errors!

Only thing now is that, and I know you only made bar oders for the procs, when Lunar / Solar is procing they are at the same place as IS is:

Aha! Finished with semantic errors, then =) Looks like barCount isn't being updated correctly once the proc bars are generated, try this debug version. You should see three prints; number of procs, barcount before the procs are added, and barcount after. This sequence may repeat, I need the values listed.

mLs · 04/01/10, 1:19 AM

When moving the Eclipse proc from 1 > 2 it prints the following:

procs: 2
barcount pre-procs: 0
barcount post-procs: 2

When procing with it on 2 it still is on the same place as IS.

When checking bar order for SAA to do it auto the Eclipse bar jumps to the top as it should so that part seems to work okay.

Dunno if you saw my update on last post in page 18 but getting following error when unchecking T10P4:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\Options.lua:1007: attempt to index field 'Languish' (a nil value)

• Adoriele · 04/01/10, 1:28 AM

Originally Posted by mLs

When moving the Eclipse proc from 1 > 2 it prints the following:

procs: 2
barcount pre-procs: 0
barcount post-procs: 2

When procing with it on 2 it still is on the same place as IS.

When checking bar order for SAA to do it auto the Eclipse bar jumps to the top as it should so that part seems to work okay.

Dunno if you saw my update on last post in page 18 but getting following error when unchecking T10P4:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\Options.lua:1007: attempt to index field 'Languish' (a nil value)

The number used in the order field doesn't actually matter. It's a priority, higher numbers are lower (or should be, that's part of what we're testing) on the list, but having one bar at 5 and one bar at 3 doesn't mean there will be an empty space between them (though there will be a bar between them if there's a bar with order 4). That said, I think I know what's up. Try this one, the numbers should be the same as before.

mLs · 04/01/10, 1:34 AM

Yep the numbers are the same as before but now all the bars are at the right places!

OoD, Eclipse, IS, FF, MF just like when having SAA to auto order them.

• Adoriele · 04/01/10, 1:37 AM

Originally Posted by mLs

Yep the numbers are the same as before but now all the bars are at the right places!

OoD, Eclipse, IS, FF, MF just like when having SAA to auto order them.

Swap the order values for OoD and Eclipse. Do they swap places? What are the numbers you use?

mLs · 04/01/10, 1:39 AM

Yep they swap.

Before OoD 4 / Eclipse 1
After OoD 1 / Eclipse 4

Anyways, heading of to bed, already been 1½ hour since I came back from work and need to get up in like 4 hours ;P

• Adoriele · 04/01/10, 1:57 AM

Originally Posted by mLs

Yep they swap.

Before OoD 4 / Eclipse 1
After OoD 1 / Eclipse 4

Anyways, heading of to bed, already been 1½ hour since I came back from work and need to get up in like 4 hours ;P

Okay, working opposite from expected, but that's fixable. Attached, the order fields should apply to all categories (except Trinkets, if anyone still uses those bars), and lower numbers mean higher on the list as expected.

mLs · 04/01/10, 6:34 AM

I can order the Procs freely but the Debuffs does not seem to take it at all, it's always MF, FF, IS.

Also still when trying to uncheck T10P4 it generates error:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\Options.lua:1007: attempt to index field 'Languish' (a nil value)

Which is:

self.db.char.bars.debuffs.Languish.show = not self.db.char.bars.Languish.show

And from my guess there should be .debuffs. inbetween bars and Langusih?

Edit: Yep that was it, added the above and it removes the Languish bar and does not generate an error any more when unchecking T10P4!

• Adoriele · 04/01/10, 3:05 PM

Originally Posted by mLs

I can order the Procs freely but the Debuffs does not seem to take it at all, it's always MF, FF, IS.

Also still when trying to uncheck T10P4 it generates error:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\Options.lua:1007: attempt to index field 'Languish' (a nil value)

Which is:

self.db.char.bars.debuffs.Languish.show = not self.db.char.bars.Languish.show

And from my guess there should be .debuffs. inbetween bars and Langusih?

Edit: Yep that was it, added the above and it removes the Languish bar and does not generate an error any more when unchecking T10P4!

Fixed and attached, was using a proc number for generating the order of debuffs, which is bad, mmkay?

[edit] Oops, forgot to fix the edit to the Options file before I uploaded, so it'll still have that 1007 error. Reuploaded.

mLs · 04/01/10, 3:56 PM

And I think we have a release candidate! :)

Ordering of both Procs and Debuffs works and no errors when mixing around the options menu so far, so all thumbs up from my end Adoriele \o/

• Adoriele · 04/01/10, 4:01 PM

Originally Posted by mLs

And I think we have a release candidate!

Ordering of both Procs and Debuffs works and no errors when mixing around the options menu so far, so all thumbs up from my end Adoriele \o/

If you could double-check for me that it doesn't mess with merged bars (it shouldn't) and that abilities and cc work as well, I'll upload to the usual sites.

mLs · 04/01/10, 4:31 PM

Bah knew I should check everything before posting -_-

Got a bit of errors here. When enabeling all the Abilities without mergeing them only Typhoon works where Starfall, Innervate, Trees and Barksin produce error:

SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:1780: attempt to index field '?' (a nil value)
SquawkAndAwe-SquawkAndAwe v1.5.0 (r1)\SquawkAndAwe.lua:1011: in function <SquawkAndAwe\SquawkAndAwe.lua:1010>

When having all Abilities merged every spell is shown correctly without any errors but then the placement is way up high, like he wanna show all the abilities bars but only one merged one is visiable.

All the CC seems to work both merged and not though.

• Adoriele · 04/01/10, 4:52 PM

Originally Posted by mLs

When having all Abilities merged every spell is shown correctly without any errors but then the placement is way up high, like he wanna show all the abilities bars but only one merged one is visiable.

Having trouble understanding this one. Is there empty space between bars that shouldn't be there?

Error fixed and attached, surprised there wasn't an error on line 915 to go with it.

mLs · 04/02/10, 3:05 AM

Sorry for not making my self clear, will show you with picture (should have done that right away).

Enabling all Abilities without mergeing them looks right when choosing to move the bars:

When then turning on merge that bar jumps all the way up to under the MF bar where they should instead anchor at the bottom:

Edit: Just realised that in image #1 & #2 the top Ability (both merged and not) is on the same bar as the bottom Debuff, the MF bar, so yeah, there is something with the bottom Debuff bar that makes other bars collide with it.
(in other words #1 = MF and starfall is on same bar / #2 = barkskin and MF is on same bar)

The errors gotten from previously version on the ablities are gone and when not mergeing all have a duration now:

But when using all abilities the Starfall bar will be on the same place as the MF bar:

So in short; when mergeing abilities it won't anchor at the bottom but way up high (like all the other abilities bars are invisible but still there) and the bottom Debuff will always collide with the top Ability.

Also when enabling all the CC (and all abilities) there is no collision between the top Ability (starfall) and the bottom CC (hibernate) but instead collision between the top CC (roots) and the bottom Debuff (mf) so I guess there is definitely something up with the bottom Debuff bar that is making it collide. This also apply to when mergeing the CC, all CC ends up on the MF bar.

Atleast no errors this time around and I hope you can understand me better now :3

• Adoriele · 04/02/10, 12:08 PM

Originally Posted by mLs

Sorry for not making my self clear, will show you with picture (should have done that right away).

Enabling all Abilities without mergeing them looks right when choosing to move the bars:

When then turning on merge that bar jumps all the way up to under the MF bar where they should instead anchor at the bottom:

This is intended behavior. There should never be empty space between bars, and the entire addon is anchored at the top, so merging multiple bars of a category will push all the bars into the first slot after the previous category. If the SAA Base frame were visible (which it may be, if you turn on borders, I honestly can't remember since it's been to long since I used them), you'd see that the frame shrinks to encapsulate only the visible bars.

Edit: Just realised that in image #1 & #2 the top Ability (both merged and not) is on the same bar as the bottom Debuff, the MF bar, so yeah, there is something with the bottom Debuff bar that makes other bars collide with it.
(in other words #1 = MF and starfall is on same bar / #2 = barkskin and MF is on same bar)

The errors gotten from previously version on the ablities are gone and when not mergeing all have a duration now:
<snip image>

But when using all abilities the Starfall bar will be on the same place as the MF bar:

<snip image>

So in short; when mergeing abilities it won't anchor at the bottom but way up high (like all the other abilities bars are invisible but still there) and the bottom Debuff will always collide with the top Ability.

Also when enabling all the CC (and all abilities) there is no collision between the top Ability (starfall) and the bottom CC (hibernate) but instead collision between the top CC (roots) and the bottom Debuff (mf) so I guess there is definitely something up with the bottom Debuff bar that is making it collide. This also apply to when mergeing the CC, all CC ends up on the MF bar.

<snip image>

Atleast no errors this time around and I hope you can understand me better now :3

Once again a bad copy pasta job, it was incrementing barCount by the number of procs instead of debuffs after the debuff bars were created. Fixed and attached, this should be a release candidate as I can't think of any other issues if the merged bars and ability durations are working correctly.