 |
04/05/10, 2:02 PM
|
#481
|
|
Piston Honda
|
Thank you sir!
|
|
|
|
|
04/05/10, 2:08 PM
|
#482
|
|
Happy October 19th!
Night Elf Druid
Dragonblight
|
Originally Posted by gannonjf
Thank you sir!
|
Working correctly? It's a fairly simple hack, but I just want to make sure before I upload.
|
|
|
|
|
04/05/10, 2:39 PM
|
#483
|
|
Piston Honda
|
I hadn't checked yet, trying to get some coffee in me before I start breaking things and not remembering what I did. I fail at documentation typically...Give me a few and I will get it installed and checked for ya.
|
|
|
|
|
04/05/10, 3:24 PM
|
#484
|
|
Piston Honda
|
Renaming the Phaly works perfectly, thank you for that. It doesn't appear that the 2nd trinket bar is working though. I tried with a Paly and Eye of the Broodmother and there is nothing being drawn for the 2nd bar nor is there an empty space there as I kind of expected with the box unchecked. It's also not throwing any LUA errors either so....
|
|
|
|
|
04/05/10, 3:49 PM
|
#485
|
|
Happy October 19th!
Night Elf Druid
Dragonblight
|
Originally Posted by gannonjf
Renaming the Phaly works perfectly, thank you for that. It doesn't appear that the 2nd trinket bar is working though. I tried with a Paly and Eye of the Broodmother and there is nothing being drawn for the 2nd bar nor is there an empty space there as I kind of expected with the box unchecked. It's also not throwing any LUA errors either so....
|
That's a bug with trinkets with no cooldown, and one that's going to take a bit to fix. Probably best to try with a different trinket if possible.
(technically, the bar will briefly exist, but since it has no cooldown and cooldown bars are drawn first, it hides the bar thinking it's done with it)
[edit] I lied, try this. Should handle 0-cooldown trinkets, hopefully.
Last edited by Adoriele : 04/05/10 at 3:56 PM.
|
|
|
|
|
04/05/10, 4:01 PM
|
#486
|
|
Piston Honda
|
Hrmm. I took a Sundial out on loan from the kind vendor in Dalaran and can confirm that proc trinkets are displaying as intended with the box checked. Also confirmed that with the box unchecked trinkets mash into eclipse as expected so... working as intended and fix is good. =)
Let me check that new version real quick...
|
|
|
|
|
04/05/10, 4:28 PM
|
#487
|
|
Piston Honda
|
The new tracking works fine on trinkets with 0 cooldown as well. I added support for the normal/heroic versions of the spyglass and Phaly. Not really sure how to approach DFO with it's stacking effect.
I don't see how/where to attach a file so you can have a version with trinkets added, if you point me in the right direction I'll stick it up here so we can both be working with the same versions.. =)
|
|
|
|
|
04/05/10, 4:30 PM
|
#488
|
|
<Druid Trainer>
|
I think only Benefactors can attach files.
|
|
|
|
04/05/10, 4:37 PM
|
#489
|
|
Piston Honda
|
Ah, that makes sense. Here are the lines then for ya.
SquawkAndAwe.combat.trinkets.Phylactery = {id = 71605, itemid = 50360, name = GetSpellInfo(71605), itemname = GetItemInfo(50360), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 100, shortname = "Phylactery"}
SquawkAndAwe.combat.trinkets.HeroicPhylactery = {id = 71636, itemid = 50365, name = GetSpellInfo(71636), itemname = GetItemInfo(50365), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 100, shortname = "Phylactery"}
SquawkAndAwe.combat.trinkets.Spyglass = {id = 71570, itemid = 50340, name = GetSpellInfo(71570), itemname = GetItemInfo(50340), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 0}
SquawkAndAwe.combat.trinkets.HeroicSpyglass = {id = 71572, itemid = 50345, name = GetSpellInfo(71572), itemname = GetItemInfo(50345), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 0}
|
|
|
|
|
04/05/10, 4:37 PM
|
#490
|
|
Happy October 19th!
Night Elf Druid
Dragonblight
|
Originally Posted by Arawethion
I think only Benefactors can attach files.
|
This is the case. If you want, just pop up the arrays for the trinkets you've added, I'll add them into the official version and upload. For DFO, it's probably okay as a normal trinket with a CD field. SAA doesn't track stacks on IDS/Broodmother either, though it's a little different of a situation.
[edit] Too slow!
|
|
|
|
|
04/05/10, 5:00 PM
|
#491
|
|
Piston Honda
|
SquawkAndAwe.combat.trinkets.DFO = {id = 71601, itemid = 50353, name = GetSpellInfo(71601), itemname = GetItemInfo(50353), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}
SquawkAndAwe.combat.trinkets.HeroicDFO = {id = 71644, itemid = 50348, name = GetSpellInfo(71644), itemname = GetItemInfo(50348), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}
I THINK these are correct for the DFO's. I can't say for sure as I don't have one myself and the proc effect actually activates two different spells from what I can see. The proc itself works just as it's written. You get two buffs, one with a 20 seconds duration and one with no duration. The one with no duration starts at 1 stack and stacks up to 10 stacks, giving 105 SP per stack and fading when the other buff expires.
|
|
|
|
|
04/05/10, 5:12 PM
|
#492
|
|
Happy October 19th!
Night Elf Druid
Dragonblight
|
Originally Posted by gannonjf
SquawkAndAwe.combat.trinkets.DFO = {id = 71601, itemid = 50353, name = GetSpellInfo(71601), itemname = GetItemInfo(50353), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}
SquawkAndAwe.combat.trinkets.HeroicDFO = {id = 71644, itemid = 50348, name = GetSpellInfo(71644), itemname = GetItemInfo(50348), color = {r=0, g=0.37, b=0.12, a=0.9}, cd = 45, shortname = "DFO"}
I THINK these are correct for the DFO's. I can't say for sure as I don't have one myself and the proc effect actually activates two different spells from what I can see. The proc itself works just as it's written. You get two buffs, one with a 20 seconds duration and one with no duration. The one with no duration starts at 1 stack and stacks up to 10 stacks, giving 105 SP per stack and fading when the other buff expires.
|
If the spellID listed is for the 20s duration buff, that should work fine.
|
|
|
|
|
04/05/10, 5:15 PM
|
#493
|
|
Piston Honda
|
Yup, just double checked and they both look correct. I can't say for a fact that the CD is correct but I'm fairly certain it is.
|
|
|
|
|
04/05/10, 5:24 PM
|
#494
|
|
Happy October 19th!
Night Elf Druid
Dragonblight
|
Originally Posted by gannonjf
Yup, just double checked and they both look correct. I can't say for a fact that the CD is correct but I'm fairly certain it is.
|
Attached. I'll upload this when I get home if no one has any errors with it.
|
|
|
|
|
04/05/10, 6:07 PM
|
#495
|
|
Piston Honda
|
I'm sure there are some trinkets missing, if anyone sees something missing and would like it added you can post here and it can get added.
Last edited by gannonjf : 04/05/10 at 6:16 PM.
|
|
|
|
|
|