"PLEASE DELETE YOUR SAVEDVARIABLES FILE BEFORE LOADING THIS UPDATE."

Where excactly do I find this file?

Quick question...Will deleting this file fuck up my other addons? For example the placement of my action bars and unit frames? (which are all addons and placed in different places than the usual default UI )

Ah, sorry, I guess I wasn't specific enough. There should be a file named for each addon. You only need to delete the one for SAA, and it won't affect any other addons.

ok thanks by the way, hows the addon fixing working? i havnt found any problems yet but i also havnt done much on my boomkin today either

Hahahahahahahahahah. This is wonderful, and hilarious, and ironic, and took me far too long, and should have been completely obvious. Remove your entries for Starsurge from CustomBars.lua, as it's been included in the base file. There's also a spelling error, which is attached.

Working on Eclipse now.

[edit] In case people were wondering, here's what was going on:
All "Abilities" except Starsurge throw a SPELL_CAST_SUCCESS event when cast (probably because they're all instant. Rebirth might be fun to add in since it's not). This is the best event to hook into for them because it happens on every cast, and only happens once per cast - SPELL_DAMAGE would be thrown multiple times for, say, Typhoon. SPELL_MISS might as well.

Since Starsurge doesn't throw a SPELL_CAST_SUCCESS, I had no choice but to tie it to DAMAGE and MISS. Since other spells throw these events multiple times per cast, I had to add a field to the Starsurge definition table to denote that it was a single-target spell. Only single-target spells would check for DAMAGE or MISS. Unfortunately, while the field was added in the definition in SAA.lua, it was being overwritten by the old definition in CB.lua.

So why was it triggering after Shooting Stars? Because it became instant, and therefore started throwing a SPELL_CAST_SUCCESS event like every other "ability" (it no longer throws SPELL_CAST_START, so it has to throw SUCCESS instead). Since SPELL_CAST_SUCCESS is only ever thrown once, I don't care if the spell is single-target, so it was allowed to spawn the bar.

SquawkAndAwe: Starsurge Triggered

I was thinking about that Starsurge I noticed in the cb.lua file when I was removing owlking and trinket bars but thought you had some purpose for having them there instead of in main file. Yet again assumptions been proven to be bad to make

Everything seems to work now.

I know your working on things at the moment but is there any chance u can add a section to remove bars for owlkin and icc rep ring in the next update please? or can someone tell me how to remove them manually?

Also im still not getting the cooldown bar for starsurge 100% of the time (not sure if u fixed it just letting u know) i have deleted the varibles etc

thanks

This is correct. In fact, unless you've added your own bars using CustomBars.lua, it's probably best to just delete it. I should never have let it get in to an uploaded build (i.e. it should have stayed as a .txt instead so that it wouldn't kill other peoples' versions, and be a general pain in my ass), luckily it should only affect people who downloaded it from this thread, not the general public, as long as I don't use the file myself again.

its definitely worth putting a bar in for the sliding scale with your bars as a default bar. With so many using spartanui out there in the raiding packs - based of cuse.com raiding packs it really needs it for clarity of where you're up to.

I've tested it for last few days on LK and seeing no warnings for starsurge or shooting stars appearing at all

Hello and thanks for a Must-Have AddOn.

I have installed your latest version and I have a question/request. Considering that Fairie Fire is now stack-able, I was wonder if there was an option I was missing in the Config to display this, or is this a feature you might still be working on?

Regardless, thanks for your work on one of my favoritest adds.

Adoriele

Thanks so much for all the hard work you've put into the project so far. Believe me its greatly appreciated. If it has to go on the back burner whilst dealing with the monstrosity of a patch Blizzard has dumped us with then so be it.