Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Reply
 
LinkBack Thread Tools
Old 10/15/10, 5:46 PM   #616
killerpavlov
Glass Joe
 
Tauren Druid
 
Blackrock
?

"PLEASE DELETE YOUR SAVEDVARIABLES FILE BEFORE LOADING THIS UPDATE."

Where excactly do I find this file?

Offline
Reply With Quote
Old 10/15/10, 5:56 PM   #617
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by killerpavlov View Post
"PLEASE DELETE YOUR SAVEDVARIABLES FILE BEFORE LOADING THIS UPDATE."

Where excactly do I find this file?
It should be in WorldOfWarcraft/WTF/Server/AccountName/CharacterName/SavedVariables.

United States Offline
Reply With Quote
Old 10/16/10, 12:05 AM   #618
killerpavlov
Glass Joe
 
Tauren Druid
 
Blackrock
Originally Posted by Adoriele View Post
It should be in WorldOfWarcraft/WTF/Server/AccountName/CharacterName/SavedVariables.
Quick question...Will deleting this file fuck up my other addons? For example the placement of my action bars and unit frames? (which are all addons and placed in different places than the usual default UI )

Offline
Reply With Quote
Old 10/16/10, 12:48 AM   #619
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by killerpavlov View Post
Quick question...Will deleting this file fuck up my other addons? For example the placement of my action bars and unit frames? (which are all addons and placed in different places than the usual default UI )
Ah, sorry, I guess I wasn't specific enough. There should be a file named for each addon. You only need to delete the one for SAA, and it won't affect any other addons.

United States Offline
Reply With Quote
Old 10/16/10, 1:54 AM   #620
killerpavlov
Glass Joe
 
Tauren Druid
 
Blackrock
ok thanks by the way, hows the addon fixing working? i havnt found any problems yet but i also havnt done much on my boomkin today either

Offline
Reply With Quote
Old 10/16/10, 4:52 AM   #621
Lotusenta
Glass Joe
 
Lotusenta's Avatar
 
Draenei Shaman
 
Auchindoun
Originally Posted by Adoriele View Post
Okay, just to double-check, it's printing "SquawkAndAwe: Starsurge Triggered" to chat when you press Surge after a Stars proc? If so, then yeah it's a borked internal combat log, which is really odd since it shows up on the exported one. And yeah, probably not intentional. I can work around it either way, and probably fairly easily.
Yeah, that's what I meant. It does do the chat message for it. And only if it's done after a Shooting Stars.

I do hope there is a way to fix it. I like the cooldown bars, rather than trying to look at my number bar to see whether or not I can use it without Shooting Stars.

Offline
Reply With Quote
Old 10/16/10, 6:21 PM   #622
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Hahahahahahahahahah. This is wonderful, and hilarious, and ironic, and took me far too long, and should have been completely obvious. Remove your entries for Starsurge from CustomBars.lua, as it's been included in the base file. There's also a spelling error, which is attached.

Working on Eclipse now.

[edit] In case people were wondering, here's what was going on:
All "Abilities" except Starsurge throw a SPELL_CAST_SUCCESS event when cast (probably because they're all instant. Rebirth might be fun to add in since it's not). This is the best event to hook into for them because it happens on every cast, and only happens once per cast - SPELL_DAMAGE would be thrown multiple times for, say, Typhoon. SPELL_MISS might as well.

Since Starsurge doesn't throw a SPELL_CAST_SUCCESS, I had no choice but to tie it to DAMAGE and MISS. Since other spells throw these events multiple times per cast, I had to add a field to the Starsurge definition table to denote that it was a single-target spell. Only single-target spells would check for DAMAGE or MISS. Unfortunately, while the field was added in the definition in SAA.lua, it was being overwritten by the old definition in CB.lua.

So why was it triggering after Shooting Stars? Because it became instant, and therefore started throwing a SPELL_CAST_SUCCESS event like every other "ability" (it no longer throws SPELL_CAST_START, so it has to throw SUCCESS instead). Since SPELL_CAST_SUCCESS is only ever thrown once, I don't care if the spell is single-target, so it was allowed to spawn the bar.
Attached Files
File Type: zip SquawkAndAwev1.6.1.364.zip (130.8 KB, 2164 views)

Last edited by Adoriele : 10/16/10 at 7:07 PM.

United States Offline
Reply With Quote
Old 10/17/10, 4:52 AM   #623
xaktsaroth
Von Kaiser
 
Night Elf Druid
 
Eonar (EU)
SquawkAndAwe: Starsurge Triggered

I was thinking about that Starsurge I noticed in the cb.lua file when I was removing owlking and trinket bars but thought you had some purpose for having them there instead of in main file. Yet again assumptions been proven to be bad to make

Everything seems to work now.

Offline
Reply With Quote
Old 10/18/10, 7:56 AM   #624
benscott
Glass Joe
 
Night Elf Druid
 
Darkspear (EU)
I know your working on things at the moment but is there any chance u can add a section to remove bars for owlkin and icc rep ring in the next update please? or can someone tell me how to remove them manually?

Also im still not getting the cooldown bar for starsurge 100% of the time (not sure if u fixed it just letting u know) i have deleted the varibles etc

thanks

Offline
Reply With Quote
Old 10/18/10, 10:59 AM   #625
xaktsaroth
Von Kaiser
 
Night Elf Druid
 
Eonar (EU)
Originally Posted by benscott View Post
I know your working on things at the moment but is there any chance u can add a section to remove bars for owlkin and icc rep ring in the next update please? or can someone tell me how to remove them manually?

Also im still not getting the cooldown bar for starsurge 100% of the time (not sure if u fixed it just letting u know) i have deleted the varibles etc

thanks
Open up the folder with SAA in there you will have a file named custombars.lua. Scroll down to the bottom and remove the sections containing text about the bars you want to remove. Reading through that document is handy if you want to add your own bars as well.

Offline
Reply With Quote
Old 10/18/10, 12:52 PM   #626
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by xaktsaroth View Post
Open up the folder with SAA in there you will have a file named custombars.lua. Scroll down to the bottom and remove the sections containing text about the bars you want to remove. Reading through that document is handy if you want to add your own bars as well.
This is correct. In fact, unless you've added your own bars using CustomBars.lua, it's probably best to just delete it. I should never have let it get in to an uploaded build (i.e. it should have stayed as a .txt instead so that it wouldn't kill other peoples' versions, and be a general pain in my ass), luckily it should only affect people who downloaded it from this thread, not the general public, as long as I don't use the file myself again.

United States Offline
Reply With Quote
Old 10/19/10, 5:30 PM   #627
JSRGibbs
Glass Joe
 
Night Elf Druid
 
Azuremyst (EU)
eclipse /lunar bar

its definitely worth putting a bar in for the sliding scale with your bars as a default bar. With so many using spartanui out there in the raiding packs - based of cuse.com raiding packs it really needs it for clarity of where you're up to.

I've tested it for last few days on LK and seeing no warnings for starsurge or shooting stars appearing at all

Offline
Reply With Quote
Old 10/19/10, 7:02 PM   #628
Ivern
Glass Joe
 
Ivern's Avatar
 
Tauren Druid
 
Frostwolf
Hello and thanks for a Must-Have AddOn.

I have installed your latest version and I have a question/request. Considering that Fairie Fire is now stack-able, I was wonder if there was an option I was missing in the Config to display this, or is this a feature you might still be working on?

Regardless, thanks for your work on one of my favoritest adds.

Last edited by Ivern : 10/22/10 at 10:57 PM.

Offline
Reply With Quote
Old 10/19/10, 7:06 PM   #629
 Adoriele
Happy October 19th!
 
Adoriele's Avatar
 
Night Elf Druid
 
Dragonblight
Originally Posted by Ivern View Post
Hello and thanks for a Must-Have AddOn.

I have installed your latest version and I have a question/request.
Considering that Fairie Fire is now stack-able, I was wonder if there was an option I was missing in the Config to display this, or is this a feature you might still be working on?

Regardless, thanks for your work on one of my favoritest adds.


Ivern
Ah, thanks for reminding me about that. Probably won't happen until the massive overhaul, but yes I intend to support that. Lunar Shower will show stacks at that point as well.

Gibbs, I'm having a very hard time parsing what you're asking.

United States Offline
Reply With Quote
Old 10/19/10, 8:09 PM   #630
JSRGibbs
Glass Joe
 
Night Elf Druid
 
Azuremyst (EU)
Adoriele

Thanks so much for all the hard work you've put into the project so far. Believe me its greatly appreciated. If it has to go on the back burner whilst dealing with the monstrosity of a patch Blizzard has dumped us with then so be it.

Offline
Reply With Quote
Reply

Go Back   Elitist Jerks » Public Discussion » User Interface and AddOns

Thread Tools