Shadowed Unit Frames - Page 3

Duilliath · 05/21/09, 12:32 PM

I'm growing the party frames up. First party member at the bottom of screen, second above it, etc.

Cheers for the code, I'll pop it in now.

//edit: Hm. Reports an error @ line 7. I'll see if I can work it out myself.

//edit2: No such luck.

Additionally, is it possibly to *solely* get MT frames, without the rest of the Raid frames?
Furthermore, it seems as though Combat Text is handling crits awkwardly. The font is blowing up and becoming extremely pixelated, rather than just using a larger font size.

Shadowed · 05/21/09, 5:34 PM

Ah oops had a typo in it, that's what I get for typing it while running out the door use:

function(unit)
local name = UnitName(unit)
if( not name ) then
return ""
end

if( string.len(name) > 11 ) then
return string.sub(name, 0, 11) .. "."
end

return name
end

I'll look into the party frame and combat text issues in a bit, I'll see if MT stuff can be added easily but ultimately it's not a priority.

Duilliath · 05/21/09, 7:17 PM

Ah great, that does work, however, there's one minor snag.

The old DogTag3 line had one major advantage: it'd shorten something like Dark Elven Archer to D.E. Archer.
Which is far preferably when yer trying to find the Mage / Shaman / Priest mob in a pack of five, all dubbed Dark Elven Something-or-other.

If you want, I can edit in the link to the old DogTag3 post where it was posted first.

Shadowed · 05/21/09, 8:26 PM

I'm not particularly show how DogTags would easily do abbreviation, but it's fine. I'm not really interested in making the tagging system into a super complicated one, what you can accomplish easily through Lua without making a mini addon is all I want.

abyssichate · 05/22/09, 3:58 AM

I've been trying to reproduce my PitBull4 layout and I must say I am quite surprised at how customizable SUF already is. I was wondering how easy it'd be to implement:

- a color hostility based name tag;
- a long format [curhp] tag;
- making possible to set different sizes for each text;
- spell icon for the cast bar;
- color (even class-based) tags for health/power text.

Shadowed · 05/22/09, 6:12 AM

Originally Posted by abyssichate

I've been trying to reproduce my PitBull4 layout and I must say I am quite surprised at how customizable SUF already is. I was wondering how easy it'd be to implement:

- a color hostility based name tag;
- a long format [curhp] tag;
- making possible to set different size for each text;
- spell icon for the cast bar;
- color (even class-based) tags for health/power text.

Hostility coloring is something I plan on adding next push for names, can already get an absolute HP value using [absolutehp]. Don't plan on adding spell icon/different sizing right now, not sure what you mean by class coloring for health and power text, are you talking about coloring the text specifically by the players class?

Skiace · 05/22/09, 6:59 AM

*removed*

Great mod so far, feels like just what I need out of a UF and nothing I don't.

tanman108 · 05/22/09, 11:10 AM

Thank you very much for making this addon - it combines the best elements of other unit frames and leaves out the cumbersome pieces. I don't even want to think about the amount of time I spent customizing pitbull to look nearly as good as Shadowed Unit Frames' default configuration. The options are intuitive an easy to navigate.

Just want to give some feedback on stability - whenever I type /SUF afte first logging in, there's a delay of about 1-3 seconds before the options pop up. Once when I typed in /SUF my computer locked up - I'm not sure if it had to do with the addon or something else entirely. I have an iMac that's about 1 year old.

Thanks again and keep up the good work!

PS I suggested it to my whole guild

abyssichate · 05/22/09, 11:25 AM

Originally Posted by Shadowed

Hostility coloring is something I plan on adding next push for names, can already get an absolute HP value using [absolutehp]. Don't plan on adding spell icon/different sizing right now, not sure what you mean by class coloring for health and power text, are you talking about coloring the text specifically by the players class?

Yeah, I meant coloring the health text by class and the power text by power type, something like this:

In general I wouldn't mind color tags like those in DogTags3 such as [name:yellow] and so on. I am aware of the existence of [absolutehp] but I haven't found any way to show tonly he current absolute health rather than your health in the long_absolute_current_health/long_absolute_max_health format.
Now that it comes to mind, is there some way to fill bars by deficit?

Cabal · 05/22/09, 12:55 PM

Was it something I missed, or is there no health fading? I mean like Aguf has, when you get damage it erodes the chunk of health you just lost. Always liked that feature, apart from that I have to say SuF is awesome so far, so easy to configure and neat.

Shadowed · 05/22/09, 1:56 PM

There's no option for it, and unless it becomes a fairly popular option I won't likely add it as most people seem to find it annoying.

I know I said there would be more tags in this push, but I lied, have to work on some other projects so it'll actually be in the next push.

globus · 05/23/09, 7:01 AM

great work shadowed, I update to the last version and appreciate some new stuff you put into (like possibility to have right text or left text occupy 100% of space for example)
I notice that some tags wizard don't work anymore : colorname, abscurhp, absmaxhp and maybe others. for replacing colorname the combo <classcolor, name, close> do the trick.
One another annoying thing is that even if I put raid frames classed by group number, my own frame in the raid is always at the end of the list.
For now I'm using your raid frame instead of Pitbul3 and I have to say that I prefer your's.

Not sure if it exists or is it possible to implement but is there a mean to force the refresh of the addon without doing a /reloadUI ?

Shadowed · 05/23/09, 11:09 PM

Originally Posted by tanman108

Thank you very much for making this addon - it combines the best elements of other unit frames and leaves out the cumbersome pieces. I don't even want to think about the amount of time I spent customizing pitbull to look nearly as good as Shadowed Unit Frames' default configuration. The options are intuitive an easy to navigate.

Just want to give some feedback on stability - whenever I type /SUF afte first logging in, there's a delay of about 1-3 seconds before the options pop up. Once when I typed in /SUF my computer locked up - I'm not sure if it had to do with the addon or something else entirely. I have an iMac that's about 1 year old.

Thanks again and keep up the good work!

PS I suggested it to my whole guild

Does this happen with other mods with lots of configuration, or is it only happening with SUF? The configuration (code wise) is poorly done and I need to rewrite it but haven't had much motivation.

Originally Posted by abyssichate

Yeah, I meant coloring the health text by class and the power text by power type, something like this:

In general I wouldn't mind color tags like those in DogTags3 such as [name:yellow] and so on. I am aware of the existence of [absolutehp] but I haven't found any way to show tonly he current absolute health rather than your health in the long_absolute_current_health/long_absolute_max_health format.
Now that it comes to mind, is there some way to fill bars by deficit?

I can add a tag for coloring by power type as well, and [abscurhp]/[abscurpp] as well as [absmaxhp]/[absmaxpp] were added in the last push for getting specifics. Not really sure what you mean by fill the bars by deficit, are you talking about growing the bars from left -> right instead of right -> left, or a tag that shows how much health is missing?

Originally Posted by globus

great work shadowed, I update to the last version and appreciate some new stuff you put into (like possibility to have right text or left text occupy 100% of space for example)
I notice that some tags wizard don't work anymore : colorname, abscurhp, absmaxhp and maybe others. for replacing colorname the combo <classcolor, name, close> do the trick.
One another annoying thing is that even if I put raid frames classed by group number, my own frame in the raid is always at the end of the list.
For now I'm using your raid frame instead of Pitbul3 and I have to say that I prefer your's.

Not sure if it exists or is it possible to implement but is there a mean to force the refresh of the addon without doing a /reloadUI ?

[colorname] was purposely removed, you're supposed to use [classcolor][name][close] now, I didn't notice any issues with [absmaxhp] but [abscurhp] was broken which I fixed in this push. I'll add an option to change the sort method of grouping.

Why do you need to force a refresh? It automatically updates anything that was changed in the configuration, and what isn't changed is a bug that I'll fix if I know of it.

If you were having issues with frames moving around after reload, grab the version I just pushed, it fixes the bug.

globus · 05/24/09, 6:35 AM

Originally Posted by Shadowed

[colorname] was purposely removed, you're supposed to use [classcolor][name][close] now, I didn't notice any issues with [absmaxhp] but [abscurhp] was broken which I fixed in this push. I'll add an option to change the sort method of grouping.

Why do you need to force a refresh? It automatically updates anything that was changed in the configuration, and what isn't changed is a bug that I'll fix if I know of it.

If you were having issues with frames moving around after reload, grab the version I just pushed, it fixes the bug.

I just need a refresh in case of a bug (typically when playing with tags or raid frame order or rarely strange behaviour when entering raids), not a very needed functionality, I can live with /reloadUI.

for the version of the 23 may :

my toon raid frame is ever at the end of the raid frames in group order and the toggle between class order/group order doesn't seem to work, after selecting class order I can't go back to group order (but if I understand well you work on it)
in case of a raid with <=5 people I have both raid frames and party frames displayed, maybe my configuration is faulty (by default I would prefer party frames instead of raid frames for raid <6 people)
I enable rune bar on a DK reroll and when reconnecting a priest The rune bar remains but in the configuration panel I can't access the rune bar, I have to revert to my dk to suppress the bar. (all my toons shared the same profile for now)
for raid frame displaying : when ordered by group I would like to see groups better, maybe with having a greater offset between frames every 5 frames or a 50% opacity rectangle behind every group of 5 frames
small thing : I have raid frames anchored to the left of the screen and I have to choose columns growth : left to have a correct display (ie to have columns growth from left to right) I would have think I have to choose columns growth : right to have this effect.

Shadowed · 05/24/09, 7:07 AM

I do not plan on adding any sort of indicator as to which group is which by offsets or special frames around them, the frames are ultimately meant to be very basic. I'll see about the growth issue. If you're in a raid, you'll get raid frames, don't plan on having it hide raid frames in raids of less than 5 people.

Rune/totem bars showing up in the incorrect class is fixed next push.

abyssichate · 05/24/09, 10:40 AM

Originally Posted by Shadowed

I can add a tag for coloring by power type as well, and [abscurhp]/[abscurpp] as well as [absmaxhp]/[absmaxpp] were added in the last push for getting specifics. Not really sure what you mean by fill the bars by deficit, are you talking about growing the bars from left -> right instead of right -> left, or a tag that shows how much health is missing?

I meant getting an "empty" bar when the - for example - health is at 100% and a "filled" one when your hit points drop to zero.

Shadowed · 05/24/09, 1:36 PM

Not planning on adding any sort of special health bar filling.

gcbirzan · 05/28/09, 12:01 AM

Latest version (20090526), right clicking on a frame and selecting Set Focus results in a "ShadowedUF has been blocked by Blizzard for being naughty" popup. Setting the focus with a keybind works fine.

Shadowed · 05/28/09, 1:42 AM

Originally Posted by gcbirzan

Latest version (20090526), right clicking on a frame and selecting Set Focus results in a "ShadowedUF has been blocked by Blizzard for being naughty" popup. Setting the focus with a keybind works fine.

This is Blizzards fault I can't fix it, any addon that uses the right click menus will have this problem.

Nailer · 05/29/09, 6:39 AM

Coming along nicely, it already replaced Pitbull on my UI. Custom tags, frame anchoring and location based frame visibility being the main reasons. The config menu is also very user friendly although being a long time Pitbull user I really have no trouble with either. Just a few questions:

Is basic plugin support planned? Can we register for events such as frame spawned / enabled / disabled / unit changed?

Strings: Although the current implementation does its job, some more anchor options (base frame) and the possibility to dynamically add / delete / name them instead of having a set number of 4 might be something to contemplate.

Custom group: I know this subject was mentioned earlier in the thread but I am quite certain either you or I misunderstood TimWischmeier's suggestion. Ag_UnitFrames had a feature where the user could provide a custom list of names and a separate group of frames was built based on it, similar to how main tank windows work. Not some unclickable list of bars that were reordered dynamically mid-combat but fully featured unit frames (inheriting raid frame properties). It is a very nice addition I am sad to see not being carried over as a standard. Just off the top of my head some examples where it proved invaluable: Easy access to raid members that are key to a certain encounter, distinguishing your friends from 40 players in BGs, monitoring healer mana and activity, checking healer range for tanks / DPS who don't fancy raid frames... Of course if this involves anything more than comparing against a table and duplicating raid frames I do understand your reluctance of implementing it, however I ask you to consider the merits it has.

Shadowed · 05/29/09, 2:54 PM

Originally Posted by Nailer

Coming along nicely, it already replaced Pitbull on my UI. Custom tags, frame anchoring and location based frame visibility being the main reasons. The config menu is also very user friendly although being a long time Pitbull user I really have no trouble with either. Just a few questions:

Is basic plugin support planned? Can we register for events such as frame spawned / enabled / disabled / unit changed?

Strings: Although the current implementation does its job, some more anchor options (base frame) and the possibility to dynamically add / delete / name them instead of having a set number of 4 might be something to contemplate.

Custom group: I know this subject was mentioned earlier in the thread but I am quite certain either you or I misunderstood TimWischmeier's suggestion. Ag_UnitFrames had a feature where the user could provide a custom list of names and a separate group of frames was built based on it, similar to how main tank windows work. Not some unclickable list of bars that were reordered dynamically mid-combat but fully featured unit frames (inheriting raid frame properties). It is a very nice addition I am sad to see not being carried over as a standard. Just off the top of my head some examples where it proved invaluable: Easy access to raid members that are key to a certain encounter, distinguishing your friends from 40 players in BGs, monitoring healer mana and activity, checking healer range for tanks / DPS who don't fancy raid frames... Of course if this involves anything more than comparing against a table and duplicating raid frames I do understand your reluctance of implementing it, however I ask you to consider the merits it has.

It already has basic module support (Although most of it is for the default features to work), I don't plan on expanding the string system by default, but I'll probably release some sort of small plugin to unlock them.

I don't plan on adding special lists that unit frames are created off of thought, even as a module.

Wyred · 05/31/09, 11:22 AM

Basically getting lots of Lua errors when in a vehicle and targetting anything. Apologies for not having the actual lua error, but was in ulduar at the time. Will try and reproduce and post actual error. No-one else getting this?

Edit: as mentioned below this is indeed now fixed

Shadowed · 05/31/09, 2:24 PM

Well, no Lua error doesn't tell me much. But I pushed a fix to revert the vehicle change, so it's likely fixed due to that.

Winco · 06/03/09, 7:31 PM

It's pretty nice, I like it so far. Feature suggestion wise

+Bit more control over the rune monitor (set the cool down opactiy much lower). Maybe colors too.
+Change bar background colors (I use a dark grey for HP bars, and typically have the class color showed as the background)
+Different textures per bar. My custom texture works well on my HP bar set ups, but I run smaller power bars, which doesn't work to well.
+Ability to adjust size of "my debuffs", and how they align (instead of its current centering).
+Ability to add additional text boxes, and how far before they will truncate

Issues
-Setting border seems off, no option (that I can see) to increase the scale, etc.

All I can think of at the moment. It's turning out quite well.

Thought I'd also add an image so you can see what I'm referring to as far as the text, and status bars, and if you're interested, what I'm doing with your mod.

(Timers on the bottom are ForteXorcist)

Kuosi · 06/06/09, 8:03 PM

Any way to alter the auraborders?