Your post is terrible. If this is all the effort you put into playing your character it's no wonder you need help. Do better.
I could just be blind and in the pages of posts have miss all the answers to the questions i want to ask.
First My priest has basically the cookie cutter but i was wondering why not to take shadow affinity? Granted its not easy to steal agro anymore if not impossible but even taking that away but without it, is it still impossible to steal agro?(if this is the case then i can respec those three points.)
is it really necessary to take Improved shadow form. Iv always seen this as more a PVP type ability since in raids i find other then moving out of fires and or other "bad" things on the ground that my dps does not really get interrupted all that much.
also i just got to trying the rotation you suggest here not to do SWP until you have the 5 stacks but iv only seen a minor dps increase which yes is still an increase but i was hopeing for more. whioch leads me to my second part of this question. I am fairly well geared(T10ish equipment) good haste decent crit and over 3000sp when self buffed and currently way over hit cap.
But i have seen shadow priests under geared compaired to my character and able to do as much or more dps then me.
On the heroic dummy i hit 4300 dps. So my one theory is my characters lack of Spirit which is not all that high at the moment but even then when i saw another shadow priest do just as much as i could with 2-300 less spellpower half my crit and way less then half my haste i thought id see if i could find some help maybe give some advice to where im going wrong.