Kahorie's DK simulator 2.0 Beta - Including Cataclysm. - Page 21

Consider · 08/15/09, 12:43 AM

The results between SS vs OB are very different now - different to the tune of ~300 dps... ~300 dps in Scourge Strike's favor.

It took me a sec to figure out why.

You didn't put the glyphs in the 3/13/55 or 0/17/54 build by default (whereas 0/10/61 does have them in). Not a big deal, but a minor fix for future changes. Once you make sure glyphs are taken care of, Oblit pulls comfortably ahead once again, as expected.

The change to the result formatting is great, by the way.

Edit: The different formatting seems to only apply to the EP results, not a regular simulation's results. If in a future update it could apply to both, that would be much appreciated.

Edit 2: I actually did get hit/expertise values, but they seem incorrect. Expertise is rating higher than hit which should be impossible, really. At the most, the two would be equal. Something odd with how it's calculating it.

AumVek · 08/15/09, 1:22 AM

Why does the combat log feature, when using a SS build, generate "SS hit for 0" everywhere you'd expect a hit? When looking at the combat log for an Ob build you see the expected hits for a number value. Thanks for all the work that has been put into this great tool.

crusaderky · 08/15/09, 6:05 AM

1.0.1 crashes as soon as I click on "start simulation". 0.9.9 worked fine. Happens bot with priority and rotation mode.

[EDIT]the problem was caused by the fact that I tried importing an old character file, which didn't have the new <GrimToll> and <MjolnirRunestone> tags.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at DKSIMVB.MainStat.init()
at DKSIMVB.Sim.Initialisation()
at DKSIMVB.Sim.Start(ProgressBar pb, Int32 SimTime, MainForm MainFrm)
at DKSIMVB.MainForm.Button1Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

crusaderky · 08/15/09, 7:21 AM

It would be EXTREMELY helpful, in order to figure out the sim's decisions, to have in the combat log:
1)Rime HB distinguished from simple HB (helps tracking runes a lot)
2)A code saying what runes are available every time the sim is going to do an attack, and when they're not how long it's left till they are. A good syntax would be: [D1F8U8] meaning that I've got 1 death rune, 1 more D/B will be available in 1 second, there's 1 FU pair available, and the next FU pair will be on CD for the next 8 seconds. (this way you can't see if the runes on CD will become regular or death runes, but IMHO it's a good tradeoff).

i.e.
1 [BBFFUU] HB crit for 5748
145 [BBF9U9] OB crit for 8227
310 [BB9797] FS crit for 7629
475 [BB8686] BS hit for 1491
640 [B96464] BS crit for 3654
805 [985353] Blood Tap
805 [985353]Unbreakable Armor

Afabar · 08/15/09, 8:22 AM

If you activate "very detailed combat log", you can see Rime proc.
However, I can add the rune state to the log. I will try to include that in the next version.

dr_AllCOM3 · 08/15/09, 9:12 AM

Originally Posted by Consider

I actually did get hit/expertise values, but they seem incorrect. Expertise is rating higher than hit which should be impossible, really. At the most, the two would be equal. Something odd with how it's calculating it.

You have to tell me your settings/config and at best leave most of them untouched. I can't just run the EP calculator twenty times for debugging, it takes far too long

.

leladax · 08/15/09, 9:35 AM

Here it works fine but it always crashes if I: Edit an existing spec -> choose the new spec -> restart simulation.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at DKSIMVB.MainForm.LoadBeforeSim()
at DKSIMVB.MainForm.Button1Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

PS. It's fine if I restart the program and choose the new spec and all other options. It's only a bit time wasting that fields are emptied and have to be chosen again.

Consider · 08/15/09, 10:05 AM

Originally Posted by dr_AllCOM3

You have to tell me your settings/config and at best leave most of them untouched. I can't just run the EP calculator twenty times for debugging, it takes far too long

.

=p.

Gear used was my own (226 hit rating, 131 expertise). Spec used was 3/13/55. Hours were first 1000, then 2000. Latency was 150. Everything else was default/shown below (Presence - Blood, etc).

EP:50	AttackPower	100
EP:50	Strength	300
EP:50	Agility	96
EP:50	CritRating	148
EP:50	HasteRating	138
EP:50	ArmorPenetrationRating	170
EP:50	ExpertiseRating	174
EP:50	HitRating	164
EP:50	SpellHitRating	0
EP:10	WeaponDPS	129
EP:0.1	WeaponSpeed	67
EP:	2T7	15081
EP:	4T7	37049
EP:	2T8	21311
EP:	4T8	27868
EP:	2T9	64262
	Template	3-13-54
	Priority	Unholy Oblit
	Presence	Blood
	Sigil	Virulence
	RuneEnchant	FallenCrusader
	Pet Calculation	True

--------------------------------------------------------------------------------

EP:50	AttackPower	100
EP:50	Strength	304
EP:50	Agility	98
EP:50	CritRating	154
EP:50	HasteRating	140
EP:50	ArmorPenetrationRating	173
EP:50	ExpertiseRating	180
EP:50	HitRating	170
EP:50	SpellHitRating	0
EP:10	WeaponDPS	131
EP:0.1	WeaponSpeed	68
EP:	2T7	15333
EP:	4T7	37333
EP:	2T8	6666
EP:	4T8	13333
EP:	2T9	50000
	Template	3-13-54
	Priority	Unholy Oblit
	Presence	Blood
	Sigil	Virulence
	RuneEnchant	FallenCrusader
	Pet Calculation	True

Also just noticing the very different set bonus EP values between the two. Odd. Not sure what caused that.

Fugazor · 08/15/09, 10:34 AM

EP seems indeed to be better. Still I noticed two things:
1) Hit seems to be undervalued (1.7-1.8) for both 51/00/20 (500h EP) and 03/13/55 (111h EP). My char sheet had 263 hit rating, EP 50 for both cases. Also spellhit showed value of 0 in both cases.
2) WDPS and set bonuses were around two times too high (for example 2xT9 was calculated as ~1000 AP value).

Other values I got from 500h 51/00/20 EP run were pretty much where I would expect them to be.

dr_AllCOM3 · 08/15/09, 12:02 PM

1.0.2 Release notes

* EP calculation corrected some more
* DC+HB were using melee hit
* Ghoul 3.2 hit+exp changes

EP for the main stats seem to work correctly now, but they can only really be tested by you

. The weapon stats can be off and the set bonuses are untouched.

Fugazor · 08/15/09, 1:08 PM

How simulator count following, I will show how I do it, it may be little less accurate but could speed up calculations of following.

2xT8:
* Unholy - [(base DPS) * (DC + UB % of total damage)] * 8% = (DPS -> compare to AP)
* Blood - [(base DPS) * (DC % of total damage)] * 8% = (DPS -> compare to AP)

4xT8:
* Unholy - {[(base DPS) * (SS % of total damage)] * 6%} + {[(base DPS) * (BS % of total damage)] * 7.5%} = (DPS -> compare to AP)
* Unholy OB - {[(base DPS) * (OB % of total damage)] * 7.5%} + {[(base DPS) * (BS % of total damage)] * 7.5%} = (DPS -> compare to AP)
* Blood - [(base DPS) * (HS % of total damage)] * 4% = (DPS -> compare to AP)

2xT9:
* Unholy - 180 * (STR value) * 0.75 = bonus value
* Blood - 180 * (STR value) = bonus value

4xT9:
* Unholy - {[(base DPS) * (diseases % of total damage)] + [(base DPS) * (WP % of total damage)]} * (spell crit) = (DPS -> compare to AP)
* Blood - [(base DPS) * (diseases % of total damage)] * (spell crit) = (DPS -> compare to AP)

For 4xT9 I have no idea if WP will really proc it, it doesn't count internal cooldown of WP and I use spell crit not melee crit (not sure if that is correct?).

Afabar · 08/15/09, 1:20 PM

Originally Posted by dr_AllCOM3

1.0.2 Release notes

* EP calculation corrected some more
* DC+HB were using melee hit
* Ghoul 3.2 hit+exp changes

Also include in the release:

* 4P T9 is now implemented on character and EP stat.
* Report is now sorted, and the first decimal is showed.

Fugazor,
That is not the approach of the simulator. Complex formula are for spreadsheets. I prefer to implement them as close as they are in game and let the random number generator make the work.

edit:
I have create a 1.0.2.1 version. A minor error on the Spell hit rating value.

GravityDK · 08/15/09, 4:08 PM

(1) bug report, (2) question on use for tanks.

UPDATE: appears that I need to select a Runeforge on the 2nd weapon within the UI, even though one isn't used, and the error stopped.

I edited the 2H character to use my tank's settings. (The file is here if you want to check it).
The error I get when using that character is below. If I switch back to the DW Ulduar character you supplied, the sim works. No other setting changed in this use-case.

************** Exception Text **************
The given paths' format is not supported.

System.NotSupportedException: The given path's format is not supported.
   at System.Security.Util.StringExpressionSet.CanonicalizePath(String path, Boolean needFullPath)
   at System.Security.Util.StringExpressionSet.CreateListFromExpressions(String[] str, Boolean needFullPath)
   at System.Security.Permissions.FileIOPermission.AddPathList(FileIOPermissionAccess access, AccessControlActions control, String[] pathListOrig, Boolean checkForDuplicates, Boolean needFullPath, Boolean copyPathList)
   at System.Security.Permissions.FileIOPermission..ctor(FileIOPermissionAccess access, String[] pathList, Boolean checkForDuplicates, Boolean needFullPath)
   at System.IO.Path.GetFullPath(String path)
   at System.Xml.XmlResolver.ResolveUri(Uri baseUri, String relativeUri)
   at System.Xml.XmlUrlResolver.ResolveUri(Uri baseUri, String relativeUri)
   at System.Xml.XmlTextReaderImpl..ctor(String url, XmlNameTable nt)
   at System.Xml.XmlTextReader..ctor(String url, XmlNameTable nt)
   at System.Xml.XmlDocument.Load(String filename)
   at DKSIMVB.MainStat.init()
   at DKSIMVB.Sim.Initialisation()
   at DKSIMVB.Sim.Start(ProgressBar pb, Int32 SimTime, MainForm MainFrm)
   at DKSIMVB.MainForm.Button1Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

(2) for tank simulation, I can't work out how you have determined the proc frequency of Rune Strike. As you know it's based on the DK dodging, but the sim doesn't know what my avoidance is.

Afabar · 08/15/09, 4:41 PM

1/ I see nothing wrong. I try to check anyway.
2/ The "tanking" module is far from been reliant. So much is missing. Rune strike is always cast if you have enough RP.

GravityDK · 08/15/09, 5:26 PM

Originally Posted by Afabar

1/ I see nothing wrong. I try to check anyway.
2/ The "tanking" module is far from been reliant. So much is missing. Rune strike is always cast if you have enough RP.

Thanks. For issue 1, it resolved when I had selected the 2nd weapon runeforge (even though it was 1H).
For Rune Strike, thanks for that.

My recommendations for how you'd make the RS a little more meaningful:
* Have it fire off 18 times every 60s, that's about what a 60% avoidance tank would see against a boss striking every 2s. It's more accurate than 'whenever RP is available', but isn't perfect.