Kahorie's DK simulator 2.0 Beta - Including Cataclysm. - Page 8

Afabar · 04/06/09, 5:55 PM

0.8.0 Release notes
* Incorrect runic power granted with Howling Blast on Rime proc.
* Option to cast Gargoyle and DRW only when on Fallen Crusader buff (if rune forged for).
* Add a latency parameter.
* Add Howling Blast in templates, because a xx/4x/xx template could cast HB on rime proc.

Beta TPS Module integration. Just select Frost presence.
* Add a TPS summary in the report.
* Add Rune Strike and Rune Strike glyph. Simulator always activate it if RP is available.
* Scent of blood implementation. I don’t have experience with this talent so it proc every time it’s not on CD. It should be adjusted latter.
* Implementation of T7 and T8 set bonus.
* A real tanking simulator may be added someday.

ron9, this is my lastest work on the simulator. I have to check the math for Rune Strike scaling, but it's a first step into a DK threat simulator.
Overview of what left to do :
* Add some parameters to tune the RS availability.
* Make basic template.
* Add Parry to calculation

Energizr, it's corrected.

Kithus and Kyruski, <GhoulFrenzy> should work. I will look at that.

Kyruski · 04/06/09, 6:00 PM

Originally Posted by ron9

Of course it doesn't make it hit harder but it decides how often you will use Rune Strike, which in the end affects how much damage, overall, your rune strike does.

But if he were to make a sim that included tanking and stuff, he might have to worry about other stuff. What if you need to save that RP for IBF, AMS, etc... Also Rune Strike is an "On next attack" strike and I would believe that would need a little extra code added in to make sure it doesn't just waste it on instant runic dumps. It's probably best just to have an internal:

if dodge/parry
set RunicStrikeAllow = 1.;

if RunicStrikeAllow = 1 and Rune Power > 20
then set NextAttackRunicStrike = 1 and RP-=20;

and then when Runic Strike is used, possibly a

set RunicStrikeAllow = 0 and NextAttackRunicStrike = 0;

or if it's not used in the period that it's allowed, just do

set RunicStrikeAllow = 0;

Or something of the sorts. Now I don't know if this would be the correct language and I forgot some of my functions, but you can probably get the point. These are just some suggestions for mechanics unless it go a lot deeper if you plan to include Rune Strike. I don't know how intricate it'd have to be though.

EDIT: Ooops. Guess that coding that I suggested wasn't needed. a new version that included Rune Strike was posted while I typed that, thought I am interested in the way you did implement Rune Strike if you could elaborate.

Cabal · 04/06/09, 6:19 PM

Can I humbly suggest you dont disperse too much effort into a "tanking module"? Thats a completely different bag of cookies, and your dps simulator is shaping up to be the tool this class badly needed, so math-disabled persons like me can get a little help making decisions without having to beg/wait for others to work their numbers magic.

And quite frankly, tank dps isnt exactly a vital concern, as tanks in this game basically need to a) not die b) stay ahead of dps on threat (which is quite easy nowadays).

Thanks again for your work, Kahorie.

Afabar · 04/06/09, 6:20 PM

I don't have uploaded changes into CVS but the code I have made is very simple right now.
As I just check, just when I enter in the Main Hand hit function if I'm in frost presence and have enough runic power to cast it.

It look like that :

If FrostPresence = 1 Then
	If RunicPower.Value >= 20 Then
		RuneStrike
		exit function
	End If
End If

Saving RP for emergency abilities is something I could throw easily in a customizable parameter. I put this in my todo list.

Originally Posted by Kyruski

You don't have a function to check if Rune Strike is available? Or is it build into the RuneStrike command?

Not right now. Adding a parameter for that is in my todo list.

Cabal,
A pure tanking module with dodge, effective health and so on is not my priority right now. But if have have enough time in the future to make something usefull for the DK tanking, I think I will if no other tools that fits my need appears.
But adding a TPS module was something I wanted to implement and started to work on a few days ago. Adding such things like I this are not very time consuming.

But, I think also that the work on the "DPS" module is nearly close to be finished. The main missing stuff I have in mind is the trinket proc implementation. The rest is more User Interface improvement and some code optimization. And I have to admit I'm missing ideas of what is missing to fits every DPS DK needs.

Kyruski · 04/06/09, 6:31 PM

Originally Posted by Afabar

I don't have uploaded changes into CVS but the code I have made is very simple right now.
As I just check, just when I enter in the Main Hand hit function if I'm in frost presence and have enough runic power to cast it.

It look like that :

If FrostPresence = 1 Then
	If RunicPower.Value >= 20 Then
		RuneStrike
		exit function
	End If
End If

Saving RP for emergency abilities is something I could throw easily in a customizable parameter. I put this in my todo list.

You don't have a function to check if Rune Strike is available? Or is it build into the RuneStrike command?

Cabal · 04/07/09, 4:15 AM

Originally Posted by Afabar

I'm missing ideas of what is missing to fits every DPS DK needs.

Thats because it already has everything thats needed :P Once we start getting confirmation from actual in raid dps values, id say this is a perfectly working tool.

Well, you could, I suppose, add details, like the possibility to import a character from armoury, or maybe a character editing menu, with boxes where you could enter stat values. But thats really very minor, its doing whats really important, the possibility to check dps variations from different gear, as well as EP values we can input into an appropriate addon.

Oderine · 04/07/09, 9:10 AM

The only thing I miss is the choice of the metagem
is the "3% Increased Critical Damage" of the Chaotic Skyflare Diamond implemented by default ?

Afabar · 04/07/09, 10:17 AM

I didn't implement it yet. It will soon be done.

ron9 · 04/07/09, 3:34 PM

Originally Posted by Cabal

as well as EP values we can input into an appropriate addon.

What addon do you think is the best for inputting EP values to rank gear in-game?

Also, I am still getting random EPvalues even when setting the simulation to 1k hours.

Afabar · 04/07/09, 3:46 PM

Pawn is a good addon to input EP value in game.
Could you send your template, character and priority file via PM ?

• frmorrison · 04/07/09, 4:09 PM

Originally Posted by Afabar

I didn't implement it yet. It will soon be done.

Did you add a Ghoul uptime to your sim?

Something like NotD + Perma Ghoul = 100% uptime

NotD talent only = 50%

Nothing = 25%

Kyruski · 04/07/09, 4:37 PM

Originally Posted by Afabar

Kithus and Kyruski, <GhoulFrenzy> should work. I will look at that.

The command <GhoulFrenzy> still does not work. It still just stops all commands after that so all the test really is is the DPS of Auto-attacks, the Ghoul, BCB, and Necrosis (also Razorice if used).

Afabar · 04/07/09, 6:06 PM

0.8.1 Release notes
* Ghoul Frenzy should now work better. You can now track it in the combat log in verbose mode.
* Add a ChaoticSkyflareDiamond in the Character config file. Set to one to enable the meta gem.

Kyruski,
I made some correction on Ghoul Frenzy. It should be ok now.

frmorrison,
As I implemented the ghoul, it last 1 minutes if untlaented and is summoned every time it not on cooldown. I don't have the exact number in mind right now but it should look like what you describe.

Kyruski · 04/07/09, 6:45 PM

Originally Posted by Afabar

Kyruski,
I made some correction on Ghoul Frenzy. It should be ok now.

I just did some sims quickly and it seems like GF isn't working correctly. When I have it in my rotation/priority, my ghoul's number of hits drops, usually a drop of 10%+. Here's my ghoul's number of hits without GF : 92386 and here it is with GF : 82877. So it seems as if instead of adding 25% haste to the ghoul, it's removing ~10% from the ghoul.

EDIT: Looked at a Combat Log and with no GF, the ghoul attacks once every 1.14 seconds and with GF, it's once every 1.33 seconds. So it seems like it's a 15% loss. Also while looking at the log, I see some places where it's missing a ghoul attack.

Lollersk8er · 04/07/09, 7:14 PM

Razorice is back at 5%. That would most likely make dual FC the best choice, again.