Hi,
First time poster here.

Maybe not the best way to start here, since this post will contain sums and numbers
I was wondering about some of the stat weights and/or trinket rankings at the start of this great guide. I realise the stat weights are by their nature quite uncertain and should be taken as guidelines rather than strict numbers. Still, there are a couple of things I don't really understand.
I'll start with the lowest ranked trinket: Needle-Encrusted Scorpion. I don't understand why it is ranked so low. It has two components: the fixed crit and the proc. The weight of the crit at, say, i264 levels, is fairly easy: 114 * 2.1 = 239.4. Let's assume we melee hit every 3 seconds and we get a crit every 10 seconds (fully raid buffed this seems a rather slow estimate). This means we can expect the buff to kick in 5 seconds (on average) after the ICD has passed, we have an uptime of 10/50 = 20% (not the 15% listed). This yields a proc component of the trinket value as: 10/50*678*2.49 = 337.644. For a total trinket rating of just over 577.
Leaving aside some trinkets we reach the Greatness card. This has a fixed component of 90 Str or about 272.7. Then there is the proc. The chance in the tooltip seems to be 1/3 (from Rawr database). Instead of going all math geeky, we will guestimate it takes (on average) 3 seconds for the proc to kick in once the ICD has passed. (At 3 seconds hits, this is an optimistic estimate.) This gives a proc uptime of 15/48 = 0.3125. At 300 Str, this means we get 300*0.3125*3.03 = 284.0625. For a total trinket rating of 556.7625. But even setting aside delays in the proc, we get a total trinket rating of 575.7, still lower than the Needle-Encrusted Scorpion.
So why is the Greatness trinket rated as better?
Also, is the physical component of some of our attack considered a melee attack?
If we look at the Herkumi War Token, the listed ramp up time is 25 seconds. This corresponds to a quite insane amount of haste. 20 attacks in 25 seconds with a typical DK 3.4 weapon corresponds to well over 100% haste. Personally I think a ramp up time of 45 is more realistic (albeit still optimistic). Unless the physical component of some of our attacks is considered a melee attack.