[Balance] WrathCalcs - Page 21

Dryadne · 09/15/11, 2:42 PM

The stats upon the 'Gale Rouser Belt of the Undertow' are incorrect

♦ Tecton · 09/15/11, 7:10 PM

They match the stat breakdowns on WoWhead, could you clarify a little more?

cybrid · 09/17/11, 6:41 PM

Not sure whether it was mentioned previously or helpful, but in order to properly support profile importing from battle.net character name and realm name should be URL-encoded when generating API URL. This is especially relevant for Russian realms or any character with non-English chars in name. With latest version of spreadsheet (110911) I was able to import my profile only after hardcoding URL-encoded values into the script. You can see the resulting URL below, as example.

← Click Here

Edit: I now see URLEncode function present in code, but somehow it was not working.

♦ Tecton · 09/18/11, 1:53 AM

Cyrillic characters might not all be working, I'm just catching edge cases as they come up. I'll have a look at getting those working too.

[edit] Scratch that, forgot that some server names would need to be encoded too. Fixed in the version below: [/edit]

Elfstrom · 09/18/11, 12:06 PM

/sadface

I can get past this error by adding PtrSafe attribute after the Declare statement for the WideCharToMultiByte function; however, I then get a series of type mismatch errors in the UTF16To8 function which I believe are related to the use of the StrPtr function.

Found this link in trying to debug it, but I'm not the programmer I once was.

Compatibility Between the 32-bit and 64-bit Versions of Office 2010

I have Office 2010 64bit on Windows 7 Ultimate 64bit and am using WrathCalcs 110918.xlsm

This seems isolated to this one module and one function so it should be a relatively simple fix to an experienced VBA programmer.

Thanks,
Elfstrom

Elfstrom · 09/18/11, 12:32 PM

The changes in red to Module4 appear to resolve the issue:

Private Declare PtrSafe Function WideCharToMultiByte Lib "Kernel32" (ByVal CodePage As Long, ByVal dwflags As Long, ByVal lpWideCharStr As LongPtr, ByVal cchWideChar As Long, ByVal lpMultiByteStr As LongPtr, ByVal cchMultiByte As Long, ByVal lpDefaultChar As Long, ByVal lpUsedDefaultChar As Long) As Long

However, now I get:

Function GetBattleNetJSON(charName As String, charServer As String, charRealm As String)
    Dim URL
    URL = "http://" & charRealm & "/api/wow/character/" & charServer & "/" & charName & "?fields=items,talents,professions"
    Set sc = CreateObject("ScriptControl")
    sc.Language = "JScript"
    Set xhr = CreateObject("Microsoft.XMLHTTP")
    xhr.Open "GET", URL, False
    xhr.send
    Set GetBattleNetJSON = sc.Eval("(" + xhr.responseText + ")")
End Function

♦ Tecton · 09/18/11, 1:35 PM

Yeah, I'm trying to resolve that one at the moment, thanks for the detailed info!

Elfstrom · 09/18/11, 2:22 PM

Try using JavaScriptSerializer.Serialize to parse your JSON.

Larrabee · 09/26/11, 8:39 PM

Latest wrathcalcs doesn't work.

Run-time Error '13':

Type Mismatch

Name: Larrabee
Region: eu.battle.net

♦ Tecton · 09/26/11, 9:02 PM

Just checked it and it's importing your armory without issues (and identifying the correct gloves). What version are you using?

• Hamlet · 09/27/11, 8:43 PM

This has the set bonuses, although it seems to be evaluating the 4p higher than I first time I looked at it. Will have to recheck and see if something is up.

Erdluf · 09/28/11, 6:41 AM

I'd really like to see simulationcraft numbers for the 4-piece.

As an extremely rough approximation for 4t13 I just assumed it eliminated two non-NG, non-Eclipse Wraths from our rotation. That would be a bit more than a 3% boost to DPS. That assumption is probably too optimistic, but by less than a factor of two.

Latas · 09/28/11, 7:36 AM

Originally Posted by Erdluf

I'd really like to see simulationcraft numbers for the 4-piece.

As an extremely rough approximation for 4t13 I just assumed it eliminated two non-NG, non-Eclipse Wraths from our rotation. That would be a bit more than a 3% boost to DPS. That assumption is probably too optimistic, but by less than a factor of two.

It would eliminate one and replace one with a starsurge.

♦ Tecton · 09/28/11, 8:20 AM

A couple of formatting changes there guys, so hold off on using the profiling features, I'm fixing it as we speak. Also, new gear and epic gems incoming.

[edit] Updated version attached.

I've amended the crafted leather legs to have an intellect bonus rather than agility, there are a few placeholder weapons without stats in the list at the moment, I've added them and can update when they get fixed on PTR. Also updated a T13 gearset on the setup page for comparison purposes. Let me know if I've missed anything or there are any snags, other than that this should be fine for live use as well.

Just noticed the edit above re: Javascript, I'll give that a shot, thanks.[/edit]

♦ Tecton · 09/28/11, 10:07 AM

Just noticed we've got differences between MMO-C and WoWhead databases on trinket cooldown (specifically, the ridiculously good Valorous Rune - Item - World of Warcraft). Can anyone remember which one was correct last time?