Your wrath casts are generally going to always be half the cast time of your starfires, and your wrath casts are what your GCD is at. So if your average starfire cast is 2.1 seconds your average wrath and GCD should be 1.05 seconds.

It gets a little more complicated than that, partly since Nature's Grace has higher uptime during Lunar Eclipse's than otherwise but mostly since with sufficient (>409) haste rating you will be capped at 1s GCD. In the specific example you quoted the person had a 1.9s Starfire in NG, which would imply that he's exceeded the haste soft cap and is getting diminishing returns on his 4T2 procs.

As for the original post in question...

Your general method isn't wrong as such, but your execution is a bit lacking.

First, your NG uptime on Starfires will generally not be 50% and so your average cast time is a weighted average, not a straight arithmetic one. A quick check of my total uptime is about 60% going by parse numbers and presumably higher during Starfire spam due to Eclipse, yours is presumably yet higher due to better gear. Second, your GCD length will vary between 1.15 seconds outside of NG and 1 second in NG. Finally, you're doing a lot of rounding for no particular reason. A slightly more accurate analysis is that 6.48 procs is really 6.48 instant Starfires, each of which saves on average (with 60% NG uptime) 0.6*0.9+0.4*1.15 = 1 second. In 6.48 seconds you'd cast 3.15 Starfires (again with 60% NG uptime), for 27 404 damage or 119 DPS in that particular fight.

Of course, this is also off by a fair amount. For a decent evaluation you'd need accurate values for your NG'd and non-NG'd cast times to start with as well as a lot more than 230 seconds of casting as a sample. You'd also need to know your exact IS uptime, then take into account some 4-piece procs being effectively unusable due to occurring in the Wrath phase of a Lunar cycle, then model the interaction between shorter casts and lag, and so on until you end up rewriting either Rawr or WrathCalcs. Unless this concept sounds instantly appealing you should probably just call the set bonus 100ish DPS and use Rawr or WrathCalcs if you desperately crave detail.

Was just trying to get a rough idea on some numbers for the 4pc to use, I think in that particular parse NG was only up 53% of the time so I stuck with 50%. NG (depending on the fight) I have seen anywhere between 45-65% uptime, as well, making the value of the 4pc change on each fight.

As you said though it would require some rewriting that I am not interested in (nor was I trying to), I was just throwing some numbers out there in hopes to provide an approximate value. I am content with estimating it at ~100 DPS for now though.

I have some decent gear, but my dps seems to be a little low. I am about the 2.2-2.5k and at times around 2.7k in raids. I would think that it could be higher, and I want to try to maximizing dps as much as I can.

I try to use use: IFF IS/MF Wrath until proc->SF->refreshing IS/MF at beginning of cd. I was playing around with my rotation, it isn't consistent.

I do have Glyphs of IS MF and Starfire and I have Squawk and Awe for eclipse and Squawk Hard to help rotation

Here is my build...Moonkin Feel free to check my gear/stats with armory.

I will try to use the suggested eclipse rotation that was in the moonkin dummies guide unless someone has the numbers to support why Starfire Proc is better for eclipse.

*edited

I can't make head or tail of your question, but erase whatever random crap you've heard and start here:
http://elitistjerks.com/f73/t59457-m...dated_3_1_3_a/