SimulationCraft - for fur and feather wearers - Page 3

charriu · 03/11/09, 7:44 AM

Originally Posted by Starfox

I don't know, but the damage of rip is a bit ridiculous from my point of view.
Rip: ~24% of total damage, but only used every ~30sec

Rip seems a bit high, indeed. But not much...

Rip with all glyphs (shred, rip, sr), 2t7 and [Idol of Worship]:

Per Tick: tickDmg = (39+99*CP [base dmg]+AP*0.06+21*CP [idol])*1.36 [glyphed sr]*1.1 [naturalist]*1.3 [mangle]
Total: ripDmg = tickDmg * (6 [base] + 2 [rip glyph] + 2 [2t7] + 3 [shred glyph]) * (1 + CRIT * 1.1 [pred. instincts] * 1.03 [RED])

So, at 7k AP with 50% crit and 5CP, thats nearly 42k damage over 26s.

dedmonwakeen · 03/11/09, 7:55 AM

Originally Posted by ramenchef

What is periodicity? if you mean time between energy ticks, it should probably be set to 0.1 due to rogues/druids regenerating energy at a rate of 10 energy/1 second in 1 energy intervals. I'd actually be interested in seeing if that changes anything.

Changing periodicity will not change the rate of energy regen...... just how smooth/choppy it is.

The reason it defaults to 1.0sec is for performance reasons...... although I haven't experimented in a while.

Starfox · 03/11/09, 1:00 PM

Originally Posted by dedmonwakeen

Changing periodicity will not change the rate of energy regen...... just how smooth/choppy it is.

The reason it defaults to 1.0sec is for performance reasons...... although I haven't experimented in a while.

The weird thing i don't quite get.
regen_periodicity=1.0: fights length is about 284sec
regen_periodicity=0.2: fights length is right at 300sec

dedmonwakeen · 03/11/09, 1:51 PM

Originally Posted by Starfox

The weird thing i don't quite get.
regen_periodicity=1.0: fights length is about 284sec
regen_periodicity=0.2: fights length is right at 300sec

Experimenting across a range of values (multiple instances at each value) gave a "reasonably" random spread for fight length...... but the distribution was a bit spiky.....

All iterations are really health-limited despite the max_time setting. The boss health is calculated half-way through the very first iteration. Depending upon how lucky/unlucky the players are during that first half the fight time will be somewhere between 285sec and 300sec. It is never greater than max_time because boss health is calculated by damage done outside of BL and the Execute abilities/talents.

Starfox · 03/11/09, 7:10 PM

Originally Posted by dedmonwakeen

Experimenting across a range of values (multiple instances at each value) gave a "reasonably" random spread for fight length...... but the distribution was a bit spiky.....

All iterations are really health-limited despite the max_time setting. The boss health is calculated half-way through the very first iteration. Depending upon how lucky/unlucky the players are during that first half the fight time will be somewhere between 285sec and 300sec. It is never greater than max_time because boss health is calculated by damage done outside of BL and the Execute abilities/talents.

Hm, I think i got my misinterpretation, was using iterations=6666.
As there is no real report on average fightlength, I used the energy_regen, but with higher periodicity it happens more often to cap out on a regen event, and therefor less gets reported. Most probably in both cases the fights were actually of the same length.

Allev · 03/12/09, 11:22 AM

Time now to figure out why SimulationCraft is overvaluing hit/expertise for ferals compared to all the other theorycraft...

dedmonwakeen · 03/12/09, 11:42 AM

Originally Posted by Allev

Time now to figure out why SimulationCraft is overvaluing hit/expertise for ferals compared to all the other theorycraft...

By default, the scale factor generation for hit/expertise SUBTRACTS stat value to determine the slope of the dps curve.

I went back and forth on this one..... Input welcome.

Allev · 03/12/09, 12:05 PM

That shouldn't be a big deal, hit rating is fairly consistent from having no hit rating to being capped (according to the other theorycraft).

Also-- any chance an option for rake time can be added? I'd like to set up my profile to not shred unless rake has time before it expires (like mangle in the mangle profile).

Starfox · 03/12/09, 12:37 PM

Originally Posted by Allev

Also-- any chance an option for rake time can be added? I'd like to set up my profile to not shred unless rake has time before it expires (like mangle in the mangle profile).

r1785: rake>=Y, rake<=Y
Post your profiles if you can squeeze out more dps

Allev · 03/12/09, 2:58 PM

Is Omen of Clarity getting a double-bonus?

I'm looking into some unexpected Ferocious Bite behavior (limiting the energy it consumes is decreasing DPS), and I may have found the problem with hit rating while doing so.

The relevant code:

// druid_attack_t::cost ====================================================

double druid_attack_t::cost()
{
  druid_t* p = player -> cast_druid();
  double c = attack_t::cost();
  if ( c == 0 ) return 0;
  if ( p -> _buffs.omen_of_clarity ) return 0;
  if ( p -> _buffs.berserk) c *= 0.5;
  return c;
}

// druid_attack_t::consume_resource ========================================

void druid_attack_t::consume_resource()
{
  druid_t* p = player -> cast_druid();
  attack_t::consume_resource();
  if( p -> _buffs.omen_of_clarity )
  {
    // Treat the savings like a energy gain.
    double amount = attack_t::cost();
    if( amount > 0 )
    {
      p -> gains_omen_of_clarity -> add( amount );
      p -> _buffs.omen_of_clarity = 0;
      p -> aura_loss( "Omen of Clarity" );
    }
  }
}

In cost(), it looks like you make the cost of the attack 0. In consume_resource(), it looks like you're adding energy. If you are doing both, then you're doing something wrong! Although I'm not sure if these are two different implementations which are separate for cat and moonkin.

Edit: Crit ticks are still 5% too high.

Starfox · 03/12/09, 3:31 PM

Originally Posted by Allev

Is Omen of Clarity getting a double-bonus?

I'm looking into some unexpected Ferocious Bite behavior (limiting the energy it consumes is decreasing DPS), and I may have found the problem with hit rating while doing so.

The relevant code:

// druid_attack_t::cost ====================================================

double druid_attack_t::cost()
{
  druid_t* p = player -> cast_druid();
  double c = attack_t::cost();
  if ( c == 0 ) return 0;
  if ( p -> _buffs.omen_of_clarity ) return 0;
  if ( p -> _buffs.berserk) c *= 0.5;
  return c;
}

// druid_attack_t::consume_resource ========================================

void druid_attack_t::consume_resource()
{
  druid_t* p = player -> cast_druid();
  attack_t::consume_resource();
  if( p -> _buffs.omen_of_clarity )
  {
    // Treat the savings like a energy gain.
    double amount = attack_t::cost();
    if( amount > 0 )
    {
      p -> gains_omen_of_clarity -> add( amount );
      p -> _buffs.omen_of_clarity = 0;
      p -> aura_loss( "Omen of Clarity" );
    }
  }
}

In cost(), it looks like you make the cost of the attack 0. In consume_resource(), it looks like you're adding energy. If you are doing both, then you're doing something wrong! Although I'm not sure if these are two different implementations which are separate for cat and moonkin.

Edit: Crit ticks are still 5% too high.

OoC let the sim subtract 0 resource from yout current one.

 p -> gains_omen_of_clarity -> add( amount );

Means that you can see in the report under Gains how much energy saved by OoC, this is for statistical purposes only here and does not really add that amount of resource back to that player.

dedmonwakeen · 03/12/09, 4:01 PM

Originally Posted by Allev

Edit: Crit ticks are still 5% too high.

Do the rip/rake crit ticks also suffer from boss "crit depression" like standard melee attacks?

Allev · 03/12/09, 5:24 PM

It hasn't been tested as far as I know, but why wouldn't they? Do caster dots not get reduced by crit depression?

Starfox · 03/12/09, 6:10 PM

Originally Posted by Allev

It hasn't been tested as far as I know, but why wouldn't they? Do caster dots not get reduced by crit depression?

Nope, caster only get their miss chance/partial resists increased.

Allev · 03/12/09, 6:58 PM

So, I think I found a bug.

I've got two profiles:

First one is this:

#!simcraft max_time=300 optimal_raid=1

patch=3.1.0
druid=Druid_T8_00_55_16
level=80
talents=http://ptr.wowhead.com/?talent=0ZEGMcfrz0eR0huVkbAczb
actions=flask,type=endless_rage/food,type=blackened_dragonfin
actions+=/cat_form
actions+=/auto_attack
actions+=/shred,omen_of_clarity=1
actions+=/tigers_fury,energy<=40
actions+=/berserk,tigers_fury=1
actions+=/savage_roar,cp>=1,savage_roar<=4
actions+=/rip,cp>=5,time_to_die>=10
actions+=/ferocious_bite,cp>=5,rip>=5,savage_roar>=6
actions+=/rake
actions+=/shred,rake>=2
actions+=/shred,cp<=4,energy>=60
actions+=/shred,energy>=80
Melee_T7_Base_Gear.simcraft
gear_expertise_rating=200
# Not fair to use the same stats for all melee since Feral 

Druid needs less expertise.
# Trade expertise for ivalue-equal amount of attack power
enchant_attack_power=+160
enchant_expertise_rating=-80
glyph_rip=1
glyph_savage_roar=1
glyph_shred=1
idol_of_worship=1
main_hand=staff,dps=222.9,speed=2.4,enchant=berserking

Second one is this:

#!simcraft max_time=300 optimal_raid=1

patch=3.1.0
druid=Druid_T8_00_55_16_Modified
level=80
talents=http://ptr.wowhead.com/?talent=0ZEGMcfrz0eR0huVkbAczb
actions=flask,type=endless_rage/food,type=blackened_dragonfin
actions+=/cat_form
actions+=/auto_attack
actions+=/shred,omen_of_clarity=1
actions+=/tigers_fury,energy<=40
actions+=/berserk,tigers_fury=1
actions+=/savage_roar,cp>=1,savage_roar<=4
actions+=/rip,cp>=5,time_to_die>=10
actions+=/rip,cp>=5,time_to_die>=10
actions+=/ferocious_bite,cp>=5,rip>=5,savage_roar>=6
actions+=/rake
actions+=/shred,rake>=2
actions+=/shred,cp<=4,energy>=60
actions+=/shred,energy>=80
Melee_T7_Base_Gear.simcraft
gear_expertise_rating=200
# Not fair to use the same stats for all melee since Feral Druid 

needs less expertise.
# Trade expertise for ivalue-equal amount of attack power
enchant_attack_power=+160
enchant_expertise_rating=-80
glyph_rip=1
glyph_savage_roar=1
glyph_shred=1
idol_of_worship=1
main_hand=staff,dps=222.9,speed=2.4,enchant=berserking

The only difference is, I repeated the Rip line. The second profile somehow consistently beats out the first, every time I run the simulation.

BTW, the first profile regularly tops 7400 DPS. It's a work in progress still, though.