FeralbyNight (Cat & Bear simulation tool) - Page 38

• jonny · 07/02/09, 8:04 AM

Looks good, thanks for your continued work on this. I can't help feeling that there is some massive feature creep going on here though. We've gone from Face Mauler's move suggestion frame to including timer bars, combo point counters, cooldown monitors, a hud, stats panel and now a boss mod & threat monitor.

I currently turn off everything but the suggestion panel as I have other solutions to the other features (that work for all classes/specs). As long as all these extra bits can be disabled I'm not too fussed, but I'd rather see a set of small specific addons for each feature rather than one big all encompasing feral one.

RagasLS · 07/02/09, 8:18 AM

I must agree with Jonny here. I realy appreciate the awesome work of Nightcrowler but I am using only the suggestion pannel myself.

nightcrowler · 07/02/09, 8:33 AM

actually the boss mod doesn't substitute generic boss mod like DBM or the like.

I highly suggest (at least to try it out) to enable it and disable the the buff/debuff and all the other frame if you have other solutions, in that way it still work in combination with suggester monitor but without showing anything not needed. As for making different/modular addon yes, I'm working on it, tha main problem is that the core part of boss mod works together with the suggestion panel so it should be a "doubling".

Basically the reason for me to implement those frames is that I already needed the math/core code for the suggester frame (for istance on hodir if you have the crit buff it will suggest to shred instead of rake, on xt you can check for energy cd management and save them for heart phase and so on). To make them I already need to read boss health, boss casts, boss id, aruas and so on. So adding a frame that show them out is simply "graphics".

• jonny · 07/02/09, 8:44 AM

I'll try and get it installed and setup to test the boss mod bit in my raid tonight.

I understand the issue with not wanting to have the suggestion engine working in several addons. How about making the suggestion pane the core addon and make all the extra windows plugins that use the single core suggestion engine? Of course I realise that doing that is a lot of work for not a lot of user benefit, so as long as all the new bits you add are switchable seperately then I'm happy.

nightcrowler · 07/02/09, 8:50 AM

@jonny
Yes it could be done and I'll probably do it, I already wanted to revamp the code to make it more likely Xperl or similar "modular" addon. FBN doesn't take a lot of resurces so it's not that kind of problem, but the code is around 7k line atm and I need it for readability.

P.S.
Remember that the boss mod still need some testing (expecially on XT and Kologarn).

Gurrshael · 07/02/09, 10:21 AM

nightcrolwer :

Can't wait to test it in a raid, especially the notification icons and other new stuff. Thanks a lot for the work you've put in the simulation and addon.

A minor bug: Everytime I change my target, "NPC, #ID" appears in my default chat frame, which is really annoying. I had to comment lines 2039 & 2040 in FeralByNight.lua to solve it.

Fishmitohren · 07/02/09, 11:34 AM

hey, nice work.

I haven't tested your addon in a raid yet but I will do it later that week.
I noticed the addon always displays the NPC's ID in the chat window, targeting a mob - maybe you can add an feature to disable this.

Pheratia · 07/02/09, 1:19 PM

Maybe if you read the post about the new version you will see that it is on intentionally to help solve a bug.

Clausm · 07/02/09, 3:02 PM

Hi, Nightcrowler!
As for me, the suggestion monitor doesn't work (3.22), even when fighting. It simply shows nothing. The previous version worked fine, even on PTR.

Pheratia · 07/02/09, 5:29 PM

Make sure you lock it, when it is unlocked it won't function.

Clausm · 07/02/09, 8:05 PM

Yes, I know. But it doesn't show anything when locked. Here are some screenshots:

(unlocked, suggestion monitor between player/target frames):

(FBN frames locked, combat, no suggestion):

Thanks for any help.

nightcrowler · 07/03/09, 3:46 AM

@Clausm:
Does v.3.22 works on live? Is the problem only on ptr?
Try to /reloadui and see if it show up an error message.

@others: the npc id is for test purpose, as already said this is a "testing" version, because I can't test it by myself at the moment, thanks for all the help.

• Daboran · 07/03/09, 4:49 AM

Just to comment.

Overall nice job on the addon. I have to agree with people that I have addons to cover everything else, so I'm only using the "suggestion" part.

Would it be practical to add an option to be able to disable the "suggestion" window when in Bear form? I really only use it in Cat.

nightcrowler · 07/03/09, 5:09 AM

@Daboran:

yes I'm already working on it. You can already shout down the addon based on your spec, for istance if you have spec1=cat, spec2=bear you can simply disable it for your second spec. When I'll finish the profile part you'll be able to bind a profile to a form.

Drvo · 07/03/09, 7:27 AM

I have trouble moving any frame but suggestion one. When i try to drag other frames they only move little then i have to try and drag them again (sometimes they move little, sometimes don't). Don't know if it's a bug or I'm missing something.

nightcrowler · 07/03/09, 8:10 AM

New FBN addon push

Changelog:

-fixed an error with the boss mod monitor. When the buff/debuff didn't have an expire date it showed a big negative number. Now fixed.

- added a check button under show option to disable NPC ID in chat frame.

@Drvo:
Try /reloadui and see if it gives an interface error.
Be sure that the addon is unlocked.
Try to disable all other addon and try again to move the frames. If the problem is solved try to load other addon selectivley. If you find another addon that gives problem post the info.
If someone else have the same problem let me now.

Ayriss · 07/03/09, 8:31 AM

Hi Night.

I thought i'd try your addon since so many are talking so positively about it.

However when i just installed it i get the error message upon /reloadui ->

Interface\AddOns\FeralbyNight\FeralbyNight.lua:792: attempt to compare nil with number

nightcrowler · 07/03/09, 9:23 AM

@Aryss

I've changed that line fixing an error with version check. Now it shold work. Thanks for report.

FBN addon v.3.231

Clausm · 07/03/09, 9:47 AM

Hi again.
The latest version (3.231) shows everything properly (PTR/live), but it resets now all settings after /reloadui and the addon get's unlocked again.

nightcrowler · 07/03/09, 10:03 AM

@Clausm

It's wanted. It should do it only the first time you do it. Try to put everything in it's right place and lock the frame, then /reloadui again. It shouldn't reset everything a second time. I had to do it in order to fix the problem (it wipes your saved data for FBN the first time you reset the interface and you have an older version, then it save the new data of the latest version and doesn't do it again).

Ayriss · 07/03/09, 10:47 AM

Thanks Night, the Addon will now start and run.

Trying to set it up and playing a bit around with the functions;

Changing the font size of "my fight buff/debuff Frame Font size" i got the error Interface\AddOns\FeralbyNight\FeralbyNight.lua:6817: Attempt to call method 'SetFont' (a nil value)

---

After some testing of your addon, its really easy to use and it seems really cool. However somethings i wonder about:

A: When Savage Roar and RIP will expire at the same time, or almost at the same time, the addon wont suggest to overlap savage roar to keep up the rip. It will in fact rather suggest a FB with 6-7 seconds left on both savage roar and rip, this must be a dps loss. Overlapping SR at 7 seconds left and then quickly starting to build CP for a new RIP will result in less RIP downtime.

B: When Savage Roar and RIP cooldowns are off-sync (as they most often are) and you have a situation where RIP expires in 1 second and savage roar expires in 4 seconds. Then the addon will suggest to reapply savage roar the very second RIP wears off the target. At this point savage roar is still active with 2-3 seconds left. This must also be a dps loss considering the fact that reapplying RIP quickly and then getting 1-2CP and refreshing savage roar must be better.
Doing it that way you would have a downtime of maximum 2seconds on Savage Roar rather than having to build up 5 cp for a new rip which could result in a very long RIP downtime on a bad RNG.

This is just a few observations and i'd love some feedback from you night, perhaps there is a reason for this that i'm missing?

But tbh all in all your addon is very well designed and the amount of options for custimization is really cool.

Omidin · 07/03/09, 12:18 PM

When I try compiling the code I get:

FeralbyNightv3_1_beta_w.obj : error LNK2019: unresolved external symbol "private: static bool MTRand_int32::init" (?init@MTRand_int32@@0_NA) referenced in function "public: __thiscall MTRand_int32::MTRand_int32(unsigned long)" (??0MTRand_int32@@QAE@K@Z)
FeralbyNightv3_1_beta_w.obj : error LNK2019: unresolved external symbol "public: void __thiscall MTRand_int32::seed(unsigned long)" (?seed@MTRand_int32@@QAEXK@Z) referenced in function "public: __thiscall MTRand_int32::MTRand_int32(unsigned long)" (??0MTRand_int32@@QAE@K@Z)
FeralbyNightv3_1_beta_w.obj : error LNK2019: unresolved external symbol "private: static unsigned long * MTRand_int32::state" (?state@MTRand_int32@@0PAKA) referenced in function "protected: unsigned long __thiscall MTRand_int32::rand_int32(void)" (?rand_int32@MTRand_int32@@IAEKXZ)
FeralbyNightv3_1_beta_w.obj : error LNK2019: unresolved external symbol "private: void __thiscall MTRand_int32::gen_state(void)" (?gen_state@MTRand_int32@@AAEXXZ) referenced in function "protected: unsigned long __thiscall MTRand_int32::rand_int32(void)" (?rand_int32@MTRand_int32@@IAEKXZ)

Compiling fails, and those are the errors I get. I assume its something to do with mtrand.h, which I downloaded and saved to the same place as the source. Any suggestions?

Jone · 07/03/09, 1:15 PM

Originally Posted by Ayriss

A: When Savage Roar and RIP will expire at the same time, or almost at the same time, the addon [...] will in fact rather suggest a FB with 6-7 seconds left on both savage roar and rip, this must be a dps loss.

B: When Savage Roar and RIP cooldowns are off-sync (as they most often are) and you have a situation where RIP expires in 1 second and savage roar expires in 4 seconds. Then the addon will suggest to reapply savage roar the very second RIP wears off the target.

A. The simulations show that FB with 5+ seconds left on rip and SR is in fact a DPS gain. You'll have time to get SR back up when it expires and you'll lose a few ticks of rip, but in return you gain an entire FB. It works out to be better damage enough of the time that it's the better general policy.

B. Dunno about that one -- is it possible you've set it to force SR refreshes at higher combo points? If you've requested it refresh at 4+ CP, the addon is doing what you ask by sacrificing damage to reduce your risk of letting SR drop/using a low CP SR.

Salazay · 07/03/09, 4:43 PM

Originally Posted by Daboran

Just to comment.

Overall nice job on the addon. I have to agree with people that I have addons to cover everything else, so I'm only using the "suggestion" part.

Would it be practical to add an option to be able to disable the "suggestion" window when in Bear form? I really only use it in Cat.

I just added an option which let you hide the suggestion frame while in bearform.

If you cannot wait until the next release, you can pm me.

Lolaan · 07/03/09, 5:51 PM

Originally Posted by Jone

A. The simulations show that FB with 5+ seconds left on rip and SR is in fact a DPS gain. You'll have time to get SR back up when it expires and you'll lose a few ticks of rip, but in return you gain an entire FB. It works out to be better damage enough of the time that it's the better general policy.

B. Dunno about that one -- is it possible you've set it to force SR refreshes at higher combo points? If you've requested it refresh at 4+ CP, the addon is doing what you ask by sacrificing damage to reduce your risk of letting SR drop/using a low CP SR.

B Happens A LOT to me, I've wondered about the answer to this question myself many times. Wouldn't refreshing rip be better dps, even if it means losing a second or two off of savage roar (which will only affect white attacks + (rarely, if ever) your combo point building move). Where did the 4 second decision come from, is it math based or arbitrary? If its math based, then I'll go ahead and start using it, but I've been refreshing rip and letting savage roar drop for a white attack or two (loss of like 300 damage, vs several bleed ticks)