Originally Posted by Furion
I seem to remember profiting a lot from your work on warriors here a long time ago so I'm confident in your modifications, but I can't verify them myself anymore, so I'll wait a bit longer before I'll eventually have to replace my script in the OP seeing the changes to mangle (which seems to make manglebot option pretty useless and encourages refreshing mangle early), glyphs and the bug in simcraft about SR consuming no energy which translated fully to my script (and whatever I might have missed).
Apart from that I think it would be a good idea for everyone who modifies a script to edit at least the second line of the script to prevent confusion about script versions.
|
You remember that? God, what a messy contrivance that was. Looking back at thing, I'm surprised anyone used it.
SR energy bug in simcraft actually shouldn't be a problem. All it does is increase your available energy, and since any decently geared/buffed cat can achieve the rip/shred extensions, that extra energy would have gone into "frivolous" shreds. In other words, it's only extra dps. Yes, it will increase your CP/s, but since you only refresh SR on average 25-30s, it's really not that much. Believe me, I tried tuning your simcraft profile for quite a while, the only improvement I could get was moving around OOC shred and rip priority.
I did have a couple questions about your Ovale script.
In the smaller "filler" window you have these lines:
unless {BuffPresent(BERSERK) or 4s before Spell(TIGER) or Mana(more 32)}
{TargetDebuffExpires(RIP 3 mine=1) and ComboPoints(less 5)}
Why? I don't see that in your simcraft profile. Also, you put the "if roar expiring very soon, shred for cp" line in the filler window. I thought that should go in the bigger window since it's intention is to maintaining roar. But, from my testing, that line didn't really do much towards improving dps in either profile, so that's more just a curiosity.
Last one I'll ask about is some of your boundary testing seems wrong. I'll admit, I'm new to Ovale, and the documentation for the language isn't great, so this might be a syntax misunderstanding on my part. In you profile for filler shreds, you put if the remaining cooldown time on tiger's fury is 3s or less(and some other conditions), use shred. In Ovale, you put:
or BuffPresent(BERSERK) or 2s before Spell(TIGER)
Wouldn't that actually mean "cooldown.tigers_fury.remains<=2"? There are other ones, like
TargetDeadIn(less 10) Spell(RAKE)
Does the comparative function in Ovale only use whole numbers when the input boundaries are whole numbers?