Elitist Jerks
Register
Blogs
Forums


Go Back   Elitist Jerks » Class Mechanics » Druids

Closed Thread
 
LinkBack Thread Tools
Old 12/19/09, 2:19 PM   #46
Furion
Don Flamenco
 
Furion's Avatar
 
Tauren Druid
 
Blutkessel (EU)
Version 1.7 up, significantly increased Rip uptime. Should really be the final update before Christmas.

Offline
Old 12/19/09, 5:08 PM   #47
bkim
Glass Joe
 
Tauren Druid
 
Frostwolf
Originally Posted by chetal View Post
Has anyone figured out a way to add a timer for the internal cooldown of trinkets as a small side window?

Such as for death's choice and runestone (both have a 45? second internal cooldown on their procs.) This is about the only thing my custom script is missing.
Try this out:

Define(MJOLNIR 65019)
Define(DCNORM 67702)
Define(DCHEROIC 67771)
AddIcon help=cd size=small nocd=1 {
	if Stance(3) {
		unless BuffPresent(MJOLNIR) if BuffGain(MJOLNIR 45) Item(Trinket0Slot);
	}
}
AddIcon help=cd size=small nocd=1 {
	if Stance(3) {
		unless BuffPresent(DCNORM) if BuffGain(DCNORM 45) Item(Trinket1Slot);
		unless BuffPresent(DCHEROIC) if BuffGain(DCHEROIC 45) Item(Trinket1Slot);
	}
}
I haven't test it because I don't have either trinket. It adds two icons, one for each trinket slot. What I'm thinking it will do is display a icon of the trinket once it has past the 45 sec timer. This assumes you have the runestone in the 1st trinket slot and the DC in the 2nd. You can modify the code if that's not the case. Let me know if this works and I can add it to my script as an option.

EDIT: Was thinking, instead of showing when the internal CD has expired, wouldn't you just wanna know when the buff is active? That would be a lot easier to implement.

EDIT #2: Doesn't quite work the way I wanted it to.

Last edited by bkim : 12/20/09 at 9:35 AM.

Offline
Old 12/19/09, 6:54 PM   #48
coldbear
Piston Honda
 
coldbear's Avatar
 
Night Elf Druid
 
Ravenholdt
Originally Posted by Furion View Post
Version 1.7 up, significantly increased Rip uptime. Should really be the final update before Christmas.
Ran a 5p and you script was suggesting Rake when it was already up. Unable to reproduce on a dummy... had a DK tank, Ret pally, Mage, Holy pally in the group if that's any help.

@bkim - thanks for putting up your version. I personally much prefer having TF included in the suggestions, and the options you've included are great. Kinda wish there was an easy way to have both your and Furion's versions up easily accessible.

Last edited by coldbear : 12/19/09 at 7:53 PM.


Offline
Old 12/20/09, 1:14 AM   #49
funnyginman
Glass Joe
 
Night Elf Druid
 
Garona
The only major issue I have with bkim's script is that if SR is about to drop soon, it doesn't suggest to reup it until it has ~1 second left. Several times I've had Rip waiting to be used without enough energy to actually use it, then right as I used Rip it switches to SR which IMO should have been a higher priority. Isn't the goal to never let SR drop whatsoever?

Offline
Old 12/20/09, 2:50 AM   #50
Bearcowcat
Glass Joe
 
Tauren Druid
 
Gurubashi
Originally Posted by funnyginman View Post
The only major issue I have with bkim's script is that if SR is about to drop soon, it doesn't suggest to reup it until it has ~1 second left. Several times I've had Rip waiting to be used without enough energy to actually use it, then right as I used Rip it switches to SR which IMO should have been a higher priority. Isn't the goal to never let SR drop whatsoever?
This is most likely the correct sequence. If Rip has already expired, and Savage Roar is about to expire, and you're low on energy, you're in a tight spot. The best you can do is make sure that the Rip you throw up is boosted by Savage Roar, then pull a quick single combo point Savage Roar.

This way, you're only losing 33% extra damage on a few auto-attacks and one special, whereas if you refreshed Savage Roar first, and you were tight for energy, it would take ages to get a five combo point Rip up again.

It all comes down to you being able to Savage Roar at one combo point without undue ill effects.

Offline
Old 12/20/09, 3:30 AM   #51
Furion
Don Flamenco
 
Furion's Avatar
 
Tauren Druid
 
Blutkessel (EU)
Originally Posted by coldbear View Post
Ran a 5p and you script was suggesting Rake when it was already up. Unable to reproduce on a dummy...
Not sure why that's the case. Changed the logic in my script a bit. I'll test it in my raid today.

Offline
Old 12/20/09, 9:37 AM   #52
bkim
Glass Joe
 
Tauren Druid
 
Frostwolf
Originally Posted by coldbear View Post
@bkim - thanks for putting up your version. I personally much prefer having TF included in the suggestions, and the options you've included are great. Kinda wish there was an easy way to have both your and Furion's versions up easily accessible.
I had originally created a new thread because mine and Furion's are quite different approaches to the Ovale script, but the moderator moved it into this thread. I'm thinking of other way to have it accessible.

EDIT: I have created a google group to host the script. You can always find it here: WoW Feral DPS Ovale Script | Google Groups . Please no discussions in the google group. Leave the discussions in EJ.

Last edited by bkim : 12/20/09 at 9:52 AM.

Offline
Old 12/20/09, 9:53 AM   #53
coldbear
Piston Honda
 
coldbear's Avatar
 
Night Elf Druid
 
Ravenholdt
Originally Posted by Bearcowcat View Post
If Rip has already expired, and Savage Roar is about to expire, and you're low on energy, you're in a tight spot. The best you can do is make sure that the Rip you throw up is boosted by Savage Roar, then pull a quick single combo point Savage Roar.
Agreed. These scripts will never be able to completely account for difficult situations like these, e.g.:
* 3+ targets in 5yd range & in 90 degree frontal arc
* SR & Rip synchronized with < ~10 seconds left
* 5CP and Rip and Mangle about to drop off within 1 second of each other right before SR and you get a dodge/parry/miss

Best practice for these scripts going forward would really be to keep making minor adjustments for a good, solid single-target dps algorithm with options to include short CDs like TF, leave Berserk out of it since its use is the most fight-specific decision we have to make, but possibly include an option to recommend Mangle (wtb more Trauma warriors pst) a second before it drops off - which would lose personal dps efficiency but make sure you have at least one other chance to not get a dodge/parry/miss on putting up a debuff that a significant amount of raid dps'ers depend on. I don't see anyone being able to get even remotely effective with these scripts without using a timer addon as well.


Offline
Old 12/20/09, 10:36 AM   #54
Furion
Don Flamenco
 
Furion's Avatar
 
Tauren Druid
 
Blutkessel (EU)
Apart from your swipe scenario I don't see why a simple script couldn't give the optimal recommendation in those situations (I actually claim that the script should already give pretty good suggestions in those cases) but I seriously think this is derailing the discussion.
If you think the script gives you a wrong suggestion in a single target situation then describe the problem here and make sure to include what the script wrongly suggested and what it should have rightly suggested (and even better if you can explain why it was wrong or how to fix it).

Offline
Old 12/20/09, 1:40 PM   #55
• moz
Get off my lawn.
 
moz's Avatar
 
Tauren Druid
 
Mal'Ganis
I edited in bkim's link to Google Groups at the end of the original post. Furion, if you want to edit the OP to more clearly reflect both scripts then that may be helpful as you can keep this the thread about all things Ovale. That way people have access to both via the first post. Thanks to you both for providing an intelligent discussion on this stuff and making your work accessible.

Personally, I find these things interesting but in raid situations there are many variables that aren't taken into account (mostly encounter-specific) and if you know what you're doing you'll always outdo a script like this (and others like fbn, facemauler etc.). That said, the models are pretty good (especially the SimCraft-based stuff) and gets you a lot of the way there. At the very least if you're new, it helps you understand how things work till you can drive yourself.

United States Offline
Old 12/20/09, 2:04 PM   #56
NaturesVoice
Von Kaiser
 
Orc Rogue
 
Tarren Mill (EU)
The latest script hardly ever suggests Ferocious Bite. I think the Savage Roar suggestion isn't working correctly now, suggesting to refresh way too early.

Edit: I'm not really sure what the reason is to be honest I just hardly ever get Bite suggested and I have a feeling the roar is refreshed too early many times.

Last edited by NaturesVoice : 12/20/09 at 2:37 PM.

Offline
Old 12/20/09, 2:55 PM   #57
Furion
Don Flamenco
 
Furion's Avatar
 
Tauren Druid
 
Blutkessel (EU)
Originally Posted by NaturesVoice View Post
The latest script hardly ever suggests Ferocious Bite. I think the Savage Roar suggestion isn't working correctly now, suggesting to refresh way too early.

Edit: I'm not really sure what the reason is to be honest I just hardly ever get Bite suggested and I have a feeling the roar is refreshed too early many times.
It increases Rip uptime which is a tradeoff but overall should lead to higher dps. Working as intended.

Originally Posted by moz View Post
I edited in bkim's link to Google Groups at the end of the original post
Actually that was unnecessary as I already linked to it in my OP. However I will make a more clear distinction today, hopefully, but unfortunately I didnt have much time today and will be away in the coming days.

Edit: 1.7b up rake should really be fixed now. If more people prefer the old version which puts less priority on Rip I might put it up as an alternative again.

Last edited by Furion : 12/20/09 at 3:20 PM.

Offline
Old 12/20/09, 3:46 PM   #58
NaturesVoice
Von Kaiser
 
Orc Rogue
 
Tarren Mill (EU)
Originally Posted by Furion View Post
It increases Rip uptime which is a tradeoff but overall should lead to higher dps. Working as intended.
No no no you misunderstood. It's not Rip pushing Bite away it's Roar. I did some testing and Roar is already suggested when there are still 6 seconds left. How can that ever be a dps increase?
So Bite can only happen if Roar has more than 6 (!!!) seconds left and Rip still have enough time as well.

Like someone else said, why not do the Bite and follow up with a lower combo point Roar.

Please explain to me because this can in no way be a dps increase.

Offline
Old 12/20/09, 3:50 PM   #59
Odas
Von Kaiser
 
Night Elf Druid
 
Eonar
I believe this could help with desynchronizing rip and roar timers.

"n"s between "node1" and "node2"
The difference between the remaining time of "node1" and the remaining time of "node2" must be at most "n" seconds. If it is the case, the node remaining time is 0, otherwise it is infinite.
From Ovale Documentation

Offline
Old 12/20/09, 4:01 PM   #60
Furion
Don Flamenco
 
Furion's Avatar
 
Tauren Druid
 
Blutkessel (EU)
Originally Posted by NaturesVoice View Post
No no no you misunderstood. It's not Rip pushing Bite away it's Roar. I did some testing and Roar is already suggested when there are still 6 seconds left. How can that ever be a dps increase?
It's to desynchronize roar and rip and the only way to do it is to roar early. Imagine something like a 1:1 rip/roar ratio with both being up almost 100% of the time (that's not exactly what the script does it's just to give you an idea). On static fights refreshing roar early to increase rip uptime should be a DPS increase. However in some other fights things might look a bit differently. With maxed passive arp things might also look differently. I think some more feedback on this issue couldn't hurt.
If you don't like it you can still use an older Version.

Define(FFF 16857)
Define(FF 770)
Define(RIP 1079)
Define(MANGLE 33876)
Define(SHRED 5221)
Define(TIGER 5217)
Define(RAKE 59886)
Define(ROAR 52610)
Define(BITE 22568)
Define(BERSERK 50334)
Define(OMEN 16870)
Define(TRAUMA 46857)
Define(MANGLEB 33878)

AddIcon help=main
{
if Stance(3) # cat
    {
    	if ComboPoints(more 0) and BuffExpires(ROAR 1) Spell(ROAR)
	if ComboPoints(more 4)
		{
        	unless BuffExpires(ROAR 6)
            	{
            	unless TargetDebuffExpires(RIP 9 mine=1)
                		{
                		unless BuffPresent(BERSERK) Spell(BITE)
                		if BuffPresent(BERSERK) and Mana(less 20) Spell(BITE)
                		}
			}
		if TargetDeadIn(less 7) Spell(BITE)
	  	unless BuffExpires(ROAR 3) {unless TargetDebuffPresent(RIP mine=1) Spell(RIP)}
		}
	unless {TargetDebuffPresent(MANGLE) or TargetDebuffPresent(MANGLEB) or TargetDebuffPresent(TRAUMA)} Spell(MANGLE)    	if TargetDebuffExpires(RAKE 0 mine=1) {unless TargetDeadIn(less 9) Spell(RAKE)}
	if {TargetDebuffPresent(MANGLE) or TargetDebuffPresent(MANGLEB) or TargetDebuffPresent(TRAUMA)}
		{
		if ComboPoints(less 5) Spell(SHRED priority=2)
		if BuffPresent(OMEN) Spell(SHRED priority=2)
        	if BuffPresent(BERSERK) Spell(SHRED priority=2)
	 	if Mana(more 70) Spell(SHRED priority=2)
		if TargetDeadIn(less 9) Spell(SHRED)
       	}
    unless {TargetDebuffPresent(FFF) or TargetDebuffPresent(FF)} Spell(FFF priority=1)
    }
}
AddIcon help=cd size=small nocd=1
{
if Stance(3) # cat
    {
    Spell(TIGER)
    Spell(BERSERK)
    }
}

Last edited by Furion : 12/20/09 at 4:28 PM.

Offline
Closed Thread

Go Back   Elitist Jerks » Class Mechanics » Druids

Thread Tools

Similar Threads
Thread Thread Starter Forum Replies Last Post
Optimal Raid Warrior Threat Rotation Daavlod Class Mechanics 14 02/05/09 9:32 AM
Optimal rotation; theory vs reality Balog Public Discussion 31 11/19/08 7:31 PM