Thundering Skyflare Diamond does not grant haste, it is just increasing your auto-hit-speed. In terms of functionality it is comparable with the goblin racial.

Thanks, did not know as the proc says grants 480 melee and ranged haste if i remember right, its up for such a short time i dont really notice it most of the time.

No, Both [Heart of Solace] & [Heart of Rage] should be counted as reforged to crit (40%). I think you forget the fact that when you are not expertise/hit capped theyre values are bigger than crit/haste and thats why you simply cant for example turn that 321 expertise to 321 crit. And if you really think about that "perfect" situation were you can change every single expertise rating of trinket to crit, You are wearing bad pieces of gear (passive mastery/expertise, haste/expertise etc. simply items without passive crit.) Case should never be like this unless you have forced to take crappy pieces of gear. And that would not be trinket value calculating, too much gear dependant things wich are offcourse included but lets say that trinkets are trinkets. In different gears other trinket can be a little better or worse but they are still in order.

And abit offtopic but [Heart of Solace] Reforged to crit > [Crushing Weight] so in youre example you have replaced wrong trinket.

The point is that you will already be at expertise/hit cap through reforging. Thus you won't be gaining any expertise/hit b/c you are at the cap.
You also don't have to be wearing "sub-optimal" gear in order to be able to reforge all the expertise to crit/haste. If you have crit/haste pieces you have reforged in order to get to the expertise cap then you can simply change them back. Thus dropping your expertise for crit/haste.

On an unrelated note, does anyone else think stacking haste (rather than crit) is the way to go? Before you start quoting the listed Stat Weightings let me explain. With their relative equal value when completely ungeared I think that stacking a stat reliant on RNG is bad for a spec that already heavily relies on RNG. Haste makes our rotation more consistent and provides us with a larger number of white swings to proc AoW.
Also when using Redcape's spreadsheet in all the gear setups I've plugged in haste is simming equal to or as much as 50% better than crit. This is with roughly 1200-1600 Haste and 900-1200 Crit. Do you think this is haste increasing in value as we gear up or is this just chance?

Imagine, for a moment, on your other pieces of gear you have reforged 321 crit into expertise (maybe you have a ton of crit/hit items, who knows). You suddenly acquire this trinket with 321 expertise, putting you 321 expertise over the cap. You then decide to unforge all of your gear that was crit -> expertise back into crit. You therefore have the same amount of expertise as before, but you have 321 crit more, essentially turning the 321 expertise to crit. These items do have passive crit and you have therefore turned that 321 extra expertise into 321 crit. Of course, you aren't necessarily going to have reforged 321 crit into expertise, because you could have reforged crit, haste, mastery (or possibly hit, if you have an abundance of hit pieces) into expertise. The worse-case scenario is to treat that 321 expertise as 321 mastery, but on an average case you should consider taking an average of the stat weights of crit, haste, and mastery and treating that as a new weight for the expertise (another complication arises if you unforge expertise into mastery, you would reforge the mastery->crit).

Your new weight would be simply:

(1/3)(7/5)(weight of crit) + (1/3)(weight of haste) + (1/3)(3/5)(weight of mastery) =
[(7/15)(weight of crit) + (1/3)(weight of haste) + (1/5)(weight of mastery)]*321 rating

where 2/5 of your mastery is assumed to be reforged as crit.

EDIT:

I just realized that the amount of scenarios for reforging on gear is very large (e.g. you have crit/mastery gear that you reforged mastery->expertise, but by getting the 321 extra expertise, you unforge it, but cannot reforge that expertise to crit because you already have crit on your gear). Therefore, the most appropriate thing to do for this would be to give a range of "DPS" values per item. You consider the worst case scenario(all that expertise turns to mastery), and you consider the best case scenario (expertise -> crit), and you list the trinket as a DPS gain in the range between the two numbers. Granted, this range may be fairly large, but that is only because the number of possibilities are large as well. This is more valid now, since we have a wide variety of heroic gear to choose from for multiple slots, whereas in BiS gear there really is only the option of a tier piece vs. non-tier piece for the tier slots.

^

If you have tons of crit/hit items then you can turn that hit to expertise. Then when you obtain new expertise trinket you unforge expertise to hit and after that you can forge spare hit to haste. You should never nerf youre crit to gain expertise/hit cap unless its really necessary. But if you have aloth crit/hit items you dont have to forge crit off.

The main goal of reforging items is to keep hit/expertise capped and maximize your crit (best secondary stat).

In the original post, it says that Swordguard Embroidery is 800 ap, when it's actually 1000 ap, which would bring the average to 250ap I believe, meaning it's a bonus of 74 ap over the other professions.

I have this on my paladin, and went up to a test dummy and tried it out real quick, on the character sheet, my AP went up by 1000 and that number is reflected in the tooltip as well.

Short answer: Yes.

Long answer: With the rise of reforging, it will almost universally be that 2 and 4 set bonuses will be worth it, since their value is not taken out of stats on the gear.

I'd like to know what the DPS value is of the 4piece set - that's just 1 extra TV every 2 minutes, right?

A related issue: which set item of the 5 (if any) to skip? The gloves and the legs have mastery on them (the legs having quite a bit of mastery), and both slots have off-set pieces without mastery.

Gloves - going from set to offset you'd be trading 89 mastery and 20 haste for 109 crit.
Legs - going from set to offset you'd be trading 137 mastery for 137 haste.

Converting those secondary stats into relative Str value using Redscape's numbers, going with the gloves offset piece would be a Str upgrade of 10.59, while the Leg offset piece would be an upgrade of 9.59 (for the 359 versions).

The 4pc set bonus makes your Inq last 40 seconds instead of 30 seconds, meaning you get ~1 extra TV every ½ minute, or something. That's perhaps the idea, someone with more mathematical skills and time do the rest.

How about using the epic PvP gloves for off-set piece? We gain 15 STR, 159 hit and 5% CS damage at the cost of 169 haste and 149 mastery. Judging by the fight about the secondary stats that has been going on for the last couple o' pages, wouldn't be much of a loss on the secondary stats.

Keep in mind the bonus is effectively a static +10 seconds to ANY Inquisition you cast, including 1 and 2 HoPo ones, which means in order to maximize the set bonus you could use Inquisition at 1 HoPo every time, netting a double duration bonus (+100% at 1 rather than +33% at 3 HoPo).

Obviously this goes against trying to reduce the number of wasted GCDs to Inquisition, but from my experience so far since we currently do CS -> 2x Filler -> CS we are definitely not as GCD locked as we used to be, neither are all our casts that powerful (if it causes you to delay one ~5k HW or Judgement it's almost negligible).

If anything, I found the best use of Inquisition to be somewhat organic and I think optimum is somewhere in between. Try to always go for 3 HoPo Inquisition to minimize wasted GCDs, but if you find yourself about to run out of Inquisition and have 1-2 HoPo with an upcoming nuke like HoW or Exorcism it's usually best to power a shorter duration Inquisition to keep up the buff than let it drop and wait till 3.

As such, the main benefit of the set bonus is that it will add a lot of convenience/smoothing out of our gameplay, though how relevant it is DPS wise would require some modeling. I would guesstimate that you would want it, but that you're also not ruined if you don't have it ("nice but not required"). Certainly with reforging there's little reason not to go for it.