I was raiding last night and oddly enough it still recommended AW to me, I thought you had removed this previously?

Not sure if this is overkill but if it didn't recomend DP or SS on general vezax that would be great since currently i try to remember to not put them in the rotation before the fight and put them back after.

Not sure if this is overkill either but i have noticed on the yogg phase that with so many little battles the DP never comes up since you almost always kill the mobs prior to hitting that phase of the rotation. If your not careful you can end up running out of mana for lack of using DP.

Just some thoughts and thx for all the great work.

edit: for clarification

We pop heroism just before the heart phase in XT b/c we aren't doing hardmode yet, i rather use AW during hearth phase.

We pop heroism when vezax is at 25%, since heroism lasts for 40sec and AW last for 20 i rather pop AW during the last 20sec of heroism to get a chance of using HoW under both effects.

We pop heroism on any fight i like to wait at least 20 sec to see if i can get a greatness proc and then use it under both effects.

All things i came up with off the top of my head as to why i don't always want to pop AW when heroism goes up. I would say your rule is really more of a guideline but if you know what your doing not something your going to follow.

So i would think it would be better to never recomend AW or have a flag to not ever recomend it for those that like it.

Be careful with this practice... if it causes you to use one less proc on the given encounter, it's not worth it. Also, having an AW <20% is more important than aligning it with a greatness proc.

As for your other points, I suppose that's fair. I should have specified hard modes. My point still stands though, if you're doing hardmodes and you're not AWing + haste potting during hero, you're doing it wrong.

Sorry for the (very) late reply, but here are my performance tests (again just idling in Dalaran in Holy spec for 10 minutes):



(Yes, I switched from Broker_CPU to AddonProfiler, but I also checked Broker_CPU and it gives the same numbers.)

As you can see, the CPU time was even higher this time (900ms compared to 700ms in my previous test).

And I think I also know why:
Dalaran wasn't very crowded this time (still morning here), so I had higher frame rates (50-60 fps). And because your OnUpdate handler is called for each and every frame, a higher frame rate causes higher load.

You already have a timeSinceLastUpdate variable in that handler, so why not use it? Something like
would reduce the load fairly.

And while I'm looking on your OnUpdate handler, I really can't see it's purpose at all. You are doing a huge amount of checks and then just returning? What's the purpose of that? You only call DecideSpells() if the GetSpellInfo() call returns null, so when the player is not in Retribution spec. That doesn't make any sense, right?
So if I'm not completely wrong now, you can just kick the whole OnUpdate handler, because it does nothing (useful) right now.

And of course the other things I mentioned in my previous post (reworking and caching the whole check if the player is in Retribution spec, making tables local, ...) would also reduce the CPU load quite a bit.


Btw: Sorry if this post is a bit harsh, I really like your Addon and appreciate your work on it. I'd just like to see it a bit better coded

Assuming you mean a c-style switch statement, there are various ways and means of doing things that are similar in effect and appearance. Be wary of where and how you use them, though (don't create large tables in a loop, for example, or in a frequently-called event handler), as you run the risk of creating a lot of garbage, particularly with the 'cleverer' examples.

First, let me just say that this has to be my favorite and most relied upon addon for my ret pally. Now i know your thinking of adding more customisation features into it eventually, but in the mean time I am wanting to use KGPanels to configure SHIT to my liking. I can't say I am an addon expert and I don't know if this is the best place to ask this question, but, I'm needing to know what the frame name of SHIT is ingame, so that I can anchor some textures to it. I've tried to find it everywhere! But can't seem to get it to work.

Any help would be greatly appreciated!

where is the serious help in timing add on in wow matrix?

PLAYER_TALENT_UPDATE is the event fired when you switch talent specs. So do a check at start and then when that event is fired.

Tiny little bug I've noticed - occasionally it briefly suggests casting Retribution Aura, before returning to the normal rotation. Not sure why (often I have it active, and it's not on the priority list etc), and it's more an oddity than a problem, but thought I'd report it.

I dont know if this have been answered before (couldnt find in previous posts), but i have a problem concerning the opacity dregree. It looks like, even is set to a certain dregree, the next time i log in the addon shows the window at full alpha (even if the meter in the option menù is still set to the previous degree) and i have to adjust it again.

Could be some kind of interaction with other addons?

I could reduce the idle CPU usage in Holy spec from about 1000 ms to just 20 ms over 5 minutes by removing the OnUpdate handler completely.
Some quick tests didn't show any different behaviour of the Addon (as I assumed).