Ret FCFS Rotation Helper - Page 40

cremor · 10/26/10, 9:06 AM

I also noticed a small problem with the first priority icon:
If I'm at 2 HP and will be using CS next, the first icon shows CS and the second shows TV, everything perfect. But if I then use CS, some times (most likely because of latency) the next filler shows for a fraction of a second as first icon before it switches to TV.
Could you please tweak it so it always assumes being at 3 HP after using CS at 2 HP, even if the server hasn't reported the third HP yet?

burghy · 10/26/10, 12:09 PM

I'll look into it, but it's a form of hack and if it's not an easy fix I'd rather do this kind of tweaks at 85 after everything is ironed out.
It also happens during Zealotry, and yeah it's because of the delay in HP update from the server.

LE:
While frapsing output to try and work around that problem, noticed something quite annoying: UNIT_POWER events seem to be throttled by the game, so depending when you get the throttle, UnitPower("player", SPELL_POWER_HOLY_POWER) can return a proper value ~0.3 before default power bar gets the update event.
That's a potential 300ms extra latency on update even though the client had already received updated data from the server.

Example1 (the numbers in the chat frame are: timestamp, cs cooldown, some timer I was tracking, hp value):
http://img541.imageshack.us/img541/6742/hp1k.jpg
http://img839.imageshack.us/img839/3926/hp2zp.jpg
Basically, the default bar didn't even notice TV was used and another HP was generated by DP.

Example 2:
http://img821.imageshack.us/img821/803/hp3j.jpg
6106.951 - client uses cs
6107.246 - client gets confirmation message from server and cooldown is updated
6107.405 - client gets updated HP value
6107.708 - client fires UNIT_POWER event and animation starts
6107.804 - 2nd rune is relatively easy visible
~400ms from when your client knows hp was updated and you are aware of it.

Incadelico · 10/26/10, 1:01 PM

I've got another small problem, (probably due to my lack of lua knowledge) it's similar to the one on page 22 with Avenging Wrath, except this time it's Zealotry. Using the default template for it, it does not fade when it's on cooldown. Using

return IconICD(85696, 120, 1, 1, 0.3)

or

local visible, texture, start, duration, enable, reversed, alpha
visible, texture, start, duration, enable, reversed = IconAura("HELPFUL|PLAYER", "player", "Zealotry")
if not visible then
  visible, texture, start, duration, enable, reversed = IconSpell("Zealotry")
  if duration > 0 then
    alpha = 0.3
  else
    alpha = 1
  end
else
  alpha = 1
end
return visible, texture, start, duration, enable, reversed, nil, alpha

it fades out, but no longer turns dark blue (i.e. unuseable) without enough holy power after it's cooldown finishes.

burghy · 10/26/10, 1:57 PM

You need to pass also the vertex colors returned by the functions. Also, duration > 1.5 so it doesn't fade each gcd.

local visible, texture, start, duration, enable, reversed, count, alpha, svc, r, g, b, a
visible, texture, start, duration, enable, reversed, count, alpha, svc, r, g, b, a = IconAura("HELPFUL|PLAYER", "player", "Zealotry")
if not visible then
  visible, texture, start, duration, enable, reversed, count, alpha, svc, r, g, b, a = IconSpell("Zealotry")
  if duration > 1.5 then
    alpha = 0.3
  else
    alpha = 1
  end
else
  alpha = 1
end
return visible, texture, start, duration, enable, reversed, nil, alpha, svc, r, g, b, a

burghy · 10/26/10, 3:07 PM

Could you please tweak it so it always assumes being at 3 HP after using CS at 2 HP, even if the server hasn't reported the third HP yet?

Check latest alpha and let me know if there are issues.
Also bruteforced the update on the modified hp bar and removed the animations on rune gain.

cremor · 10/27/10, 3:31 PM

Seems to work, thanks!

Another request:
If you have the time, could you maybe add the party/raid size as a template option? Because I'd like to use different placements for the icons in my Holy spec when in a party/10 men raid and when in a 25 men raid. Right now I'm using the "force template" option for this, which of course works, but automatic switching would be better

Spotnick · 10/27/10, 8:33 PM

Is it normal that clcret is spamming me like crazy when I switch to my prot spec with "This message shouldn't be here" messages?

There is one per second non-stop in the chat window.

burghy · 10/28/10, 4:00 AM

It's not normal and I can't reproduce it.
Do you get lua errors from the addon? Are you using some other addon like clcprot or a modified version of clcret?

Because I'd like to use different placements for the icons in my Holy spec when in a party/10 men raid and when in a 25 men raid. Right now I'm using the "force template" option for this, which of course works, but automatic switching would be better

Check latest alpha.

Chrion · 10/28/10, 5:24 AM

Originally Posted by Spotnick

Is it normal that clcret is spamming me like crazy when I switch to my prot spec with "This message shouldn't be here" messages?

There is one per second non-stop in the chat window.

I was having this same issue, so I shut off all my addons and went through and turned them all on one by one to find out which one was causing the trouble and it turned out to be RatingBuster. So it seems like RatingBuster is causing some sort of conflict with Clcret. I'm pretty sure I'm using the most recent verson of both clc and RatingBuster. Hope this helps.

burghy · 10/30/10, 8:04 AM

Tried to tweak around ret module in clcInfo, ended up rewriting quite a lot of code.
Should be available in r138 and newer alphas (clcInfo - r138 - WoW AddOns - CurseForge.com).

Give it a spin on live or beta and let me know if you notice problems with it (the new command line function is: /clcinfo ret_opt and it's used to change 1 value options from command line if needed for macros, when you change weapons etc).

Teleros · 10/30/10, 6:26 PM

Just a thought burghy, but how about enabling bars to grow from right to left? I couldn't see any settings for it, but off the top of my head it'd be nice for a lunar / solar power setup.

burghy · 10/30/10, 6:42 PM

They're statusbars atm and that object doesn't have right to left mode.

Durandal · 10/30/10, 7:57 PM

I've been trying to change the color of icon borders but can't seem to get it. I was playing around with the svc and r, g, b, a under behavior. It's the only thing keeping me from switching from CLCret at the moment.

burghy · 10/31/10, 5:19 AM

There's no way to change icon border color atm. It might be implemented for Button Facade skins.

Teleros · 11/01/10, 2:39 PM

Originally Posted by burghy

They're statusbars atm and that object doesn't have right to left mode.

No problem, although I'm still trying to figure out the lunar / solar energy code.