Ret FCFS Rotation Helper - Page 44

aylen86 · 01/12/11, 6:06 AM

Originally Posted by burghy

Still can't reproduce it on dummy.
There is some commented debug code in the file. Would be great if you could post a sshot with the debugging enabled. Not sure you can do it in raids though since it's blocking a huge part of the view.
To enable it:
- replace -- dbg with dbg in the whole file
- remove comments from the block at the end of the file

I have uploaded 11 screenshots where I noticed the strange behavior of TV or double CS suggestions. Take a look at your private messages. I can provide another 300 images (70 MB of data) in a range of 2 seconds of these screenshots or a higher resolution when needed.

(Wild) observations:

The first 5 minutes playing with the experimental code were fine. I'm quite sure the problems started when I first hit Zealotry.
TV frequently flashed up for 0.2 seconds shortly after hitting an ability at 1 or 2 HoPo. Not quite sure but this never happened to Inquisition.
Both the primary attack and the next attack icon were affected.
Dying or hitting zealotry again were sometimes canceling this behaviour (again not quite sure about this).

burghy · 01/12/11, 7:42 AM

I assume your settings are the ones posted before.
Flashing of TV (it could also happen on INQ) are due to the low hpDelay value. Basically the addon catches SPELL_CAST event on CS, and increases HP with 1 or 3 until t=t+hpDelay or HP is updated by the server. Most likely your server doesn't send HP updates faster than 0.2s so it will first suggest increased HP (which makes TV show), then actual HP (which hides TV) then again increased HP after server update (TV pops back).
So you want to slightly overshot that value. If usually server gives you HP updates after 0.5s put it at 0.6 and so on. You can test it by going to a dummy, getting to 2HP, use CS and see what happens with first icon. If it's TV -> X -> TV (or INQ) then the value is too small.

Any way you could upload the fraps or describe exactly what's the issue with specific screenshots? Only thing i notice is a discordance between your HoPo bar and the value considered by the addon which can happen for 2 reasons: CS prediction (try increasing hpDelay as I described above) or slow update from HoPo bar.
If the HoPo bar is from Holy Trinity (looks like it), it could happen that it doesn't update HP as fast as possible (I made a post a while ago explaining how UNIT_POWER events aren't fired instantly when HP value is updated on the client and looking through the code Holy Trinity updates on that event not every frame). Not saying that's the issue 100% but I need to see a succession of frames or better explanation.

aylen86 · 01/13/11, 3:21 AM

Unfortunately I don't think it's that easy. Yes I am using Holy Trinity in the latest version but I also tried the HoPo-bar provided by clcinfo. Additionally there is the holypowerbar from shadowed unitframes in the left corner of my screens. They can't all be wrong. Even if there is a delay of several frames clcinfo shouldn't suggest TV at 1 HoPo with CS on cooldown.

My settings were the ones I posted above (almost the default ones you've suggested) but I further experimented with them:

Rising the general delay (or tolerance) from 0.1 to 0.3 or 0.5 makes it only worse. It is no longer a 'flashing' as the wrong suggestion is up for almost a second. So I leave that as it is.
hpDelay - I really tried all reasonable adjustements: 0.5, 0.6, 0.8, 1, 1.2, 1.5. There might be a plateau at '1' but the problem is still there. 0.8 was fine on a training dummy but the problem wasn't fixable by adjusting these values in my 25-man raid where it occured again.
How do I know? I'm trained to react to Art of War or Hand of Light-procs in a fraction of a second. It's really annoying when I see a TV only hitting for 2000 or when a TV suggestion flashes in when I totally know that it shouldn't be there.
Furthermore I copied all the values from cremor (except the localization and UseInq/Cons) and my problem still persist.

I don't think further explanation or access to all screenshots is going to help. So I will follow your suggestion and will fraps and upload it to YouTube tonight. I was using an automated screenshot tool before (smartision screencopy) and the smallest time interval available is 2s.
I'm somewhat confused that I'm the only one experiencing these problems. I made a fresh clcinfo install a week ago to eliminate old version fragments. Hopefully there is no strange interaction between old saved variables or my grid/icon settings.

burghy · 01/13/11, 3:43 AM

Found a "doh" error that could cause problems (and the chance for me to experience it was close to 0).
Get latest alpha (181+) before you fraps please and also uncomment -- print(GetTime(), event, spell).

Spotnick · 01/13/11, 4:07 PM

A nice interesting feature would be to check if the paladin has enough mana to do the spell before suggesting it, I don't know if it's possible. 99% of the time it's due to having consecration as lowest priority, so it suggests it even if you can't cast it.

I remember the very first version of the software where you could add divine plea to you priority list, that was useful. I know it's not a dps ability but it was a nice to have. Same for seal, if you forgot to refresh it before the encounter and it falls off, it is pretty much a dps loss.

It's not needed per say, the add-on is doing its job very well, but like I said, nice to have. Keep up the good work.

Teleros · 01/14/11, 5:10 AM

The new Ret module only suggests Cons if you have X mana (default 20k I believe).

Also having fun with TV popping up when it shouldn't with the new Ret module (default settings, uses Inq + Cons though).

Zalinda · 01/14/11, 6:00 AM

Have been pondering adding a "rebuke this" type icon to the clcinfo grid.

So if my target is in melee, and is casting a spell that I really should be interrupting, it pops up a rebuke signal/icon.

It would need some configuring since you don't want to desperately interrupt everything of course.
Config would ideall be a mob name + spells to interrupt on that mob. Default would be any mob, any spell. But then you can configure it to only do certain spells of specific mobs.

Is this within the realm of feasibility for clcinfo, or do I need to go looking for some other mod.

aylen86 · 01/14/11, 7:03 AM

Originally Posted by burghy

Found a "doh" error that could cause problems (and the chance for me to experience it was close to 0).
Get latest alpha (181+) before you fraps please and also uncomment -- print(GetTime(), event, spell).

Not sure if it was your "doh" error or another adjustment of my settings, but I wasn't able to reproduce it last night. If the latter is true the default settings should be changed.

Settings:

				["retributionex"] = {
					["jClash"] = 0.4,
					["rangePerSkill"] = true,
					["useInq"] = true,
					["cons"] = true,
					["hw"] = true,
					["tolerance"] = 0.1,
					["consClash"] = 0.8,
					["demon"] = "Demon",
					["version"] = 2,
					["hpDelay"] = 0.8,
					["undead"] = "Undead",
					["preInq"] = 6,
					["hwClash"] = 0.4,
					["consMana"] = 19000,
				},

A hpDelay of 0.8 or 1 was fine.

In addition suggesting two Crusader Strikes in a row was correct as there were no other fillers available in this span of time. There is the case where IconRetEx2() is misleading and suddenly a Judgement is jumping in between but I guess this is caused by the clash settings of my own.

So well it works perfectly now. Thanks!

Davidovski · 01/14/11, 8:15 AM

Originally Posted by aylen86

I'm somewhat confused that I'm the only one experiencing these problems. I made a fresh clcinfo install a week ago to eliminate old version fragments. Hopefully there is no strange interaction between old saved variables or my grid/icon settings.

I have noticed the same behavior in a couple of nights so far this week and it puzzled me enough to seek out this topic. I'm pretty much hitting TV and Exo on reflex when I see the icons flash up but I've noticed hitting TV (WITHOUT HoL active) when only one or two HoPo is visible on the bar resulting in a low damage TV.

cremor · 01/16/11, 6:28 AM

Originally Posted by burghy

Still can't reproduce it on dummy.
There is some commented debug code in the file. Would be great if you could post a sshot with the debugging enabled. Not sure you can do it in raids though since it's blocking a huge part of the view.
To enable it:
- replace -- dbg with dbg in the whole file
- remove comments from the block at the end of the file

I think I found the problem.
As you can see in the screenshot, Exo is skill1 and J is skill2. But CS Cd is only 0.57/0.67 sec (don't know what's the difference between the two shown values), so if I would cast Exo right now, the next usable spell after the GCD would already be CS.
(edit: I'm using r181)

And a question: What's the purpose of the "General delay" option?

burghy · 01/16/11, 8:50 AM

Regarding that setting, hypothetical situation: let's say you are during a gcd, at the end of the gcd your AoW proc will have 0.1s left on duration. Addon will suggest Exo, but some people might not be able to hit it for some reason. If that setting is set at 0.1 it won't suggest that exo.
It was an experiment mostly, can be safely set at 0.

I won't have time to test in game today probably. Something you can try if you have time:
- add s1time after: local sx, s1, s2
- remove local from: local s1time = 0
It's a dumb bug on my part and most likely causes that prediction error.

Lusias · 01/19/11, 1:28 PM

Originally Posted by solacespecs

You can set CLCInfo to set the priority to Inquisition at a time of your choosing. I have mine set to 6 seconds, but you can easily change it to 3 seconds.

I use CLCRet and CLCInfo and find them invaluable. However Inquisition was not on my list and I'm unsure how to set Inquisition to show this. Can someone provide me the steps in breif summary?

Thank You

burghy · 01/24/11, 10:16 AM

Newest alpha should have a ptr module. Don't have that much time atm to tweak and also ptr lags insanely for me. Let me know what issues you find if you can give it a try.
Debug display is now enabled from options, so would be nice to have a sshots with it when you report wierd behavior.

Meebo · 01/25/11, 3:57 AM

Is there a means to which you can run 2 modules at the same time?
My offspec is Protection and have been trying to no avail to get the Protection Module to run with the Ret Module so I wouldn't have to change the settings for "Active when" each time I change specs.
I added Icons for the "Now" and "Next" abilities but when I add in "return IconProtection1()" into the Behaviour it spits out "ProtIcon1: Interface\Addons\clcinfo\data\paladin\protection.lua:181: attempt to compare number with nil".

burghy · 01/25/11, 4:00 AM

If you setup the templates properly you shouldn't change anything, it auto switches at respec.
You kinda need to be specced ret for ret module to work (same as protection) because they rely on spec specific spells.