Ret FCFS Rotation Helper - Page 51

• Gnarfoz · 10/12/11, 5:46 AM

Ah, right, I see.

From what I gathered, he basically reversed the direction of how the addon works.
Instead of BF offering skins and addons using those, Masque now handles skinning of everything and you supply it with your buttons to be skinned.

(However, clcInfo's buttons don't inherit from the (Secure)ActionButton template, so things get interesting? Hmm.)

Handled · 10/21/11, 1:52 AM

Originally Posted by Gnarfoz

Ah, right, I see.

From what I gathered, he basically reversed the direction of how the addon works.
Instead of BF offering skins and addons using those, Masque now handles skinning of everything and you supply it with your buttons to be skinned.

(However, clcInfo's buttons don't inherit from the (Secure)ActionButton template, so things get interesting? Hmm.)

If you just roll back and don't update to Masque everything works perfectly fine I found this out a while ago and have just not updated from BF to Masque and everything works fine.

Phangor · 11/29/11, 4:26 PM

Will our priorities be changing much in 4.3 with the change to HoW? I've been using the same string for a little while which looks like it should still work fine for now, until 2pc t13 maybe.

inqa inqrhp cs inqrdp tvdp exoud exo how tvhp j hw cons

slipey · 11/30/11, 1:24 AM

CLCInfo seems to be working fine with the new 4.3 patch but I did get t13 2pc tonight and I noticed that HP prediction was not working for Judgement. I was hoping that you could add an option called "Predict that Judge will generate HP" similar to the "Predict that CS will generate HP" option. When judging while you already have 2 HP, CLCinfo will suggest a filler or CS as the next skill instead of inq/TV and will not update until the HP is actually acquired. A feature like this would be a huge help.

Thanks!
-Slipey

burghy · 11/30/11, 10:13 AM

Can't properly test it myself but try clcInfo - r211 - WoW AddOns - CurseForge.
Use jhp instead of j (remember to adjust judgement clash value if you want higher priority for judgement) and let me know if it works fine so I roll it as release.

mackaque · 11/30/11, 3:27 PM

Hey burghy,

Tested your new r193 CLCRET and for me it's not working as soon as I have 3HP it still propose me Judgement and I used jhp in the priority list.

Thanks

burghy · 11/30/11, 4:29 PM

What priority are you using?

mackaque · 11/30/11, 4:41 PM

Tested with this

inqa inqrhp inqrdp cs jhp tvdp exo tvhp how hw cons

What I did is get INQ up ... get 3HP and then waited for J to come off cooldown and as soon it was up it proposed me to use J instead of TV.

slipey · 11/30/11, 5:56 PM

I just tested the r211 and it seems good for predicting the next action. The only problem is that there is delay between the time you judge and when the HP is awarded. This seems like the same issue we had with CS before so hopefully blizz will fix it.

There is, however, another issue. With t13 2pc, the prio of judgement will drastically change depending on if we do or do not have zealotry buff. According to my simulationcraft runs, dropping judgement back down in prio during zealotry can net ~200dps increase.

I made some edits to r211 clcInfo\data\paladin\retribution.lua that seemed to net the result I was looking for.

I added an action called jhpzeal and updated jhp so it doesnt suggest Judgement if you have 3 HP or zealotry is up.

This way I was able to implement the following rotation:

cs jhp inqr inqa tvdp exoud tvhp exo how jhpzeal hw cons

The code changes I made are below. I'm not sure if this is the best solution but it does seem to work in my testing. If you could implement something similar to this it would be greatly appreciated.

	jhpzeal = {
		id = jId,
		GetCD = function()
			if s1 ~= jId then
				return GetCooldown(jId) + db.jClash
			end
			return 100
		end,
		UpdateStatus = function()
			s_ctime = s_ctime + s_gcd + 1.5
			s_hp = s_hp + 1
		end,
		info = "Judgement that generates 1 HP",
	},
	jhp = {
		id = jId,
		GetCD = function()
			if s_hp >= 3 then return 100 end
			if s_zeal > 0 then return 100 end
			if s1 ~= jId then
				return GetCooldown(jId) + db.jClash
			end
			return 100
		end,
		UpdateStatus = function()
			s_ctime = s_ctime + s_gcd + 1.5
			s_hp = s_hp + 1
		end,
		info = "Judgement that generates 1 HP (for use without zealotry buff and when HP<3)",
	},

burghy · 12/01/11, 4:06 AM

Added the 2 variations, should be in the next alpha when curse packager finishes.

mackaque · 12/01/11, 4:16 AM

Haaa now you talk Burghy it works fine I don't have the problem anymore thx a lot for those quick update. Testing those zeal and nozeal atm to see if it works.

Thanks again

mackaque · 12/01/11, 4:28 AM

Ok after playing with the zeal and nozeal I can't make it work.

For example :

inqa inqrhp cs jhpnozeal inqrdp exoud tvdp exo tvhp how jhpzeal hw cons

Using this if Zeal is not up and I have J off cooldown and get an EXO proc it's asking me to use EXO but it should tell me to use J since it's higher in the priority. With "jhp" it works fine tho it tells me to use J even with an EXO proc so jhp got fixed but the 2 new one you implemented seems to not work or it's me doing something wrong.

Just let me know what you want me to try if I'm doing something wrong

Thanks

burghy · 12/01/11, 6:17 AM

Named them wrong ><
Should update soon.

Pallytos · 12/02/11, 5:56 PM

is there a possibility of adding a TVZEAL to it, so that under zeal it wont prompt for fillers?

requital and I were talking about it yesterday, and he mentioned this could be helpful. otherwise we were using an event so that TV was prioritized over all fillers while under zeal

Paxtez · 12/02/11, 11:44 PM

Also, would it be possible to add divine plea?